drivers/net/pse-pd/Kconfig | 2 +- drivers/net/pse-pd/pse_core.c | 10 +++++++++- 2 files changed, 10 insertions(+), 2 deletions(-)
From: Kory Maincent (Dent Project) <kory.maincent@bootlin.com>
This patch series fix few issues in PSE net subsystem like Regulator
dependency, PSE regulator type and kernel Documentation.
Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---
Changes in v3:
- Add a missing Fixes tag.
- Remove "Dent project" from the patch author description.
- Link to v2: https://lore.kernel.org/r/20240422-fix_poe-v2-0-e58325950f07@bootlin.com
Changes in v2:
- Remove "Dent project" from my sob.
- Link to v1: https://lore.kernel.org/r/20240422-fix_poe-v1-0-811c8c0b9da7@bootlin.com
---
Kory Maincent (3):
net: pse-pd: pse_core: Add missing kdoc return description
net: pse-pd: pse_core: Fix pse regulator type
net: pse-pd: Kconfig: Add missing Regulator API dependency
drivers/net/pse-pd/Kconfig | 2 +-
drivers/net/pse-pd/pse_core.c | 10 +++++++++-
2 files changed, 10 insertions(+), 2 deletions(-)
---
base-commit: 6a57f091622a1251c2826f7380577049199b80ea
change-id: 20240422-fix_poe-d0fb292c9d8e
Best regards,
--
K�ry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
Tue, Apr 23, 2024 at 11:21:09AM CEST, kory.maincent@bootlin.com wrote: >From: Kory Maincent (Dent Project) <kory.maincent@bootlin.com> > >This patch series fix few issues in PSE net subsystem like Regulator >dependency, PSE regulator type and kernel Documentation. > >Signed-off-by: Kory Maincent <kory.maincent@bootlin.com> set- Reviewed-by: Jiri Pirko <jiri@nvidia.com>
On Tue, 23 Apr 2024 13:28:00 +0200 Jiri Pirko <jiri@resnulli.us> wrote: > Tue, Apr 23, 2024 at 11:21:09AM CEST, kory.maincent@bootlin.com wrote: > >From: Kory Maincent (Dent Project) <kory.maincent@bootlin.com> > > > >This patch series fix few issues in PSE net subsystem like Regulator > >dependency, PSE regulator type and kernel Documentation. > > > >Signed-off-by: Kory Maincent <kory.maincent@bootlin.com> > > set- > Reviewed-by: Jiri Pirko <jiri@nvidia.com> Your reviewed-by tag has not been taken in the commit merged. It seems patchwork does not take the cover letter tag reply into account, I think only b4 does. Regards, -- Köry Maincent, Bootlin Embedded Linux and kernel engineering https://bootlin.com
On Thu, 25 Apr 2024 10:31:10 +0200 Kory Maincent wrote: > Your reviewed-by tag has not been taken in the commit merged. > It seems patchwork does not take the cover letter tag reply into > account, I think only b4 does. Sorry about that. The problem is that patchwork doesn't correctly group the cover letter in your postings. Not sure why. Could you experiment with tweaking the posting? Maybe we can "bisect" the problem.
On Thu, 25 Apr 2024 07:06:19 -0700 Jakub Kicinski <kuba@kernel.org> wrote: > On Thu, 25 Apr 2024 10:31:10 +0200 Kory Maincent wrote: > > Your reviewed-by tag has not been taken in the commit merged. > > It seems patchwork does not take the cover letter tag reply into > > account, I think only b4 does. > > Sorry about that. > The problem is that patchwork doesn't correctly group the cover letter > in your postings. Not sure why. Weird, I used b4 so it should work. > Could you experiment with tweaking the posting? > Maybe we can "bisect" the problem. Do you want me to like post a v5 with the "pw-bot: cr" tag? But if I put the tag only on the cover letter it won't work then. Maybe on all patches? Was it the same for the PoE support patch series? If so, we could look at it with my future patch series that will bring new features to PoE. Regards, -- Köry Maincent, Bootlin Embedded Linux and kernel engineering https://bootlin.com
On Thu, 25 Apr 2024 16:30:02 +0200 Kory Maincent wrote: > > Could you experiment with tweaking the posting? > > Maybe we can "bisect" the problem. > > Do you want me to like post a v5 with the "pw-bot: cr" tag? But if I put the > tag only on the cover letter it won't work then. > Maybe on all patches? Probably not worth posting for a test. I'll try to be more careful when applying in the future, we can experiment with real postings. > Was it the same for the PoE support patch series? Yeah, I had to apply that one manually. > If so, we could look at it with my future patch series that will bring new > features to PoE. 👍️
On Thu, 25 Apr 2024 07:42:05 -0700 Jakub Kicinski <kuba@kernel.org> wrote: > On Thu, 25 Apr 2024 16:30:02 +0200 Kory Maincent wrote: > > > Could you experiment with tweaking the posting? > > > Maybe we can "bisect" the problem. > > > > Do you want me to like post a v5 with the "pw-bot: cr" tag? But if I put the > > tag only on the cover letter it won't work then. > > Maybe on all patches? > > Probably not worth posting for a test. I'll try to be more careful when > applying in the future, we can experiment with real postings. > > > Was it the same for the PoE support patch series? > > Yeah, I had to apply that one manually. Does this patch series is on the same state? https://lore.kernel.org/netdev/20240422-feature_ptp_netnext-v11-0-f14441f2a1d8@bootlin.com/ Regards, -- Köry Maincent, Bootlin Embedded Linux and kernel engineering https://bootlin.com
On Thu, 25 Apr 2024 16:57:08 +0200 Kory Maincent wrote: > On Thu, 25 Apr 2024 07:42:05 -0700 > > > Do you want me to like post a v5 with the "pw-bot: cr" tag? But if I put the > > > tag only on the cover letter it won't work then. > > > Maybe on all patches? > > > > Probably not worth posting for a test. I'll try to be more careful when > > applying in the future, we can experiment with real postings. > > > > > Was it the same for the PoE support patch series? > > > > Yeah, I had to apply that one manually. > > Does this patch series is on the same state? > https://lore.kernel.org/netdev/20240422-feature_ptp_netnext-v11-0-f14441f2a1d8@bootlin.com/ That one was fine: https://patchwork.kernel.org/project/netdevbpf/cover/20240422-feature_ptp_netnext-v11-0-f14441f2a1d8@bootlin.com/ Are you thinking it's the extra From in the cover letter?
On Thu, 25 Apr 2024 08:07:24 -0700 Jakub Kicinski <kuba@kernel.org> wrote: > On Thu, 25 Apr 2024 16:57:08 +0200 Kory Maincent wrote: > > On Thu, 25 Apr 2024 07:42:05 -0700 > > > > Do you want me to like post a v5 with the "pw-bot: cr" tag? But if I > > > > put the tag only on the cover letter it won't work then. > > > > Maybe on all patches? > > > > > > Probably not worth posting for a test. I'll try to be more careful when > > > applying in the future, we can experiment with real postings. > > > > > > > Was it the same for the PoE support patch series? > > > > > > Yeah, I had to apply that one manually. > > > > Does this patch series is on the same state? > > https://lore.kernel.org/netdev/20240422-feature_ptp_netnext-v11-0-f14441f2a1d8@bootlin.com/ > > > > That one was fine: > > https://patchwork.kernel.org/project/netdevbpf/cover/20240422-feature_ptp_netnext-v11-0-f14441f2a1d8@bootlin.com/ > > Are you thinking it's the extra From in the cover letter? Maybe or some patches between b4 version 0.13.0 and 0.14-dev. I will try next time without my extra From b4 patch to test 0.14-dev. Regards, -- Köry Maincent, Bootlin Embedded Linux and kernel engineering https://bootlin.com
On Thu, 25 Apr 2024 19:04:26 +0200 Kory Maincent wrote: > > That one was fine: > > > > https://patchwork.kernel.org/project/netdevbpf/cover/20240422-feature_ptp_netnext-v11-0-f14441f2a1d8@bootlin.com/ > > > > Are you thinking it's the extra From in the cover letter? > > Maybe or some patches between b4 version 0.13.0 and 0.14-dev. I will try > next time without my extra From b4 patch to test 0.14-dev. Another random thought is that some people put the name in quotes if it contains non-trivial chars, so may be worth trying with: From: "Kory Maincent (Dent Project)" <kory.maincent@bootlin.com>
On Thu, 25 Apr 2024 10:15:11 -0700 Jakub Kicinski <kuba@kernel.org> wrote: > On Thu, 25 Apr 2024 19:04:26 +0200 Kory Maincent wrote: > > > That one was fine: > > > > > > https://patchwork.kernel.org/project/netdevbpf/cover/20240422-feature_ptp_netnext-v11-0-f14441f2a1d8@bootlin.com/ > > > > > > Are you thinking it's the extra From in the cover letter? > > > > Maybe or some patches between b4 version 0.13.0 and 0.14-dev. I will try > > next time without my extra From b4 patch to test 0.14-dev. > > Another random thought is that some people put the name in quotes if > it contains non-trivial chars, so may be worth trying with: > > From: "Kory Maincent (Dent Project)" <kory.maincent@bootlin.com> Ok, I will try also with quotes. Regards, -- Köry Maincent, Bootlin Embedded Linux and kernel engineering https://bootlin.com
On Thu, 25 Apr 2024 07:42:05 -0700 Jakub Kicinski <kuba@kernel.org> wrote: > On Thu, 25 Apr 2024 16:30:02 +0200 Kory Maincent wrote: > > > Could you experiment with tweaking the posting? > > > Maybe we can "bisect" the problem. > > > > Do you want me to like post a v5 with the "pw-bot: cr" tag? But if I put the > > tag only on the cover letter it won't work then. > > Maybe on all patches? > > Probably not worth posting for a test. I'll try to be more careful when > applying in the future, we can experiment with real postings. > > > Was it the same for the PoE support patch series? > > Yeah, I had to apply that one manually. Mmh that's annoying. Thanks for the information. Regards, -- Köry Maincent, Bootlin Embedded Linux and kernel engineering https://bootlin.com
© 2016 - 2024 Red Hat, Inc.