[PATCH 0/2] tracing/selftests: Verbosity improvements to KTAP output

Mark Brown posted 2 patches 1 year, 10 months ago
tools/testing/selftests/ftrace/ftracetest      | 8 +++++++-
tools/testing/selftests/ftrace/ftracetest-ktap | 2 +-
2 files changed, 8 insertions(+), 2 deletions(-)
[PATCH 0/2] tracing/selftests: Verbosity improvements to KTAP output
Posted by Mark Brown 1 year, 10 months ago
This series aims to improve the usability of the ftrace selftests when
running as part of the kselftest runner, mainly for use with automated
systems.  It fixes the output of verbose mode when run in KTAP output
mode and then enables verbose mode by default when invoked from the
kselftest runner so that the diagnostic information is there by default
when run in automated systems.

I've split this into two patches in case there is a concern with one
part but not the other, especially given the verbosity of the verbose
output when it triggers.

Signed-off-by: Mark Brown <broonie@kernel.org>
---
Mark Brown (2):
      tracing/selftests: Support log output when generating KTAP output
      tracing/selftests: Default to verbose mode when running in kselftest

 tools/testing/selftests/ftrace/ftracetest      | 8 +++++++-
 tools/testing/selftests/ftrace/ftracetest-ktap | 2 +-
 2 files changed, 8 insertions(+), 2 deletions(-)
---
base-commit: 4cece764965020c22cff7665b18a012006359095
change-id: 20240319-kselftest-ftrace-ktap-verbose-72e37957e213

Best regards,
-- 
Mark Brown <broonie@kernel.org>
Re: [PATCH 0/2] tracing/selftests: Verbosity improvements to KTAP output
Posted by Steven Rostedt 1 year, 10 months ago
Shuah,

If Masami is OK with this, can you take this through your tree?

Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>

-- Steve


On Mon, 25 Mar 2024 16:15:49 +0000
Mark Brown <broonie@kernel.org> wrote:

> This series aims to improve the usability of the ftrace selftests when
> running as part of the kselftest runner, mainly for use with automated
> systems.  It fixes the output of verbose mode when run in KTAP output
> mode and then enables verbose mode by default when invoked from the
> kselftest runner so that the diagnostic information is there by default
> when run in automated systems.
> 
> I've split this into two patches in case there is a concern with one
> part but not the other, especially given the verbosity of the verbose
> output when it triggers.
> 
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
> Mark Brown (2):
>       tracing/selftests: Support log output when generating KTAP output
>       tracing/selftests: Default to verbose mode when running in kselftest
> 
>  tools/testing/selftests/ftrace/ftracetest      | 8 +++++++-
>  tools/testing/selftests/ftrace/ftracetest-ktap | 2 +-
>  2 files changed, 8 insertions(+), 2 deletions(-)
> ---
> base-commit: 4cece764965020c22cff7665b18a012006359095
> change-id: 20240319-kselftest-ftrace-ktap-verbose-72e37957e213
> 
> Best regards,
Re: [PATCH 0/2] tracing/selftests: Verbosity improvements to KTAP output
Posted by Shuah Khan 1 year, 10 months ago
On 3/26/24 10:08, Steven Rostedt wrote:
> 
> Shuah,
> 
> If Masami is OK with this, can you take this through your tree?
> 
> Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>
> 
> -- Steve
> 
> 

Yes. Will do once Masami gives me the okay.

> On Mon, 25 Mar 2024 16:15:49 +0000
> Mark Brown <broonie@kernel.org> wrote:
> 
>> This series aims to improve the usability of the ftrace selftests when
>> running as part of the kselftest runner, mainly for use with automated
>> systems.  It fixes the output of verbose mode when run in KTAP output
>> mode and then enables verbose mode by default when invoked from the
>> kselftest runner so that the diagnostic information is there by default
>> when run in automated systems.
>>
>> I've split this into two patches in case there is a concern with one
>> part but not the other, especially given the verbosity of the verbose
>> output when it triggers.
>>
>> Signed-off-by: Mark Brown <broonie@kernel.org>
>> ---
>> Mark Brown (2):
>>        tracing/selftests: Support log output when generating KTAP output
>>        tracing/selftests: Default to verbose mode when running in kselftest
>>
>>   tools/testing/selftests/ftrace/ftracetest      | 8 +++++++-
>>   tools/testing/selftests/ftrace/ftracetest-ktap | 2 +-
>>   2 files changed, 8 insertions(+), 2 deletions(-)
>> ---
>> base-commit: 4cece764965020c22cff7665b18a012006359095
>> change-id: 20240319-kselftest-ftrace-ktap-verbose-72e37957e213
>>
>> Best regards,
> 

thanks,
-- Shuah
Re: [PATCH 0/2] tracing/selftests: Verbosity improvements to KTAP output
Posted by Shuah Khan 1 year, 10 months ago
On 3/26/24 13:11, Shuah Khan wrote:
> On 3/26/24 10:08, Steven Rostedt wrote:
>>
>> Shuah,
>>
>> If Masami is OK with this, can you take this through your tree?
>>
>> Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>
>>
>> -- Steve
>>
>>
> 
> Yes. Will do once Masami gives me the okay
Hi Masami,

Are you okay with this patch?

thanks,
-- Shuah
Re: [PATCH 0/2] tracing/selftests: Verbosity improvements to KTAP output
Posted by Masami Hiramatsu (Google) 1 year, 10 months ago
On Thu, 4 Apr 2024 10:32:33 -0600
Shuah Khan <skhan@linuxfoundation.org> wrote:

> On 3/26/24 13:11, Shuah Khan wrote:
> > On 3/26/24 10:08, Steven Rostedt wrote:
> >>
> >> Shuah,
> >>
> >> If Masami is OK with this, can you take this through your tree?
> >>
> >> Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>
> >>
> >> -- Steve
> >>
> >>
> > 
> > Yes. Will do once Masami gives me the okay
> Hi Masami,
> 
> Are you okay with this patch?

Hi Shuah and Mark,

Sorry, I missed this series. This looks good to me.

Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>

Thank you!

> 
> thanks,
> -- Shuah
> 
> 


-- 
Masami Hiramatsu (Google) <mhiramat@kernel.org>