From nobody Mon Feb 9 05:19:27 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A65D128384; Mon, 25 Mar 2024 16:17:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711383477; cv=none; b=nAIA7S2ksbD1zguxjXkj+u8ot/SuliGINp1sUYXuU+q5/M58h8rOakw3Lu+4woklKzTzrWpVC4ftd0R/aRggrEVIFQNMLiKsdFD5rdw9UAUIxMLW+N23p1hD6Grmwm5TJJq3KlR4ZmcM536RnLyuWjTBqwKMcXuNmkVeCsTzq4U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711383477; c=relaxed/simple; bh=CxI/roqLmFPpR2Hha1nY/b7X963/yvMAOGGo5SgRBwY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=JVCyeBs8Xcpv00A40FqAnNic5vAJ2/6wkejTXwVfE/LLFQU/nEj+U8NCsmmO1ll14KAIWgW5mzNdoanoO6r5mQBw1ZUTD6fIaWi85qhQZvbt+suCh/JYQBiwN6ibro4PCB1XsJZkfFAgy5LYy+9MvHD4r1issQulkdlu1+aBZ60= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=nsfSBmoK; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="nsfSBmoK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B4217C433B1; Mon, 25 Mar 2024 16:17:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711383476; bh=CxI/roqLmFPpR2Hha1nY/b7X963/yvMAOGGo5SgRBwY=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=nsfSBmoKyXXPw+fT5obU4phfsjWDn2XOldfVOnQRulY08FsNuIX3Oz/6rtvxiBU3w lGY6BVp3pF7/+Hast6zF7sPFxEhwEB5gIxmO3J9QN56wcGa8Esc+udlC0yapn2CD7p tNXJSC1zex2E+1yNvxm1MIHYiHqckDt1XRZWfSkZFTeHIjU2dhYJh6mJoULNPmmyqx ptrUGeGqOaPsTko9wWs2+6Kf8SEUpmRzcL31AVsGCvyFwYwborjS7aleryRG9aMCI2 tMM+C1dBcxvoLvwI/ekA8qvG/3+v17AZqUlYWwf8IjLsXtixSUC9pNzkZaXScy0Bwv VOBogIt7ImBzw== From: Mark Brown Date: Mon, 25 Mar 2024 16:15:50 +0000 Subject: [PATCH 1/2] tracing/selftests: Support log output when generating KTAP output Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240325-kselftest-ftrace-ktap-verbose-v1-1-3785199809da@kernel.org> References: <20240325-kselftest-ftrace-ktap-verbose-v1-0-3785199809da@kernel.org> In-Reply-To: <20240325-kselftest-ftrace-ktap-verbose-v1-0-3785199809da@kernel.org> To: Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Shuah Khan Cc: Mark Rutland , Aishwarya TCV , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Mark Brown X-Mailer: b4 0.14-dev X-Developer-Signature: v=1; a=openpgp-sha256; l=1218; i=broonie@kernel.org; h=from:subject:message-id; bh=CxI/roqLmFPpR2Hha1nY/b7X963/yvMAOGGo5SgRBwY=; b=owEBbQGS/pANAwAKASTWi3JdVIfQAcsmYgBmAaOuDdcW/Bl6VlAkmoAAnO4Bj4ULO6YUx1zdiLb7 P08+SPyJATMEAAEKAB0WIQSt5miqZ1cYtZ/in+ok1otyXVSH0AUCZgGjrgAKCRAk1otyXVSH0Fr0B/ wPqT/zxNbf5zUFigZq4cx0MyjRgJbriybraCGdQLbt4rIEY6OVikQztgYZ5huMIyZZnqDWT6pE3G+j tJerHTgzylob9cxVuBGrHv/zxXtV+NVAL7PjYwdW2560TvZ6CqunTFTgBWUnDKEc8l9au7z0Vuxg3T zv48QQQcguh9Fw9agc/pGuRwopP8nFpYXhCGWGuE6u6sneHmctMJHVkgBvGZbiBmajGBtom0n5oE6L UWRkwlndIWVM+1dTz8GfTYhxpz4MfF1zKXtovnkL35sPuzWfiwKYXkjFe9mdR9i/1+5D+9zX/CkwHo ZmTEC2EcsRBGFKs0lEJTRtpTnEb6pK X-Developer-Key: i=broonie@kernel.org; a=openpgp; fpr=3F2568AAC26998F9E813A1C5C3F436CA30F5D8EB When -v is specified ftracetest will dump logs of test execution to the console which if -K is also specified for KTAP output will result in output that is not properly KTAP formatted. All that's required for KTAP formatting is that anything we log have a '#' at the start of the line so we can improve things by washing the output through a simple read loop. This will help automated parsers when verbose mode is enabled. Signed-off-by: Mark Brown Acked-by: Masami Hiramatsu (Google) Acked-by: Steven Rostedt (Google) Reviewed-by: Muhammad Usama Anjum --- tools/testing/selftests/ftrace/ftracetest | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/ftrace/ftracetest b/tools/testing/self= tests/ftrace/ftracetest index 25d4e0fca385..cce72f8b03dc 100755 --- a/tools/testing/selftests/ftrace/ftracetest +++ b/tools/testing/selftests/ftrace/ftracetest @@ -255,7 +255,13 @@ prlog() { # messages [ "$LOG_FILE" ] && printf "$*$newline" | strip_esc >> $LOG_FILE } catlog() { #file - cat $1 + if [ "${KTAP}" =3D "1" ]; then + cat $1 | while read line ; do + echo "# $line" + done + else + cat $1 + fi [ "$LOG_FILE" ] && cat $1 | strip_esc >> $LOG_FILE } prlog "=3D=3D=3D Ftrace unit tests =3D=3D=3D" --=20 2.30.2 From nobody Mon Feb 9 05:19:27 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67BED12B16C; Mon, 25 Mar 2024 16:17:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711383479; cv=none; b=I22R1LEr58uehzetsWQQa2YwbaE8IqYStw1mgEWOZkNdFVDO4SHkI6e2ue7ZncbuxsKa+n19UlS4kxI9oZ353Mz0/7ZlKOY3S2NPpCSQ8shGLEBkuVB3maK1hIIILWGiBzNNhq/V1k651MN03PVl7MYydM9T2eTNpdTCfMKyTdM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711383479; c=relaxed/simple; bh=IDZmVTQL6FUPF4VXy4kvhrE06bFthcPgs9kXAUa4MHw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=j+zOB9H8AbdKZmGiF4eyQI1cth8c2eYF1KzaIOy/PzhOc6iG4WYwNsxceKF9d8FM5KNHyWGg1+9b+dwaZ66MlIlqwyxtmykNlT+cOWmTrjia/CipKdS9X1Pzk7HOk6xWSJ9ZU7RbCOZJsQnTN+00XVE+7qyIF+iLY4wXraSNoVg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=olLbVQnO; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="olLbVQnO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1196DC433C7; Mon, 25 Mar 2024 16:17:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711383479; bh=IDZmVTQL6FUPF4VXy4kvhrE06bFthcPgs9kXAUa4MHw=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=olLbVQnO7TGptxzycuqWSNXMlKEHChyw3zRv46MXcNhG+rA4lTdWrWl1p55ElHepQ LLd4jgr2KR4jhrjUtvXYUfu7scQNng9XgK4kos6NVaei3IUfMdEcAxuoBK+0eRBcYX HiQ2h/cZ5godDGLrRp6KN3QVrUUK70k7nGyYk9aBnR9ZNJNteTnSdMPfcoHX7fiuFd WR8pYa1ht+0Kdyhj+QL/FwKlq8wKY7h5usqz6ItdcSmaZOHoMiUx+7qKIajX3+eYD1 1P5S7MRnrcRwaIfDgPuPGyFfJnmUcvtqxonsRC/Mlz+IVV/a6dgWoI11bpWZcs26I+ Aju6CICJQAWxQ== From: Mark Brown Date: Mon, 25 Mar 2024 16:15:51 +0000 Subject: [PATCH 2/2] tracing/selftests: Default to verbose mode when running in kselftest Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240325-kselftest-ftrace-ktap-verbose-v1-2-3785199809da@kernel.org> References: <20240325-kselftest-ftrace-ktap-verbose-v1-0-3785199809da@kernel.org> In-Reply-To: <20240325-kselftest-ftrace-ktap-verbose-v1-0-3785199809da@kernel.org> To: Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Shuah Khan Cc: Mark Rutland , Aishwarya TCV , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Mark Brown X-Mailer: b4 0.14-dev X-Developer-Signature: v=1; a=openpgp-sha256; l=1363; i=broonie@kernel.org; h=from:subject:message-id; bh=IDZmVTQL6FUPF4VXy4kvhrE06bFthcPgs9kXAUa4MHw=; b=owEBbQGS/pANAwAKASTWi3JdVIfQAcsmYgBmAaOvbRVid4KdhaOgoFVH1DkequIpxxcu0SW4Fv5d efPO+peJATMEAAEKAB0WIQSt5miqZ1cYtZ/in+ok1otyXVSH0AUCZgGjrwAKCRAk1otyXVSH0DT3B/ 4o3VAA+e8nn0hiFSXN4UX8I2TMbL8acEu2QQIzdscZ6Hm9SoRI6ksxZ8fu8/7a+JEhPhKL0z/yYYsW K4z3InUL1ZUWoavhgesdozrbtaBDRDayXXZgcL0op5eaSwOJk1yGD2kS1rp4Eqpvokuua+5D1Kf+qf rO/etGks1AFPnn4qQboUAKX6gr1j6erXjqG4jhuSd28c+7CgS9ojhHvDFbz4X42+R+lgdU8bwGLPIw FewY60hhYn8c26Va7vDNHCREvWEoNNUz6zGKzVZxTzU2ln8tAWyFAbPVZ5OHewsrvoWooJR9JW32WA kelLkuwOuNi5IuCvZX6c9qAgmiJQDP X-Developer-Key: i=broonie@kernel.org; a=openpgp; fpr=3F2568AAC26998F9E813A1C5C3F436CA30F5D8EB In order to facilitate debugging of issues from automated runs of the ftrace selftests turn on verbose logging by default when run from the kselftest runner. This is primarily used by automated systems where developers may not have direct access to the system so defaulting to providing diagnostic information which might help debug problems seems like a good idea. When tests pass no extra output is generated, when they fail a full log of the test run is provided. Since this really is rather verbose when there are a large number of test failures or output is slow (eg, with a serial console) this could substantially increase the run time for the tests which might present problems with timeout detection for affected systems, hopefully we keep the tests running well enough that this is not too much of an issue. Signed-off-by: Mark Brown Acked-by: Masami Hiramatsu (Google) Acked-by: Steven Rostedt (Google) Reviewed-by: Muhammad Usama Anjum --- tools/testing/selftests/ftrace/ftracetest-ktap | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/ftrace/ftracetest-ktap b/tools/testing= /selftests/ftrace/ftracetest-ktap index b3284679ef3a..14e62ef3f3b9 100755 --- a/tools/testing/selftests/ftrace/ftracetest-ktap +++ b/tools/testing/selftests/ftrace/ftracetest-ktap @@ -5,4 +5,4 @@ # # Copyright (C) Arm Ltd., 2023 =20 -./ftracetest -K +./ftracetest -K -v --=20 2.30.2