drivers/staging/pi433/pi433_if.c | 5 +++-- drivers/staging/pi433/rf69.c | 1 + drivers/staging/pi433/rf69.h | 1 - 3 files changed, 4 insertions(+), 3 deletions(-)
1. Untangle include hierarchy. 2. Update #minors the driver can accept. 3. Make use of general macro instead of magic number. Shahar Avidar (3): staging: pi433: Use headers in appropriate files. staging: pi433: Reduce N_PI433_MINORS to conform with N_SPI_MINORS. staging: pi433: Make use of spi mode macro instead of magic number. drivers/staging/pi433/pi433_if.c | 5 +++-- drivers/staging/pi433/rf69.c | 1 + drivers/staging/pi433/rf69.h | 1 - 3 files changed, 4 insertions(+), 3 deletions(-) base-commit: bfa8f18691ed2e978e4dd51190569c434f93e268 -- 2.34.2
On Sun, Mar 24, 2024 at 11:31:58AM +0200, Shahar Avidar wrote: > 1. Untangle include hierarchy. > 2. Update #minors the driver can accept. > 3. Make use of general macro instead of magic number. > Shahar Avidar (3): > staging: pi433: Use headers in appropriate files. > staging: pi433: Reduce N_PI433_MINORS to conform with N_SPI_MINORS. > staging: pi433: Make use of spi mode macro instead of magic number. For patches 1 and 3 Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> -- With Best Regards, Andy Shevchenko
On Mon, Mar 25, 2024 at 11:18:42AM +0200, Andy Shevchenko wrote: > On Sun, Mar 24, 2024 at 11:31:58AM +0200, Shahar Avidar wrote: > > 1. Untangle include hierarchy. > > 2. Update #minors the driver can accept. > > 3. Make use of general macro instead of magic number. > > > Shahar Avidar (3): > > staging: pi433: Use headers in appropriate files. > > staging: pi433: Reduce N_PI433_MINORS to conform with N_SPI_MINORS. > > staging: pi433: Make use of spi mode macro instead of magic number. > > For patches 1 and 3 > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> That's impossible for b4 to parse, it would have applied this to all of the commits if I had taken them :( thanks, greg k-h
On Mon, Mar 25, 2024 at 07:05:46PM +0100, Greg KH wrote: > On Mon, Mar 25, 2024 at 11:18:42AM +0200, Andy Shevchenko wrote: > > On Sun, Mar 24, 2024 at 11:31:58AM +0200, Shahar Avidar wrote: > > > 1. Untangle include hierarchy. > > > 2. Update #minors the driver can accept. > > > 3. Make use of general macro instead of magic number. > > > > > Shahar Avidar (3): > > > staging: pi433: Use headers in appropriate files. > > > staging: pi433: Reduce N_PI433_MINORS to conform with N_SPI_MINORS. > > > staging: pi433: Make use of spi mode macro instead of magic number. > > > > For patches 1 and 3 > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > That's impossible for b4 to parse, it would have applied this to all of > the commits if I had taken them :( You can apply only patches 1 and 3 as long as they are independent to patch 2. b4 am -st -P 1,3 ... or we can wait for the author to react on the comments and issue a new version. -- With Best Regards, Andy Shevchenko
On Mon, Mar 25, 2024 at 08:41:50PM +0200, Andy Shevchenko wrote: > On Mon, Mar 25, 2024 at 07:05:46PM +0100, Greg KH wrote: > > On Mon, Mar 25, 2024 at 11:18:42AM +0200, Andy Shevchenko wrote: > > > On Sun, Mar 24, 2024 at 11:31:58AM +0200, Shahar Avidar wrote: > > > > 1. Untangle include hierarchy. > > > > 2. Update #minors the driver can accept. > > > > 3. Make use of general macro instead of magic number. > > > > > > > Shahar Avidar (3): > > > > staging: pi433: Use headers in appropriate files. > > > > staging: pi433: Reduce N_PI433_MINORS to conform with N_SPI_MINORS. > > > > staging: pi433: Make use of spi mode macro instead of magic number. > > > > > > For patches 1 and 3 > > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > > > That's impossible for b4 to parse, it would have applied this to all of > > the commits if I had taken them :( > > You can apply only patches 1 and 3 as long as they are independent to patch 2. > > b4 am -st -P 1,3 ... I don't do that, it would not scale at all :)
On Mon, Mar 25, 2024 at 07:51:16PM +0100, Greg KH wrote: > On Mon, Mar 25, 2024 at 08:41:50PM +0200, Andy Shevchenko wrote: > > On Mon, Mar 25, 2024 at 07:05:46PM +0100, Greg KH wrote: > > > On Mon, Mar 25, 2024 at 11:18:42AM +0200, Andy Shevchenko wrote: > > > > On Sun, Mar 24, 2024 at 11:31:58AM +0200, Shahar Avidar wrote: > > > > > 1. Untangle include hierarchy. > > > > > 2. Update #minors the driver can accept. > > > > > 3. Make use of general macro instead of magic number. > > > > > > > > > Shahar Avidar (3): > > > > > staging: pi433: Use headers in appropriate files. > > > > > staging: pi433: Reduce N_PI433_MINORS to conform with N_SPI_MINORS. > > > > > staging: pi433: Make use of spi mode macro instead of magic number. > > > > > > > > For patches 1 and 3 > > > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > > > > > That's impossible for b4 to parse, it would have applied this to all of > > > the commits if I had taken them :( > > > > You can apply only patches 1 and 3 as long as they are independent to patch 2. > > > > b4 am -st -P 1,3 ... > > I don't do that, it would not scale at all :) Yeah, this requires too much maintainer's involvement. Alternative option, in case you are fine with patch 2, is to drop my tags and apply. -- With Best Regards, Andy Shevchenko
On Mon, Mar 25, 2024 at 09:12:16PM +0200, Andy Shevchenko wrote: > On Mon, Mar 25, 2024 at 07:51:16PM +0100, Greg KH wrote: > > On Mon, Mar 25, 2024 at 08:41:50PM +0200, Andy Shevchenko wrote: > > > On Mon, Mar 25, 2024 at 07:05:46PM +0100, Greg KH wrote: > > > > On Mon, Mar 25, 2024 at 11:18:42AM +0200, Andy Shevchenko wrote: > > > > > On Sun, Mar 24, 2024 at 11:31:58AM +0200, Shahar Avidar wrote: > > > > > > 1. Untangle include hierarchy. > > > > > > 2. Update #minors the driver can accept. > > > > > > 3. Make use of general macro instead of magic number. > > > > > > > > > > > Shahar Avidar (3): > > > > > > staging: pi433: Use headers in appropriate files. > > > > > > staging: pi433: Reduce N_PI433_MINORS to conform with N_SPI_MINORS. > > > > > > staging: pi433: Make use of spi mode macro instead of magic number. > > > > > > > > > > For patches 1 and 3 > > > > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > > > > > > > That's impossible for b4 to parse, it would have applied this to all of > > > > the commits if I had taken them :( > > > > > > You can apply only patches 1 and 3 as long as they are independent to patch 2. > > > > > > b4 am -st -P 1,3 ... > > > > I don't do that, it would not scale at all :) > > Yeah, this requires too much maintainer's involvement. > > Alternative option, in case you are fine with patch 2, is to drop my tags and > apply. I wasn't fine with them, I'll wait for a new version of this series to be posted before looking at them again. thanks, greg k-h
© 2016 - 2026 Red Hat, Inc.