From nobody Sun Feb 8 06:53:50 2026 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56EED15E88 for ; Sun, 24 Mar 2024 09:32:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711272734; cv=none; b=eleKnndmFdRlzAPp0Sk0ZnuLMJskMIqm0yLN13fQwbTU5OQEpdDPx0tCZowihtyTlbmv07OpDHtgXlLpYQEJLuCjEYI7Q4okiURK820dNlZpwBiw//ht3EhtUSSMea222Q4b+zxzlSBE5p7A3bofCfS4zqUnAXMENaKs7dxhhpA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711272734; c=relaxed/simple; bh=YVVA/Nue1HWli9ajTETSkp/Z8ht1gvkZIg5G81ES5Jk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=szbnyK+IBCIbpXZL7RsCAXTmIw+1aPxPHWukNmT3fH/3cTYK7r4B3AsQE09gJSxa71a60566w/AXAU8s+8zFPIbWXdnKiLsKlmLJ1drwk6fogGvKHvOTH85/aJ4MfQjWWKLO8M7PwCqT2pb8wzoFq1+grpFPytkGat+rBSG2Uk0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YhjlHaZD; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YhjlHaZD" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-4146e9e45c8so22304235e9.1 for ; Sun, 24 Mar 2024 02:32:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711272731; x=1711877531; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9z4c5G0kdSZAq5c11ZQYphuwgiNaPxmvqYLKdSmtxQw=; b=YhjlHaZDIH8qOdbP0w0MhKNs2FfIPtf3D9Y3MXqWo6qbbHR/v72IXTC89HCLFelbvc Zpv0EZvUEm+/yh8KUNKO6uDHexkARbPhefz4x8tEdAthm9AqPGghOLwiAoWYQTASMvej ffa46+tfYIGpNtMEIPLhD5s36PBxiHp6/sAfSZZ4iDgi5Dw30uHBjpGv1ltaTQvIRvjU T1kho8sBK6mSRgkxq4NFF+q1mp8C+ErOV0L4QQnp5JWEW5oLUan3jW8V+CPwj4FOrLM2 v8aWECyOAXYSY3lW5ZJfs4o1b0YDAPw7MevQWUVHyZIDBMEEGtV69BoTG+HObJ7Paao+ bfyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711272731; x=1711877531; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9z4c5G0kdSZAq5c11ZQYphuwgiNaPxmvqYLKdSmtxQw=; b=f6c/tCebvMOvQtErERzBrBJk8IfcJOOcmicu+b2YdLEEs2aabR8fmFNPJw/M3cyWtc K8g0JQ1yG6ckKWGLQmydIDijiSXqdZgb1a07Gdgy3nmH9fq2VA8bNJDdZp23X2gEr5u5 MZx2UdfA0Vvo/r9VpGsoQrGZlqM/ALcCAqgG+NoZNY0ZhD2DuJjM/bSS5DHyGRPxhRDV QeMwxvTn20QvUAUa3UVYMfpeZ05CjVzp0fT7SfghVayOTvZG/A68CoFPNOyCp63pBv7Z 8TOvADn0ozDaTxjp6GzwewU5p6eHRyU3EJbc+iD3nD90aSnXPqgrcdsp1f7VhK2kCS9B +dxg== X-Forwarded-Encrypted: i=1; AJvYcCUQxZi+FjyYmwXTTBFde0df09Jffh3uz2A59i/E7GpaK08KQ7v8mCifbF0chaKQQfZtioPcvuRrxnRfVy6tRm7jWveZEEt9j9a7SndA X-Gm-Message-State: AOJu0YxM7bMkxG0r1D9rea/r6tq/dmKpWoVtuN8Y/eleuzWjQtv02h6n 0z7HbcO4B1S3knouv/VfUnGCRjrvJPi12ZrUNHc5Lo1qb8kExEHl X-Google-Smtp-Source: AGHT+IGMRut/BEV6BtVvBXPHbQ6PxSc0Wph7gW5unAlhd861t5LWGUaO56+dlY9f44h3fJp8ac1pwg== X-Received: by 2002:a05:600c:3b98:b0:414:5e9b:804b with SMTP id n24-20020a05600c3b9800b004145e9b804bmr2787739wms.10.1711272730644; Sun, 24 Mar 2024 02:32:10 -0700 (PDT) Received: from YOGA.local ([2a06:c701:736b:f200:42b5:8c78:fc9d:7600]) by smtp.gmail.com with ESMTPSA id ay9-20020a5d6f09000000b0033b87c2725csm6490711wrb.104.2024.03.24.02.32.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Mar 2024 02:32:10 -0700 (PDT) From: Shahar Avidar To: gregkh@linuxfoundation.org, elder@linaro.org, andriy.shevchenko@linux.intel.com, robh@kernel.org, parthiban.veerasooran@microchip.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 1/3] staging: pi433: Use headers in appropriate files. Date: Sun, 24 Mar 2024 11:31:59 +0200 Message-Id: <20240324093201.793485-2-ikobh7@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240324093201.793485-1-ikobh7@gmail.com> References: <20240324093201.793485-1-ikobh7@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Ensure rf69.c directly includes rf69_enum.h. Move rf69_registers.h from header to the relevant source file. Signed-off-by: Shahar Avidar Reviewed-by: Andy Shevchenko --- drivers/staging/pi433/pi433_if.c | 1 + drivers/staging/pi433/rf69.c | 1 + drivers/staging/pi433/rf69.h | 1 - 3 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433= _if.c index b6c4917d515e..a351b7acfcff 100644 --- a/drivers/staging/pi433/pi433_if.c +++ b/drivers/staging/pi433/pi433_if.c @@ -45,6 +45,7 @@ =20 #include "pi433_if.h" #include "rf69.h" +#include "rf69_registers.h" =20 #define N_PI433_MINORS BIT(MINORBITS) /*32*/ /* ... up to 256 */ #define MAX_MSG_SIZE 900 /* min: FIFO_SIZE! */ diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c index 5a1c362badb6..bf802f097310 100644 --- a/drivers/staging/pi433/rf69.c +++ b/drivers/staging/pi433/rf69.c @@ -11,6 +11,7 @@ #include =20 #include "rf69.h" +#include "rf69_enum.h" #include "rf69_registers.h" =20 #define F_OSC (32 * HZ_PER_MHZ) diff --git a/drivers/staging/pi433/rf69.h b/drivers/staging/pi433/rf69.h index 76f0f9896a52..dd6fa8af9b9c 100644 --- a/drivers/staging/pi433/rf69.h +++ b/drivers/staging/pi433/rf69.h @@ -9,7 +9,6 @@ #define RF69_H =20 #include "rf69_enum.h" -#include "rf69_registers.h" =20 #define FIFO_SIZE 66 /* bytes */ =20 --=20 2.34.1 From nobody Sun Feb 8 06:53:50 2026 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C63A3171D1 for ; Sun, 24 Mar 2024 09:32:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711272735; cv=none; b=YOwaF8Mx5tfwMULLEeEoAc8IC39Mm4QIvlU4Tw9/WzkbrZzjVIlXIWMWgUtdIrJOGcz5lj2f6AToEvnCwFsR9XHC48OvGsDiDXbFKTIawp5aiEcbg2rsuhRDvY5hC5A8h8OOwZB+gFL8UOJFGvwxN56QfeX+Pa64iM01ex+scdc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711272735; c=relaxed/simple; bh=VT0EkNrQhjDBbAPpzVyUfpRwQiQqlFeykNPMlZxlnAk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=p91QSJ2KVxX7hhXpbTlPyN20XlrTM527KpUkUv51UPGHK1fDeleJGsksZjsmt7E/3AL52goJY00R9H3hxMWm+PdsnvVdH6ywQ8s8/zCeCmfdg5N95tHI8trQ1i3pAwNIdou7qu3QXy3fUFHr62Eevg+2ZTJYqxcN/z+tyOSytYo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dP20/q8m; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dP20/q8m" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4146e9e45c8so22304285e9.1 for ; Sun, 24 Mar 2024 02:32:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711272732; x=1711877532; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=f6o+af74WSP97HZ3puohPzQ1dX5G0dkc3ZQTYmDMAGE=; b=dP20/q8mJbHx8pWOFqzeAcLXhJ15cwt/FNg0/PpObP7cxc47G9GnOSp3xiV+C3Wi1k WzG2wlVljgS8wu+ux7jfNG4/XWH2AghWRgVgoJLze2Q8a/LxcuoyQXnWnTfENNr3Zzga aItVfMrn89IlTb2cO7HMGnzSm6aR2CJk1YoykrPCMwjPOfKFQJsHaHEEiEXFqEIDp2KM mujwby9KQjcV5FUfv5M5YcSs+CgVGvqR57fXAIxpHYO9hTpnZozPfGTOgfqeGqZebWsi RNWuyUjhFX1Yi410PbwYErPgWEu9c6XDL19rjbvs6GTUPR+VeSHPoTxQmFW+Tker8UJY TmmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711272732; x=1711877532; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=f6o+af74WSP97HZ3puohPzQ1dX5G0dkc3ZQTYmDMAGE=; b=axxDm+e936aSlNUDK3B7wU7oQ8yYTLLwSXPypKUTEbisHyATECdNeKT5ZLnGXGjBRH 5stE2sclemSQyyIAI9OWeHtkP6S2rh5yZQYt/yvCMb1/yaReV+UTqs8/tCRF/1dgD7iD EOrCTlucuJqdShsF1AfDFQFiUBq2apd7xw9MigjId9/dWW04m8viekpmkAKbKqf6P2t0 RsCoUL+VrWAG8DF2OFajoifU02/HIBlPBTkH1KI+Re3H1WQ8lh2Nfb2XsWnZuIcZ/rj9 YsoUthMc3t6ubA3VTvhR7Rt54o7FOmwVSq1ZPs+UIRSF3HDWmn+Oo2e8UQPW1n55N/sS Evow== X-Forwarded-Encrypted: i=1; AJvYcCVxFaWsna+pF7GNd99x+q0gbX9SCDItTi4pY13O32z8zdj2747iGCJXKmYgfFPZ2t6XAJ9JmoGaG8BszLlAvIpzZ6v6LSCuIsfLm4h4 X-Gm-Message-State: AOJu0YwXj/uJ4Wqd6RyV5U8e1Is9NoqONRbV1kej/TXtNJmhKxBkadSk 0dpOQFAmz1IBWVBrMp+acBT0PD+aq50pJTvoY4vROHRYpX2VVHSB X-Google-Smtp-Source: AGHT+IEcC/5j7E19kInkz6JcOC3nZEaLiAPqs7fStpTxOCqmWu64LIxS1gCBhb1GmJrsFvK69qshSA== X-Received: by 2002:a5d:42d1:0:b0:33d:7e9:9543 with SMTP id t17-20020a5d42d1000000b0033d07e99543mr2605274wrr.32.1711272732281; Sun, 24 Mar 2024 02:32:12 -0700 (PDT) Received: from YOGA.local ([2a06:c701:736b:f200:42b5:8c78:fc9d:7600]) by smtp.gmail.com with ESMTPSA id ay9-20020a5d6f09000000b0033b87c2725csm6490711wrb.104.2024.03.24.02.32.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Mar 2024 02:32:11 -0700 (PDT) From: Shahar Avidar To: gregkh@linuxfoundation.org, elder@linaro.org, andriy.shevchenko@linux.intel.com, robh@kernel.org, parthiban.veerasooran@microchip.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 2/3] staging: pi433: Reduce N_PI433_MINORS to conform with N_SPI_MINORS. Date: Sun, 24 Mar 2024 11:32:00 +0200 Message-Id: <20240324093201.793485-3-ikobh7@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240324093201.793485-1-ikobh7@gmail.com> References: <20240324093201.793485-1-ikobh7@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The driver can't actually support 2^20 devices. Current RasPis GPIO pins can actually support only 1 device. Other or future platforms might support more. Signed-off-by: Shahar Avidar Reviewed-by: Andy Shevchenko --- drivers/staging/pi433/pi433_if.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433= _if.c index a351b7acfcff..9fc93fa454b1 100644 --- a/drivers/staging/pi433/pi433_if.c +++ b/drivers/staging/pi433/pi433_if.c @@ -47,7 +47,7 @@ #include "rf69.h" #include "rf69_registers.h" =20 -#define N_PI433_MINORS BIT(MINORBITS) /*32*/ /* ... up to 256 */ +#define N_PI433_MINORS 32 #define MAX_MSG_SIZE 900 /* min: FIFO_SIZE! */ #define MSG_FIFO_SIZE 65536 /* 65536 =3D 2^16 */ #define FIFO_THRESHOLD 15 /* bytes */ --=20 2.34.1 From nobody Sun Feb 8 06:53:50 2026 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 39934175AB for ; Sun, 24 Mar 2024 09:32:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711272736; cv=none; b=cOCHUaGa26WHfAnzlNqWGUakhXX8uQ0OEXEQ0jW7EGs85zUupQROvvD9zI8h3CQEsPeFFE+mDdAH386WEdy9w403097YHG7qnLw3fm075qyouxL6V6H6N2HuPDq4m2abTkwEgRi3fD0laz6NZ9HQ8SdFgAnt9hV3CbmnIdJ+/Nk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711272736; c=relaxed/simple; bh=u5pB1sDbN4TWFvIqouYPN1Z7rf5l2iCYMwm/u0Zd89Y=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=HizZMB8eP9VNBnxNL+TEqBYU5VU0yDS5s9lge50JKQ1AdFQDSEhJ9Vev10vfWJe0EcNnpuXXty0cjvkusW4+mAiYAppy3rQMR+kKTXN6fs8VmNvPPkFaNZyxG04VNZ0SDNg3vlBbaBzGAD0DfPu1stl2bYDUiA1sijGh3wqPOvk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VufvP2RW; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VufvP2RW" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-33fd12a06fdso2347835f8f.1 for ; Sun, 24 Mar 2024 02:32:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711272733; x=1711877533; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LopSDTAPBYKt0PL+7kumsFXpTtF7FOQgTtXMVa1BlOc=; b=VufvP2RWxOcxPgN47DruWnxHaFz4QD/cGJ1WADEfu1YWG9i/rQjECkhR3pzFek/UkA k9KzEGZ8P5q1OSTxeFaohkA8Qo5wY7QxSrferkQnqJEMf6dlLwsWyFS+nYaLOhYJGloY rvMOK0+Sg03xTg6QiNpLDFQSPBwDivWyPJyv89cXY/1RAYog+LZ9dFsYJ/lSafPHdlld zpMpwYpyb81AiT/T7lpSw7goqtWN9xJm3bzec/+s6HmLfOnQKWsfZbaOCL1wryPl0SHp /AP5Aj2+awka7B58qnGjCOGRq2sG0YkKDUoqn7fQEFbRx7WAdMg+fa8f2IVaKw5fU3rM 4YmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711272733; x=1711877533; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LopSDTAPBYKt0PL+7kumsFXpTtF7FOQgTtXMVa1BlOc=; b=mEYV7k4fl+GolkQfBAVyIqkLlXB7DVnxUUdNpuBEzFZTw8VVqggVZ4+tTdpy8MBKzE gKSCClYMmYvKgFBFDVEbdohADCLrsYmwT19wQWhPhJmKbqnQBx7iEYEPCxfsfi42lLxZ w0/VNoZN774Rw+CralHUdzK729PuHaJTl0od/n07/Vlspp4mDo353cXwyrk9EavqZkOU tWeryxAOXDCgnjpY8mbn5FI0wovIiW9hCLaJR6luHqL21Ax5VBNLBPtCoZUsEauCFexV rD3GYsYGn+vy76BLRyPmej9CqjzJ5VkzyEfjvz3Hb3ML1LEUIXUfGGaEhgWAKU8QP+yG YKGA== X-Forwarded-Encrypted: i=1; AJvYcCVBU65EYAJ2/FQEZcP7nKaB0PLE+oLNkh/Xrq81QFtEMvxjAGSg24mWNwM0+EebSkBga78EHJ6RVE5iMRnyD/rAAypYTmsQX65ekcEt X-Gm-Message-State: AOJu0Yz2fPqBGYhckgs4hW0n/34u9o99wEPa469DEcYLcAbiU4ofHhIR TNIvZMUKwkxjMXIHXzwg7NJ/BpeEAiw9BwIlM7ivNVZ0gzHizhSh X-Google-Smtp-Source: AGHT+IF91Uh6i88LrUzD+gi+FwyOQaAtfAZXHw4cg56yiqD7KbRaau00hOa/ZC4pWwll5Q63J9ScPg== X-Received: by 2002:adf:e885:0:b0:33e:781e:da57 with SMTP id d5-20020adfe885000000b0033e781eda57mr2494177wrm.53.1711272733665; Sun, 24 Mar 2024 02:32:13 -0700 (PDT) Received: from YOGA.local ([2a06:c701:736b:f200:42b5:8c78:fc9d:7600]) by smtp.gmail.com with ESMTPSA id ay9-20020a5d6f09000000b0033b87c2725csm6490711wrb.104.2024.03.24.02.32.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Mar 2024 02:32:13 -0700 (PDT) From: Shahar Avidar To: gregkh@linuxfoundation.org, elder@linaro.org, andriy.shevchenko@linux.intel.com, robh@kernel.org, parthiban.veerasooran@microchip.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 3/3] staging: pi433: Make use of spi mode macro instead of magic number. Date: Sun, 24 Mar 2024 11:32:01 +0200 Message-Id: <20240324093201.793485-4-ikobh7@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240324093201.793485-1-ikobh7@gmail.com> References: <20240324093201.793485-1-ikobh7@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use SPI_MODE_0 to setup spi mode. Signed-off-by: Shahar Avidar Reviewed-by: Andy Shevchenko --- drivers/staging/pi433/pi433_if.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433= _if.c index 9fc93fa454b1..2a22342eda69 100644 --- a/drivers/staging/pi433/pi433_if.c +++ b/drivers/staging/pi433/pi433_if.c @@ -1164,7 +1164,7 @@ static int pi433_probe(struct spi_device *spi) struct dentry *entry; =20 /* setup spi parameters */ - spi->mode =3D 0x00; + spi->mode =3D SPI_MODE_0; spi->bits_per_word =3D 8; /* * spi->max_speed_hz =3D 10000000; --=20 2.34.1