[PATCH 00/11] Staging: rtl8192e: Style guide Renames and Macros

Tree Davies posted 11 patches 1 year, 11 months ago
.../staging/rtl8192e/rtl8192e/r8192E_dev.c    | 16 ++--
.../staging/rtl8192e/rtl8192e/r8192E_dev.h    |  4 +-
drivers/staging/rtl8192e/rtl8192e/rtl_core.c  |  2 +-
drivers/staging/rtl8192e/rtl819x_HTProc.c     | 24 +++---
drivers/staging/rtl8192e/rtllib.h             | 80 +++++++++----------
5 files changed, 63 insertions(+), 63 deletions(-)
[PATCH 00/11] Staging: rtl8192e: Style guide Renames and Macros
Posted by Tree Davies 1 year, 11 months ago
10/11 patches in this series rename variables to fix camelCase style
guide violations. The 11th patch implements the use of the BIT macro
instead of regular bit shift operations.

MOTE: Because patch #11 changes DEFINEs the compiler issues 
redefinition warnings. I don't know how to address these as part
of this submission. 

All changes Tested on Hardware

Thank you in advance to reviewers.
Tree

Tree Davies (11):
  Staging: rtl8192e: Rename variable ReturnPoint
  Staging: rtl8192e: Rename variable TimeStampLow
  Staging: rtl8192e: Rename variable TimeStampHigh
  Staging: rtl8192e: Rename variable Frame_Order
  Staging: rtl8192e: Rename variable aSifsTime
  Staging: rtl8192e: Rename variable posHTCap
  Staging: rtl8192e: Rename variable bRTSUseShortPreamble
  Staging: rtl8192e: Rename variable pBssHT
  Staging: rtl8192e: Rename variable bAllowAllDA
  Staging: rtl8192e: Rename variable WriteIntoReg
  Staging: rtl8192e: Implement BIT macro for bit shift ops

 .../staging/rtl8192e/rtl8192e/r8192E_dev.c    | 16 ++--
 .../staging/rtl8192e/rtl8192e/r8192E_dev.h    |  4 +-
 drivers/staging/rtl8192e/rtl8192e/rtl_core.c  |  2 +-
 drivers/staging/rtl8192e/rtl819x_HTProc.c     | 24 +++---
 drivers/staging/rtl8192e/rtllib.h             | 80 +++++++++----------
 5 files changed, 63 insertions(+), 63 deletions(-)

-- 
2.30.2
Re: [PATCH 00/11] Staging: rtl8192e: Style guide Renames and Macros
Posted by Greg KH 1 year, 10 months ago
On Sun, Mar 10, 2024 at 04:55:41PM -0700, Tree Davies wrote:
> 10/11 patches in this series rename variables to fix camelCase style
> guide violations. The 11th patch implements the use of the BIT macro
> instead of regular bit shift operations.
> 
> MOTE: Because patch #11 changes DEFINEs the compiler issues 
> redefinition warnings. I don't know how to address these as part
> of this submission. 
> 
> All changes Tested on Hardware

This patch series blows up the build, as the kernel test bot says, so I
can't apply it, sorry.

greg k-h
Re: [PATCH 00/11] Staging: rtl8192e: Style guide Renames and Macros
Posted by Greg KH 1 year, 10 months ago
On Mon, Mar 25, 2024 at 07:01:50PM +0100, Greg KH wrote:
> On Sun, Mar 10, 2024 at 04:55:41PM -0700, Tree Davies wrote:
> > 10/11 patches in this series rename variables to fix camelCase style
> > guide violations. The 11th patch implements the use of the BIT macro
> > instead of regular bit shift operations.
> > 
> > MOTE: Because patch #11 changes DEFINEs the compiler issues 
> > redefinition warnings. I don't know how to address these as part
> > of this submission. 
> > 
> > All changes Tested on Hardware
> 
> This patch series blows up the build, as the kernel test bot says, so I
> can't apply it, sorry.

Ah, it's just the last patch, I applied the first 10 now, thanks.

greg k-h
Re: [PATCH 00/11] Staging: rtl8192e: Style guide Renames and Macros
Posted by Dan Carpenter 1 year, 11 months ago
Thanks!

Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>

regards,
dan carpenter