From nobody Thu Dec 18 19:37:24 2025 Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8D743BB4D for ; Sun, 10 Mar 2024 23:55:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710114959; cv=none; b=gJUg1TQfzHm6D1BUwy2YArYI6KAMbmemKd5JrQw2lSEEmqIE9QOHTW7e5uDN3eI9T6kKG5D5/9+E8jGEiEDlEL+gHQ1aWkA/K9RtmA7P/96/b5cpbTgWY5zslP2Gn2lr6MQNKyNNGdNoUlscZ6YQRIQDfMSH0JGDwh/qFhgkT3g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710114959; c=relaxed/simple; bh=3K0sO1C4XLSXE8b13C4nNIhyadNMqY3iN3rrAQeDfb8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=dRxd+jV/t8AfVsVhh/K7VZ6mrOGeQEjdXXLQmlP1tALLS23sdZ6em9KSs52fQ/MSJHwxSDcYXMAAGHkyNvN/rRmtb+3bkcPoKc6AZFo47UgizrfNyTJLZEhDAJ/1NYbxVKpSu2/hFEDpAphwpcd3l1nXCJ4UpQThNDTULc2kTtI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=iaTxUwe3; arc=none smtp.client-ip=209.85.215.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="iaTxUwe3" Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-5dbf7b74402so2884081a12.0 for ; Sun, 10 Mar 2024 16:55:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1710114957; x=1710719757; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=O21vPxTFfXzVjkRb4ZxaMigBSRssVgbLO2eIiMZRryw=; b=iaTxUwe3En8/a30sVete7js9o/bttAgN6tKuvTCeTFL2fv/c3/NV+FbcRUv0GO4X7D ACDxRScW05bK8y7V20aGrHR3FF1IW65OP6aHLA1DoOmWsJHwtnmenCbWgT9MMhdu1jyT DokMCGjxMQEKZDC4QEulBbCeFgmYNy9t27k1Bxx9wFTpeJsJsBSbGvZ5QGuC+A2xr7ky 3q4Yotyp/7ljX3iY9Ngf/qZYJEOPM8f1SXtRKXXaBOEwrhVEgytyVEU+CN/T2fHHG4NM vTooH9QfiH4TlMSrdAb1OCvsqSCBfiMRSoP9CCI7qBlvvvdQBjLZhtrqnKiSH9YdKDXJ MCVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710114957; x=1710719757; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=O21vPxTFfXzVjkRb4ZxaMigBSRssVgbLO2eIiMZRryw=; b=P28kzbM/XA/2sON54B+lZUr29zoyXNMb9w81RNAkbJ2eS1j13OHdKBaEx0j5ChK7bI X5KjbmiuyJRIgj6r+YxJ+SVFeKvJOHEh4C8DIPB9VVlyGoNHBL+2HOwH+1hf6BZ8Nymt 1Z9qPqTxtjrY3jqCbF9wdUMD+ffWBDIaXrnrnXK5DFfc2kW4tz3pDw0X3b1T3yUn7Nwk SaRqOOOauu/3yEi1dSPO22H1cYWRJm+Gut0ThCYtoHm6BZXkmxxkqGsdDEQoGsQELyLV MvD9r8TZ7xVbRLvr2U3kV/hy6nF51rJWnOyt4u8csZD/rSr+5eUe6taPJQecdljJp6yE kdmg== X-Forwarded-Encrypted: i=1; AJvYcCUAPdl4jOMueYDh8GedwyFar2fQ3B0UPl0JMEmYgcFOizvMIoe10m+5MSKLd7pU71GCo3rBo3DDHl57qvZ4q1N9GLEtuSZvHbnI/ckR X-Gm-Message-State: AOJu0YyFYoI4765OctbJHgjhn9quKsnCHSKdeLmpjisDkCzUZZR0ApFg 5zATmvi1s+phbHfczIKa+Nen23TX9m2TArt/0QCCuC+uRYEOuJ971WEZ0uukCz6nOaXOIfJRFrQ o X-Google-Smtp-Source: AGHT+IG80U2lYnIb95/FIBq/xcNYhI2Eh4gJda58mSg/SdUj+hFqN33boAFHMBHJuUtkuJQH53XUyQ== X-Received: by 2002:a17:90b:3a81:b0:29b:efcb:7e7c with SMTP id om1-20020a17090b3a8100b0029befcb7e7cmr1007369pjb.24.1710114956974; Sun, 10 Mar 2024 16:55:56 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id o7-20020a17090ac08700b0029bb29ef41bsm2903439pjs.50.2024.03.10.16.55.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Mar 2024 16:55:56 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH 01/11] Staging: rtl8192e: Rename variable ReturnPoint Date: Sun, 10 Mar 2024 16:55:42 -0700 Message-Id: <20240310235552.4217-2-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240310235552.4217-1-tdavies@darkphysics.net> References: <20240310235552.4217-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable ReturnPoint to return_point to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 2 +- drivers/staging/rtl8192e/rtllib.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging= /rtl8192e/rtl8192e/rtl_core.c index 649b529657ba..08d057ab8f74 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -964,7 +964,7 @@ static void _rtl92e_watchdog_wq_cb(void *data) MAC80211_NOLINK) && (ieee->rf_power_state =3D=3D rf_on) && !ieee->is_set_key && (!ieee->proto_stoppping) && !ieee->wx_set_enc) { - if (ieee->pwr_save_ctrl.ReturnPoint =3D=3D IPS_CALLBACK_NONE) + if (ieee->pwr_save_ctrl.return_point =3D=3D IPS_CALLBACK_NONE) rtl92e_ips_enter(dev); } } diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index 6fbf11ac168f..b2b8947da89d 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -1051,7 +1051,7 @@ enum rt_rf_power_state { struct rt_pwr_save_ctrl { bool bSwRfProcessing; enum rt_rf_power_state eInactivePowerState; - enum ips_callback_function ReturnPoint; + enum ips_callback_function return_point; =20 bool bLeisurePs; u8 lps_idle_count; --=20 2.30.2 From nobody Thu Dec 18 19:37:24 2025 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A0313BB50 for ; Sun, 10 Mar 2024 23:55:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710114960; cv=none; b=Rv49ZPPZWzDW66l9+WQLGzVz/5fXjU6IJIYwizZHf5lnVe3+dDqQtBk5ORaqduVlKgVuwP2id5quppD2+VDaC7FznSGUfIl5OD7hwq2Hei97wVhDKa2qAqIm1IR+CM8ZimqJiqftoiYEAwie3I1ul6Q4xQfuG5bxWKDclJO4oFM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710114960; c=relaxed/simple; bh=QMV0z9mf9YDD1V2uvitlkWMmFWbtS8GiCtqxLiRVx6k=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=UbD48nQJHSNkqPSkO685LRd1KXCtnGWbtdvwuKD7QatSc8wfNITg2PyxwYJ3QxJaAp135LlooeKFQhZQbe0rvQ7oqYPM5pgUQarq67HgT2+vGgphO5qhVIloF8I95jtJrqUgAp0sIHsWJ8PuZkTV+P6uiM/98ECtM/ilpLxT3cg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=D+EYgsdl; arc=none smtp.client-ip=209.85.216.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="D+EYgsdl" Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-29b95c02ea2so1644631a91.0 for ; Sun, 10 Mar 2024 16:55:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1710114958; x=1710719758; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Y9TYrldhcrL23tvPQUFhNBx5Yj6HnYD00fOJGXP/nac=; b=D+EYgsdl+L3XN9qoQ0O3tFgANArKJvTjozz2iAg7jJgDA5+3+e040RPzWoh7slXzI3 5Ar2WWBC3YSZEc5Emja8nQuuMG99XDIPDrsHnHvdVmy8U6v6oubp7xe9fbVeCFbX+3YQ ZpujJa1Ptgrxl6AdiaIZtnbtR32EOz192R7mudrnKMGWYMzCpcwzr16mYttYOs9oGlqL O0bu7r8NCS/1rIKGRJnj8fYgRSBGTltYEcHKjPXSmiS6dR/WwUNxl2hVkWTaNVzeKipT wAAK/F63jJ0oAg+yK0HheSt6b2KWwryHYV3CBJjqqyR5deYQoutXuBWt5MjjMxY+V4Ul 1B7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710114958; x=1710719758; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Y9TYrldhcrL23tvPQUFhNBx5Yj6HnYD00fOJGXP/nac=; b=X8KHQFOVPS0Tjm03wKCtUE8uMXfKcpt92/Q7uBD40b2USjEYeUCHt8pVLjSr2W0W8y HDfZxZ1NcWMdn4TfTm3+cpKxk29ZWBhh7/AWsySW1gXYXGnaf6kTRGVAN2GnxQX1DBp0 sTISm6YuZ//D5dxL9gkoK1rtjQ3zxvZsT7mqNSDPLqkkOawZV1M525fTkDvlaQSPkpjc tu9V8QwTQvVumkinjY59sKh4CI2uncGVDVOL9RLTK+Jb6tV8sYOzP+83ndijYXwZrhsV y7Av+ziYUYIRlLX/RuqG9QD7NqcLXX+0TEASICXAdvX6OKVGOC4dpnGg3QebvdX6Tc4D LLzA== X-Forwarded-Encrypted: i=1; AJvYcCUTPi8+Tq8Cm0rgYN/TzS97DZis3r9YkRhqTpmYlbig9mtehhm/AgYhQdwYQwl/PhTmE/solD9xHLby0DOl25j0IjY3RLabga+UgFz4 X-Gm-Message-State: AOJu0YyLxSK7yDB5N8XQYv6nHJz2brI0+LQibF2jttoWUmCuN2OP5Vrw eiBHx1dMBJgTpQ74PNNRx3pY2FkeGgEmVIOHOM/EMW8N4TugClk01dIYP+jrJkk= X-Google-Smtp-Source: AGHT+IFuVkhYJAzUsK7cjL//XGCmaqOPV5lvrzEu/IMY3yWrVmtaT2/naXMOXeLxEmgvfGvntiYQIA== X-Received: by 2002:a17:90a:dc0f:b0:29b:364b:79e1 with SMTP id i15-20020a17090adc0f00b0029b364b79e1mr2598069pjv.25.1710114957753; Sun, 10 Mar 2024 16:55:57 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id o7-20020a17090ac08700b0029bb29ef41bsm2903439pjs.50.2024.03.10.16.55.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Mar 2024 16:55:57 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH 02/11] Staging: rtl8192e: Rename variable TimeStampLow Date: Sun, 10 Mar 2024 16:55:43 -0700 Message-Id: <20240310235552.4217-3-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240310235552.4217-1-tdavies@darkphysics.net> References: <20240310235552.4217-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable TimeStampLow to time_stamp_low to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 2 +- drivers/staging/rtl8192e/rtllib.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_dev.c index e3ed709a7674..480315404969 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c @@ -1659,7 +1659,7 @@ bool rtl92e_get_rx_stats(struct net_device *dev, stru= ct rtllib_rx_stats *stats, stats->bFirstMPDU =3D (pDrvInfo->PartAggr =3D=3D 1) && (pDrvInfo->FirstAGGR =3D=3D 1); =20 - stats->TimeStampLow =3D pDrvInfo->TSFL; + stats->time_stamp_low =3D pDrvInfo->TSFL; stats->TimeStampHigh =3D rtl92e_readl(dev, TSFR + 4); =20 _rtl92e_translate_rx_signal_stats(dev, skb, stats, pdesc, pDrvInfo); diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index b2b8947da89d..72264e1ef877 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -482,7 +482,7 @@ struct rtllib_rx_stats { u16 bCRC:1; u16 bICV:1; u16 Decrypted:1; - u32 TimeStampLow; + u32 time_stamp_low; u32 TimeStampHigh; =20 u8 RxDrvInfoSize; --=20 2.30.2 From nobody Thu Dec 18 19:37:24 2025 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5469A3BBE3 for ; Sun, 10 Mar 2024 23:55:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710114960; cv=none; b=YWckaQGqzDhhTXBBKtEVpwzW2n80S5Xa0tabznzcP2Owzqtt/JPnI01fBUw6qx/c0Vc0SKVnm9yFbO9ZseSHvZAb4HPsfk6qsMM4Np2mCc2rCbWV0SZ95OSr/kFDomsWl+LuG1mvvcFyUO4rtHtXg1+ZPC5G764Wa5T2NiP9W7g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710114960; c=relaxed/simple; bh=n7KXQpozyW+nnrXGfVAreK2+9LiwspOCcLcvVc6HNXI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=cirRYKvNp2sJ366k+HFhvp5QRAsBjVE5sjfDZWpVg5KZK9B+gTpukeWDpBomfMqu/zOXHAjndQJQivEsiz0XHLp2+UceDAY2YiyGAhrUQiswa+mt9xGk72FLloVahNHCksjR09uHH7aat0TW384Vt13bBuvlWjkxbniXwtgmEAo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=LE0VdvwO; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="LE0VdvwO" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-29bd0669781so711862a91.1 for ; Sun, 10 Mar 2024 16:55:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1710114958; x=1710719758; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FL8d9MTcpYN8bDTWPCmzHn5aeTaz5Kj78gvK+tvBcF8=; b=LE0VdvwOveZrykgFgRbaKy8gGT41plEfInE/x2+s4gQOjZHKDGArvHD+U7Vy275+MM eZRN8rlS+vQwpo2vHkwhwHS+GSrI9pS5//9QUADNiL83hDf2MVnziK+hTQWIk7Dqe170 2HmyHfJAtkX28pSb2XdWALb+I8VdtHuBw7OxxofB2/nlBzgyLdbVDiCQZyJZc+Az/B2z bXmGyE3tBDeM11IJnEAFM4Api+v1Cpmu0N4yLu7XpbmfpLD3NdLCA0RfhrfJpJ5f4hPL hVjmiXCIFV2n424ZmVL1CfTq7RHJtfGXw5c1V7e4qvT0i/LZi657u8+os2cr7kriUDkq HQXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710114958; x=1710719758; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FL8d9MTcpYN8bDTWPCmzHn5aeTaz5Kj78gvK+tvBcF8=; b=etTIELKXRPNILW1LfZFRjCxoqTM9gmqv6m7nU0/zkvPpI/sm+6g+RO4mPa6cffyv0U zEP38W07XINZ5+RhW7X0hYjeDwgQZZJxhHvO0M9tFRAHdRKQU5dzQQgJ/wcA61/BYG1K 1PveGwWqEg9inn5KZq2zFkWcTuS55gnsLLOPeAjbckEPgMrB++m1xbZOU9YDzX0BxTyk 5lA3HWh24nyNqUAzHkzDGdTW06xU8Ub59lEvUjRD1AYvunKS1pk3ALDhxfvfQIhLKNWp 8Tyfnyrd8kKtklvZPX6nZ2lGAV1kF+d9zr51aL1hyAxACXbXhFha6s1EXB/RKxsbhnya W+JA== X-Forwarded-Encrypted: i=1; AJvYcCUTvUHzHX9VmcT9UhIskb7xBCjFHybojUHJLLCNHb9Dmg4ZhJxuL0uSszTdocGWB7JzaV9oxtfXX1v8n0JJD60Yr//pyX+VdsA71rSn X-Gm-Message-State: AOJu0YwsTkvQlltUMRt82gZYpSky8dx4PovuUZprZ9hofPchbRNfJRhu DS0qf99WTC2f8JbYAi8UyK1zdpOKjcdGvNjxsDF8sBf37dE8OOhhQb4/b2ZrSvU= X-Google-Smtp-Source: AGHT+IFDJkt+sGBsjG7YpqYO6xmDXouhYwlWkHzbp38WU4LKg4lxD5K1SNC3CWszOYhKTjfwWFIgeg== X-Received: by 2002:a17:90a:9f8d:b0:29a:6b1d:4d32 with SMTP id o13-20020a17090a9f8d00b0029a6b1d4d32mr3951003pjp.38.1710114958723; Sun, 10 Mar 2024 16:55:58 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id o7-20020a17090ac08700b0029bb29ef41bsm2903439pjs.50.2024.03.10.16.55.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Mar 2024 16:55:58 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH 03/11] Staging: rtl8192e: Rename variable TimeStampHigh Date: Sun, 10 Mar 2024 16:55:44 -0700 Message-Id: <20240310235552.4217-4-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240310235552.4217-1-tdavies@darkphysics.net> References: <20240310235552.4217-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable TimeStampHigh to time_stamp_high to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 2 +- drivers/staging/rtl8192e/rtllib.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_dev.c index 480315404969..15b0ac6e6eef 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c @@ -1660,7 +1660,7 @@ bool rtl92e_get_rx_stats(struct net_device *dev, stru= ct rtllib_rx_stats *stats, (pDrvInfo->FirstAGGR =3D=3D 1); =20 stats->time_stamp_low =3D pDrvInfo->TSFL; - stats->TimeStampHigh =3D rtl92e_readl(dev, TSFR + 4); + stats->time_stamp_high =3D rtl92e_readl(dev, TSFR + 4); =20 _rtl92e_translate_rx_signal_stats(dev, skb, stats, pdesc, pDrvInfo); skb_trim(skb, skb->len - S_CRC_LEN); diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index 72264e1ef877..e165f1e32e7f 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -483,7 +483,7 @@ struct rtllib_rx_stats { u16 bICV:1; u16 Decrypted:1; u32 time_stamp_low; - u32 TimeStampHigh; + u32 time_stamp_high; =20 u8 RxDrvInfoSize; u8 RxBufShift; --=20 2.30.2 From nobody Thu Dec 18 19:37:24 2025 Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06C0D3C08D for ; Sun, 10 Mar 2024 23:55:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710114961; cv=none; b=Yh3MGi1nuMQRMLuFS8Nzi0iQaUquQVF4TZ9/blQ5+NrLSrK5U8TSdMgD5OQA1sxYJaTBNNeZkKiNF5pjEPjt7KO9sWxDGhhNVmMIWO1f2tqzvxNcdRkb2uFuTKMjTGkaVM1/Vobe1B5fAfR5ocDJtmfmQ0kOsdQJjc9OA7acGWE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710114961; c=relaxed/simple; bh=/7W2TBTFMXEWX5q4IZIqxcsH8VjtOr50ERYjHCmesi0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Rca/AsKW/J1FCSo2pSW5DHbylENPOJb3evPHju2t/C5gFv4IgngtFP+rmexRq2oeXHfONrEVJ0E4nggicCjedd66mpejFbIutLn3uiuXNer60TmFttEQOAX+gEaEtUvhWTFRSGX27ebDS/dXCzkRi5zCdT69zb1nKIfLrg9l+Ds= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=VzagO1+j; arc=none smtp.client-ip=209.85.215.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="VzagO1+j" Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-5c66b093b86so3563952a12.0 for ; Sun, 10 Mar 2024 16:55:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1710114959; x=1710719759; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SFuDApE8FQFMLl4CuhW76of50jVUBMd2o0lVaLFxbvY=; b=VzagO1+jWfI9bDvHn2AZbaK/N2p92R7kETn6tsYAMYVQZfSgOjGxrN/j/clE8mOOvA 7UiJcJPvFBvpr269BkhcpVrmE65PWE0UFEBCW1oP4FqXx56ZLFNNezMcRF3yhAQlFvCv 9uipNjyRu3rOi/hSc3dkIzEFaydQ2dyuu83L2fLYE4rX+wW9C0ESDTmflltSysBKkuFf NsJWtd0f/B9cfOqYCiTjn63ywaNxxwj2gtJ8zDm2Y8SAqYU6yCy3mJeWudHeWDVJXgy5 nlv/G36QwAEqznXmhgWOrVsBdkE2VTuPnhA1czSnWSF64kK7Sm7gh6hDMq4OCO6mFmEQ hu6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710114959; x=1710719759; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SFuDApE8FQFMLl4CuhW76of50jVUBMd2o0lVaLFxbvY=; b=MrqndcXyi+HEaglOpEES3obVc2zPw6ily0XIJZkgI5MrdNgYexq9b3BR7LSMf9j+rR BX17/K2eX5FMLIjdD+9rETXbPaPEdCHT7VG+Kv8q1zob7A2Be69W+9mEs9ukP6cQnPH9 keM/32C9cEsXWHsmL/OdSePWNEhVNjY06RvPOs1APWczu9yC5MzhmNuSWHzBSKX8JXTO SvxniTelD8SZioqMp/BGfltyHsGgC+pOW9EP0yDFD0uylgJvyaWK99N/cfveVqzo0XUw YXU/GOWHJzrsy8smfsRQ+fyjosKJQOszukMnpHUZzm0/30+NEi0CiW+yvLnxKz/wAbIs bK5Q== X-Forwarded-Encrypted: i=1; AJvYcCWZqdsD8mAm6zFVfDslgw4+FoFuoRO9P8CBFgq3qyzjN/dNCS+aGqAtPhyVaUTyDQhlMZGrTEvsWaonCNHkFIpdo13VG89WI1pedHvS X-Gm-Message-State: AOJu0Ywh5XLv+vOnNfBwC62ApRs8FUnl6yv205yldmL/7TTSdWfcxcG7 LliV7TEcWZorqF9FTwkzEi+J5a+/D8bzy1npab371U2yn7qVv/UbuMzzgN2z0+k= X-Google-Smtp-Source: AGHT+IFvNR7UEMWVzVCIr634nx0mJcfHMJDJZXdKUnyD9DRq5o0Osi1gfGQWUr1Eps07OMoJ0910MQ== X-Received: by 2002:a17:90a:fe10:b0:29a:ee6f:58cc with SMTP id ck16-20020a17090afe1000b0029aee6f58ccmr7323537pjb.6.1710114959374; Sun, 10 Mar 2024 16:55:59 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id o7-20020a17090ac08700b0029bb29ef41bsm2903439pjs.50.2024.03.10.16.55.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Mar 2024 16:55:59 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH 04/11] Staging: rtl8192e: Rename variable Frame_Order Date: Sun, 10 Mar 2024 16:55:45 -0700 Message-Id: <20240310235552.4217-5-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240310235552.4217-1-tdavies@darkphysics.net> References: <20240310235552.4217-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable Frame_Order frame_order to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter --- drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 +- drivers/staging/rtl8192e/rtllib.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rt= l8192e/rtl819x_HTProc.c index fa96a2c2c916..dd0e2931b9ca 100644 --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c @@ -625,7 +625,7 @@ EXPORT_SYMBOL(HT_update_self_and_peer_setting); u8 ht_c_check(struct rtllib_device *ieee, u8 *pFrame) { if (ieee->ht_info->current_ht_support) { - if ((IsQoSDataFrame(pFrame) && Frame_Order(pFrame)) =3D=3D 1) { + if ((IsQoSDataFrame(pFrame) && frame_order(pFrame)) =3D=3D 1) { netdev_dbg(ieee->dev, "HT CONTROL FILED EXIST!!\n"); return true; } diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index e165f1e32e7f..748bb25cbd23 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -343,7 +343,7 @@ enum rt_op_mode { #define IsQoSDataFrame(pframe) \ ((*(u16 *)pframe&(IEEE80211_STYPE_QOS_DATA|RTLLIB_FTYPE_DATA)) =3D=3D \ (IEEE80211_STYPE_QOS_DATA|RTLLIB_FTYPE_DATA)) -#define Frame_Order(pframe) (*(u16 *)pframe&IEEE80211_FCTL_ORDER) +#define frame_order(pframe) (*(u16 *)pframe&IEEE80211_FCTL_ORDER) #define SN_LESS(a, b) (((a-b)&0x800) !=3D 0) #define SN_EQUAL(a, b) (a =3D=3D b) #define MAX_DEV_ADDR_SIZE 8 --=20 2.30.2 From nobody Thu Dec 18 19:37:24 2025 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B09B33C484 for ; Sun, 10 Mar 2024 23:56:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710114962; cv=none; b=lUzkgCcqekX+YvAqbSJO9TgzpfSYljxDcwtwOQeZ8fd5/woynfwvD96aM+kZ7cvXFeNuxOWWWHzQEbNd7w3mAl9QCv1omBVJnZRZQbWUUdnj7oZ8priILGIr3h0p/fMlZEP3Br5qC/XVvyVLlNWLl0xqmKws0jtGML1xHCD3+l0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710114962; c=relaxed/simple; bh=bweBxxz3LlZ0HmKixuMAFxkEfCgWUQfWz3S2D81EsJw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=GiZRitfLfAL51x7POczReIkTtukBY3yeJhAr8WNSc+3RtM8MZR1eVJSGjr9GTyjvRIhNxd4SzAyavC/uLgdD0iXIPB1JZUvrcHvZjAjlsCe20fsp7Mi+j5oaVV+U7HVk6z64OADDvYCv0IRHbJDGoWMdyf0EnnpGA2T9rrPK8hQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=gJIaLuYt; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="gJIaLuYt" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-29b7164eef6so1922078a91.2 for ; Sun, 10 Mar 2024 16:56:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1710114960; x=1710719760; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vBTPiNFuf4aLeiCUUd1FRn8541x9xrCbKeUzzWFh6y0=; b=gJIaLuYtmiojDD210dfDrpHi0QeP1aYrG59hqkxhaWFUSiKolrgVZBSIDkK0CXYK6M rngFaNYcS0CHUKSAxTG96eV7HCYWl6ACcCmjHdDiGqjes7XPBqGssuD6LjOpr55cY7Ks jx8Wd0oCPfAAF+aOtcMPc3O1+bvCJBJcQtX3CH4ssKFc3J84sTVWN8JnPhvPSddRcYR+ F0JtcyCA3OIb32X+HQeHYTm/nX8zJsO7vbVwdWyrqDLqzRoaDPzK7XcAQzayT4KtYWDw 1joxfD+SKPz/h/4/VLryPpwr+mtMBiuAaoFk3Kb0VwcUXmfvwmt+dbBuU07cyKkVQyTI RcqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710114960; x=1710719760; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vBTPiNFuf4aLeiCUUd1FRn8541x9xrCbKeUzzWFh6y0=; b=Pvl6o8J5lMVWNyCkTaHgo77MtXTSpDYMGdusvVWaV3t9LSUQqNmvKzxXkyMQEPsHKw k4gJ3jzbW+u6ZQlaPyCoaWS6XPK00wmMOMxmO6o6376JpddF1MTCI+y9a/ojD+OdW355 +lgXRUzCWs2Pyf+qlO28yIjULIfiULsoeCQBTeFFt1PMtTTwIO/AVlphsJ/6EZHkFm99 4SeSxswo6KFVg6OIVfrZ9NSOV91NBOpxJRWautnV4EDo9Kex5tzrdSLx32UUgAVJy1xA YpL+sEHLTi4GjizcLMQEv3g7wt1QtzFEc7C13egt/s7APAZeH3/g1yV6m92e+5mh6PCv oA4g== X-Forwarded-Encrypted: i=1; AJvYcCUNfehV2lSapZ9SXSwf/vwlQqNwTgqBQsLxZt4/TCa2/DQWx0Lm7jTUnqV0XozhAZrRECKdu4oyiTwl6LMIR16XmRkR5n7O6rMlNMap X-Gm-Message-State: AOJu0YyHfEsx8HjO9aw7sBDI7HJNjlHR/zAbE0XhVTpE5BCO68P41l/2 2ob6yJ9VN8BYb16iI+QnIsV/zQjDIsyBYWpp2B/w+QjfRcm4BUYwW+nJo4eWOmQ= X-Google-Smtp-Source: AGHT+IEZmMmuGHF5Ga+XC93hN0IcCqDus5vAc6pEcEZMM5blm/JErY6CmFJSYnAk7cNANb0tFX9CVQ== X-Received: by 2002:a17:90a:300a:b0:29b:2779:2a69 with SMTP id g10-20020a17090a300a00b0029b27792a69mr3712320pjb.36.1710114960070; Sun, 10 Mar 2024 16:56:00 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id o7-20020a17090ac08700b0029bb29ef41bsm2903439pjs.50.2024.03.10.16.55.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Mar 2024 16:55:59 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH 05/11] Staging: rtl8192e: Rename variable aSifsTime Date: Sun, 10 Mar 2024 16:55:46 -0700 Message-Id: <20240310235552.4217-6-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240310235552.4217-1-tdavies@darkphysics.net> References: <20240310235552.4217-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable aSifsTime to asifs_time to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 2 +- drivers/staging/rtl8192e/rtllib.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_dev.c index 15b0ac6e6eef..dcb78cd2e840 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c @@ -130,7 +130,7 @@ void rtl92e_set_reg(struct net_device *dev, u8 variable= , u8 *val) &priv->rtllib->current_network.qos_data.parameters; =20 u1bAIFS =3D qop->aifs[pAcParam] * - ((mode & (WIRELESS_MODE_G | WIRELESS_MODE_N_24G)) ? 9 : 20) + aSifsTi= me; + ((mode & (WIRELESS_MODE_G | WIRELESS_MODE_N_24G)) ? 9 : 20) + asifs_t= ime; =20 rtl92e_dm_init_edca_turbo(dev); =20 diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index 748bb25cbd23..640fb8abcfa3 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -299,7 +299,7 @@ enum rt_op_mode { RT_OP_MODE_NO_LINK, }; =20 -#define aSifsTime \ +#define asifs_time \ ((priv->rtllib->current_network.mode =3D=3D WIRELESS_MODE_N_24G) ? 16 : = 10) =20 #define MGMT_QUEUE_NUM 5 --=20 2.30.2 From nobody Thu Dec 18 19:37:24 2025 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 63B473D0C4 for ; Sun, 10 Mar 2024 23:56:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710114962; cv=none; b=u1xkYBTw1vqpCwfTxIDk+WkpFfcYnO8P2lBbyc/IVQqfKYsQ9KPAW8QCUoTo52Na456Fpzy/ZVDFVN6EVdLieoxc+TiYB2qsAGNLw/yduBxG/E5V+4UQHSGJ0RVnclc70uSDMDub33I7+rt9Zequ/C7+rtlFyUBpPca/Yz1AOg8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710114962; c=relaxed/simple; bh=2z5au05SIFx2OjI10T3LxZdsNMivY8wiNBtTg1TTQfg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=oSBM3MQXexF3aTPgY6OlqS9JA1xxEjiMNwSWzfXHw6sotxC+f5wApjHWwfI3tOAVys2ArCMZDhA3NIDkvhRXfaMUH9FP+Ca/C9I11Hh8AK0BQOCl+qxFa3jhoWOWnWTtQkKFCV5oUNLDVMkUxdMRFTKwhQvghYMyyf8BaM0ZBnQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=EqCgf90j; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="EqCgf90j" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-29a2d0f69a6so2510896a91.3 for ; Sun, 10 Mar 2024 16:56:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1710114961; x=1710719761; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+aLp3TbZt7Nin0dNx9AujLhlrUoyJ4oXXhWmCb5RlNM=; b=EqCgf90jrm0IPIw0JPvIKdX1Vjc7daD3hcMpd7HjDY41QQCNrfkjtL14r1Xdc5Hpvc jgVSVvc4eRivuF0VZKJ7BdH+Dk8dHOpLiseHb0eDGal8GsrkTEpaxtFxxbKNp1b3uE+6 qxvCz+spk9kZ1xPvr7YwucFH+YYOe61I3wbm6Kh/TDh+mwPFaX5+dWEysD6NcN2mg+Hv VnR8z5+sp81a61BYYKTkmZ+wveLahyuY5l+kdyVkEix6EhkIya5W8XdCUd4vO2OOxyU6 yu786ODhvjHVitVXajNzcWOkMphX93I4kqtbQSIQXpyCwOeM6tvEQeoVO41eJ4aDANuP Q3Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710114961; x=1710719761; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+aLp3TbZt7Nin0dNx9AujLhlrUoyJ4oXXhWmCb5RlNM=; b=TWliNiV+UNbULl4GHIll+iWgQh1LlWFKU5ukvleEirGc25OXOwxVpzw9abnn7hK664 3yGOy2bSl68ws/a4BpW64tS4LplfzGyOnVl6PdyvhVGT/LI86ihOV3l1Mn/cY3hI9bDF KzPzHQGT4i/G1ZSv0+6OgVvXue53Jm+DhKAm9+9QR8ltBn08MeXJqjr0ZuEkuSiYBZOg f8OOxKAO2vmPM4DQl98lXYBnv+iLy2KsLuu4rb15HpgNnyHzVJFjUkHXs/dVI49IWowW UpTaYZ4IrPo2R6Dm3nktX5hIYAV8fgX6hwGyaQMOxKunsQGLSZkEV68/JWLd408AaySw FH4A== X-Forwarded-Encrypted: i=1; AJvYcCU9OVoJg5SDDuWokzTT1UhNg4eUAGmaN79jxRaHgRgqC5RSLlSalskpGiFPVb1bsO/E3G4fPiThSCvnBmgk3yc+bDLqbtw62k03hCn8 X-Gm-Message-State: AOJu0YyGDZ1tnG+wOfdKPNlgjF7dmLTdZn5vyffVWyWcaLTwlezynhdy rklGQGcUmfy8sKgwRoq5yMv2nn+LvIpwhO0vqup71D7ge0Pa0iGEK2zsSM0vfFY= X-Google-Smtp-Source: AGHT+IEQUXU4Mse6356LFmqZAOo6r/3WjPG3NJ6sjRGTpTcR4Wb8U0xFVc7PTDhsih6auD7Wz+96ag== X-Received: by 2002:a17:90a:43a2:b0:29b:90d7:36dc with SMTP id r31-20020a17090a43a200b0029b90d736dcmr3537987pjg.19.1710114960871; Sun, 10 Mar 2024 16:56:00 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id o7-20020a17090ac08700b0029bb29ef41bsm2903439pjs.50.2024.03.10.16.56.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Mar 2024 16:56:00 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH 06/11] Staging: rtl8192e: Rename variable posHTCap Date: Sun, 10 Mar 2024 16:55:47 -0700 Message-Id: <20240310235552.4217-7-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240310235552.4217-1-tdavies@darkphysics.net> References: <20240310235552.4217-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable posHTCap to pos_ht_cap to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter --- drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 +- drivers/staging/rtl8192e/rtllib.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rt= l8192e/rtl819x_HTProc.c index dd0e2931b9ca..1c3ef1b7ebd8 100644 --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c @@ -235,7 +235,7 @@ void ht_construct_capability_element(struct rtllib_devi= ce *ieee, u8 *pos_ht_cap, =20 if (!pos_ht_cap || !ht) { netdev_warn(ieee->dev, - "%s(): posHTCap and ht_info are null\n", __func__); + "%s(): pos_ht_cap and ht_info are null\n", __func__); return; } memset(pos_ht_cap, 0, *len); diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index 640fb8abcfa3..525242b0313f 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -1736,7 +1736,7 @@ void ht_set_connect_bw_mode(struct rtllib_device *iee= e, enum ht_extchnl_offset Offset); void ht_update_default_setting(struct rtllib_device *ieee); void ht_construct_capability_element(struct rtllib_device *ieee, - u8 *posHTCap, u8 *len, + u8 *pos_ht_cap, u8 *len, u8 isEncrypt, bool bAssoc); void ht_construct_rt2rt_agg_element(struct rtllib_device *ieee, u8 *posRT2RTAgg, u8 *len); --=20 2.30.2 From nobody Thu Dec 18 19:37:24 2025 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4320A3D980 for ; Sun, 10 Mar 2024 23:56:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710114963; cv=none; b=pilc1zeUGqzaifln16lJhO3YyEMKNOOdP8oUYSU9Vk8yjeC/FsPvRat0bLfSmgUoNrXnDyu0X8cXcldMPUlnuXujcnjMNF/Q2t0350Lhe4hpUZn8SSe5kUbMXYj4wxZT6molUGGTt4SWG3iI8nlVUiq+bqYDrjJMysf91gQLBg4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710114963; c=relaxed/simple; bh=HADUIoGNxxZzzQVbd0yS7ovHI657F4f4qpl2PdUmfl4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=qTqMG49depQXV5vz9sqULn7Q1KTDtAlT6TP9dIi+xI5RmBUMQKMK2ezIkfCiIyqA3NPaYNQQmpfSg1+jcuDJ8r5TU88Zms2Dwqg1ETsa8eU1TFmtFaPL5P7dvx2ndT3iQjc/msVRZxQHO+Aa9q+5jIS72VJqMHtiLUwZzRhHpX4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=jVEKdv7+; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="jVEKdv7+" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-6e5eaf5bb3eso2836253b3a.3 for ; Sun, 10 Mar 2024 16:56:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1710114961; x=1710719761; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3ek+tNEVfANxjTbowDv0K1U1oO/hLiu0/vhpb377ZsU=; b=jVEKdv7+AXbtA456K4lLrfhr//Txk9X/9BesUCj1T3MYRgBtcB2MmUVVd5TQvSiGmc ZEpQZUm7n8PWrPIP0m9+86COnSEMiFdzvUONwTNQ6ur12BvCItdk0egsW0aLbJ2r0qlL KYbET4TJJcVaAgLpzHGW4mh2AqqVJoqo0DDGqagS2cGp8mg6aN+JHU+pE+r560VvP+HY YMob6xGZNkmOHVhk3vOaORjXaZZkCHqVp8f703o36RXknmZOtn4sC6YtHxyKnvKLPIVP 8bfrzxgfsZ2ON73S9YFQPdI1lhgj37Fn/7dACVe2T064fplQQR1GfVkgbCuLk9FRwsd2 VbZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710114961; x=1710719761; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3ek+tNEVfANxjTbowDv0K1U1oO/hLiu0/vhpb377ZsU=; b=O6RUpC8cQMl/mkA8GogOFHAB+1ENyCBMpxwwgffRsa2ASd6xhy7CK995FphdmBk9iJ +rhgyHb3h/WP6GOabiTPI3LWIphvFQSOTwmUXNWPp/q0eAPiMvXGKihBM9DF3yGp7StD s1eATNdcFtv0c8lXz8F4p9tVRbVOXKagqlVzXCBC7msbZUfU5Vt8MvkM+mypScAQ4oID E/p1Y9275zXPJ8S7cUEk2ZzjtravfSBCiWmpSzf6r0xZVPQVuiwVWqbVtg1nN7YUDWzn mpdXm62Us6YdApmFCcV/uf9C4F1b0q5HVT9mU26Xa4BJ8Ivg5BefKnsfFIkXwf7XKEiG Oohw== X-Forwarded-Encrypted: i=1; AJvYcCUgLpQg68UMqsjH4gARBZgDVYg/8eFpCmZ/UbTa5K4l0W9mf+rbmY9eg477X8Codc8kzp6vnymZoHIQ/O8lUK3fcbUED9WQq9rGjjkt X-Gm-Message-State: AOJu0YyIHEUzb4pF0m4PiFdhnUCil7sxEBXnmubJTcS8oZ+PFq5tlLcd DThGToKFEoyQEiX5cw8XuXaTdn8JYtahM7GozIynegaCNwlo4eT3vY5CR3Mhgqxa11WO7Ia4m1V a X-Google-Smtp-Source: AGHT+IG7CX8dL1RSwnt03aj3Eop80TAIeNKxlDtk7/JKFUXyCnlK82z7gXgIDqAY8BQmAbDiyH4v0g== X-Received: by 2002:a05:6a21:1f24:b0:1a1:67fb:924b with SMTP id ry36-20020a056a211f2400b001a167fb924bmr2233425pzb.28.1710114961466; Sun, 10 Mar 2024 16:56:01 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id o7-20020a17090ac08700b0029bb29ef41bsm2903439pjs.50.2024.03.10.16.56.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Mar 2024 16:56:01 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH 07/11] Staging: rtl8192e: Rename variable bRTSUseShortPreamble Date: Sun, 10 Mar 2024 16:55:48 -0700 Message-Id: <20240310235552.4217-8-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240310235552.4217-1-tdavies@darkphysics.net> References: <20240310235552.4217-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable bRTSUseShortPreamble to rts_use_short_preamble to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 2 +- drivers/staging/rtl8192e/rtllib.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_dev.c index dcb78cd2e840..41373c013299 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c @@ -900,7 +900,7 @@ void rtl92e_fill_tx_desc(struct net_device *dev, struc= t tx_desc *pdesc, pTxFwInfo->RtsBandwidth =3D 0; pTxFwInfo->RtsSubcarrier =3D cb_desc->RTSSC; pTxFwInfo->RtsShort =3D (pTxFwInfo->RtsHT =3D=3D 0) ? - (cb_desc->bRTSUseShortPreamble ? 1 : 0) : + (cb_desc->rts_use_short_preamble ? 1 : 0) : (cb_desc->bRTSUseShortGI ? 1 : 0); if (priv->current_chnl_bw =3D=3D HT_CHANNEL_WIDTH_20_40) { if (cb_desc->bPacketBW) { diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index 525242b0313f..cf75d1225501 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -121,7 +121,7 @@ struct cb_desc { =20 u8 bRTSBW:1; u8 bPacketBW:1; - u8 bRTSUseShortPreamble:1; + u8 rts_use_short_preamble:1; u8 bRTSUseShortGI:1; u8 multicast:1; u8 bBroadcast:1; --=20 2.30.2 From nobody Thu Dec 18 19:37:24 2025 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B0A6E3F8C3 for ; Sun, 10 Mar 2024 23:56:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710114964; cv=none; b=JFr/XJzKweFyGgGrtPg9cVjoJh9zBiTI/Wx42L1S8kZ7x1sY38VRSjZR8Apaf4QtH7gkxcNyYcALO/adcAWNoXQ3SO4ZohfxLKNNhHQAwxlyV+OA1gvpEROK1UJpkOXwnFxGjkT14FhEtqO1pnKx4PfxNeJhynQtdgEYC+c5CG8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710114964; c=relaxed/simple; bh=vt2AS0MY2T5K9VNmNLC6qpITMvYnpGjqYDDGu9p7wvM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=o/kjKSLec0ohV4amyMktvGTElHTACBFbkk61Bx3bc9iLtbZOlVpKyNOQdorF/r9BCgz46mtGhtqjS8AXV/wqimunl2D+4U8yE8IrRkrM9wUJ+maKRxe4LPO4StvAkzRUtn564AbSkhzsaw1QadRYsYVnuqNdUcCFj+zVkDSkmQw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=Fbt6awNK; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="Fbt6awNK" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-29bad5f4ae8so1740369a91.1 for ; Sun, 10 Mar 2024 16:56:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1710114962; x=1710719762; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2jkuqB7qYV1V/hZ7KuA1uZbe/cubaPjlVg/I55Vf+yE=; b=Fbt6awNKAkjCEzZqXy1JEmsMuNYlBV37/rjyR/gnsoqhVdjsHk9l1TgQ1zs+EISU+Z BX9fbyu+iS1dnG/5q2LUj1lIrBu9mim8q+NPef/tl5BEcRvIQrNBP9nR4XkRfa8vKuFJ GjdX8b4DztfXSvzBTSOfpcFKDMnLtHUqT8cnvFnw5u+VtUNwV7dxwa6+2rV9CWC8cM95 BbA4gZFbl8KL2tQYjRWrtcoNW0Ocz8ZPEb5au6uxPf9csJvSJE1ivtUFp0kKlufVvAMg f/hFWSpZ0TiRTDE6PabpU8NrA3XdyCKjXcWHG4S3M3OEhqVWwUY6Sbn726aW9y/YTl42 ObZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710114962; x=1710719762; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2jkuqB7qYV1V/hZ7KuA1uZbe/cubaPjlVg/I55Vf+yE=; b=MiZ0E4Bq2iJqzHUze+upWke5jYTz6/8EBU6MEGGffu/ZAGPJmTZFXFVAwtTNcbIzrp RRZb8hgDNdnXr7bipxTHihTADeIxS7vYhciVo7k9KFJbJicm/SjivJblrNu5btSu9YGw 8GOhijxJ+7Scv+g+oWak6dzf24gOr5LENyJdXTXWvkcXNlqCnhjSYvl2xewR16YJzhW0 iAI/9MnO0WnPlOk5kCAehbbEl9G5/nvQxRua+iNnRsrNjcUX72n+IFM9DGf5w9N8Kjal s5OzyD134FpuQLytOrtUY0RtLWtl8GJ09EUa4v2aimuGDzE5RDIT2ZDHg/C4rPkeH5xu 4YaA== X-Forwarded-Encrypted: i=1; AJvYcCVKiRK9l26qW2Aot074tbPDJYlNlX/g8FjW312VM4JNi8u6WSs12gUeWcwqAeqkcBDCFWNAQzO7DxLYWy3MF/FtvZK4ZmhPRZpc2tQj X-Gm-Message-State: AOJu0YyqonofodaHgqrFraKsBierbAwyhBwXvmuQZhtTzLGii0A2S0dJ SDUUbf8oaRZ/PxI8C3ghIsQlbr7HsO+ICGcU1INTRT+BSc9tPSRuanuwEU4ha2Y= X-Google-Smtp-Source: AGHT+IErnq8bbjzofXvfZsXHjRCyuNv83rcb1XF4zm4IiAjFp2CfdNYJUbASppyyMagZYgs85rgH1g== X-Received: by 2002:a17:90b:a18:b0:29b:badf:cc1d with SMTP id gg24-20020a17090b0a1800b0029bbadfcc1dmr3893667pjb.29.1710114962133; Sun, 10 Mar 2024 16:56:02 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id o7-20020a17090ac08700b0029bb29ef41bsm2903439pjs.50.2024.03.10.16.56.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Mar 2024 16:56:01 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH 08/11] Staging: rtl8192e: Rename variable pBssHT Date: Sun, 10 Mar 2024 16:55:49 -0700 Message-Id: <20240310235552.4217-9-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240310235552.4217-1-tdavies@darkphysics.net> References: <20240310235552.4217-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable pBssHT to bss_ht to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter --- drivers/staging/rtl8192e/rtl819x_HTProc.c | 20 ++++++++++---------- drivers/staging/rtl8192e/rtllib.h | 2 +- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rt= l8192e/rtl819x_HTProc.c index 1c3ef1b7ebd8..618523bacc8e 100644 --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c @@ -543,19 +543,19 @@ void ht_initialize_ht_info(struct rtllib_device *ieee) } } =20 -void ht_initialize_bss_desc(struct bss_ht *pBssHT) +void ht_initialize_bss_desc(struct bss_ht *bss_ht) { - pBssHT->bd_support_ht =3D false; - memset(pBssHT->bd_ht_cap_buf, 0, sizeof(pBssHT->bd_ht_cap_buf)); - pBssHT->bd_ht_cap_len =3D 0; - memset(pBssHT->bd_ht_info_buf, 0, sizeof(pBssHT->bd_ht_info_buf)); - pBssHT->bd_ht_info_len =3D 0; + bss_ht->bd_support_ht =3D false; + memset(bss_ht->bd_ht_cap_buf, 0, sizeof(bss_ht->bd_ht_cap_buf)); + bss_ht->bd_ht_cap_len =3D 0; + memset(bss_ht->bd_ht_info_buf, 0, sizeof(bss_ht->bd_ht_info_buf)); + bss_ht->bd_ht_info_len =3D 0; =20 - pBssHT->bd_ht_spec_ver =3D HT_SPEC_VER_IEEE; + bss_ht->bd_ht_spec_ver =3D HT_SPEC_VER_IEEE; =20 - pBssHT->bd_rt2rt_aggregation =3D false; - pBssHT->bd_rt2rt_long_slot_time =3D false; - pBssHT->rt2rt_ht_mode =3D (enum rt_ht_capability)0; + bss_ht->bd_rt2rt_aggregation =3D false; + bss_ht->bd_rt2rt_long_slot_time =3D false; + bss_ht->rt2rt_ht_mode =3D (enum rt_ht_capability)0; } =20 void ht_reset_self_and_save_peer_setting(struct rtllib_device *ieee, diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index cf75d1225501..3819a859710d 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -1742,7 +1742,7 @@ void ht_construct_rt2rt_agg_element(struct rtllib_dev= ice *ieee, u8 *posRT2RTAgg, u8 *len); void ht_on_assoc_rsp(struct rtllib_device *ieee); void ht_initialize_ht_info(struct rtllib_device *ieee); -void ht_initialize_bss_desc(struct bss_ht *pBssHT); +void ht_initialize_bss_desc(struct bss_ht *bss_ht); void ht_reset_self_and_save_peer_setting(struct rtllib_device *ieee, struct rtllib_network *pNetwork); void HT_update_self_and_peer_setting(struct rtllib_device *ieee, --=20 2.30.2 From nobody Thu Dec 18 19:37:24 2025 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5761A3FB8E for ; Sun, 10 Mar 2024 23:56:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710114964; cv=none; b=tUPO338FszT640HG+pmtFJlujGxMryLNvsHd92m2XtDsBnuEhDosAoHW9ytbQKu/qgcvjwbZAB9fPWPPou4taCHYSTVMURw+i36DV4rqRlDmNTKhF40c2uuUUWbqwk9r0F7x3dOTITT2KP0/c9btjtdwwrmqWezVms+eg95xUIM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710114964; c=relaxed/simple; bh=0rM740sBdk8huHY4NhOTOHcOY/GxVUJCFjfyR5Pl/4w=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=CjDY7iodSQrdW5xQmvCznZKr1YFGVWMbWfIGILwK2WSSxiUAQvbOwRxpHUeTsknNV2xO/giprs1ZjPSjt4VNPpk+zD3AQjttdURvEbCPai98Hz6w2TdqnHyQ9euM1NkEX57Db5MMt3j8IvXrTOnPVQZpPqg/KpI0xgppYTBoIYk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=PNecXnWe; arc=none smtp.client-ip=209.85.216.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="PNecXnWe" Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-29a8911d11cso1953952a91.1 for ; Sun, 10 Mar 2024 16:56:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1710114962; x=1710719762; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=s7EKp2vsKNvqYuCUlnv6xBioKoVPQsG67LiV/PqaQG8=; b=PNecXnWeF/EGHNEztZMnXzk216d5b7YDmKAtqYOZ3LVaDDVsmb/nQSwA/CBeg2iFuo 2VKLByyJi/XscA0JW6KL4jl01gPNWUip6Op741iKHTaoHQsGmULYQ9WmB/qFs1ZI6ON+ JPU45IBrNeOO/JDPwgaPGj03jmTv/2C1AE+ccV9JfchUdyYspdv2uXr/7SGUWAn1EUMH dv+ow/7XlMEijQeT0KF0vTHBqCi3zwPYuX26Kmvyl94fSNtqN1zzu3osVvpLQiq9p9F2 Vr7jVuQ17czFw3BepFunpg5YGPg/Ph1en97tQSFF9rsyYI5DkrA2n1x7A6HtsISOo563 FReA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710114962; x=1710719762; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=s7EKp2vsKNvqYuCUlnv6xBioKoVPQsG67LiV/PqaQG8=; b=GfFypx6giPHOZI4oM7iovT6nRyndYNZvWSZXSI1bSG+kD7WfOX0IH0OQ+uz0NYkPtx 72fh0oWdTdMpETXY6d5SaxB7x1Z6WHKccgOup0HXTA2wzV9mU4SLIuRVBhIfHehf9ENu R8HHDqSOt4zA7YUndTrjHj7koZaaHNxmhQGNV2C7Vv6LW6CpNMw19r5Ns4XNan6AtyIw 8Zef4VfFJ+hJ0TBVG4xjSk7eAya/qxQGPKA3Rk4T1MLUb1FE4KPiGpYvsyAD2mVaaH65 u5xighcwohhdEuj0iPDxOYnPuch1KIe6qHBu8EyNhjsJ3utsGg2NiQxZHl2gkfewnheb du7Q== X-Forwarded-Encrypted: i=1; AJvYcCXtNIlZRCYxXujAUuEO3h3Clv1mCAHYg56odW0mCb35I04X1TU1BT2Ch2ZU+vTvF2RuS4AcZdQEMAO3QJZJAVZA4QzTH6R/gFUj97V+ X-Gm-Message-State: AOJu0Yy7zLXvozpaSpZ6drQtUK80lV/GJRlqBcJF5YNPTYnKtbxhYhxo e/JBaisha6K08aPl6DZW+d+R6NEThPKfRE2zLuS3ezCVsw3G8c+2IC/CbtXbD6w= X-Google-Smtp-Source: AGHT+IEyS1YeZzKbvQgPctRBcV6Cg1k8qI2HQXgKh+rzOM36uKfAjbZhzNULukcyyLJwJ52A5lvn5A== X-Received: by 2002:a17:90a:df96:b0:29b:aae6:49da with SMTP id p22-20020a17090adf9600b0029baae649damr2396493pjv.47.1710114962764; Sun, 10 Mar 2024 16:56:02 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id o7-20020a17090ac08700b0029bb29ef41bsm2903439pjs.50.2024.03.10.16.56.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Mar 2024 16:56:02 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH 09/11] Staging: rtl8192e: Rename variable bAllowAllDA Date: Sun, 10 Mar 2024 16:55:50 -0700 Message-Id: <20240310235552.4217-10-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240310235552.4217-1-tdavies@darkphysics.net> References: <20240310235552.4217-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable bAllowAllDA to allow_all_da to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 4 ++-- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.h | 2 +- drivers/staging/rtl8192e/rtllib.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_dev.c index 41373c013299..e3276d2c3616 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c @@ -702,12 +702,12 @@ void rtl92e_link_change(struct net_device *dev) } } =20 -void rtl92e_set_monitor_mode(struct net_device *dev, bool bAllowAllDA, +void rtl92e_set_monitor_mode(struct net_device *dev, bool allow_all_da, bool WriteIntoReg) { struct r8192_priv *priv =3D rtllib_priv(dev); =20 - if (bAllowAllDA) + if (allow_all_da) priv->receive_config |=3D RCR_AAP; else priv->receive_config &=3D ~RCR_AAP; diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.h b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_dev.h index 878c96236824..1224f190937e 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.h +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.h @@ -21,7 +21,7 @@ void rtl92e_set_reg(struct net_device *dev, u8 variable, = u8 *val); void rtl92e_get_eeprom_size(struct net_device *dev); bool rtl92e_start_adapter(struct net_device *dev); void rtl92e_link_change(struct net_device *dev); -void rtl92e_set_monitor_mode(struct net_device *dev, bool bAllowAllDA, +void rtl92e_set_monitor_mode(struct net_device *dev, bool allow_all_da, bool WriteIntoReg); void rtl92e_fill_tx_desc(struct net_device *dev, struct tx_desc *pdesc, struct cb_desc *cb_desc, struct sk_buff *skb); diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index 3819a859710d..393fff7e6a8d 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -1477,7 +1477,7 @@ struct rtllib_device { void (*set_hw_reg_handler)(struct net_device *dev, u8 variable, u8 *val); =20 void (*allow_all_dest_addr_handler)(struct net_device *dev, - bool bAllowAllDA, + bool allow_all_da, bool WriteIntoReg); =20 void (*rtllib_ips_leave_wq)(struct net_device *dev); --=20 2.30.2 From nobody Thu Dec 18 19:37:24 2025 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E447405DB for ; Sun, 10 Mar 2024 23:56:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710114965; cv=none; b=cpfZBLOJrLCKWvSE0dNzNuBJebSIJIlXaw7LEg3JI0t6bUcye3Wp/ymD5NVs7SwjIbmUfncLpzttBhyqvHegjpIsRwlur0BvwtKO88iID9VgrYFJUv/UTcRsnw8tEv5AVtTbMDStGDa1dP2dtW4VkfZXMMqgpbq+D8esoC/Zn5o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710114965; c=relaxed/simple; bh=aaynatjePreX+ZKYWdldnU245uJ/F0v5BQjpQnzULeM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=SW9Ybl4794RifCxgHv7e7gRBgdodvzMWYJqVHST42TJ+OaHN5Rf5Pe4ENxRyUoy43im2Pm1x2LM4Tsi0krCHHIDY8J+xY+4EHEMeGX2TvG+QX4HdEWqk6T2E6Fed+oiTx0knKzmjEWj3r3jOKu1nAsKWWwKI7vXlEY9RjjFJ20U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=f5GQfz4M; arc=none smtp.client-ip=209.85.216.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="f5GQfz4M" Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-29c0b648713so152774a91.2 for ; Sun, 10 Mar 2024 16:56:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1710114963; x=1710719763; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ln106wSAsJuT/MNbqsLOu6Yq7Zx1wW1j4VdR3CdkZKI=; b=f5GQfz4M2jqx/Ncb1OFlcJxOhfWNh+UBTfPTQIdizcniYvYbfG6wXO/SOhCPoYEMM4 MC2Xn3IW2I9KAjxqh5WpfU3gGPzpA83LUmJnMAPSBzKSzyFuzIIJb4lDSHTA+wPjh/nv J7rZTDftXu8vYcPQPdo62wtcMW6T09V4MSkb5IhbFG3Oc4moUksb4gCecBGITLqVywWz J5iOQLJLwWmeYO1N5DLmUr2swzCYShP5LBzJUvKQ4PMbzs+eO4YWEpafSyNXFWDPumH9 XDQiA6j83DowD8bOPf6NLdYG7bILQWM/pKyNvntSF7MeOyF6Zld3dXlgHz21+G1eMWcJ iZoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710114963; x=1710719763; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ln106wSAsJuT/MNbqsLOu6Yq7Zx1wW1j4VdR3CdkZKI=; b=td8nvs7APAwJn89MXcHsleZnGlXR0uWsvO5FU5sBPUkaU+fvnh61kiLfO2XBiy/RRq w2kiKuXHQNLGWbaCCy3Z+A5twq2xxRPigLG8XeT1lg2noIHHPhDrVQX4ZS9m2O+QsP9y 59739E4KITUZ1jQEZwy9SSjq/UfFVN0m8pl1sgub0KdeLaO9xfpthANttvBJLd5DnjvF TE9V/MTfYFQCKqAhe1NHuZ0iKcA4OnKQMxERTRb4NPNeegDXE+ya8Zj9gvyTzK+4Yo7V 9cYeyLq59//f/OVYoKVEsGgHBQGO2E/Wu5Nm5POu0PPgbhh8kOaTq31UUMhCAIbEzaiA gVnw== X-Forwarded-Encrypted: i=1; AJvYcCWKvEFwxsyFWuR3n2ILgFYl3XUPKI8qIr1/tvuWDccg3JKVTar71NQnp9yWVKjc66/KPCRJmioD8vG36e6/H9FeWM3F420n0lpXCxkf X-Gm-Message-State: AOJu0YxLvD1yFcHEVMBVp62Fckr5fMYHCmUqZXn7XB5XNS3A7rh2vkWW k28LTLp5CtNGyXPrh4efVtdw7e1mkf7FAhF4A5K9ULkAb4Pv+aYux44Aade6y+g= X-Google-Smtp-Source: AGHT+IEIAbOVNnGKx6wzOoW8hNNjB2NnNHkQsiZkONPnLfuHT6c9vJuyffUCYHWNfE+Y4POPboHX3g== X-Received: by 2002:a17:90b:33d1:b0:29b:38c0:b933 with SMTP id lk17-20020a17090b33d100b0029b38c0b933mr3947602pjb.8.1710114963563; Sun, 10 Mar 2024 16:56:03 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id o7-20020a17090ac08700b0029bb29ef41bsm2903439pjs.50.2024.03.10.16.56.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Mar 2024 16:56:03 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH 10/11] Staging: rtl8192e: Rename variable WriteIntoReg Date: Sun, 10 Mar 2024 16:55:51 -0700 Message-Id: <20240310235552.4217-11-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240310235552.4217-1-tdavies@darkphysics.net> References: <20240310235552.4217-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable WriteIntoReg to write_into_reg to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 4 ++-- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.h | 2 +- drivers/staging/rtl8192e/rtllib.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_dev.c index e3276d2c3616..fdf8fc66939d 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c @@ -703,7 +703,7 @@ void rtl92e_link_change(struct net_device *dev) } =20 void rtl92e_set_monitor_mode(struct net_device *dev, bool allow_all_da, - bool WriteIntoReg) + bool write_into_reg) { struct r8192_priv *priv =3D rtllib_priv(dev); =20 @@ -712,7 +712,7 @@ void rtl92e_set_monitor_mode(struct net_device *dev, bo= ol allow_all_da, else priv->receive_config &=3D ~RCR_AAP; =20 - if (WriteIntoReg) + if (write_into_reg) rtl92e_writel(dev, RCR, priv->receive_config); } =20 diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.h b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_dev.h index 1224f190937e..9d9c5051c7fe 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.h +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.h @@ -22,7 +22,7 @@ void rtl92e_get_eeprom_size(struct net_device *dev); bool rtl92e_start_adapter(struct net_device *dev); void rtl92e_link_change(struct net_device *dev); void rtl92e_set_monitor_mode(struct net_device *dev, bool allow_all_da, - bool WriteIntoReg); + bool write_into_reg); void rtl92e_fill_tx_desc(struct net_device *dev, struct tx_desc *pdesc, struct cb_desc *cb_desc, struct sk_buff *skb); void rtl92e_fill_tx_cmd_desc(struct net_device *dev, struct tx_desc_cmd *= entry, diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index 393fff7e6a8d..0809af3fd041 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -1478,7 +1478,7 @@ struct rtllib_device { =20 void (*allow_all_dest_addr_handler)(struct net_device *dev, bool allow_all_da, - bool WriteIntoReg); + bool write_into_reg); =20 void (*rtllib_ips_leave_wq)(struct net_device *dev); void (*rtllib_ips_leave)(struct net_device *dev); --=20 2.30.2 From nobody Thu Dec 18 19:37:24 2025 Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D40504176D for ; Sun, 10 Mar 2024 23:56:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710114966; cv=none; b=bXwACPxmNxXcWZ7et5ZIONzBt7voNMpLuuqcJLVqPJoDET7ayzLLovYge0A7TG0/4A95564Hbj0fS4bfRA6S/1BgaCKky1mgK42KZsj87LyuLiCehaU9hST7ckZKYgJqC7hCLHOJxxJ/MfbgqGaY9i9SvCNfDCvtasBvrcweye8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710114966; c=relaxed/simple; bh=Yoz7vyXQjE5UxlSJlr9TyMpfr1WYINLnMFLNfcfdSBA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=YsjqBQKCE/QQRt+md4wi1/snkLUT6pnxXczScyiEdAU+n4z2NbrYeuYgX5X6y65Uz8fgG6Jk7oTRNLGKF826VqL2eMogdxxb4ctv6WzMePHzMH2DNQW6YZr3g9hH9vHyctyTxCVKiRdDdX56GCIPip00oCa8f7VeYwaBIjAa8xo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=FHyf/oCw; arc=none smtp.client-ip=209.85.215.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="FHyf/oCw" Received: by mail-pg1-f176.google.com with SMTP id 41be03b00d2f7-5e4b775e1d6so2533628a12.1 for ; Sun, 10 Mar 2024 16:56:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1710114964; x=1710719764; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mBEMlnbFodhUGo6oxESS68T4iON/CdBhosdLVyFF1rE=; b=FHyf/oCwXmHUDoWcu1+lX/UYkFYiqW2NghM2tN9ZdEpa7IjyGvLaAvUGoQ3/HZRWZ3 D2qx7tun3WG/e6RUUX1xJ8mBgw15ZZDb8KWtbPRQXKAnDRU0/nOq+erzyRrr+oNQUgh0 je5iak8abNs7LrftznqIaeKIJ/GLjJ3tjlPI/+IQ3CH+h3zJ9x1QnRaqzKrytP98rclK 8biJJxZve9OHBuWeH8tjlMtHA/6bJ0KY5Z8ycve8MfykyifjPza77JAL6sLjWHEMu+NX 5swWb65uZJtIbSrT0tOgPfxEA7SLcFkxuWm1dm9gnLXa2CVj7uYSEZTtMsGvxJNocacX OKng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710114964; x=1710719764; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mBEMlnbFodhUGo6oxESS68T4iON/CdBhosdLVyFF1rE=; b=GzBrvtqixgeR6ildV03DDqEOuqLGK4pa6Ag8NwwEq1Qn7BLNB7Ix5iuy0HJnBx/OnA lTbWUkjv/2FgKicCxhr6w9BhMtevtAkdoOz6Z9sjsmETdVyhAA4k0yKbq0u6su5eASAj 2YjnwCD7RwHKXqRa1Fznu4MqaIhXPnpb/rPqk0VOT9xgSJdTG3r7PKWGuKNzY4cKobn9 l+CXMN7SWq5vgtGAmL5PdHCnVC9+M+9vpt487bgHvpT3ai++ZdopWPxcMWYaUeoLQ15R d7TpSCWRcknbLluiyiPeBwvXADvo4qjYagwphPUhgHjfMAdu5aOYUMV+vVwQYS+HsMTL /u9g== X-Forwarded-Encrypted: i=1; AJvYcCUkJrx/Tu1bhAmaABwOfulsrVKoWAHnka0tH3jmr4a8E4rlZCn8d/UeCEl5xJjiIW+YkA6O8UFYvfHrddLQlxwWldrD73b1fBykCkom X-Gm-Message-State: AOJu0Yx0+XF9QHYLldRxy+odBQn8GwpMBnakcwMhp4TdY2yX7IeU4X8q l9D1hAbYvHrGdUhVP8DbZ5iRhHQxdU04rIAldz/tzMklcutiMaVIS7gmBVKV89c= X-Google-Smtp-Source: AGHT+IHuUX/u1Kb6N1OPq8+HSb3c5l+qN8ReWr/b4PeYFNuVg2G8eJDP/4OnjDW/EuboilYEgI/jfQ== X-Received: by 2002:a17:90a:69a5:b0:29a:f199:1647 with SMTP id s34-20020a17090a69a500b0029af1991647mr7821537pjj.1.1710114964303; Sun, 10 Mar 2024 16:56:04 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id o7-20020a17090ac08700b0029bb29ef41bsm2903439pjs.50.2024.03.10.16.56.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Mar 2024 16:56:03 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH 11/11] Staging: rtl8192e: Implement BIT macro for bit shift ops Date: Sun, 10 Mar 2024 16:55:52 -0700 Message-Id: <20240310235552.4217-12-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240310235552.4217-1-tdavies@darkphysics.net> References: <20240310235552.4217-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace bit shift operations with BIT macro, to fix warning CHECK: Prefer using the BIT macro Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter --- drivers/staging/rtl8192e/rtllib.h | 62 +++++++++++++++---------------- 1 file changed, 31 insertions(+), 31 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index 0809af3fd041..5c00d663193f 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -419,19 +419,19 @@ enum _REG_PREAMBLE_MODE { #define WLAN_AUTH_SHARED_KEY 1 #define WLAN_AUTH_LEAP 128 =20 -#define WLAN_CAPABILITY_ESS (1<<0) -#define WLAN_CAPABILITY_IBSS (1<<1) -#define WLAN_CAPABILITY_PRIVACY (1<<4) -#define WLAN_CAPABILITY_SHORT_PREAMBLE (1<<5) -#define WLAN_CAPABILITY_SHORT_SLOT_TIME (1<<10) - -#define RTLLIB_STATMASK_SIGNAL (1<<0) -#define RTLLIB_STATMASK_RSSI (1<<1) -#define RTLLIB_STATMASK_NOISE (1<<2) +#define WLAN_CAPABILITY_ESS BIT(0) +#define WLAN_CAPABILITY_IBSS BIT(1) +#define WLAN_CAPABILITY_PRIVACY BIT(4) +#define WLAN_CAPABILITY_SHORT_PREAMBLE BIT(5) +#define WLAN_CAPABILITY_SHORT_SLOT_TIME BIT(10) + +#define RTLLIB_STATMASK_SIGNAL BIT(0) +#define RTLLIB_STATMASK_RSSI BIT(1) +#define RTLLIB_STATMASK_NOISE BIT(2) #define RTLLIB_STATMASK_WEMASK 0x7 =20 -#define RTLLIB_CCK_MODULATION (1<<0) -#define RTLLIB_OFDM_MODULATION (1<<1) +#define RTLLIB_CCK_MODULATION BIT(0) +#define RTLLIB_OFDM_MODULATION BIT(1) =20 #define RTLLIB_CCK_RATE_LEN 4 #define RTLLIB_CCK_RATE_1MB 0x02 @@ -518,11 +518,11 @@ struct rtllib_frag_entry { =20 struct rtllib_device; =20 -#define SEC_ACTIVE_KEY (1<<4) -#define SEC_AUTH_MODE (1<<5) -#define SEC_UNICAST_GROUP (1<<6) -#define SEC_LEVEL (1<<7) -#define SEC_ENABLED (1<<8) +#define SEC_ACTIVE_KEY BIT(4) +#define SEC_AUTH_MODE BIT(5) +#define SEC_UNICAST_GROUP BIT(6) +#define SEC_LEVEL BIT(7) +#define SEC_ENABLED BIT(8) =20 #define SEC_LEVEL_0 0 /* None */ #define SEC_LEVEL_1 1 /* WEP 40 and 104 bit */ @@ -707,17 +707,17 @@ union frameqos { #define MAX_WPA_IE_LEN 64 #define MAX_WZC_IE_LEN 256 =20 -#define NETWORK_EMPTY_ESSID (1<<0) -#define NETWORK_HAS_OFDM (1<<1) -#define NETWORK_HAS_CCK (1<<2) +#define NETWORK_EMPTY_ESSID BIT(0) +#define NETWORK_HAS_OFDM BIT(1) +#define NETWORK_HAS_CCK BIT(2) =20 /* QoS structure */ -#define NETWORK_HAS_QOS_PARAMETERS (1<<3) -#define NETWORK_HAS_QOS_INFORMATION (1<<4) +#define NETWORK_HAS_QOS_PARAMETERS BIT(3) +#define NETWORK_HAS_QOS_INFORMATION BIT(4) #define NETWORK_HAS_QOS_MASK (NETWORK_HAS_QOS_PARAMETERS | \ NETWORK_HAS_QOS_INFORMATION) /* 802.11h */ -#define NETWORK_HAS_ERP_VALUE (1<<10) +#define NETWORK_HAS_ERP_VALUE BIT(10) =20 #define QOS_QUEUE_NUM 4 #define QOS_OUI_LEN 3 @@ -1007,8 +1007,8 @@ enum rtl_link_state { #define DEFAULT_MAX_SCAN_AGE (15 * HZ) #define DEFAULT_FTS 2346 =20 -#define CFG_RTLLIB_RESERVE_FCS (1<<0) -#define CFG_RTLLIB_COMPUTE_FCS (1<<1) +#define CFG_RTLLIB_RESERVE_FCS BIT(0) +#define CFG_RTLLIB_COMPUTE_FCS BIT(1) =20 struct tx_pending { int frag; @@ -1497,32 +1497,32 @@ struct rtllib_device { /* Uses the channel change callback directly * instead of [start/stop] scan callbacks */ -#define IEEE_SOFTMAC_SCAN (1<<2) +#define IEEE_SOFTMAC_SCAN BIT(2) =20 /* Perform authentication and association handshake */ -#define IEEE_SOFTMAC_ASSOCIATE (1<<3) +#define IEEE_SOFTMAC_ASSOCIATE BIT(3) =20 /* Generate probe requests */ -#define IEEE_SOFTMAC_PROBERQ (1<<4) +#define IEEE_SOFTMAC_PROBERQ BIT(4) =20 /* Generate response to probe requests */ -#define IEEE_SOFTMAC_PROBERS (1<<5) +#define IEEE_SOFTMAC_PROBERS BIT(5) =20 /* The ieee802.11 stack will manage the netif queue * wake/stop for the driver, taking care of 802.11 * fragmentation. See softmac.c for details. */ -#define IEEE_SOFTMAC_TX_QUEUE (1<<7) +#define IEEE_SOFTMAC_TX_QUEUE BIT(7) =20 /* Uses only the softmac_data_hard_start_xmit * even for TX management frames. */ -#define IEEE_SOFTMAC_SINGLE_QUEUE (1<<8) +#define IEEE_SOFTMAC_SINGLE_QUEUE BIT(8) =20 /* Generate beacons. The stack will enqueue beacons * to the card */ -#define IEEE_SOFTMAC_BEACONS (1<<6) +#define IEEE_SOFTMAC_BEACONS BIT(6) =20 static inline void *rtllib_priv(struct net_device *dev) { --=20 2.30.2