[PATCH v1 0/6] mfd: kempld: A few cleanups

Andy Shevchenko posted 6 patches 1 year, 11 months ago
drivers/mfd/kempld-core.c | 105 ++++++++++++--------------------------
1 file changed, 33 insertions(+), 72 deletions(-)
[PATCH v1 0/6] mfd: kempld: A few cleanups
Posted by Andy Shevchenko 1 year, 11 months ago
Just a set of ad-hoc cleanups. No functional change intended.

Andy Shevchenko (6):
  mfd: kempld: Replace ACPI code with agnostic one
  mfd: kempld: Use device core to create driver-specific device
    attributes
  mfd: kempld: Simplify device registration
  mfd: kempld: Use PLATFORM_DEVID_NONE instead of -1
  mfd: kempld: Drop duplicate NULL check in ->exit()
  mfd: kempld: Remove dead code

 drivers/mfd/kempld-core.c | 105 ++++++++++++--------------------------
 1 file changed, 33 insertions(+), 72 deletions(-)

-- 
2.43.0.rc1.1.gbec44491f096
Re: [PATCH v1 0/6] mfd: kempld: A few cleanups
Posted by Andy Shevchenko 1 year, 10 months ago
On Fri, Feb 23, 2024 at 09:49:49PM +0200, Andy Shevchenko wrote:
> Just a set of ad-hoc cleanups. No functional change intended.

Any comments?

(I assume the 6+ weeks in the mailing list is enough for all kind of CIs
 to complain. But they hadn't AFAICS.)

-- 
With Best Regards,
Andy Shevchenko
Re: [PATCH v1 0/6] mfd: kempld: A few cleanups
Posted by Lee Jones 1 year, 10 months ago
On Tue, 02 Apr 2024, Andy Shevchenko wrote:

> On Fri, Feb 23, 2024 at 09:49:49PM +0200, Andy Shevchenko wrote:
> > Just a set of ad-hoc cleanups. No functional change intended.
> 
> Any comments?
> 
> (I assume the 6+ weeks in the mailing list is enough for all kind of CIs
>  to complain. But they hadn't AFAICS.)

Not sure why these were dropped from my queue.

Likely another Mutt "feature".

Back in the queue.

-- 
Lee Jones [李琼斯]
Re: [PATCH v1 0/6] mfd: kempld: A few cleanups
Posted by Andy Shevchenko 1 year, 10 months ago
On Thu, Apr 11, 2024 at 10:29:28AM +0100, Lee Jones wrote:
> On Tue, 02 Apr 2024, Andy Shevchenko wrote:
> > On Fri, Feb 23, 2024 at 09:49:49PM +0200, Andy Shevchenko wrote:
> > > Just a set of ad-hoc cleanups. No functional change intended.
> > 
> > Any comments?
> > 
> > (I assume the 6+ weeks in the mailing list is enough for all kind of CIs
> >  to complain. But they hadn't AFAICS.)
> 
> Not sure why these were dropped from my queue.
> 
> Likely another Mutt "feature".

Hmm... Using mutt as well, but probably not in advanced way.

> Back in the queue.

Thanks!

-- 
With Best Regards,
Andy Shevchenko
Re: [PATCH v1 0/6] mfd: kempld: A few cleanups
Posted by Lee Jones 1 year, 10 months ago
On Thu, 11 Apr 2024, Andy Shevchenko wrote:

> On Thu, Apr 11, 2024 at 10:29:28AM +0100, Lee Jones wrote:
> > On Tue, 02 Apr 2024, Andy Shevchenko wrote:
> > > On Fri, Feb 23, 2024 at 09:49:49PM +0200, Andy Shevchenko wrote:
> > > > Just a set of ad-hoc cleanups. No functional change intended.
> > > 
> > > Any comments?
> > > 
> > > (I assume the 6+ weeks in the mailing list is enough for all kind of CIs
> > >  to complain. But they hadn't AFAICS.)
> > 
> > Not sure why these were dropped from my queue.
> > 
> > Likely another Mutt "feature".
> 
> Hmm... Using mutt as well, but probably not in advanced way.

I use:

  I               flag-message               toggle a message's 'important' flag

... to mark messages as requiring review.

Sometimes Mutt drops them for seemingly no reason.  It's also not
uncommon for me to fetch new mail or open Mutt to find 300 unread mails
which I've already parsed.  When that happens, all of the mails that
I've previously flagged have also been (not so) helpfully unflagged!

It's just something that I've grown accustomed to.

-- 
Lee Jones [李琼斯]
Re: [PATCH v1 0/6] mfd: kempld: A few cleanups
Posted by Andy Shevchenko 1 year, 10 months ago
On Thu, Apr 11, 2024 at 11:56:07AM +0100, Lee Jones wrote:
> On Thu, 11 Apr 2024, Andy Shevchenko wrote:
> > On Thu, Apr 11, 2024 at 10:29:28AM +0100, Lee Jones wrote:
> > > On Tue, 02 Apr 2024, Andy Shevchenko wrote:
> > > > On Fri, Feb 23, 2024 at 09:49:49PM +0200, Andy Shevchenko wrote:
> > > > > Just a set of ad-hoc cleanups. No functional change intended.
> > > > 
> > > > Any comments?
> > > > 
> > > > (I assume the 6+ weeks in the mailing list is enough for all kind of CIs
> > > >  to complain. But they hadn't AFAICS.)
> > > 
> > > Not sure why these were dropped from my queue.
> > > 
> > > Likely another Mutt "feature".
> > 
> > Hmm... Using mutt as well, but probably not in advanced way.
> 
> I use:
> 
>   I               flag-message               toggle a message's 'important' flag
> 
> ... to mark messages as requiring review.

I don't (yet?).

> Sometimes Mutt drops them for seemingly no reason.  It's also not
> uncommon for me to fetch new mail or open Mutt to find 300 unread mails
> which I've already parsed.  When that happens, all of the mails that
> I've previously flagged have also been (not so) helpfully unflagged!
> 
> It's just something that I've grown accustomed to.

Okay, thanks for sharing your experience.

-- 
With Best Regards,
Andy Shevchenko
Re: [PATCH v1 0/6] mfd: kempld: A few cleanups
Posted by Lee Jones 1 year, 10 months ago
On Fri, 23 Feb 2024 21:49:49 +0200, Andy Shevchenko wrote:
> Just a set of ad-hoc cleanups. No functional change intended.
> 
> Andy Shevchenko (6):
>   mfd: kempld: Replace ACPI code with agnostic one
>   mfd: kempld: Use device core to create driver-specific device
>     attributes
>   mfd: kempld: Simplify device registration
>   mfd: kempld: Use PLATFORM_DEVID_NONE instead of -1
>   mfd: kempld: Drop duplicate NULL check in ->exit()
>   mfd: kempld: Remove dead code
> 
> [...]

Applied, thanks!

[1/6] mfd: kempld: Replace ACPI code with agnostic one
      commit: 2757d27d24b6c92b2476caaceca1e2666b0945be
[2/6] mfd: kempld: Use device core to create driver-specific device attributes
      commit: 28a8ad605b6b5819514467da6925b2e5b3f77c3e
[3/6] mfd: kempld: Simplify device registration
      commit: 3f3f569bea415066618f9680278f26d341ddf23d
[4/6] mfd: kempld: Use PLATFORM_DEVID_NONE instead of -1
      commit: c1a0b1194c5e0a5c2f027578439fdea009275bf9
[5/6] mfd: kempld: Drop duplicate NULL check in ->exit()
      commit: bb42768bd22196976acb217d1748b37ea55f8f3a
[6/6] mfd: kempld: Remove dead code
      commit: b89163d2e1235677f766895b596b3cd7447b69a3

--
Lee Jones [李琼斯]