From nobody Sat Feb 7 23:22:55 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B29AD149393 for ; Fri, 23 Feb 2024 19:51:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708717881; cv=none; b=axnxPaQPsceBfhJAccecNWUg0aOgc3T5l7PwkzrLUDnza3zifMER16DEKHP7tSFY9mjThFXjh0cqpISvVAe/zEH86cx7PPvv0U+Hhtop7YZXL6abXlrncuOa95/oefCxc7p73r26OrmXQhlxfzMRDm96UmmRy2Bpc65jAtL7X5I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708717881; c=relaxed/simple; bh=Wj2D0oBH1J9oTB67/0tbEOo9q7DzAHlzlDkwpbhKu14=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GZzirf40fbOu8kM4u0oK52RLZQxbDa4Tjpe2V2kI/s9FVwYPPkHqS0ux6/1xVxexS7y1DJZdB0j5XzXXRCu4TE+wLef9JBsW1kmAWyMtjaawGcmd0jF2aQgcrHgs6ybpuEvq5TxPFjSdb4qlL/ImZt2r2j324smwdU+X1ulvm8o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=h0wh6rG4; arc=none smtp.client-ip=192.198.163.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="h0wh6rG4" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708717880; x=1740253880; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Wj2D0oBH1J9oTB67/0tbEOo9q7DzAHlzlDkwpbhKu14=; b=h0wh6rG4xI7UdJN6Yq86nPJN+fhEvIoJ7IpAY531V97qvdwdYmccJER5 +2h313nLl3jR1DN8E85cYS9fdeRvOaVWCliArOQObZicEF5J9jL7KQyZl 3mbouiNhjMAM7yPDl/nRND2BBtmHHrUAwAhxssnJuuUMnKdjyiJd9ByeA lLhM1GXjlPji3n33ENctX7RJJ+nx8Uw+ke84CyUVMSuYuuwLmx/Gyfe3i rC7oSHX6mJv3S9d7swQlb1zlS0qij7nzKvA2reJ5LmTZzUYj2AeYOpQPs PYwCjBnDcL3h0m+UNsa8YvDDTn4b4MyMtKv3PIq61QAeJMZIThUGjUDKD A==; X-IronPort-AV: E=McAfee;i="6600,9927,10993"; a="6837326" X-IronPort-AV: E=Sophos;i="6.06,180,1705392000"; d="scan'208";a="6837326" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2024 11:51:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10993"; a="937025652" X-IronPort-AV: E=Sophos;i="6.06,180,1705392000"; d="scan'208";a="937025652" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 23 Feb 2024 11:51:15 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 96B134A5; Fri, 23 Feb 2024 21:51:14 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , linux-kernel@vger.kernel.org Cc: Lee Jones Subject: [PATCH v1 1/6] mfd: kempld: Replace ACPI code with agnostic one Date: Fri, 23 Feb 2024 21:49:50 +0200 Message-ID: <20240223195113.880121-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20240223195113.880121-1-andriy.shevchenko@linux.intel.com> References: <20240223195113.880121-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" There is no need to include and use entire ACPI stack in the driver. Replace respective pieces by agnostic code. No functional change indented. Signed-off-by: Andy Shevchenko --- drivers/mfd/kempld-core.c | 38 +++++++++++--------------------------- 1 file changed, 11 insertions(+), 27 deletions(-) diff --git a/drivers/mfd/kempld-core.c b/drivers/mfd/kempld-core.c index 5557f023a173..99c8656e723c 100644 --- a/drivers/mfd/kempld-core.c +++ b/drivers/mfd/kempld-core.c @@ -9,11 +9,12 @@ #include #include #include +#include #include +#include #include #include #include -#include =20 #define MAX_ID_LEN 4 static char force_device_id[MAX_ID_LEN + 1] =3D ""; @@ -425,26 +426,6 @@ static int kempld_detect_device(struct kempld_device_d= ata *pld) return ret; } =20 -#ifdef CONFIG_ACPI -static int kempld_get_acpi_data(struct platform_device *pdev) -{ - struct device *dev =3D &pdev->dev; - const struct kempld_platform_data *pdata; - int ret; - - pdata =3D acpi_device_get_match_data(dev); - ret =3D platform_device_add_data(pdev, pdata, - sizeof(struct kempld_platform_data)); - - return ret; -} -#else -static int kempld_get_acpi_data(struct platform_device *pdev) -{ - return -ENODEV; -} -#endif /* CONFIG_ACPI */ - static int kempld_probe(struct platform_device *pdev) { const struct kempld_platform_data *pdata; @@ -458,10 +439,16 @@ static int kempld_probe(struct platform_device *pdev) * No kempld_pdev device has been registered in kempld_init, * so we seem to be probing an ACPI platform device. */ - ret =3D kempld_get_acpi_data(pdev); + pdata =3D device_get_match_data(dev); + if (!pdata) + return -ENODEV; + + ret =3D platform_device_add_data(pdev, pdata, sizeof(*pdata)); if (ret) return ret; - } else if (kempld_pdev !=3D pdev) { + } else if (kempld_pdev =3D=3D pdev) { + pdata =3D dev_get_platdata(dev); + } else { /* * The platform device we are probing is not the one we * registered in kempld_init using the DMI table, so this one @@ -472,7 +459,6 @@ static int kempld_probe(struct platform_device *pdev) dev_notice(dev, "platform device exists - not using ACPI\n"); return -ENODEV; } - pdata =3D dev_get_platdata(dev); =20 pld =3D devm_kzalloc(dev, sizeof(*pld), GFP_KERNEL); if (!pld) @@ -509,19 +495,17 @@ static void kempld_remove(struct platform_device *pde= v) pdata->release_hardware_mutex(pld); } =20 -#ifdef CONFIG_ACPI static const struct acpi_device_id kempld_acpi_table[] =3D { { "KEM0000", (kernel_ulong_t)&kempld_platform_data_generic }, { "KEM0001", (kernel_ulong_t)&kempld_platform_data_generic }, {} }; MODULE_DEVICE_TABLE(acpi, kempld_acpi_table); -#endif =20 static struct platform_driver kempld_driver =3D { .driver =3D { .name =3D "kempld", - .acpi_match_table =3D ACPI_PTR(kempld_acpi_table), + .acpi_match_table =3D kempld_acpi_table, }, .probe =3D kempld_probe, .remove_new =3D kempld_remove, --=20 2.43.0.rc1.1.gbec44491f096 From nobody Sat Feb 7 23:22:55 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70034149390 for ; Fri, 23 Feb 2024 19:51:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708717881; cv=none; b=cpoqsg3ItDSkr0ESHiiz51IZnMVevGWiXT6g/CjX5Gn69rEj6AaXZUjw5Mv+pFH+PXvP/f3ZU5bEBMFQ6j0yBUALbnAekx6owhv1kHCVBeYVN9lF3vfTTj3cJlH510QXA7x9gYCBzpySN/lntqftdbz+a+Z2gEUVGBrbqvkCdgg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708717881; c=relaxed/simple; bh=dXoPLDQhxVnWDcsR1gAg8K6LjURfRWuoMXcIAZ0xYSk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Ila4LGUklJM6DEazNFs5mnb2c8uPecC2Nx5Ghi3phDBA9PT77pcoffapfgQlYs9M5wJ6dG5ZeGPQ5uhygYr2RvEaawepnXttAVXTcCAAm0hfxsNNJWGmb1i5YY9wt7upc3IWs2TtpR+1rRBN/5wK2jmSpFF+/hYHAthKV8u/LSg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=HlMsneYa; arc=none smtp.client-ip=192.198.163.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="HlMsneYa" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708717879; x=1740253879; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=dXoPLDQhxVnWDcsR1gAg8K6LjURfRWuoMXcIAZ0xYSk=; b=HlMsneYaxN1uF0SVb85m9QJ3eyD6xBP0ZEksgzhWd1ir409VXWPWAJto OIIlagwd2KDbLLpTOKA8mgOP31Fi8utyRtIvTuktKOJf9rcR8j+yAgQ8y D0V0E1MVidqaXtnirFL4PFyfmE3UMhx0xlAJta6tcx/NiKyhImTLdatjr gjhW/Vhqq/iEulBQYtJ2lmL0usX9arMz4XYk3QgqjCntL+V+O/eK+5+7z 6/43IRLGjbyN+Ity5NAGBj0xkfj15b4qpdG/3RHAt4YSTjwTmKcKC+BZe HQ+LJ2HvdPD8+DkHpdzmQV5tSeBRys0rszR0T1LkJhJG7xHBswB8rHdOJ g==; X-IronPort-AV: E=McAfee;i="6600,9927,10993"; a="6837324" X-IronPort-AV: E=Sophos;i="6.06,180,1705392000"; d="scan'208";a="6837324" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2024 11:51:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10993"; a="937025651" X-IronPort-AV: E=Sophos;i="6.06,180,1705392000"; d="scan'208";a="937025651" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 23 Feb 2024 11:51:15 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id A2BFE4F1; Fri, 23 Feb 2024 21:51:14 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , linux-kernel@vger.kernel.org Cc: Lee Jones Subject: [PATCH v1 2/6] mfd: kempld: Use device core to create driver-specific device attributes Date: Fri, 23 Feb 2024 21:49:51 +0200 Message-ID: <20240223195113.880121-3-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20240223195113.880121-1-andriy.shevchenko@linux.intel.com> References: <20240223195113.880121-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Instead of creating driver-specific device attributes with sysfs_create_group() have device core do this by setting up dev_groups pointer in the driver structure. Signed-off-by: Andy Shevchenko --- drivers/mfd/kempld-core.c | 21 +++++---------------- 1 file changed, 5 insertions(+), 16 deletions(-) diff --git a/drivers/mfd/kempld-core.c b/drivers/mfd/kempld-core.c index 99c8656e723c..e8ac30528085 100644 --- a/drivers/mfd/kempld-core.c +++ b/drivers/mfd/kempld-core.c @@ -15,6 +15,7 @@ #include #include #include +#include =20 #define MAX_ID_LEN 4 static char force_device_id[MAX_ID_LEN + 1] =3D ""; @@ -373,16 +374,13 @@ static DEVICE_ATTR_RO(pld_version); static DEVICE_ATTR_RO(pld_specification); static DEVICE_ATTR_RO(pld_type); =20 -static struct attribute *pld_attributes[] =3D { +static struct attribute *pld_attrs[] =3D { &dev_attr_pld_version.attr, &dev_attr_pld_specification.attr, &dev_attr_pld_type.attr, NULL }; - -static const struct attribute_group pld_attr_group =3D { - .attrs =3D pld_attributes, -}; +ATTRIBUTE_GROUPS(pld); =20 static int kempld_detect_device(struct kempld_device_data *pld) { @@ -415,15 +413,7 @@ static int kempld_detect_device(struct kempld_device_d= ata *pld) pld->info.version, kempld_get_type_string(pld), pld->info.spec_major, pld->info.spec_minor); =20 - ret =3D sysfs_create_group(&pld->dev->kobj, &pld_attr_group); - if (ret) - return ret; - - ret =3D kempld_register_cells(pld); - if (ret) - sysfs_remove_group(&pld->dev->kobj, &pld_attr_group); - - return ret; + return kempld_register_cells(pld); } =20 static int kempld_probe(struct platform_device *pdev) @@ -489,8 +479,6 @@ static void kempld_remove(struct platform_device *pdev) struct kempld_device_data *pld =3D platform_get_drvdata(pdev); const struct kempld_platform_data *pdata =3D dev_get_platdata(pld->dev); =20 - sysfs_remove_group(&pld->dev->kobj, &pld_attr_group); - mfd_remove_devices(&pdev->dev); pdata->release_hardware_mutex(pld); } @@ -506,6 +494,7 @@ static struct platform_driver kempld_driver =3D { .driver =3D { .name =3D "kempld", .acpi_match_table =3D kempld_acpi_table, + .dev_groups =3D pld_groups, }, .probe =3D kempld_probe, .remove_new =3D kempld_remove, --=20 2.43.0.rc1.1.gbec44491f096 From nobody Sat Feb 7 23:22:55 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B02391493B4 for ; Fri, 23 Feb 2024 19:51:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708717883; cv=none; b=AVs3wfUisDXS2lVc7IhvIYd2HV0CHh7I/5qu/9pewDreE11wLKyRkJW9DwhhefSnQhN9j2oJI7UQdpDmiGS53SWf9XRjf0/Ll0TAQ6e0RwyGFVoEgtXCWnuArbJxXyLZxatwN1XNdln8ZMMX9/eymr5bHmw0YMLFvVsXrnZLaAk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708717883; c=relaxed/simple; bh=0PKdh4pEIrqDSQO7ZRWs0TVdP0lCYrCSx8iDEn/lkVs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=maaweI5YbJDzr8Tiipzdrz0X98zWYyAEe6oQeYXbmA7rVnxYuo1dHc5CCXQTSCDt1kUEXZ10Ax8EF14+mES3rc2W4vofZ/g7a9HXg10GA0Utb69BltyXHao+WzCLAv6NAMW1XQ0KibhKVrONhL7mY+3CRM47Ul9MEgFsg3ZfUB0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=hAb3t4HU; arc=none smtp.client-ip=192.198.163.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="hAb3t4HU" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708717882; x=1740253882; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=0PKdh4pEIrqDSQO7ZRWs0TVdP0lCYrCSx8iDEn/lkVs=; b=hAb3t4HUBUl3zBlB/a7OjwUDRIEVS57tTUQSTyoyUYkHicJiD5sW+QMJ vlqoYr6aMmoAkClKqd0jVSUxwTgoCgJTEApLJuA0ApZyyvHj4IgjagnLI ou3ZpndePmqRA0/boK4gJcFPK/JYhVFPtHnvYHhwve3QmVg8tl2rZzNf7 ruIXNF5Ty5XD2cpK7KfrKA0ctK0kXf52U3q5Q0qg45k60NsZuwWk1W4z3 tJ1TjA0jsLk6otoCsmtNcH+Sed28VTdera68ZIVquohZ8K190hkv24fkZ yu8++u9VXTVX6ygYir6dbO+Fz0Rq+di5tOepU3LtXaDyJtbwVoKborM3G Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10993"; a="6837328" X-IronPort-AV: E=Sophos;i="6.06,180,1705392000"; d="scan'208";a="6837328" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2024 11:51:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10993"; a="937025653" X-IronPort-AV: E=Sophos;i="6.06,180,1705392000"; d="scan'208";a="937025653" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 23 Feb 2024 11:51:15 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id AF78479A; Fri, 23 Feb 2024 21:51:14 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , linux-kernel@vger.kernel.org Cc: Lee Jones Subject: [PATCH v1 3/6] mfd: kempld: Simplify device registration Date: Fri, 23 Feb 2024 21:49:52 +0200 Message-ID: <20240223195113.880121-4-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20240223195113.880121-1-andriy.shevchenko@linux.intel.com> References: <20240223195113.880121-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use platform_device_register_full() instead of open coding this function. Signed-off-by: Andy Shevchenko --- drivers/mfd/kempld-core.c | 33 +++++++++++++-------------------- 1 file changed, 13 insertions(+), 20 deletions(-) diff --git a/drivers/mfd/kempld-core.c b/drivers/mfd/kempld-core.c index e8ac30528085..e207a62d6577 100644 --- a/drivers/mfd/kempld-core.c +++ b/drivers/mfd/kempld-core.c @@ -6,6 +6,7 @@ * Author: Michael Brunner */ =20 +#include #include #include #include @@ -131,28 +132,20 @@ static struct platform_device *kempld_pdev; static int kempld_create_platform_device(const struct dmi_system_id *id) { const struct kempld_platform_data *pdata =3D id->driver_data; - int ret; + const struct platform_device_info pdevinfo =3D { + .name =3D "kempld", + .id =3D PLATFORM_DEVID_NONE, + .res =3D pdata->ioresource, + .num_res =3D 1, + .data =3D pdata, + .size_data =3D sizeof(*pdata), + }; =20 - kempld_pdev =3D platform_device_alloc("kempld", -1); - if (!kempld_pdev) - return -ENOMEM; - - ret =3D platform_device_add_data(kempld_pdev, pdata, sizeof(*pdata)); - if (ret) - goto err; - - ret =3D platform_device_add_resources(kempld_pdev, pdata->ioresource, 1); - if (ret) - goto err; - - ret =3D platform_device_add(kempld_pdev); - if (ret) - goto err; + kempld_pdev =3D platform_device_register_full(&pdevinfo); + if (IS_ERR(kempld_pdev)) + return PTR_ERR(kempld_pdev); =20 return 0; -err: - platform_device_put(kempld_pdev); - return ret; } =20 /** @@ -424,7 +417,7 @@ static int kempld_probe(struct platform_device *pdev) struct resource *ioport; int ret; =20 - if (kempld_pdev =3D=3D NULL) { + if (IS_ERR_OR_NULL(kempld_pdev)) { /* * No kempld_pdev device has been registered in kempld_init, * so we seem to be probing an ACPI platform device. --=20 2.43.0.rc1.1.gbec44491f096 From nobody Sat Feb 7 23:22:55 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B01ED1493B3 for ; Fri, 23 Feb 2024 19:51:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708717883; cv=none; b=ljz8wt/K+erjjyZxxGupzOHPWT9WOQFp62jNezLbn8sD6umaHOFVp1p6vPWro68+yPvMRtcOipV8mAJaxO6mCIc/pAwkrUNxzKJ1eJHRx0y2ZoUPyO7qhTP1v51fJ34aWGNKNALSZ6nmmurLrO9W1R1HD8rzkqUwjLpQGxZjX7c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708717883; c=relaxed/simple; bh=JOR5ZbgquS01wBvWAK1H9MXS0YUwJRqWZazvt54flDI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=aP2KyOY+YljhT9FnzR6heLqieJfNb6RJ7yR8sguebs0RAz2i/R7mAhBLKGaTocx/A2SJl1Y2/o5G59QYeIBD8kW+kDA8FRu5aftmdLmyc0uRoA1HirUaGyCfn2cFnZ7bqempPod/fWe9R5x52XVk7Ox7tiDQABknWVzu1gho1go= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Jsv4uSfg; arc=none smtp.client-ip=192.198.163.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Jsv4uSfg" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708717882; x=1740253882; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=JOR5ZbgquS01wBvWAK1H9MXS0YUwJRqWZazvt54flDI=; b=Jsv4uSfgUXwdTHJXrzzPaojcnTBHgIohnNZi91BBIuylQQxlp+ujUCtd h1SKm60m/uANQAu1s20lTNbX8nW917s/ZGqskA0tRK/z/6Snn0X8ztGKL wEnJphsdFLoSXNCbHazRLJsstMY+ko46KuQckBpJCTZIJSUZDpq++xyTc ZcImKuig2mkEGAiyVOPD6U87VvwWGCNCKciicQev7H2RMHC9csXKzQ3HT lI8ikJb7FIYD9AQHkhhCJnEhohqVl+CpG0v/rZcz4vsHFdK3Vrrq5Tx1l fpPy8SXrH48zcEgXY4TImvNB8jDJR7pcbyJ+5RUG4D0ApBwuQgBGuhWJz A==; X-IronPort-AV: E=McAfee;i="6600,9927,10993"; a="6837330" X-IronPort-AV: E=Sophos;i="6.06,180,1705392000"; d="scan'208";a="6837330" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2024 11:51:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10993"; a="937025654" X-IronPort-AV: E=Sophos;i="6.06,180,1705392000"; d="scan'208";a="937025654" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 23 Feb 2024 11:51:15 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id BF63B80C; Fri, 23 Feb 2024 21:51:14 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , linux-kernel@vger.kernel.org Cc: Lee Jones Subject: [PATCH v1 4/6] mfd: kempld: Use PLATFORM_DEVID_NONE instead of -1 Date: Fri, 23 Feb 2024 21:49:53 +0200 Message-ID: <20240223195113.880121-5-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20240223195113.880121-1-andriy.shevchenko@linux.intel.com> References: <20240223195113.880121-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use the `PLATFORM_DEVID_NONE` constant instead of hard-coding -1 when creating a platform device. No functional changes are intended. Signed-off-by: Andy Shevchenko --- drivers/mfd/kempld-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/kempld-core.c b/drivers/mfd/kempld-core.c index e207a62d6577..c3bc61dcd098 100644 --- a/drivers/mfd/kempld-core.c +++ b/drivers/mfd/kempld-core.c @@ -109,7 +109,7 @@ static int kempld_register_cells_generic(struct kempld_= device_data *pld) if (pld->feature_mask & KEMPLD_FEATURE_MASK_UART) devs[i++].name =3D kempld_dev_names[KEMPLD_UART]; =20 - return mfd_add_devices(pld->dev, -1, devs, i, NULL, 0, NULL); + return mfd_add_devices(pld->dev, PLATFORM_DEVID_NONE, devs, i, NULL, 0, N= ULL); } =20 static struct resource kempld_ioresource =3D { --=20 2.43.0.rc1.1.gbec44491f096 From nobody Sat Feb 7 23:22:55 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B9B114CAA5 for ; Fri, 23 Feb 2024 19:51:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708717884; cv=none; b=FGl4hk7nPBkJq0dTkXte0D3E1B9abpjOhS8clo2dJgt+eG72hn3AXazLtZScNDzQ8AfWGyh/iQF8N2swVHn7sEvGABjMaYwUydJ4YUl/mcT2SgqsDr1JI9nihxYhY6d9ilgq86I4of6QQqylkaweQTp+kPcNE9Oaw7pkyvReDuc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708717884; c=relaxed/simple; bh=a9fjCoKlNy7EqqwDnIhus04TAUmuVLHwGiBZ5ufchNE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jN+oLCjiGpKxYQsW/TPGb0X0o2uXBIgkbhaiAznubnXURm5r/Cq6u2kP8t7sopAVFHGKORkrnJBZI0OlPmQ48LWnDxTprlUZZSUtWLD5lU9/69apgNrCSG3i/Qe5jN3Cf+d8KDcQE9lHsV+f6VlRKdV+DjfmVnILLyvWR5GEZBU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=DdTrt5gM; arc=none smtp.client-ip=192.198.163.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="DdTrt5gM" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708717883; x=1740253883; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=a9fjCoKlNy7EqqwDnIhus04TAUmuVLHwGiBZ5ufchNE=; b=DdTrt5gM5sUZoK6aLgExcHZIltaDXOTr4XYtJpAEvggWx1bkTOplL1e+ oFRzVjj0y8Hu2EdRRrEGieFe4RpC3oq+WkMkA1O4MOLGgY8nd1Qu3AlCZ 3mKMm0+1j5YPJfgBEp/LilaRaqffaqiFWI0kYbRFK3D75boxieJUBtytu rWizjc7iSyba5JX83Hxw5vC9gGFVIQEudd7NBWdY1cqywPCKa84uHV9da cReRjV3wEZGy6OLIiUCvtSBJTdXMMuUAhyHsBrzNAwwwbILQ+B/Hyz8zp Hrppo9OLgLYuWWWCxXKsJ1p86NAKO+kSLxhH1fOWsXH81mN5BNB33o2nn A==; X-IronPort-AV: E=McAfee;i="6600,9927,10993"; a="6837340" X-IronPort-AV: E=Sophos;i="6.06,180,1705392000"; d="scan'208";a="6837340" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2024 11:51:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10993"; a="937025656" X-IronPort-AV: E=Sophos;i="6.06,180,1705392000"; d="scan'208";a="937025656" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 23 Feb 2024 11:51:17 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id C7BAB8D2; Fri, 23 Feb 2024 21:51:14 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , linux-kernel@vger.kernel.org Cc: Lee Jones Subject: [PATCH v1 5/6] mfd: kempld: Drop duplicate NULL check in ->exit() Date: Fri, 23 Feb 2024 21:49:54 +0200 Message-ID: <20240223195113.880121-6-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20240223195113.880121-1-andriy.shevchenko@linux.intel.com> References: <20240223195113.880121-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Since platform_device_unregister() is NULL-aware, we don't need to duplicate this check. Remove it and fold the rest of the code. Signed-off-by: Andy Shevchenko --- drivers/mfd/kempld-core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/mfd/kempld-core.c b/drivers/mfd/kempld-core.c index c3bc61dcd098..30b8408c094e 100644 --- a/drivers/mfd/kempld-core.c +++ b/drivers/mfd/kempld-core.c @@ -895,9 +895,7 @@ static int __init kempld_init(void) =20 static void __exit kempld_exit(void) { - if (kempld_pdev) - platform_device_unregister(kempld_pdev); - + platform_device_unregister(kempld_pdev); platform_driver_unregister(&kempld_driver); } =20 --=20 2.43.0.rc1.1.gbec44491f096 From nobody Sat Feb 7 23:22:55 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 555451F600 for ; Fri, 23 Feb 2024 19:51:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708717883; cv=none; b=M2pfkTJS/ts66wSZyRdGeH7Dsk0QmMLzyS7enlxLMR3UJ5bOeJg62pJcva6K9q43BJV7CRMKOpibTTaFWSW5FsbIr+DIcXWpBh6P3AsthOrHU2znrCpX+0gGj5Qx4mR7wAbynw29cmTCbwQJU1IcE/j+CgBCYXVGHOkdBoAvyxk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708717883; c=relaxed/simple; bh=3FltV39b/2p9W6TJ/uXFx7JU9OLaxSUoPbI0iGl341g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DAq5pcJ/Aah0VmWKRLW6uDCkHiCeWleKehH6q++W2NY3BxXufZgzWzI6HoieKMHWErFkhePoOJPyZSJq1a0ClL8lBHLOir/ZaTbXALwj6cSBO7JzThAqHEa1Xp0QzM4kbzWNzLR/s06mmnmydn8uOPgcQ5U6Drn8Qhb89+ocSMg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=DZjlJvMp; arc=none smtp.client-ip=192.198.163.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="DZjlJvMp" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708717882; x=1740253882; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=3FltV39b/2p9W6TJ/uXFx7JU9OLaxSUoPbI0iGl341g=; b=DZjlJvMp25obSDOoJZJZY3CYp098UyPBOO1L7h73++JUD3ss5R0aircT sLO86HyqBBP+A80DnvCK63ymkU9WZM9gPE6J8/Z7hJWxeNg0PkI/94YCR SchXPhRBj3GgtMWzhxpL1grnUnrEe6SNcaM07GduOuLgOykvIBGAjeJ+H wEHDgFr6DOmD5KR94mGTygDWC78Qr/g/jI2evDdbZQH91xgwOAJMFXSN/ f+Ha/WFHjDjoMJtvYxo5zL7UqG54Ooo0dL5ZUbQOPLfDLBmbopfEbwcSD ty/fUO89MjAehT4L2lRRGtXsuLMNqFzx22ZWp5qqYsHz/CuyqXC6omYUb w==; X-IronPort-AV: E=McAfee;i="6600,9927,10993"; a="6837338" X-IronPort-AV: E=Sophos;i="6.06,180,1705392000"; d="scan'208";a="6837338" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2024 11:51:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10993"; a="937025655" X-IronPort-AV: E=Sophos;i="6.06,180,1705392000"; d="scan'208";a="937025655" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 23 Feb 2024 11:51:17 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id D42DD8E7; Fri, 23 Feb 2024 21:51:14 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , linux-kernel@vger.kernel.org Cc: Lee Jones Subject: [PATCH v1 6/6] mfd: kempld: Remove dead code Date: Fri, 23 Feb 2024 21:49:55 +0200 Message-ID: <20240223195113.880121-7-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20240223195113.880121-1-andriy.shevchenko@linux.intel.com> References: <20240223195113.880121-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" scnprintf() never returns negative value, drop the respective dead code. Signed-off-by: Andy Shevchenko --- drivers/mfd/kempld-core.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/mfd/kempld-core.c b/drivers/mfd/kempld-core.c index 30b8408c094e..ce7d52a62e51 100644 --- a/drivers/mfd/kempld-core.c +++ b/drivers/mfd/kempld-core.c @@ -294,11 +294,8 @@ static int kempld_get_info(struct kempld_device_data *= pld) else minor =3D (pld->info.minor - 10) + 'A'; =20 - ret =3D scnprintf(pld->info.version, sizeof(pld->info.version), - "P%X%c%c.%04X", pld->info.number, major, minor, - pld->info.buildnr); - if (ret < 0) - return ret; + scnprintf(pld->info.version, sizeof(pld->info.version), "P%X%c%c.%04X", + pld->info.number, major, minor, pld->info.buildnr); =20 return 0; } --=20 2.43.0.rc1.1.gbec44491f096