.../devicetree/bindings/pwm/pwm-amlogic.yaml | 115 ++++++- drivers/pwm/pwm-meson.c | 289 ++++++++++-------- 2 files changed, 260 insertions(+), 144 deletions(-)
This patchset aims to: * Fix the incorrect bindings for the s4 type of pwm that was introduced while converting the documentation from txt to yaml format. * Introduce a new compatible for the existing PWMs to better describe the HW in DT, instead of describing driver settings. * Make the introduction of a new pwm variant (s4) slightly easier. Changes since v4 [4]: * Rebased on Uwe's pwm rework in pwm-next * Drop change to carry device data in drvdata * Make the length of parent name array fixed * Single allocation instead 3 for the internal clock elements * meson8-pwm-v2 and meson-pwm-s4 compatibles under an enum instead of 2 const Changes since v3 [3]: * Split first rework patch into 3 changes * Use dev_warn_once() to notify use of obsolete bindings * Rebased on Uwe dev_err_probe() change. Changes since v2 [2]: * Drop DTS changes. These will be re-submitted later on. Possibly after u-boot gets support for the new compatible to minimise conversion problems. * Position deprecated property correctly in dt-bindings for the old meson8 type pwm bindings * Reword commit description of patch #2 to make more obvious it does not introduce a new HW support but fixes a bad bindings. * Dropped Rob's Reviewed-by on patch #2. It seemed appropriate considering the discussion on this change. Changes since v1 [1]: * Fix typo in the new binding compatible documentation * Disallow clock-names for the new compatibles in the schema documenation [1]: https://lore.kernel.org/linux-amlogic/20231106103259.703417-1-jbrunet@baylibre.com [2]: https://lore.kernel.org/linux-amlogic/20231117125919.1696980-1-jbrunet@baylibre.com [3]: https://lore.kernel.org/linux-amlogic/20231129134004.3642121-1-jbrunet@baylibre.com [4]: https://lore.kernel.org/linux-amlogic/20231222111658.832167-1-jbrunet@baylibre.com Jerome Brunet (5): dt-bindings: pwm: amlogic: fix s4 bindings dt-bindings: pwm: amlogic: Add a new binding for meson8 pwm types pwm: meson: generalize 4 inputs clock on meson8 pwm type pwm: meson: don't carry internal clock elements around pwm: meson: add generic compatible for meson8 to sm1 .../devicetree/bindings/pwm/pwm-amlogic.yaml | 115 ++++++- drivers/pwm/pwm-meson.c | 289 ++++++++++-------- 2 files changed, 260 insertions(+), 144 deletions(-) -- 2.43.0
Hello Jerome, On Wed, Feb 21, 2024 at 04:11:46PM +0100, Jerome Brunet wrote: > Jerome Brunet (5): > dt-bindings: pwm: amlogic: fix s4 bindings > dt-bindings: pwm: amlogic: Add a new binding for meson8 pwm types > pwm: meson: generalize 4 inputs clock on meson8 pwm type > pwm: meson: don't carry internal clock elements around > pwm: meson: add generic compatible for meson8 to sm1 I applied patches #1 to #3. This doesn't mean #4 and #5 are bad, just that I need some more time for review. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
On Sat 02 Mar 2024 at 11:04, Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > [[PGP Signed Part:Undecided]] > Hello Jerome, > > On Wed, Feb 21, 2024 at 04:11:46PM +0100, Jerome Brunet wrote: >> Jerome Brunet (5): >> dt-bindings: pwm: amlogic: fix s4 bindings >> dt-bindings: pwm: amlogic: Add a new binding for meson8 pwm types >> pwm: meson: generalize 4 inputs clock on meson8 pwm type >> pwm: meson: don't carry internal clock elements around >> pwm: meson: add generic compatible for meson8 to sm1 > > I applied patches #1 to #3. This doesn't mean #4 and #5 are bad, just > that I need some more time for review. No worries. The change in those, especially #5, are pretty simple but the diff are indeed hard to read :/ > > Best regards > Uwe -- Jerome
On Sat 02 Mar 2024 at 16:50, Jerome Brunet <jbrunet@baylibre.com> wrote: > On Sat 02 Mar 2024 at 11:04, Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > >> [[PGP Signed Part:Undecided]] >> Hello Jerome, >> >> On Wed, Feb 21, 2024 at 04:11:46PM +0100, Jerome Brunet wrote: >>> Jerome Brunet (5): >>> dt-bindings: pwm: amlogic: fix s4 bindings >>> dt-bindings: pwm: amlogic: Add a new binding for meson8 pwm types >>> pwm: meson: generalize 4 inputs clock on meson8 pwm type >>> pwm: meson: don't carry internal clock elements around >>> pwm: meson: add generic compatible for meson8 to sm1 >> >> I applied patches #1 to #3. This doesn't mean #4 and #5 are bad, just >> that I need some more time for review. > > No worries. The change in those, especially #5, are pretty simple but > the diff are indeed hard to read :/ Hello Uwe, Introducing the s4 support depends on this series. Is there any news ? Thanks Regards > >> >> Best regards >> Uwe -- Jerome
Hello Jerome, Uwe On 4/12/24 11:04, Jerome Brunet wrote: > > On Sat 02 Mar 2024 at 16:50, Jerome Brunet <jbrunet@baylibre.com> wrote: > >> On Sat 02 Mar 2024 at 11:04, Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: >> >>> [[PGP Signed Part:Undecided]] >>> Hello Jerome, >>> >>> On Wed, Feb 21, 2024 at 04:11:46PM +0100, Jerome Brunet wrote: >>>> Jerome Brunet (5): >>>> dt-bindings: pwm: amlogic: fix s4 bindings >>>> dt-bindings: pwm: amlogic: Add a new binding for meson8 pwm types >>>> pwm: meson: generalize 4 inputs clock on meson8 pwm type >>>> pwm: meson: don't carry internal clock elements around >>>> pwm: meson: add generic compatible for meson8 to sm1 >>> >>> I applied patches #1 to #3. This doesn't mean #4 and #5 are bad, just >>> that I need some more time for review. >> >> No worries. The change in those, especially #5, are pretty simple but >> the diff are indeed hard to read :/ > > Hello Uwe, > > Introducing the s4 support depends on this series. > Is there any news ? Actually we're waiting for the opportunity to introduce a1 support too. > > Thanks > Regards > >> >>> >>> Best regards >>> Uwe > > -- Best regards George
© 2016 - 2025 Red Hat, Inc.