[PATCH v4 0/3] iio: humidity: hdc3020: add threshold events support

Dimitri Fedrau posted 3 patches 1 year, 11 months ago
.../bindings/iio/humidity/ti,hdc3020.yaml     |   3 +
drivers/iio/humidity/hdc3020.c                | 445 ++++++++++++------
2 files changed, 312 insertions(+), 136 deletions(-)
[PATCH v4 0/3] iio: humidity: hdc3020: add threshold events support
Posted by Dimitri Fedrau 1 year, 11 months ago
Based on Fix:
a69eeaad093d "iio: humidity: hdc3020: fix temperature offset" in branch
fixes-togreg

Changes in V2:
  - Fix alphabetical order of includes(Christophe)
  - Fix typo: change varibale name "HDC3020_R_R_RH_THRESH_LOW_CLR" to
    HDC3020_R_T_RH_THRESH_LOW_CLR to match variable name pattern(Christophe)
  - Add constants HDC3020_MIN_TEMP and HDC3020_MAX_TEMP for min/max threshold
    inputs (Christophe)
  - Change HDC3020_MIN_TEMP to -40, as stated in the datasheet(Javier)

Changes in V3:
  - drop u8 register pairs and switch to 16bit defines(Jonathan)
  - create helper functions to avoid code duplication(Jonathan)
  - Add interrupt bindings in example
  - use the decimal part for setting thresholds(Javier)
  - use return in switch cases hdc3020_read_thresh(Jonathan)
  - fix interrupt handler:(Jonathan)
    - return IRQ_HANDLED when we get a read back failure
    - take the timestamp into a local variable
  - fix multiline comments(Jonathan)
  - use fixed value "hdc3020" instead of dev_id in probe
  - clear interrupt after registering the interrupt handler
  - remove interrupt polarity

Changes in V4:
  - fix commit message of patch "iio: humidity: hdc3020: switch to 16bit
    register defines". (Jonathan)
  - add missing include in bindings example. (Javier, Rob)
  - added copyright information

Dimitri Fedrau (3):
  iio: humidity: hdc3020: switch to 16bit register defines
  dt-bindings: iio: humidity: hdc3020: add interrupt bindings in example
  iio: humidity: hdc3020: add threshold events support

 .../bindings/iio/humidity/ti,hdc3020.yaml     |   3 +
 drivers/iio/humidity/hdc3020.c                | 445 ++++++++++++------
 2 files changed, 312 insertions(+), 136 deletions(-)

-- 
2.39.2
Re: [PATCH v4 0/3] iio: humidity: hdc3020: add threshold events support
Posted by Jonathan Cameron 1 year, 11 months ago
On Wed, 14 Feb 2024 09:53:42 +0100
Dimitri Fedrau <dima.fedrau@gmail.com> wrote:

> Based on Fix:
> a69eeaad093d "iio: humidity: hdc3020: fix temperature offset" in branch
> fixes-togreg

This applies fine independent of that (they will meet each other upstream!)
so I'll take this via my tree now rather than waiting to get that dependency
after a pull request  / rebase.  It will also actually get built in next
where the missing Kconfig / Makefile fix is in place.

Applied to the togreg branch of iio.git. Normally I'd push it out as testing but
given I haven't yet queued anything up today and this won't get built
until it hits next I've pushed it out as togreg directly after a quick local
build test.

Thanks,

Jonathan

> 
> Changes in V2:
>   - Fix alphabetical order of includes(Christophe)
>   - Fix typo: change varibale name "HDC3020_R_R_RH_THRESH_LOW_CLR" to
>     HDC3020_R_T_RH_THRESH_LOW_CLR to match variable name pattern(Christophe)
>   - Add constants HDC3020_MIN_TEMP and HDC3020_MAX_TEMP for min/max threshold
>     inputs (Christophe)
>   - Change HDC3020_MIN_TEMP to -40, as stated in the datasheet(Javier)
> 
> Changes in V3:
>   - drop u8 register pairs and switch to 16bit defines(Jonathan)
>   - create helper functions to avoid code duplication(Jonathan)
>   - Add interrupt bindings in example
>   - use the decimal part for setting thresholds(Javier)
>   - use return in switch cases hdc3020_read_thresh(Jonathan)
>   - fix interrupt handler:(Jonathan)
>     - return IRQ_HANDLED when we get a read back failure
>     - take the timestamp into a local variable
>   - fix multiline comments(Jonathan)
>   - use fixed value "hdc3020" instead of dev_id in probe
>   - clear interrupt after registering the interrupt handler
>   - remove interrupt polarity
> 
> Changes in V4:
>   - fix commit message of patch "iio: humidity: hdc3020: switch to 16bit
>     register defines". (Jonathan)
>   - add missing include in bindings example. (Javier, Rob)
>   - added copyright information
> 
> Dimitri Fedrau (3):
>   iio: humidity: hdc3020: switch to 16bit register defines
>   dt-bindings: iio: humidity: hdc3020: add interrupt bindings in example
>   iio: humidity: hdc3020: add threshold events support
> 
>  .../bindings/iio/humidity/ti,hdc3020.yaml     |   3 +
>  drivers/iio/humidity/hdc3020.c                | 445 ++++++++++++------
>  2 files changed, 312 insertions(+), 136 deletions(-)
>
Re: [PATCH v4 0/3] iio: humidity: hdc3020: add threshold events support
Posted by Dimitri Fedrau 1 year, 11 months ago
Am Fri, Feb 16, 2024 at 01:17:21PM +0000 schrieb Jonathan Cameron:
> On Wed, 14 Feb 2024 09:53:42 +0100
> Dimitri Fedrau <dima.fedrau@gmail.com> wrote:
> 
> > Based on Fix:
> > a69eeaad093d "iio: humidity: hdc3020: fix temperature offset" in branch
> > fixes-togreg
> 
> This applies fine independent of that (they will meet each other upstream!)
> so I'll take this via my tree now rather than waiting to get that dependency
> after a pull request  / rebase.  It will also actually get built in next
> where the missing Kconfig / Makefile fix is in place.
> 
> Applied to the togreg branch of iio.git. Normally I'd push it out as testing but
> given I haven't yet queued anything up today and this won't get built
> until it hits next I've pushed it out as togreg directly after a quick local
> build test.
>
Great, thanks for reviewing. :)

Best regards,
Dimitri Fedrau