From nobody Sat Feb 7 15:35:22 2026 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC64A111B0; Wed, 14 Feb 2024 08:54:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707900844; cv=none; b=os+2hshg/osQpZHieNDIbaMVDGBQSgce2DtNHi9rLfofhcQwYLlYtVz3n+7z53Eo3TT6qjdP27Z2AR4SRa91gXBYgqlRCRDBJcLB7Z6LxJzCQoNzt4J30rLg63bRgbXqalrQbGvRDYLzGMzfIV36X6mEFLx6uCpUmqdSB7RfTdI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707900844; c=relaxed/simple; bh=/I94xPVjnIq2HIvcr6fMZBPjlXY+pJTqZwOleEM2c3A=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=D7QeJZEYzDwkqfraNJIs1kwpYRK3/T8XsKFB0TylMzRu2xUAUk4t/oSWNbkZXfGHfSBBWsAfH/X+hzcefQW7kdVzoqgtLwnph5szWqTZDE0IUe3Uoqo+rcVmA6sXweetwyZsqbpFaRzfXc1ByigmCv+ogybTCOZt4l7AbLEAWb4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=evW/NNZH; arc=none smtp.client-ip=209.85.208.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="evW/NNZH" Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-561f4bc306fso1844900a12.1; Wed, 14 Feb 2024 00:54:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707900841; x=1708505641; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+cvQcXYmE+WFFmcvLefoIoD/Qtdtc6QI44VWrdwhE3w=; b=evW/NNZHciFTThwqAQKL3qFXjR5BnQprcPORtMWcvgf+O6Xa5imP7KQ0xULLOZNiAd dRt/Jawv17igdHJZCbYVMvgJCYnZZoCpwDuLoTD57/X5XFy6hRtw6KOx1IoRkOvrdVUS uRCi+cLKXfytPg43Q7DbZ/UIyhp/DIaB2T04WPxWFcmU+kXDprZMsmxwrqUobz1q596i ViIax8Wc0rmO1xt/nMyT+M+zIr6prerq3bnsxXojdAb3R6B2FUCJF4hiSb1sgPRGYkrR wtCMM68yY5sVe0E1m5AaWsrTawZrJTAMxxolJsEWEzSWgaQHeMBYeqWrsP0LnHJUopdk 1D9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707900841; x=1708505641; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+cvQcXYmE+WFFmcvLefoIoD/Qtdtc6QI44VWrdwhE3w=; b=dvdt5OpNs4SVjUoIrM34v3sRl6OhV6SOzZ/5137OuAFLF9ooWAfI7ijcVX2Bfw0Jgv d01u6AVZxYJw70N5GIKgi4nHtq3z7LEpObGyTMNekKTeHcQXcjftOp29Sji+OQdIhgKK Eirb4lYolIFyYVePP3JpuTL0ds+p6oPV9jdsTS6RuYNflsQj/v8CnprOI9bMCLOKq7hI nTNj+D6yQxGPHCanWijkskBo1kuLZmfjDhMHB4NuWikqrvHzc7d/T/+hyS/RGIlbBWwd 1vuossH6Nhj533RiS0Yy7R4vPWkWnJBblDE3uiHBzrHqcBC/p1o7+XdVpe3ahaX/Aotd bKWA== X-Forwarded-Encrypted: i=1; AJvYcCW8Xo8r7IlKrIJyw5qbTnfjT0Ww6alvF5nf4OIbf5tbBbr/bwQMFXgklVBRw9iyevryw6LCHV8YDxPKyUpOmaGJyWPeeu2gMVQgo8MuQXg9b2Rx9oebytjZBk8Bicwf/6nDMfqC6Z9w X-Gm-Message-State: AOJu0Yy6/6yAjkhLAsgCgHhw4jp+vo8RW/NvhuyUkcnMY3suWfgu2qgn 0EvoQHKLtmFEACk07M2U7KpuXZX586/NRUqCwOGoubddntMrKKRS X-Google-Smtp-Source: AGHT+IH8EwimYquqU90ikto09jz3bEwyjwWezT7c3AOk30eezhCtXvW5HU5ymplwZcJrrGvTDi7BWQ== X-Received: by 2002:a17:906:d28d:b0:a35:e7a1:66ec with SMTP id ay13-20020a170906d28d00b00a35e7a166ecmr1237831ejb.44.1707900840722; Wed, 14 Feb 2024 00:54:00 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCWw7n5FCY7L9mC+XbXBQvV9YVSwYXyOCK3OYyciQY31HBFuRSKrfuafpljzW7oTiuFz+/ZRZYyafRW0b31t8XgYo2/a2rm+W78djCZ0xa0bpiKSjRjs/dKL1EjEpAL4/BN4ZQB5b7gIgyNzSerpNVndx/VLgmzVSFgT7MlA/EmhchJuXPLfVVZj7ulWhk2c8E5H4MzroyfGRd8x2AJVsndhN/oI079/OkGzy/RfoFw/CzfLxLkh/MIbbMIw4oUK7ULVSTLv6/Pxq9CiiH7DAddA Received: from debian.fritz.box ([93.184.186.109]) by smtp.gmail.com with ESMTPSA id tj3-20020a170907c24300b00a3cf5450b28sm1617264ejc.189.2024.02.14.00.53.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Feb 2024 00:54:00 -0800 (PST) From: Dimitri Fedrau To: Cc: Dimitri Fedrau , Jonathan Cameron , Lars-Peter Clausen , Javier Carrasco , Nuno Sa , Li peiyu <579lpy@gmail.com>, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 1/3] iio: humidity: hdc3020: switch to 16bit register defines Date: Wed, 14 Feb 2024 09:53:43 +0100 Message-Id: <20240214085350.19382-2-dima.fedrau@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240214085350.19382-1-dima.fedrau@gmail.com> References: <20240214085350.19382-1-dima.fedrau@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Switch to 16bit register defines and drop the const u8 register pairs. By doing so we change the parameter of functions for reading and writing to the device. Additionally create helper functions that are aware of the new register format and apply them wherever possible. Signed-off-by: Dimitri Fedrau --- drivers/iio/humidity/hdc3020.c | 200 +++++++++++---------------------- 1 file changed, 63 insertions(+), 137 deletions(-) diff --git a/drivers/iio/humidity/hdc3020.c b/drivers/iio/humidity/hdc3020.c index ed70415512f6..4ae4dd3187db 100644 --- a/drivers/iio/humidity/hdc3020.c +++ b/drivers/iio/humidity/hdc3020.c @@ -21,26 +21,22 @@ =20 #include =20 -#define HDC3020_HEATER_CMD_MSB 0x30 /* shared by all heater commands */ -#define HDC3020_HEATER_ENABLE 0x6D -#define HDC3020_HEATER_DISABLE 0x66 -#define HDC3020_HEATER_CONFIG 0x6E +#define HDC3020_S_AUTO_10HZ_MOD0 0x2737 +#define HDC3020_HEATER_DISABLE 0x3066 +#define HDC3020_HEATER_ENABLE 0x306D +#define HDC3020_HEATER_CONFIG 0x306E +#define HDC3020_EXIT_AUTO 0x3093 +#define HDC3020_R_T_RH_AUTO 0xE000 +#define HDC3020_R_T_LOW_AUTO 0xE002 +#define HDC3020_R_T_HIGH_AUTO 0xE003 +#define HDC3020_R_RH_LOW_AUTO 0xE004 +#define HDC3020_R_RH_HIGH_AUTO 0xE005 =20 #define HDC3020_READ_RETRY_TIMES 10 #define HDC3020_BUSY_DELAY_MS 10 =20 #define HDC3020_CRC8_POLYNOMIAL 0x31 =20 -static const u8 HDC3020_S_AUTO_10HZ_MOD0[2] =3D { 0x27, 0x37 }; - -static const u8 HDC3020_EXIT_AUTO[2] =3D { 0x30, 0x93 }; - -static const u8 HDC3020_R_T_RH_AUTO[2] =3D { 0xE0, 0x00 }; -static const u8 HDC3020_R_T_LOW_AUTO[2] =3D { 0xE0, 0x02 }; -static const u8 HDC3020_R_T_HIGH_AUTO[2] =3D { 0xE0, 0x03 }; -static const u8 HDC3020_R_RH_LOW_AUTO[2] =3D { 0xE0, 0x04 }; -static const u8 HDC3020_R_RH_HIGH_AUTO[2] =3D { 0xE0, 0x05 }; - struct hdc3020_data { struct i2c_client *client; /* @@ -82,7 +78,7 @@ static const struct iio_chan_spec hdc3020_channels[] =3D { =20 DECLARE_CRC8_TABLE(hdc3020_crc8_table); =20 -static int hdc3020_write_bytes(struct hdc3020_data *data, const u8 *buf, u= 8 len) +static int hdc3020_write_bytes(struct hdc3020_data *data, u8 *buf, u8 len) { struct i2c_client *client =3D data->client; struct i2c_msg msg; @@ -90,7 +86,7 @@ static int hdc3020_write_bytes(struct hdc3020_data *data,= const u8 *buf, u8 len) =20 msg.addr =3D client->addr; msg.flags =3D 0; - msg.buf =3D (char *)buf; + msg.buf =3D buf; msg.len =3D len; =20 /* @@ -109,26 +105,28 @@ static int hdc3020_write_bytes(struct hdc3020_data *d= ata, const u8 *buf, u8 len) return -ETIMEDOUT; } =20 -static int hdc3020_read_bytes(struct hdc3020_data *data, const u8 *buf, - void *val, int len) +static +int hdc3020_read_bytes(struct hdc3020_data *data, u16 reg, u8 *buf, int le= n) { + u8 reg_buf[2]; int ret, cnt; struct i2c_client *client =3D data->client; struct i2c_msg msg[2] =3D { [0] =3D { .addr =3D client->addr, .flags =3D 0, - .buf =3D (char *)buf, + .buf =3D reg_buf, .len =3D 2, }, [1] =3D { .addr =3D client->addr, .flags =3D I2C_M_RD, - .buf =3D val, + .buf =3D buf, .len =3D len, }, }; =20 + put_unaligned_be16(reg, reg_buf); /* * During the measurement process, HDC3020 will not return data. * So wait for a while and try again @@ -145,48 +143,12 @@ static int hdc3020_read_bytes(struct hdc3020_data *da= ta, const u8 *buf, return -ETIMEDOUT; } =20 -static int hdc3020_read_measurement(struct hdc3020_data *data, - enum iio_chan_type type, int *val) -{ - u8 crc, buf[6]; - int ret; - - ret =3D hdc3020_read_bytes(data, HDC3020_R_T_RH_AUTO, buf, 6); - if (ret < 0) - return ret; - - /* CRC check of the temperature measurement */ - crc =3D crc8(hdc3020_crc8_table, buf, 2, CRC8_INIT_VALUE); - if (crc !=3D buf[2]) - return -EINVAL; - - /* CRC check of the relative humidity measurement */ - crc =3D crc8(hdc3020_crc8_table, buf + 3, 2, CRC8_INIT_VALUE); - if (crc !=3D buf[5]) - return -EINVAL; - - if (type =3D=3D IIO_TEMP) - *val =3D get_unaligned_be16(buf); - else if (type =3D=3D IIO_HUMIDITYRELATIVE) - *val =3D get_unaligned_be16(&buf[3]); - else - return -EINVAL; - - return 0; -} - -/* - * After exiting the automatic measurement mode or resetting, the peak - * value will be reset to the default value - * This method is used to get the highest temp measured during automatic - * measurement - */ -static int hdc3020_read_high_peak_t(struct hdc3020_data *data, int *val) +static int hdc3020_read_be16(struct hdc3020_data *data, u16 reg) { u8 crc, buf[3]; int ret; =20 - ret =3D hdc3020_read_bytes(data, HDC3020_R_T_HIGH_AUTO, buf, 3); + ret =3D hdc3020_read_bytes(data, reg, buf, 3); if (ret < 0) return ret; =20 @@ -194,73 +156,43 @@ static int hdc3020_read_high_peak_t(struct hdc3020_da= ta *data, int *val) if (crc !=3D buf[2]) return -EINVAL; =20 - *val =3D get_unaligned_be16(buf); - - return 0; + return get_unaligned_be16(buf); } =20 -/* - * This method is used to get the lowest temp measured during automatic - * measurement - */ -static int hdc3020_read_low_peak_t(struct hdc3020_data *data, int *val) +static int hdc3020_exec_cmd(struct hdc3020_data *data, u16 reg) { - u8 crc, buf[3]; - int ret; - - ret =3D hdc3020_read_bytes(data, HDC3020_R_T_LOW_AUTO, buf, 3); - if (ret < 0) - return ret; - - crc =3D crc8(hdc3020_crc8_table, buf, 2, CRC8_INIT_VALUE); - if (crc !=3D buf[2]) - return -EINVAL; - - *val =3D get_unaligned_be16(buf); + u8 reg_buf[2]; =20 - return 0; + put_unaligned_be16(reg, reg_buf); + return hdc3020_write_bytes(data, reg_buf, 2); } =20 -/* - * This method is used to get the highest humidity measured during automat= ic - * measurement - */ -static int hdc3020_read_high_peak_rh(struct hdc3020_data *data, int *val) +static int hdc3020_read_measurement(struct hdc3020_data *data, + enum iio_chan_type type, int *val) { - u8 crc, buf[3]; + u8 crc, buf[6]; int ret; =20 - ret =3D hdc3020_read_bytes(data, HDC3020_R_RH_HIGH_AUTO, buf, 3); + ret =3D hdc3020_read_bytes(data, HDC3020_R_T_RH_AUTO, buf, 6); if (ret < 0) return ret; =20 + /* CRC check of the temperature measurement */ crc =3D crc8(hdc3020_crc8_table, buf, 2, CRC8_INIT_VALUE); if (crc !=3D buf[2]) return -EINVAL; =20 - *val =3D get_unaligned_be16(buf); - - return 0; -} - -/* - * This method is used to get the lowest humidity measured during automatic - * measurement - */ -static int hdc3020_read_low_peak_rh(struct hdc3020_data *data, int *val) -{ - u8 crc, buf[3]; - int ret; - - ret =3D hdc3020_read_bytes(data, HDC3020_R_RH_LOW_AUTO, buf, 3); - if (ret < 0) - return ret; - - crc =3D crc8(hdc3020_crc8_table, buf, 2, CRC8_INIT_VALUE); - if (crc !=3D buf[2]) + /* CRC check of the relative humidity measurement */ + crc =3D crc8(hdc3020_crc8_table, buf + 3, 2, CRC8_INIT_VALUE); + if (crc !=3D buf[5]) return -EINVAL; =20 - *val =3D get_unaligned_be16(buf); + if (type =3D=3D IIO_TEMP) + *val =3D get_unaligned_be16(buf); + else if (type =3D=3D IIO_HUMIDITYRELATIVE) + *val =3D get_unaligned_be16(&buf[3]); + else + return -EINVAL; =20 return 0; } @@ -286,28 +218,28 @@ static int hdc3020_read_raw(struct iio_dev *indio_dev, } case IIO_CHAN_INFO_PEAK: { guard(mutex)(&data->lock); - if (chan->type =3D=3D IIO_TEMP) { - ret =3D hdc3020_read_high_peak_t(data, val); - if (ret < 0) - return ret; - } else { - ret =3D hdc3020_read_high_peak_rh(data, val); - if (ret < 0) - return ret; - } + if (chan->type =3D=3D IIO_TEMP) + ret =3D hdc3020_read_be16(data, HDC3020_R_T_HIGH_AUTO); + else + ret =3D hdc3020_read_be16(data, HDC3020_R_RH_HIGH_AUTO); + + if (ret < 0) + return ret; + + *val =3D ret; return IIO_VAL_INT; } case IIO_CHAN_INFO_TROUGH: { guard(mutex)(&data->lock); - if (chan->type =3D=3D IIO_TEMP) { - ret =3D hdc3020_read_low_peak_t(data, val); - if (ret < 0) - return ret; - } else { - ret =3D hdc3020_read_low_peak_rh(data, val); - if (ret < 0) - return ret; - } + if (chan->type =3D=3D IIO_TEMP) + ret =3D hdc3020_read_be16(data, HDC3020_R_T_LOW_AUTO); + else + ret =3D hdc3020_read_be16(data, HDC3020_R_RH_LOW_AUTO); + + if (ret < 0) + return ret; + + *val =3D ret; return IIO_VAL_INT; } case IIO_CHAN_INFO_SCALE: @@ -352,23 +284,17 @@ static int hdc3020_update_heater(struct hdc3020_data = *data, int val) if (val < hdc3020_heater_vals[0] || val > hdc3020_heater_vals[2]) return -EINVAL; =20 - buf[0] =3D HDC3020_HEATER_CMD_MSB; + if (!val) + hdc3020_exec_cmd(data, HDC3020_HEATER_DISABLE); =20 - if (!val) { - buf[1] =3D HDC3020_HEATER_DISABLE; - return hdc3020_write_bytes(data, buf, 2); - } - - buf[1] =3D HDC3020_HEATER_CONFIG; + put_unaligned_be16(HDC3020_HEATER_CONFIG, buf); put_unaligned_be16(val & GENMASK(13, 0), &buf[2]); buf[4] =3D crc8(hdc3020_crc8_table, buf + 2, 2, CRC8_INIT_VALUE); ret =3D hdc3020_write_bytes(data, buf, 5); if (ret < 0) return ret; =20 - buf[1] =3D HDC3020_HEATER_ENABLE; - - return hdc3020_write_bytes(data, buf, 2); + return hdc3020_exec_cmd(data, HDC3020_HEATER_ENABLE); } =20 static int hdc3020_write_raw(struct iio_dev *indio_dev, @@ -397,7 +323,7 @@ static const struct iio_info hdc3020_info =3D { =20 static void hdc3020_stop(void *data) { - hdc3020_write_bytes((struct hdc3020_data *)data, HDC3020_EXIT_AUTO, 2); + hdc3020_exec_cmd((struct hdc3020_data *)data, HDC3020_EXIT_AUTO); } =20 static int hdc3020_probe(struct i2c_client *client) @@ -425,7 +351,7 @@ static int hdc3020_probe(struct i2c_client *client) indio_dev->channels =3D hdc3020_channels; indio_dev->num_channels =3D ARRAY_SIZE(hdc3020_channels); =20 - ret =3D hdc3020_write_bytes(data, HDC3020_S_AUTO_10HZ_MOD0, 2); + ret =3D hdc3020_exec_cmd(data, HDC3020_S_AUTO_10HZ_MOD0); if (ret) return dev_err_probe(&client->dev, ret, "Unable to set up measurement\n"); --=20 2.39.2 From nobody Sat Feb 7 15:35:22 2026 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0715C125D3; Wed, 14 Feb 2024 08:54:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707900852; cv=none; b=rr3ZxVt7UifkRQSZKiXmHgsXBnPnRmPtdlhJ4tzlxGgjJ3EvCXBnXN7lxob+lLGhDku/pvAZ9zBbqFI87+B+M3gV1Su1EnA6DGlnc9LgaGasi+FDHN1Pkjy0wG2nWUVbxearMZSQt88mUAzbN2BKGsW3fPOxepVoJxS4Hc2DykE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707900852; c=relaxed/simple; bh=JIupEgZdlhi1DwMWARijZBjPHa2nr9YDs+J+OgdUkYY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Z+rWdj/g5Kd4oFwL2HsG5TMBQQScszlzblkkoci8iw54VrOGGlxG68lfneMGNk4O9t4xWFYk5LOLkAurbr/UcH1UxKV+yDLBgxiCTV40IviWKVa1WvrSOWWJLnr8LT+fr9nRWm/mxVBsVPqy4dc/qifpOspvB095OVWgxy3sk94= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=W2/18nlT; arc=none smtp.client-ip=209.85.218.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="W2/18nlT" Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-a26fa294e56so705375366b.0; Wed, 14 Feb 2024 00:54:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707900849; x=1708505649; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ds/QrOAUfj55fwmiogY89G0c95jjcvTfyeTi82RwVPQ=; b=W2/18nlT/wmqK186h0NIRKl/S3O1p8BMibKV64D27f6Mj8+Nfh2eMApn0p1qOmcxRg 4OLnwrFjGWGXNY01Tasl8gSNAXr7kbsCLWqOZ6iwRnOmqdoR3mVBCGuK/gYeQKS3McTe thYksbRtda1PyZd8YH5F837rZGrdzyVOgKjlfjrwsxP1GAIIfD6pGosXodPK2PZRWaN5 1BLksh7EUKEhsidiZR18XmRBfpOQKuh4kg93v+lNEOFG2daTCUQHc+9zEs/5AB2Z8a/z VqCZ6WldIOn/kM7h8gBSut91ac2ad2IWmu558RnUdSWfm+l2jJwYlzOum1BwYx6skhT+ 1O+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707900849; x=1708505649; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ds/QrOAUfj55fwmiogY89G0c95jjcvTfyeTi82RwVPQ=; b=lcqDyIpWR7y+pYl5tjRyO2XKRu8rWD8/PIKBsCK2sWuzhEjZLPxTAKNYTj4HbSfxAN 43W/UeuK8Fm2PAHNbfdofG4JP1netWurbLkkaPqvA679AmA9H14g7+769H0a+fww/eFF xYK7XJmFuqAdsPy1Z1jMzItSTUbSI1115z6amGoe9JT7wxfO0CLVTIE+rzYCuoLipZYa RwafwnLf1OdvyaUVFACRCvK7IouKTzEPamFqvPHF37mK2OqF2m9lerWGkxKTV5SjF/Dm wYlhW3nqDoDkaRlsDMIXmo+yCzSGawMlCXQ9/HEkyKP87Nu10eGD1TC+WMZ97cT81BtA 86gw== X-Forwarded-Encrypted: i=1; AJvYcCXanTfprVQBsjYTdix30b3orEpx3jGWONlP0GNwrwmPJpEIOWh02+q5Mej0HaaRWynvdT2VdlwmYSRlZMk+KzKYUcxDrY9xmV+/Cb/jzuZhaqZ/nmoTzLs7iyCQHaXBzRV2TxjzD2uN1xn2TQ7HnYsnUf6x1GQuvlLe63ZGK7smrp2zCQ== X-Gm-Message-State: AOJu0YwgsUOXihQGyvmFIhxNRdQ2jGHlLRecBndOf7uWf2I5+0O8EAYb 1PiKqywHTTrHZsvWY4CU6hQMlFh19qJ6cGWmHnILDojPpfHC9Guc X-Google-Smtp-Source: AGHT+IHtQkkg7cmPOVNhPqSRXK5hIlaovqOGnDqh3sNWSzqQsse6el+sdvq++8Bg64n7SL5C0jJ2WQ== X-Received: by 2002:a17:906:118d:b0:a3d:4036:4543 with SMTP id n13-20020a170906118d00b00a3d40364543mr858290eja.51.1707900848950; Wed, 14 Feb 2024 00:54:08 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCVEJYQ2MujHYQ4aClq9TFiI/b7CEexbSpF3JNd4i7OZvcIvbNQufcjzKwdtnXvO0cP9yuL59lijEE++hQo3ZDB1scsWxygqwZ70735Yj0gJB7s3FJ54vSyACtrIe1cVw6b5hfxFHxaWfprgP/DMa5eTF1w4RJkzlKUprjkMcg5HpzJ8eXAPU9FVFpdnR6HCWNFUD9KLOVtLN/rJCIucyHGlCz16qTgGewEwZ7686VR8+aX5hUuL2T7cHkd6BYDy36K23YJH1aaHucoMRHVXG9RgK94pn5+l3BstckIkciTOPKuqpRKqd/NJYSHLgTTrPiqyvvhaa+SSyHKvMvumGCvi4WtmNw0s7RqBhcJHY+a3lQZmDpL0ULk/JU3qBbMuHStaiwkYcNcsS6VYGrxeShvreiFZomM5OCA= Received: from debian.fritz.box ([93.184.186.109]) by smtp.gmail.com with ESMTPSA id tj3-20020a170907c24300b00a3cf5450b28sm1617264ejc.189.2024.02.14.00.54.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Feb 2024 00:54:08 -0800 (PST) From: Dimitri Fedrau To: Cc: Dimitri Fedrau , Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Li peiyu <579lpy@gmail.com>, Nuno Sa , Javier Carrasco , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 2/3] dt-bindings: iio: humidity: hdc3020: add interrupt bindings in example Date: Wed, 14 Feb 2024 09:53:44 +0100 Message-Id: <20240214085350.19382-3-dima.fedrau@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240214085350.19382-1-dima.fedrau@gmail.com> References: <20240214085350.19382-1-dima.fedrau@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add interrupt bindings in example. Signed-off-by: Dimitri Fedrau Acked-by: Rob Herring --- Documentation/devicetree/bindings/iio/humidity/ti,hdc3020.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/iio/humidity/ti,hdc3020.yaml= b/Documentation/devicetree/bindings/iio/humidity/ti,hdc3020.yaml index 7f6d0f9edc75..8b5dedd1a598 100644 --- a/Documentation/devicetree/bindings/iio/humidity/ti,hdc3020.yaml +++ b/Documentation/devicetree/bindings/iio/humidity/ti,hdc3020.yaml @@ -43,6 +43,7 @@ additionalProperties: false =20 examples: - | + #include i2c { #address-cells =3D <1>; #size-cells =3D <0>; @@ -51,5 +52,7 @@ examples: compatible =3D "ti,hdc3021", "ti,hdc3020"; reg =3D <0x47>; vdd-supply =3D <&vcc_3v3>; + interrupt-parent =3D <&gpio3>; + interrupts =3D <23 IRQ_TYPE_EDGE_RISING>; }; }; --=20 2.39.2 From nobody Sat Feb 7 15:35:22 2026 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E640612B98; Wed, 14 Feb 2024 08:54:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707900859; cv=none; b=WKiR4wNrPyDV9FfvHrU+cFe7v8bCQfkV/fMKh/tr+Qhyviqm/PCnULQ3Tp1zH0MkegxCoUN+cF0O7YV8lPaQXgvAEIn7XjM5WsyaAqMQ5p9yyIwiwQ39isGw8mD4ugGIAuG2of6H8xoPU3dA6of8HB+hDpst2Pe5aN3NJ5w1NqM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707900859; c=relaxed/simple; bh=27TB8y3R5pl3bqJcGL/bPZHjMjG/ti4dr0pzQuI9Rm0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=Ml8/4huYITG4ggTD6vtw7noJA8MSrysd69tx6nWBkUk5mweTiNbpcV+kGrTUtvy6XyAvSwJNNEkdUjyk0Mevxg+H5hyw2Priv3oKvv0HeW5n3TcF3ov6ZpB55ecysw2F3heuXwuIRNWz6MkEwombv4WszSBc4hsFc8JrhJHsfBI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CmNMoxy4; arc=none smtp.client-ip=209.85.218.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CmNMoxy4" Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-a3d54555692so24296266b.1; Wed, 14 Feb 2024 00:54:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707900855; x=1708505655; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CE2NV3RRaf38fxRK5UVybyzXRuOyJW56L0G7b0zCM/g=; b=CmNMoxy4z1yNsaV+ql0f8MuoQKGuIwwr3uAE2vr3gwiFspS4f2siOxOsXcPI12afat PBZ70TvOLz3ZOaM+EYQUgQV74bexDgvv/dbKhSXolGuDcP3Bt8+KDo6BuwbUswtYbn1z wMw06hVWuy89viFuoRmReLBhnWOXUuNgJT6sV5798uG2fUBLnJy+a/YXfksTysoyGgkW mM7FzLCj2RZVRP2u5E/IMyGIm4AGIe2/5Ep2qpyqIIGWxipNLxLln3BP20PCFFkps0fh X3GWu6xtCH18suGWbU6Bnpp1CKE/EPpcP4r4zpuSoJRofKUmBRu93Iy3R9XeInSJTBMl xBKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707900855; x=1708505655; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CE2NV3RRaf38fxRK5UVybyzXRuOyJW56L0G7b0zCM/g=; b=I4opP3uiTAUPc9rOKiFpCAXrbhyyJGCRi6YqtXFK8ZiYBt/PQqj3iWrc63kRW68ATt X1mIiqWosUVfowbbNuSpJ4lToIJFzVomhqAd1KQjg6kelBblUVdb1gUvH+Np9Me9QNMy CuGZzT4uoMeSjAyG00Mi4kq2VXSfFJvE6QzcQt127iLEJ/O3I5dcnykYUj3RUi1h2Flt o1xRm31qcX681jX0t7t4mgJYYJjrLTSdYUYdiJSXZ67yuZODEeMSKsJER7MJKzKXdFmp Wven0EiJ3UrQDVko1CNqRqB/8bqsBhBqZhnecWZggsRWug7L/BR75yjxwUrC6CQhKoG0 KvQQ== X-Forwarded-Encrypted: i=1; AJvYcCV9Xpz6Xm7qzukD2mXmbkH3aEEfwerB1TuyxIS6sPBTeX2mFz4GVVciBSwt6NUe78lVXc0YPqQRA8t3fs0w6Gaf5GGrR3WIRKnB7wxUPRUtLB4jqryuDZZUWDa9R2CuDfkq5fYGerKj X-Gm-Message-State: AOJu0YzitUFVhX/oATtsFXI/TT+fgP2KKpd9uddw0sa9ibC8provWPeP 5R9UbgBBYa+gZSMWRbcf8B8KBbY36xI9TZYLrKeTlg5I1zh0VaEe X-Google-Smtp-Source: AGHT+IFM/FCLSiunhvKT4RhDXum8svplDtQFSHbnlcpXjRAaGu+P0zauc4RNG36fA4H/gwivsPG3aA== X-Received: by 2002:a17:906:378a:b0:a3d:14ce:d95 with SMTP id n10-20020a170906378a00b00a3d14ce0d95mr1278136ejc.47.1707900855060; Wed, 14 Feb 2024 00:54:15 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCUuzonwDxhVRQGXt7tO1Pt36qkuxtjOmCEpxZTBdnLkS1i1b7DKwrf76spj27oQ7aj8KAVfUWmXgnQd1J6c3X2pzaZaQwIvgtMBB4HNTPMXbICrCj03zn/+0MEL5k8gpm4v+MDz0/4x5XsnmdJmJF7jIO0Aywlj3BsvSbgN1CDV8BTdUb926KaswdmyDAeGcF+GW35PB8USSinCH+iNHDPKA68O5qcIK34iX1o9kCWabrgK592F1zGx5pIJQVrC4q5YAQ5LK7cn5YhKQeJ8httf Received: from debian.fritz.box ([93.184.186.109]) by smtp.gmail.com with ESMTPSA id tj3-20020a170907c24300b00a3cf5450b28sm1617264ejc.189.2024.02.14.00.54.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Feb 2024 00:54:14 -0800 (PST) From: Dimitri Fedrau To: Cc: Dimitri Fedrau , Jonathan Cameron , Lars-Peter Clausen , Nuno Sa , Javier Carrasco , Li peiyu <579lpy@gmail.com>, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 3/3] iio: humidity: hdc3020: add threshold events support Date: Wed, 14 Feb 2024 09:53:45 +0100 Message-Id: <20240214085350.19382-4-dima.fedrau@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240214085350.19382-1-dima.fedrau@gmail.com> References: <20240214085350.19382-1-dima.fedrau@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Add threshold events support for temperature and relative humidity. To enable them the higher and lower threshold registers must be programmed and the higher threshold must be greater then or equal to the lower threshold. Otherwise the event is disabled. Invalid hysteresis values are ignored by the device. There is no further configuration possible. Tested by setting thresholds/hysteresis and turning the heater on/off. Used iio_event_monitor in tools/iio to catch events while constantly displaying temperature and humidity values. Signed-off-by: Dimitri Fedrau Tested-by: Javier Carrasco --- drivers/iio/humidity/hdc3020.c | 247 +++++++++++++++++++++++++++++++++ 1 file changed, 247 insertions(+) diff --git a/drivers/iio/humidity/hdc3020.c b/drivers/iio/humidity/hdc3020.c index 4ae4dd3187db..1e5d0d4797b1 100644 --- a/drivers/iio/humidity/hdc3020.c +++ b/drivers/iio/humidity/hdc3020.c @@ -5,38 +5,67 @@ * * Copyright (C) 2023 * + * Copyright (C) 2024 Liebherr-Electronics and Drives GmbH + * * Datasheet: https://www.ti.com/lit/ds/symlink/hdc3020.pdf */ =20 +#include #include #include #include #include #include #include +#include #include #include +#include =20 #include =20 +#include #include =20 #define HDC3020_S_AUTO_10HZ_MOD0 0x2737 +#define HDC3020_S_STATUS 0x3041 #define HDC3020_HEATER_DISABLE 0x3066 #define HDC3020_HEATER_ENABLE 0x306D #define HDC3020_HEATER_CONFIG 0x306E #define HDC3020_EXIT_AUTO 0x3093 +#define HDC3020_S_T_RH_THRESH_LOW 0x6100 +#define HDC3020_S_T_RH_THRESH_LOW_CLR 0x610B +#define HDC3020_S_T_RH_THRESH_HIGH_CLR 0x6116 +#define HDC3020_S_T_RH_THRESH_HIGH 0x611D #define HDC3020_R_T_RH_AUTO 0xE000 #define HDC3020_R_T_LOW_AUTO 0xE002 #define HDC3020_R_T_HIGH_AUTO 0xE003 #define HDC3020_R_RH_LOW_AUTO 0xE004 #define HDC3020_R_RH_HIGH_AUTO 0xE005 +#define HDC3020_R_T_RH_THRESH_LOW 0xE102 +#define HDC3020_R_T_RH_THRESH_LOW_CLR 0xE109 +#define HDC3020_R_T_RH_THRESH_HIGH_CLR 0xE114 +#define HDC3020_R_T_RH_THRESH_HIGH 0xE11F +#define HDC3020_R_STATUS 0xF32D + +#define HDC3020_THRESH_TEMP_MASK GENMASK(8, 0) +#define HDC3020_THRESH_TEMP_TRUNC_SHIFT 7 +#define HDC3020_THRESH_HUM_MASK GENMASK(15, 9) +#define HDC3020_THRESH_HUM_TRUNC_SHIFT 9 + +#define HDC3020_STATUS_T_LOW_ALERT BIT(6) +#define HDC3020_STATUS_T_HIGH_ALERT BIT(7) +#define HDC3020_STATUS_RH_LOW_ALERT BIT(8) +#define HDC3020_STATUS_RH_HIGH_ALERT BIT(9) =20 #define HDC3020_READ_RETRY_TIMES 10 #define HDC3020_BUSY_DELAY_MS 10 =20 #define HDC3020_CRC8_POLYNOMIAL 0x31 =20 +#define HDC3020_MIN_TEMP -40 +#define HDC3020_MAX_TEMP 125 + struct hdc3020_data { struct i2c_client *client; /* @@ -50,18 +79,37 @@ struct hdc3020_data { =20 static const int hdc3020_heater_vals[] =3D {0, 1, 0x3FFF}; =20 +static const struct iio_event_spec hdc3020_t_rh_event[] =3D { + { + .type =3D IIO_EV_TYPE_THRESH, + .dir =3D IIO_EV_DIR_RISING, + .mask_separate =3D BIT(IIO_EV_INFO_VALUE) | + BIT(IIO_EV_INFO_HYSTERESIS), + }, + { + .type =3D IIO_EV_TYPE_THRESH, + .dir =3D IIO_EV_DIR_FALLING, + .mask_separate =3D BIT(IIO_EV_INFO_VALUE) | + BIT(IIO_EV_INFO_HYSTERESIS), + }, +}; + static const struct iio_chan_spec hdc3020_channels[] =3D { { .type =3D IIO_TEMP, .info_mask_separate =3D BIT(IIO_CHAN_INFO_RAW) | BIT(IIO_CHAN_INFO_SCALE) | BIT(IIO_CHAN_INFO_PEAK) | BIT(IIO_CHAN_INFO_TROUGH) | BIT(IIO_CHAN_INFO_OFFSET), + .event_spec =3D hdc3020_t_rh_event, + .num_event_specs =3D ARRAY_SIZE(hdc3020_t_rh_event), }, { .type =3D IIO_HUMIDITYRELATIVE, .info_mask_separate =3D BIT(IIO_CHAN_INFO_RAW) | BIT(IIO_CHAN_INFO_SCALE) | BIT(IIO_CHAN_INFO_PEAK) | BIT(IIO_CHAN_INFO_TROUGH), + .event_spec =3D hdc3020_t_rh_event, + .num_event_specs =3D ARRAY_SIZE(hdc3020_t_rh_event), }, { /* @@ -315,10 +363,192 @@ static int hdc3020_write_raw(struct iio_dev *indio_d= ev, return -EINVAL; } =20 +static int hdc3020_write_thresh(struct iio_dev *indio_dev, + const struct iio_chan_spec *chan, + enum iio_event_type type, + enum iio_event_direction dir, + enum iio_event_info info, + int val, int val2) +{ + struct hdc3020_data *data =3D iio_priv(indio_dev); + u8 buf[5]; + u64 tmp; + u16 reg; + int ret; + + /* Supported temperature range is from =E2=80=9340 to 125 degree celsius = */ + if (val < HDC3020_MIN_TEMP || val > HDC3020_MAX_TEMP) + return -EINVAL; + + /* Select threshold register */ + if (info =3D=3D IIO_EV_INFO_VALUE) { + if (dir =3D=3D IIO_EV_DIR_RISING) + reg =3D HDC3020_S_T_RH_THRESH_HIGH; + else + reg =3D HDC3020_S_T_RH_THRESH_LOW; + } else { + if (dir =3D=3D IIO_EV_DIR_RISING) + reg =3D HDC3020_S_T_RH_THRESH_HIGH_CLR; + else + reg =3D HDC3020_S_T_RH_THRESH_LOW_CLR; + } + + guard(mutex)(&data->lock); + ret =3D hdc3020_read_be16(data, reg); + if (ret < 0) + return ret; + + switch (chan->type) { + case IIO_TEMP: + /* + * Calculate temperature threshold, shift it down to get the + * truncated threshold representation in the 9LSBs while keeping + * the current humidity threshold in the 7 MSBs. + */ + tmp =3D ((u64)(((val + 45) * MICRO) + val2)) * 65535ULL; + tmp =3D div_u64(tmp, MICRO * 175); + val =3D tmp >> HDC3020_THRESH_TEMP_TRUNC_SHIFT; + val =3D FIELD_PREP(HDC3020_THRESH_TEMP_MASK, val); + val |=3D (FIELD_GET(HDC3020_THRESH_HUM_MASK, ret) << + HDC3020_THRESH_HUM_TRUNC_SHIFT); + break; + case IIO_HUMIDITYRELATIVE: + /* + * Calculate humidity threshold, shift it down and up to get the + * truncated threshold representation in the 7MSBs while keeping + * the current temperature threshold in the 9 LSBs. + */ + tmp =3D ((u64)((val * MICRO) + val2)) * 65535ULL; + tmp =3D div_u64(tmp, MICRO * 100); + val =3D tmp >> HDC3020_THRESH_HUM_TRUNC_SHIFT; + val =3D FIELD_PREP(HDC3020_THRESH_HUM_MASK, val); + val |=3D FIELD_GET(HDC3020_THRESH_TEMP_MASK, ret); + break; + default: + return -EOPNOTSUPP; + } + + put_unaligned_be16(reg, buf); + put_unaligned_be16(val, buf + 2); + buf[4] =3D crc8(hdc3020_crc8_table, buf + 2, 2, CRC8_INIT_VALUE); + return hdc3020_write_bytes(data, buf, 5); +} + +static int hdc3020_read_thresh(struct iio_dev *indio_dev, + const struct iio_chan_spec *chan, + enum iio_event_type type, + enum iio_event_direction dir, + enum iio_event_info info, + int *val, int *val2) +{ + struct hdc3020_data *data =3D iio_priv(indio_dev); + u16 reg; + int ret; + + /* Select threshold register */ + if (info =3D=3D IIO_EV_INFO_VALUE) { + if (dir =3D=3D IIO_EV_DIR_RISING) + reg =3D HDC3020_R_T_RH_THRESH_HIGH; + else + reg =3D HDC3020_R_T_RH_THRESH_LOW; + } else { + if (dir =3D=3D IIO_EV_DIR_RISING) + reg =3D HDC3020_R_T_RH_THRESH_HIGH_CLR; + else + reg =3D HDC3020_R_T_RH_THRESH_LOW_CLR; + } + + guard(mutex)(&data->lock); + ret =3D hdc3020_read_be16(data, reg); + if (ret < 0) + return ret; + + switch (chan->type) { + case IIO_TEMP: + /* + * Get the temperature threshold from 9 LSBs, shift them to get + * the truncated temperature threshold representation and + * calculate the threshold according to the formula in the + * datasheet. + */ + *val =3D FIELD_GET(HDC3020_THRESH_TEMP_MASK, ret); + *val =3D *val << HDC3020_THRESH_TEMP_TRUNC_SHIFT; + *val =3D -2949075 + (175 * (*val)); + *val2 =3D 65535; + return IIO_VAL_FRACTIONAL; + case IIO_HUMIDITYRELATIVE: + /* + * Get the humidity threshold from 7 MSBs, shift them to get the + * truncated humidity threshold representation and calculate the + * threshold according to the formula in the datasheet. + */ + *val =3D FIELD_GET(HDC3020_THRESH_HUM_MASK, ret); + *val =3D (*val << HDC3020_THRESH_HUM_TRUNC_SHIFT) * 100; + *val2 =3D 65535; + return IIO_VAL_FRACTIONAL; + default: + return -EOPNOTSUPP; + } +} + +static irqreturn_t hdc3020_interrupt_handler(int irq, void *private) +{ + struct iio_dev *indio_dev =3D private; + struct hdc3020_data *data; + s64 time; + int ret; + + data =3D iio_priv(indio_dev); + ret =3D hdc3020_read_be16(data, HDC3020_R_STATUS); + if (ret < 0) + return IRQ_HANDLED; + + if (!(ret & (HDC3020_STATUS_T_HIGH_ALERT | HDC3020_STATUS_T_LOW_ALERT | + HDC3020_STATUS_RH_HIGH_ALERT | HDC3020_STATUS_RH_LOW_ALERT))) + return IRQ_NONE; + + time =3D iio_get_time_ns(indio_dev); + if (ret & HDC3020_STATUS_T_HIGH_ALERT) + iio_push_event(indio_dev, + IIO_MOD_EVENT_CODE(IIO_TEMP, 0, + IIO_NO_MOD, + IIO_EV_TYPE_THRESH, + IIO_EV_DIR_RISING), + time); + + if (ret & HDC3020_STATUS_T_LOW_ALERT) + iio_push_event(indio_dev, + IIO_MOD_EVENT_CODE(IIO_TEMP, 0, + IIO_NO_MOD, + IIO_EV_TYPE_THRESH, + IIO_EV_DIR_FALLING), + time); + + if (ret & HDC3020_STATUS_RH_HIGH_ALERT) + iio_push_event(indio_dev, + IIO_MOD_EVENT_CODE(IIO_HUMIDITYRELATIVE, 0, + IIO_NO_MOD, + IIO_EV_TYPE_THRESH, + IIO_EV_DIR_RISING), + time); + + if (ret & HDC3020_STATUS_RH_LOW_ALERT) + iio_push_event(indio_dev, + IIO_MOD_EVENT_CODE(IIO_HUMIDITYRELATIVE, 0, + IIO_NO_MOD, + IIO_EV_TYPE_THRESH, + IIO_EV_DIR_FALLING), + time); + + return IRQ_HANDLED; +} + static const struct iio_info hdc3020_info =3D { .read_raw =3D hdc3020_read_raw, .write_raw =3D hdc3020_write_raw, .read_avail =3D hdc3020_read_available, + .read_event_value =3D hdc3020_read_thresh, + .write_event_value =3D hdc3020_write_thresh, }; =20 static void hdc3020_stop(void *data) @@ -350,6 +580,23 @@ static int hdc3020_probe(struct i2c_client *client) indio_dev->info =3D &hdc3020_info; indio_dev->channels =3D hdc3020_channels; indio_dev->num_channels =3D ARRAY_SIZE(hdc3020_channels); + if (client->irq) { + ret =3D devm_request_threaded_irq(&client->dev, client->irq, + NULL, hdc3020_interrupt_handler, + IRQF_ONESHOT, "hdc3020", + indio_dev); + if (ret) + return dev_err_probe(&client->dev, ret, + "Failed to request IRQ\n"); + + /* + * The alert output is activated by default upon power up, + * hardware reset, and soft reset. Clear the status register. + */ + ret =3D hdc3020_exec_cmd(data, HDC3020_S_STATUS); + if (ret) + return ret; + } =20 ret =3D hdc3020_exec_cmd(data, HDC3020_S_AUTO_10HZ_MOD0); if (ret) --=20 2.39.2