bcachefs: clean up some redundant assignments

[PATCH 0/5][next] bcachefs: clean up some redundant assignments

Posted by Colin Ian King 2 years, 3 months ago

Clean up some redundant assignments and variables based on warnings
found by clang scan build static analysis.

Colin Ian King (5):
  bcachefs: remove redundant initialization of pointer d
  bcachefs: remove redundant initialization of pointer dst
  bcachefs: remove redundant initializations of variables start_offset
    and end_offset
  bcachefs: remove duplicated assignment to variable offset_into_extent
  bcachefs: remove redundant pointer q

 fs/bcachefs/btree_update_interior.c | 2 +-
 fs/bcachefs/buckets.c               | 2 +-
 fs/bcachefs/disk_groups.c           | 3 +--
 fs/bcachefs/fs-io.c                 | 4 ++--
 fs/bcachefs/io.c                    | 1 -
 fs/bcachefs/quota.c                 | 3 ---
 6 files changed, 5 insertions(+), 10 deletions(-)

-- 
2.39.2

Re: [PATCH 0/5][next] bcachefs: clean up some redundant assignments

Posted by Kent Overstreet 2 years, 3 months ago

On Tue, Sep 12, 2023 at 01:37:39PM +0100, Colin Ian King wrote:
> Clean up some redundant assignments and variables based on warnings
> found by clang scan build static analysis.
> 
> Colin Ian King (5):
>   bcachefs: remove redundant initialization of pointer d
>   bcachefs: remove redundant initialization of pointer dst
>   bcachefs: remove redundant initializations of variables start_offset
>     and end_offset
>   bcachefs: remove duplicated assignment to variable offset_into_extent
>   bcachefs: remove redundant pointer q
> 
>  fs/bcachefs/btree_update_interior.c | 2 +-
>  fs/bcachefs/buckets.c               | 2 +-
>  fs/bcachefs/disk_groups.c           | 3 +--
>  fs/bcachefs/fs-io.c                 | 4 ++--
>  fs/bcachefs/io.c                    | 1 -
>  fs/bcachefs/quota.c                 | 3 ---
>  6 files changed, 5 insertions(+), 10 deletions(-)

Applied - thanks

Re: [PATCH 0/5][next] bcachefs: clean up some redundant assignments

Posted by Brian Foster 2 years, 3 months ago

On Tue, Sep 12, 2023 at 01:37:39PM +0100, Colin Ian King wrote:
> Clean up some redundant assignments and variables based on warnings
> found by clang scan build static analysis.
> 

These all look good to me. For the series:

Reviewed-by: Brian Foster <bfoster@redhat.com>

> Colin Ian King (5):
>   bcachefs: remove redundant initialization of pointer d
>   bcachefs: remove redundant initialization of pointer dst
>   bcachefs: remove redundant initializations of variables start_offset
>     and end_offset
>   bcachefs: remove duplicated assignment to variable offset_into_extent
>   bcachefs: remove redundant pointer q
> 
>  fs/bcachefs/btree_update_interior.c | 2 +-
>  fs/bcachefs/buckets.c               | 2 +-
>  fs/bcachefs/disk_groups.c           | 3 +--
>  fs/bcachefs/fs-io.c                 | 4 ++--
>  fs/bcachefs/io.c                    | 1 -
>  fs/bcachefs/quota.c                 | 3 ---
>  6 files changed, 5 insertions(+), 10 deletions(-)
> 
> -- 
> 2.39.2
>