From nobody Thu Dec 18 21:47:06 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76B1FCA0ED6 for ; Tue, 12 Sep 2023 12:37:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235240AbjILMh4 (ORCPT ); Tue, 12 Sep 2023 08:37:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235208AbjILMhx (ORCPT ); Tue, 12 Sep 2023 08:37:53 -0400 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E71419F; Tue, 12 Sep 2023 05:37:48 -0700 (PDT) Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-401c90ed2ecso60012835e9.0; Tue, 12 Sep 2023 05:37:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694522267; x=1695127067; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iPgIpG5TOZNPAt8S1evljl9V3lEAQHO8eSzeI6GnXt4=; b=QUvvzmsHcWrsb7/vMtgO4JlEG+7lILTzCtRWevxVBXxSOldldIUp3nCeZUUzASYHwJ vB+Tey3lHIIrwfJ7UFnElFPlZGHoTcXjFG3TQTtDRpXyT3Lgtu0nt7sGkfzZDXrlTtdh Hvjd414+Z1Xff1FYLyQCIqior4Dhx3Wqvz/Sxwcw7sy/iKaabJZz2yDHF4357xLQoszr uotDK399JGEbBhKKT0OtDAYyNCdSHuHxM5hN3NTkLcz5GwDH5j58jm657gOd0oUwfvun 6dBL7wCUcDUdXAbSYfFQOVUwz0qUqGaoqRYhadshgSDAj4xkiBwt97SSFjyupPkmq5zH zPlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694522267; x=1695127067; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iPgIpG5TOZNPAt8S1evljl9V3lEAQHO8eSzeI6GnXt4=; b=q+VrSZs0OyTmdRq1vHAFpg8goYdK4NE5yyfc6PBxxojA1PXiK5sa3yoraePAU36ILd tH/sX3fBF8grNBmF+5PjEnkIt3Ph1ROHHSQl/9TUQW+ZoOMoaFkCR91B8e53Uwk35eva ZpHOokYnkqEgg5hxPnyvpj9KbdP+lXrmuXMj34ZjbchvqRMcOp96I3HC47tT6lfDB5tK msVe23TcidThCSHNvwWsVPsr+ZOVhRcIFUDqldxRrLTaZwr+0TkBqvJtffjDTqY6uBLp iuIQpi+xrVPPD7SvfHGshUEmShihnXZedCNAMJpLKYwNCbFsJut+1vXWESqaER3DilWy 2GGA== X-Gm-Message-State: AOJu0YzLhNHtWpzKHQkUmo25K7CrXMbnWgSRQ7H6NzvYkVNc5e/G8IiO 2YgAbxOI5/2A8A9aUFb++vM= X-Google-Smtp-Source: AGHT+IGLbUH2Z4MFC9hO43WmWIhDOXRou/I+QOr4ZR8s1bVOyzOUZrD8TLyAlTqwj93v0teYLODyVw== X-Received: by 2002:a5d:4ac3:0:b0:31a:e772:ddf6 with SMTP id y3-20020a5d4ac3000000b0031ae772ddf6mr10792700wrs.39.1694522267081; Tue, 12 Sep 2023 05:37:47 -0700 (PDT) Received: from localhost (cpc154979-craw9-2-0-cust193.16-3.cable.virginm.net. [80.193.200.194]) by smtp.gmail.com with ESMTPSA id j6-20020adfb306000000b003142c85fbcdsm8184474wrd.11.2023.09.12.05.37.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Sep 2023 05:37:46 -0700 (PDT) From: Colin Ian King To: Kent Overstreet , Brian Foster , linux-bcachefs@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/5][next] bcachefs: remove redundant initialization of pointer d Date: Tue, 12 Sep 2023 13:37:40 +0100 Message-Id: <20230912123744.3929609-2-colin.i.king@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230912123744.3929609-1-colin.i.king@gmail.com> References: <20230912123744.3929609-1-colin.i.king@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The pointer d is being initialized with a value that is never read, it is being re-assigned later on when it is used in a for-loop. The initialization is redundant and can be removed. Cleans up clang-scan build warning: fs/bcachefs/buckets.c:1303:25: warning: Value stored to 'd' during its initialization is never read [deadcode.DeadStores] Signed-off-by: Colin Ian King Reviewed-by: Brian Foster --- fs/bcachefs/btree_update_interior.c | 2 +- fs/bcachefs/buckets.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/bcachefs/btree_update_interior.c b/fs/bcachefs/btree_update= _interior.c index 73c950d2788e..35f7af297ac0 100644 --- a/fs/bcachefs/btree_update_interior.c +++ b/fs/bcachefs/btree_update_interior.c @@ -143,7 +143,7 @@ static size_t btree_node_u64s_with_format(struct btree = *b, } =20 /** - * btree_node_format_fits - check if we could rewrite node with a new form= at + * bch2_btree_node_format_fits - check if we could rewrite node with a new= format * * This assumes all keys can pack with the new format -- it just checks if * the re-packed keys would fit inside the node itself. diff --git a/fs/bcachefs/buckets.c b/fs/bcachefs/buckets.c index c02c8c917a29..951f945bbc22 100644 --- a/fs/bcachefs/buckets.c +++ b/fs/bcachefs/buckets.c @@ -1300,7 +1300,7 @@ int bch2_trans_fs_usage_apply(struct btree_trans *tra= ns, static int warned_disk_usage =3D 0; bool warn =3D false; unsigned disk_res_sectors =3D trans->disk_res ? trans->disk_res->sectors = : 0; - struct replicas_delta *d =3D deltas->d, *d2; + struct replicas_delta *d, *d2; struct replicas_delta *top =3D (void *) deltas->d + deltas->used; struct bch_fs_usage *dst; s64 added =3D 0, should_not_have_added; --=20 2.39.2 From nobody Thu Dec 18 21:47:06 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E49BBCA0EC3 for ; Tue, 12 Sep 2023 12:37:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235261AbjILMh6 (ORCPT ); Tue, 12 Sep 2023 08:37:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235216AbjILMhx (ORCPT ); Tue, 12 Sep 2023 08:37:53 -0400 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D1D2910D3; Tue, 12 Sep 2023 05:37:49 -0700 (PDT) Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-403004a96a4so35120395e9.3; Tue, 12 Sep 2023 05:37:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694522268; x=1695127068; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0QWtGYWuF5LIVU/WAF0Ixic7dfS96mQ79iX0NaLlRek=; b=ANSkYU+yTbzN2dijjlwFMDCMSW/bSYa6B0Hn+kbW9XbbIBG6gQA8lIG3/4Zj6CqoAD rfw9v6zXbWjpllOeJTIQ0+aXm98vr71/jVl3KqNmTO/nq6p9z5uTm0im96i1Y8FAGb0o cmTiGecy3paX7N0SiRVPg9MT3WM8ifur5UM90psnGP9l823gkZIzdTKsg32EVzrN5cRP Yu8WVqweLnBzPHL1cjsGc+/gAeucKM0Z5VhR3Ph2QU6uXXn+Papxlk74TkJ2WjrxmDEf K/XOMYhqLcESPrv9msGW7+eRJZ81Th8VoasMWMxFYI472RstQAKPdD1SN/PkVzA8f34F C0jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694522268; x=1695127068; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0QWtGYWuF5LIVU/WAF0Ixic7dfS96mQ79iX0NaLlRek=; b=u0cc3tiO2kiOYZ3JVdxDPFAco4H7ytsQwoz20mTbX3LaYrVTG0zv1cNOvIja7uPKWM eEHRW2VhKRkuiihs86i+RbiuAovDlEsdFd41iiCKlT+F7IiEGL0JjDz5l14hnsA5c9N4 bXN7cY8J2JvwCSpQn5Fm8HK6JoyJyUYlOgLmLMCXEuWEfQL4cQ4+se11ar+zUads48vG P8Poy6Av8JFZiHx83SY6JWU8Dy4Bsmi/wRElvOUjoPMqcbBSlVhugs4dQcXcRpbrIlU6 qCjvUj46WuOnPoO6tTTHQbP8a9lCXV4wxIEprDPIVJeXXda7LEJH8wZUjKEBUUMEx4Wu AW3g== X-Gm-Message-State: AOJu0YzE5w3RJ2u15HkbPGWAa610bbEoRdq+ufdEVf6OWCT0KyS+Ea/o u9hzW830dvtZu1p6xtyAPhg= X-Google-Smtp-Source: AGHT+IFev/gnHA4MpFv7arGmL5MKepo/ibmW+1fWlLThdleRnVCHHztlkRbz3HeOBTdNx8hpE494uQ== X-Received: by 2002:a05:600c:21ca:b0:3f7:f2d0:b904 with SMTP id x10-20020a05600c21ca00b003f7f2d0b904mr10593501wmj.8.1694522268316; Tue, 12 Sep 2023 05:37:48 -0700 (PDT) Received: from localhost (cpc154979-craw9-2-0-cust193.16-3.cable.virginm.net. [80.193.200.194]) by smtp.gmail.com with ESMTPSA id z21-20020a05600c221500b003fbb25da65bsm12834554wml.30.2023.09.12.05.37.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Sep 2023 05:37:47 -0700 (PDT) From: Colin Ian King To: Kent Overstreet , Brian Foster , linux-bcachefs@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/5][next] bcachefs: remove redundant initialization of pointer dst Date: Tue, 12 Sep 2023 13:37:41 +0100 Message-Id: <20230912123744.3929609-3-colin.i.king@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230912123744.3929609-1-colin.i.king@gmail.com> References: <20230912123744.3929609-1-colin.i.king@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The pointer dst is being initialized with a value that is never read, it is being re-assigned later on when it is used in a while-loop The initialization is redundant and can be removed. Cleans up clang-scan build warning: fs/bcachefs/disk_groups.c:186:30: warning: Value stored to 'dst' during its initialization is never read [deadcode.DeadStores] Signed-off-by: Colin Ian King Reviewed-by: Brian Foster --- fs/bcachefs/disk_groups.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/bcachefs/disk_groups.c b/fs/bcachefs/disk_groups.c index f36472c4a781..9fa8d7d49f3e 100644 --- a/fs/bcachefs/disk_groups.c +++ b/fs/bcachefs/disk_groups.c @@ -183,8 +183,7 @@ int bch2_sb_disk_groups_to_cpu(struct bch_fs *c) =20 for (i =3D 0; i < c->disk_sb.sb->nr_devices; i++) { struct bch_member *m =3D mi->members + i; - struct bch_disk_group_cpu *dst =3D - &cpu_g->entries[BCH_MEMBER_GROUP(m)]; + struct bch_disk_group_cpu *dst; =20 if (!bch2_member_exists(m)) continue; --=20 2.39.2 From nobody Thu Dec 18 21:47:06 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DAD3CA0EC3 for ; Tue, 12 Sep 2023 12:38:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235283AbjILMiC (ORCPT ); Tue, 12 Sep 2023 08:38:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56304 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235234AbjILMhz (ORCPT ); Tue, 12 Sep 2023 08:37:55 -0400 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41EDD9F; Tue, 12 Sep 2023 05:37:51 -0700 (PDT) Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-307d58b3efbso5078650f8f.0; Tue, 12 Sep 2023 05:37:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694522269; x=1695127069; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HEO6kgqgI5vn5yqCel7J3Crgbo274n/viTPMDLC7L+A=; b=UiZBd69W9ZPkGlw5DnU+JQTZZlJrRVdWTThVjGnV7Ux4arE6H6Ne47vkJGj3IkU3rg UXrSocBbNoJrdDh4vDDfxR/AK0oUrFIXUZVAy3IkRd5IVjocsGQQuXFMFoQxYUVreE0y NvCV2oC348kSVJQFLMazIaq3Ghcl6Bmx4YOL1781a4OxKjonJjqoXbSOl6H82vbzOupG rPsaGpIJx6JwT/s1KiuE8Yx5tZ7OjWHMGxPyw4aABWGHuODuGC8K4Z10FWGlYMnGBtFA xZKBSIJMWPqYEMmeqiviN+/+v60tsDKzuGplFFcj+P9ai9csgFMqUgwl+qrFkKAdFK3b ranw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694522269; x=1695127069; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HEO6kgqgI5vn5yqCel7J3Crgbo274n/viTPMDLC7L+A=; b=R5R3jtGgJ35H6Dx71SCuOPNBGYXlmAqd4B7kIVaNR3Kqe5Ef9FkJaQfUelf+hhK3Sx tIJoGA1WXrV2J99ID7pZ3YieJqdLeQG/BEmdck0oR14xw6CnZDWq5uKyz7/6ODvh4gff eHuXz53/Vb8nTW8MOUM7NRmFzvnGfZ5AtLfDAvwz+8dYwQQO7U73nyKQ0juFlhmkxB7B 9heZTU0AbMyOfXr+HY7LznvduEuLdIAETnJypYptgCBsVw0vfbyVlzHWnvV80hybM2p1 tpYO9eNZF7fGCfHiK9Ck0uELTRqxlyFCQm3yU0Bjex1PBdZUCfxYilEz/Zz3H6bSP28H pnFw== X-Gm-Message-State: AOJu0YzhB1/v32uYeL8Ym7TyvE8LA7jcH69PP/eDk+CXI+O/mQdPCKYF emWfD6RFBc1rdH1wSlloTsE= X-Google-Smtp-Source: AGHT+IHl/OXcJHtvaj4TIUpM83JndSB4xGljGcu/Vx4JZhhUO+zqjuAd0nO/tlPxv53fDqnB/ETV8w== X-Received: by 2002:adf:e491:0:b0:319:6997:942e with SMTP id i17-20020adfe491000000b003196997942emr10164158wrm.8.1694522269336; Tue, 12 Sep 2023 05:37:49 -0700 (PDT) Received: from localhost (cpc154979-craw9-2-0-cust193.16-3.cable.virginm.net. [80.193.200.194]) by smtp.gmail.com with ESMTPSA id f7-20020a7bcd07000000b00401c595fcc7sm16010129wmj.11.2023.09.12.05.37.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Sep 2023 05:37:48 -0700 (PDT) From: Colin Ian King To: Kent Overstreet , Brian Foster , linux-bcachefs@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/5][next] bcachefs: remove redundant initializations of variables start_offset and end_offset Date: Tue, 12 Sep 2023 13:37:42 +0100 Message-Id: <20230912123744.3929609-4-colin.i.king@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230912123744.3929609-1-colin.i.king@gmail.com> References: <20230912123744.3929609-1-colin.i.king@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The variables start_offset and end_offset are being initialized with values that are never read, they being re-assigned later on. The initializations are redundant and can be removed. Cleans up clang-scan build warnings: fs/bcachefs/fs-io.c:243:11: warning: Value stored to 'start_offset' during its initialization is never read [deadcode.DeadStores] fs/bcachefs/fs-io.c:244:11: warning: Value stored to 'end_offset' during its initialization is never read [deadcode.DeadStores] Signed-off-by: Colin Ian King Reviewed-by: Brian Foster --- fs/bcachefs/fs-io.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/bcachefs/fs-io.c b/fs/bcachefs/fs-io.c index ceab12fb8a8f..c108335e0502 100644 --- a/fs/bcachefs/fs-io.c +++ b/fs/bcachefs/fs-io.c @@ -240,8 +240,8 @@ static int __bch2_truncate_folio(struct bch_inode_info = *inode, struct bch_fs *c =3D inode->v.i_sb->s_fs_info; struct address_space *mapping =3D inode->v.i_mapping; struct bch_folio *s; - unsigned start_offset =3D start & (PAGE_SIZE - 1); - unsigned end_offset =3D ((end - 1) & (PAGE_SIZE - 1)) + 1; + unsigned start_offset; + unsigned end_offset; unsigned i; struct folio *folio; s64 i_sectors_delta =3D 0; --=20 2.39.2 From nobody Thu Dec 18 21:47:06 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD5ECCA0ECA for ; Tue, 12 Sep 2023 12:38:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235289AbjILMiG (ORCPT ); Tue, 12 Sep 2023 08:38:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56322 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235241AbjILMh4 (ORCPT ); Tue, 12 Sep 2023 08:37:56 -0400 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3DA6310D5; Tue, 12 Sep 2023 05:37:52 -0700 (PDT) Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-313e742a787so3508642f8f.1; Tue, 12 Sep 2023 05:37:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694522270; x=1695127070; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=49e+l1Yidi/qhSW+/Oluai/nUug0SULS4Us9G5sFvjU=; b=FLQZlfM159anfLTemEMPJnC59yNZNoIRVg6n4xlQB2R+fzEU1mdmOKczXSuINLagUV 70b4XPP6kSnBJEeo5G8Qkw7ye805tqeHUqwSPAknHp7BFpfFCa6d76K41meBqGahJQ+f 9BWqmvEGkZDCYM8tS0KKOKqcUgp/XVWzPT1w2vBZOfimiRls3NHytLkLMdEdSjMon4Gl 06eyzrY7YVG96srJofl2pfvLlvmUSE6+QvnEnlWxkwzEHl3npwxkbKRGs4KAYTZApxBS ZPDHibw+FMRMnXWdZ1anj+z9ZsAc9ZXZ2EpjQOPIEyTV5krtsXCAhxAuY/OEKC8XASoh fD2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694522270; x=1695127070; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=49e+l1Yidi/qhSW+/Oluai/nUug0SULS4Us9G5sFvjU=; b=QNWac7/vcYEBhvjkQO/3jMW7TqyU810ws9m/CyirFSfOkarzrSQcuLeEpnhYmdRuTt /gOSB7FoFsbem+UboeHNx1bjToFav0oN1rWZbfZkAruK6hSlyWw8PaUI0LEkTzudkycc jqOG8YHo5uKKZGamWKtrRbMuNk1od+NqC8WqjElbMqSxSC06TxqDZRo3e18fmEtpLWpq Ds+1Sn0OqpuJCzNgBSTXDPNV126gsgM2zaajc9xDcWSgVMTg746GZ2oK6t6fqa7hMxgW VTTBn/QZRis6viRyd6YsOeqJcfYwPS/C4P6lbl+aQyKYsazj5rGFLlmXMSWU4jibO0Av WDgw== X-Gm-Message-State: AOJu0YzUytbqWDuIrUyss/5FafnsqsYuepzJRSp5lGbAvaLH7RraHWz+ XGhBUeBUdnleFyZ7gislqAY= X-Google-Smtp-Source: AGHT+IGYEebIYgKMreGO33DsSvXOiEZOsQqChsZdmr7EgKjYmVw9IGu/0wfCT9WxOBuJNK2xhec+7Q== X-Received: by 2002:a5d:594f:0:b0:31a:dbd8:95dd with SMTP id e15-20020a5d594f000000b0031adbd895ddmr1647946wri.29.1694522270650; Tue, 12 Sep 2023 05:37:50 -0700 (PDT) Received: from localhost (cpc154979-craw9-2-0-cust193.16-3.cable.virginm.net. [80.193.200.194]) by smtp.gmail.com with ESMTPSA id y13-20020adffa4d000000b0031f5f0d0be0sm12660276wrr.31.2023.09.12.05.37.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Sep 2023 05:37:50 -0700 (PDT) From: Colin Ian King To: Kent Overstreet , Brian Foster , linux-bcachefs@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 4/5][next] bcachefs: remove duplicated assignment to variable offset_into_extent Date: Tue, 12 Sep 2023 13:37:43 +0100 Message-Id: <20230912123744.3929609-5-colin.i.king@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230912123744.3929609-1-colin.i.king@gmail.com> References: <20230912123744.3929609-1-colin.i.king@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Variable offset_into_extent is being assigned to zero and a few statements later it is being re-assigned again to the save value. The second assignment is redundant and can be removed. Cleans up clang-scan build warning: fs/bcachefs/io.c:2722:3: warning: Value stored to 'offset_into_extent' is never read [deadcode.DeadStores] Signed-off-by: Colin Ian King Reviewed-by: Brian Foster --- fs/bcachefs/io.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/bcachefs/io.c b/fs/bcachefs/io.c index 3c614c864b6e..3b827c8dbf12 100644 --- a/fs/bcachefs/io.c +++ b/fs/bcachefs/io.c @@ -2724,7 +2724,6 @@ int __bch2_read_extent(struct btree_trans *trans, str= uct bch_read_bio *orig, pick.crc.uncompressed_size =3D bvec_iter_sectors(iter); pick.crc.offset =3D 0; pick.crc.live_size =3D bvec_iter_sectors(iter); - offset_into_extent =3D 0; } get_bio: if (rbio) { --=20 2.39.2 From nobody Thu Dec 18 21:47:06 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1ECFCA0ECA for ; Tue, 12 Sep 2023 12:38:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235318AbjILMiN (ORCPT ); Tue, 12 Sep 2023 08:38:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56330 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235255AbjILMh5 (ORCPT ); Tue, 12 Sep 2023 08:37:57 -0400 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 484A29F; Tue, 12 Sep 2023 05:37:53 -0700 (PDT) Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-4018af1038cso60783375e9.0; Tue, 12 Sep 2023 05:37:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694522272; x=1695127072; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=I02ZJvcK6GhbUBW4QVsF58xjpd6UhuUZvB8KzEHFDwg=; b=MEIdJ2HBNbtKTq8IgNBYBBcoLEe9frcuAhh8htpYP//OGDwqB6qgL+peb9SJZ1xvhL 6nlsvII5iQ98PMrsjZGVJdl+0RlaKf95yq8IOxqbX33LI2tAxcrs4O9tZrOYByReoL/y fN/EmaOSaMv9G1WUz/dy5Iu3qtdEyElXt2+OrFx8HNeLJuFQFQGM7NxfrIYhbdRPpj/x 83ZGyYlpMdJ+iP5AoWwv4Kl06iiASsG7zb3qY8zYaCRTLtYs37bkRdSJzt0zcXCUoFsX qofeM3HGi0OtCqKOfeSHv/cGIYvhlj1m5JOl1wyQhQbc7xKxInvGcTPNwkkTHXYiwUV7 Dn1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694522272; x=1695127072; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=I02ZJvcK6GhbUBW4QVsF58xjpd6UhuUZvB8KzEHFDwg=; b=aV258qZod/BczGhZKP0ZQmvjdRVT0+38uB7zsIWKNxbtpbyawZ77C5HKEXHKRkIxa+ ++xWQtYvu9fTpmrWuZJvXWlhvCSI8RvEu2xrlVWZKhFSXO4hS+3sJlObqpoN0DtUEekc A5qd3XLStTwBm/SdwpEYXvwj7kVZXLdP24Qi0jHcGzcxNKEPX0f6BxNlHDGhjrQuUjUY mfTs9CxPFb/LJ2Ic4pUcU7Epq8l7z2FIjw3yJ+V5RZscMvsXBZRCAeacitvEhg2mMl5j C+z7jJGq5HVPyiCts+9bLyl6t8Za1UAeRpraoI479tC05chaG7p39T5x2FYFtSLqx7xl jjfA== X-Gm-Message-State: AOJu0Yz4BSajsLAkPic74IJS9WbqPSzTt9waMtYryUIUXS4TWYgahWve zeQwWn5X+4qQShqsuA90LD0= X-Google-Smtp-Source: AGHT+IG4Zr99DFTYBW2EgYycCExLwNij4YIY3l3le/zFhcTUIlm/6cB/7qB1+8HiFhhUSjDkP++M8Q== X-Received: by 2002:a05:600c:2946:b0:3f9:c82e:9d87 with SMTP id n6-20020a05600c294600b003f9c82e9d87mr10697629wmd.13.1694522271728; Tue, 12 Sep 2023 05:37:51 -0700 (PDT) Received: from localhost (cpc154979-craw9-2-0-cust193.16-3.cable.virginm.net. [80.193.200.194]) by smtp.gmail.com with ESMTPSA id s6-20020a5d4ec6000000b003177074f830sm12805397wrv.59.2023.09.12.05.37.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Sep 2023 05:37:51 -0700 (PDT) From: Colin Ian King To: Kent Overstreet , Brian Foster , linux-bcachefs@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 5/5][next] bcachefs: remove redundant pointer q Date: Tue, 12 Sep 2023 13:37:44 +0100 Message-Id: <20230912123744.3929609-6-colin.i.king@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230912123744.3929609-1-colin.i.king@gmail.com> References: <20230912123744.3929609-1-colin.i.king@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The pointer q is being assigned a value but it is never read. The assignment and pointer are redundant and can be removed. Cleans up clang scan build warning: fs/bcachefs/quota.c:813:2: warning: Value stored to 'q' is never read [deadcode.DeadStores] Signed-off-by: Colin Ian King Reviewed-by: Brian Foster --- fs/bcachefs/quota.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/fs/bcachefs/quota.c b/fs/bcachefs/quota.c index ca99772aedc6..719c4c9fc51f 100644 --- a/fs/bcachefs/quota.c +++ b/fs/bcachefs/quota.c @@ -786,7 +786,6 @@ static int bch2_quota_set_info(struct super_block *sb, = int type, { struct bch_fs *c =3D sb->s_fs_info; struct bch_sb_field_quota *sb_quota; - struct bch_memquota_type *q; int ret =3D 0; =20 if (0) { @@ -810,8 +809,6 @@ static int bch2_quota_set_info(struct super_block *sb, = int type, ~(QC_SPC_TIMER|QC_INO_TIMER|QC_SPC_WARNS|QC_INO_WARNS)) return -EINVAL; =20 - q =3D &c->quotas[type]; - mutex_lock(&c->sb_lock); sb_quota =3D bch2_sb_get_or_create_quota(&c->disk_sb); if (!sb_quota) { --=20 2.39.2