.../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 164 +++++++++--------- 1 file changed, 85 insertions(+), 79 deletions(-)
This is a series of patches to fix some trivial checkpatch issues. Not all issues have been fixed. I intend to submit another series to fix more stuff. Testing: --- v3: Series to contain only remaining patches. Franziska Naepelt (3): staging: rtl8723bs: Fix space issues staging: rtl8723bs: Fix alignment open parenthesis staging: rtl8723bs: Fix remaining blank line issue .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 164 +++++++++--------- 1 file changed, 85 insertions(+), 79 deletions(-) -- 2.39.2 (Apple Git-143)
On 6/25/23 17:56, Franziska Naepelt wrote: > This is a series of patches to fix some trivial checkpatch issues. Not all > issues have been fixed. I intend to submit another series to fix more stuff. > > Testing: > > --- > v3: Series to contain only remaining patches. > > Franziska Naepelt (3): > staging: rtl8723bs: Fix space issues > staging: rtl8723bs: Fix alignment open parenthesis > staging: rtl8723bs: Fix remaining blank line issue > > .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 164 +++++++++--------- > 1 file changed, 85 insertions(+), 79 deletions(-) > > -- > 2.39.2 (Apple Git-143) > > checkpatch prints the following warning: WARNING: From:/Signed-off-by: email address mismatch: 'From: Franziska Naepelt <franziska.naepelt@googlemail.com>' != 'Signed-off-by: Franziska Naepelt <franziska.naepelt@gmail.com>' I propose you change the git email matching the one that you use to send. When testing you can compile the driver with this command: make -C . M=drivers/staging/rtl8723bs Typically a compile of the entire kernel is not required. Please use the subsystem and driver also for the Subject line of the cover letter. Bye Philipp
Hi Philipp, Am Mo., 26. Juni 2023 um 19:09 Uhr schrieb Philipp Hortmann <philipp.g.hortmann@gmail.com>: > > On 6/25/23 17:56, Franziska Naepelt wrote: > > This is a series of patches to fix some trivial checkpatch issues. Not all > > issues have been fixed. I intend to submit another series to fix more stuff. > > > > Testing: > > > > --- > > v3: Series to contain only remaining patches. > > > > Franziska Naepelt (3): > > staging: rtl8723bs: Fix space issues > > staging: rtl8723bs: Fix alignment open parenthesis > > staging: rtl8723bs: Fix remaining blank line issue > > > > .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 164 +++++++++--------- > > 1 file changed, 85 insertions(+), 79 deletions(-) > > > > -- > > 2.39.2 (Apple Git-143) > > > > > > checkpatch prints the following warning: > WARNING: From:/Signed-off-by: email address mismatch: 'From: Franziska > Naepelt <franziska.naepelt@googlemail.com>' != 'Signed-off-by: Franziska > Naepelt <franziska.naepelt@gmail.com>' > > I propose you change the git email matching the one that you use to send. > > When testing you can compile the driver with this command: > make -C . M=drivers/staging/rtl8723bs > Typically a compile of the entire kernel is not required. > > Please use the subsystem and driver also for the Subject line of the > cover letter. > > Bye Philipp Do you want me to submit v4 to fix the email address as well as the subject of the cover letter or are you ok with me promising to make it properly the next time? ;) Thanks, Franziska
On 6/28/23 18:38, Franziska Näpelt wrote: > Hi Philipp, > > Am Mo., 26. Juni 2023 um 19:09 Uhr schrieb Philipp Hortmann > <philipp.g.hortmann@gmail.com>: >> >> On 6/25/23 17:56, Franziska Naepelt wrote: >>> This is a series of patches to fix some trivial checkpatch issues. Not all >>> issues have been fixed. I intend to submit another series to fix more stuff. >>> >>> Testing: >>> >>> --- >>> v3: Series to contain only remaining patches. >>> >>> Franziska Naepelt (3): >>> staging: rtl8723bs: Fix space issues >>> staging: rtl8723bs: Fix alignment open parenthesis >>> staging: rtl8723bs: Fix remaining blank line issue >>> >>> .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 164 +++++++++--------- >>> 1 file changed, 85 insertions(+), 79 deletions(-) >>> >>> -- >>> 2.39.2 (Apple Git-143) >>> >>> >> >> checkpatch prints the following warning: >> WARNING: From:/Signed-off-by: email address mismatch: 'From: Franziska >> Naepelt <franziska.naepelt@googlemail.com>' != 'Signed-off-by: Franziska >> Naepelt <franziska.naepelt@gmail.com>' >> >> I propose you change the git email matching the one that you use to send. >> >> When testing you can compile the driver with this command: >> make -C . M=drivers/staging/rtl8723bs >> Typically a compile of the entire kernel is not required. >> >> Please use the subsystem and driver also for the Subject line of the >> cover letter. >> >> Bye Philipp > > Do you want me to submit v4 to fix the email address as well as the subject of > the cover letter or are you ok with me promising to make it properly the next > time? ;) > > Thanks, > Franziska Hi Franziska, you do not need to submit v4 for me. Here the reason what you need to take into account. If you leave the e-mail addresses this way you need to monitor both for the next weeks. Because somebody(or a robot) may contact you for questions, errors or hints for improvement. If you look into the kernel patch statistics: http://www.remword.com/kps_result/all_petop.html Look in google for: "kernel patch statistics" You can find this person: Franziska Naepelt <franziska ! naepelt () idt ! com> 1(0.00%) @IDT @Unknown May be this is you. Maybe you want to see the number of patches in total that you have submitted. That is best possible if you submit all patches under one Email address. May be you plan to vote for the Technical Advisory Board. Then you need to collect your patches (credits under one email address) So all your choice. Bye Philipp
On Wed, Jun 28, 2023 at 06:38:03PM +0200, Franziska Näpelt wrote: > > Do you want me to submit v4 to fix the email address as well as the subject of > the cover letter or are you ok with me promising to make it properly the next > time? ;) Philipp is not the person to ask, it's Greg. Yes, you are going to need to resend because of the email address thing. Probably the cover letter is not a reason to resend, but since you are resending then please fix that as well. The reason why we insist that you resend is a couple things: 1) This is a checkpatch change to staging so we assume that you're just doing it to learn how patches are supposed to be sent. So this is an educational opportunity. ;) 2) Greg maintains staging, usb, serial and -stable. He's super busy. It doesn't scale to hand edit patches. Some maintainers are less busy so they can fix trivial stuff like this but in staging you will need to resend. Also if it were a security fix maybe I would step in and help you fix your patch but since it's just a checkpatch thing no one is going to edit your patch. Right now the merge window is open so Greg isn't going to see your patch for a few weeks. When he does he will press the button on his keyboard which sends an automatic reply about the email address thing and deletes the thread from his inbox. regards, dan carpenter
Am Do., 29. Juni 2023 um 09:40 Uhr schrieb Dan Carpenter <dan.carpenter@linaro.org>: > > On Wed, Jun 28, 2023 at 06:38:03PM +0200, Franziska Näpelt wrote: > > > > Do you want me to submit v4 to fix the email address as well as the subject of > > the cover letter or are you ok with me promising to make it properly the next > > time? ;) > > Philipp is not the person to ask, it's Greg. > > Yes, you are going to need to resend because of the email address thing. > > Probably the cover letter is not a reason to resend, but since you are > resending then please fix that as well. > > The reason why we insist that you resend is a couple things: > 1) This is a checkpatch change to staging so we assume that you're just > doing it to learn how patches are supposed to be sent. So this is an > educational opportunity. ;) > 2) Greg maintains staging, usb, serial and -stable. He's super busy. > It doesn't scale to hand edit patches. Some maintainers are less > busy so they can fix trivial stuff like this but in staging you will > need to resend. Also if it were a security fix maybe I would step > in and help you fix your patch but since it's just a checkpatch thing > no one is going to edit your patch. > > Right now the merge window is open so Greg isn't going to see your patch > for a few weeks. When he does he will press the button on his keyboard > which sends an automatic reply about the email address thing and deletes > the thread from his inbox. > > regards, > dan carpenter Thanks for your help and the comprehensive explanation Dan and Philipp :) Just send v4: https://lore.kernel.org/linux-staging/20230701102223.5308-1-franziska.naepelt@googlemail.com/T/#t
Am So., 25. Juni 2023 um 17:56 Uhr schrieb Franziska Naepelt <franziska.naepelt@googlemail.com>: > > This is a series of patches to fix some trivial checkpatch issues. Not all > issues have been fixed. I intend to submit another series to fix more stuff. > > Testing: > > --- > v3: Series to contain only remaining patches. > > Franziska Naepelt (3): > staging: rtl8723bs: Fix space issues > staging: rtl8723bs: Fix alignment open parenthesis > staging: rtl8723bs: Fix remaining blank line issue > > .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 164 +++++++++--------- > 1 file changed, 85 insertions(+), 79 deletions(-) > > -- > 2.39.2 (Apple Git-143) > Testing: * Build the kernel with `CONFIG_RTL8723BS=m` * Boot the kernel with busybox in initramfs * Load the module -> No errors or warnings
© 2016 - 2026 Red Hat, Inc.