From nobody Sun Feb 8 13:44:58 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A4B5EB64DC for ; Sun, 25 Jun 2023 16:00:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230029AbjFYP76 (ORCPT ); Sun, 25 Jun 2023 11:59:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46522 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229929AbjFYP7z (ORCPT ); Sun, 25 Jun 2023 11:59:55 -0400 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5DFB4F3 for ; Sun, 25 Jun 2023 08:59:53 -0700 (PDT) Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-98e25fa6f5bso156899366b.3 for ; Sun, 25 Jun 2023 08:59:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20221208; t=1687708792; x=1690300792; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3f2Bwx9OHEoUHaGLwGWm/ExlduY8t03yzRUP7zROP3E=; b=XkhZYj8BOcd7LyZdr/hivV7kQesKztqzI0oejZ4ntDQoTjJnrjcz6RYEZIlJW9yoGC 5U8R+P70ZsgcYZAqoJHrazm9mFi2OPpdsn0bFR5reR9S/SdijtuF02ailZ93VXThiNER YiAEQ0RjfueEQojgh3uTOEVTXj0lQbnA5pkQcMrHI5Mvbjx6pVoE5L2okkpTTHNxJi70 vKNrOVKFtb1k/pyjRaeffwQSSgVsZcVk8N5ZiidV8p8f7h6noKlTuz5Spqsc703fzxXV o6YYPze6LnSX3Tihbu+BhLvVXZs1hd6jFvZSyEl8F7NljXkVUgQhCukPjOskNO8ZKmt/ GoKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687708792; x=1690300792; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3f2Bwx9OHEoUHaGLwGWm/ExlduY8t03yzRUP7zROP3E=; b=UhUO3fegnytlkRRbUUEiMyarKWGZjxJt/6ya1M3UVxeGaOiRgN2DDbKhzRPZMjMy14 dNqB8JUGYq2tiER/v+taq0kpQ2lxtUL/jJPIlmOL1XTNCRbuAIUXMbDjdedSL5+xDvLf PEFya8A0Laldo2Uk/S4rhYv1p3d5yfJfM9lVq1C8rWrHs8BD/PjujRVv+6ypSiSiPRQX WabQ0yWNs6G53eVkMkGtlBiKJo80h2liqWsWyT2xGDRoe3MioSjnoyDhno/AJCKgHyl7 zLRGFSXOPRVEg+YQ2ooQ1gzBr7vLfVfokyRZPlVRL4OiBGdLEHrzGC0f1xZ1DJfNhCJs Lrnw== X-Gm-Message-State: AC+VfDzH0lE/jSKU4YkEVlfAIEsIAW295wYa+shJQpjmrnOMH6UAAB9F 8CO8Y0dcyTwQtEOxY/+47Gs= X-Google-Smtp-Source: ACHHUZ6WAdF49d0WkHAi+ndYB64qzVH9NBSXU4Z99LhUzh5+NSHRw4HVBT34NJtpbz6213VxGg8Kww== X-Received: by 2002:a17:907:2da4:b0:988:76ed:e563 with SMTP id gt36-20020a1709072da400b0098876ede563mr21364541ejc.50.1687708791495; Sun, 25 Jun 2023 08:59:51 -0700 (PDT) Received: from localhost.localdomain ([2a02:810a:9640:26a8:484f:5091:3ba0:ecc]) by smtp.gmail.com with ESMTPSA id h13-20020a1709060f4d00b0097073f1ed84sm2225211ejj.4.2023.06.25.08.59.50 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 25 Jun 2023 08:59:51 -0700 (PDT) From: Franziska Naepelt X-Google-Original-From: Franziska Naepelt To: franziska.naepelt@googlemail.com Cc: eperi1024@gmail.com, franziska.naepelt@gmail.com, gregkh@linuxfoundation.org, hdegoede@redhat.com, johannes.berg@intel.com, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, quic_vjakkam@quicinc.com, tegongkang@gmail.com Subject: [PATCH v3 1/3] staging: rtl8723bs: Fix space issues Date: Sun, 25 Jun 2023 17:59:01 +0200 Message-Id: <20230625155901.32459-1-franziska.naepelt@gmail.com> X-Mailer: git-send-email 2.39.2 (Apple Git-143) In-Reply-To: <20230625155632.32403-1-franziska.naepelt@gmail.com> References: <20230625155632.32403-1-franziska.naepelt@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Fix the following checkpatch space issues: - CHECK: spaces preferred around that '*' (ctx:VxV) - CHECK: spaces preferred around that '+' (ctx:VxV) - CHECK: spaces preferred around that '-' (ctx:VxV) - CHECK: spaces preferred around that '|' (ctx:VxV) - CHECK: No space is necessary after a cast - WARNING: please, no spaces at the start of a line Signed-off-by: Franziska Naepelt --- v3: Make the patch apply to staging-next --- .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 76 +++++++++---------- 1 file changed, 38 insertions(+), 38 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/st= aging/rtl8723bs/os_dep/ioctl_cfg80211.c index 2ae7843abdf7..7a651952f77c 100644 --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c @@ -95,14 +95,14 @@ static struct ieee80211_channel rtw_2ghz_channels[] =3D= { static void rtw_2g_channels_init(struct ieee80211_channel *channels) { memcpy((void *)channels, (void *)rtw_2ghz_channels, - sizeof(struct ieee80211_channel)*RTW_2G_CHANNELS_NUM + sizeof(struct ieee80211_channel) * RTW_2G_CHANNELS_NUM ); } =20 static void rtw_2g_rates_init(struct ieee80211_rate *rates) { memcpy(rates, rtw_g_rates, - sizeof(struct ieee80211_rate)*RTW_G_RATES_NUM + sizeof(struct ieee80211_rate) * RTW_G_RATES_NUM ); } =20 @@ -126,8 +126,8 @@ static struct ieee80211_supported_band *rtw_spt_band_al= loc( if (!spt_band) goto exit; =20 - spt_band->channels =3D (struct ieee80211_channel *)(((u8 *)spt_band)+size= of(struct ieee80211_supported_band)); - spt_band->bitrates =3D (struct ieee80211_rate *)(((u8 *)spt_band->channel= s)+sizeof(struct ieee80211_channel)*n_channels); + spt_band->channels =3D (struct ieee80211_channel *)(((u8 *)spt_band) + si= zeof(struct ieee80211_supported_band)); + spt_band->bitrates =3D (struct ieee80211_rate *)(((u8 *)spt_band->channel= s) + sizeof(struct ieee80211_channel) * n_channels); spt_band->band =3D band; spt_band->n_channels =3D n_channels; spt_band->n_bitrates =3D n_bitrates; @@ -247,10 +247,10 @@ struct cfg80211_bss *rtw_cfg80211_inform_bss(struct a= dapter *padapter, struct wl u32 wpsielen =3D 0; u8 *wpsie =3D NULL; =20 - wpsie =3D rtw_get_wps_ie(pnetwork->network.ies+_FIXED_IE_LENGTH_, pnetwo= rk->network.ie_length-_FIXED_IE_LENGTH_, NULL, &wpsielen); + wpsie =3D rtw_get_wps_ie(pnetwork->network.ies + _FIXED_IE_LENGTH_, pnet= work->network.ie_length - _FIXED_IE_LENGTH_, NULL, &wpsielen); =20 if (wpsie && wpsielen > 0) - psr =3D rtw_get_wps_attr_content(wpsie, wpsielen, WPS_ATTR_SELECTED_RE= GISTRAR, (u8 *)(&sr), NULL); + psr =3D rtw_get_wps_attr_content(wpsie, wpsielen, WPS_ATTR_SELECTED_REG= ISTRAR, (u8 *)(&sr), NULL); =20 if (sr !=3D 0) { /* it means under processing WPS */ @@ -277,9 +277,9 @@ struct cfg80211_bss *rtw_cfg80211_inform_bss(struct ada= pter *padapter, struct wl /* We've set wiphy's signal_type as CFG80211_SIGNAL_TYPE_MBM: signal stre= ngth in mBm (100*dBm) */ if (check_fwstate(pmlmepriv, _FW_LINKED) =3D=3D true && is_same_network(&pmlmepriv->cur_network.network, &pnetwork->network, 0))= { - notify_signal =3D 100*translate_percentage_to_dbm(padapter->recvpriv.sig= nal_strength);/* dbm */ + notify_signal =3D 100 * translate_percentage_to_dbm(padapter->recvpriv.s= ignal_strength);/* dbm */ } else { - notify_signal =3D 100*translate_percentage_to_dbm(pnetwork->network.phy_= info.signal_strength);/* dbm */ + notify_signal =3D 100 * translate_percentage_to_dbm(pnetwork->network.ph= y_info.signal_strength);/* dbm */ } =20 buf =3D kzalloc(MAX_BSSINFO_LEN, GFP_ATOMIC); @@ -449,20 +449,20 @@ void rtw_cfg80211_indicate_connect(struct adapter *pa= dapter) roam_info.links[0].channel =3D notify_channel; roam_info.links[0].bssid =3D cur_network->network.mac_address; roam_info.req_ie =3D - pmlmepriv->assoc_req+sizeof(struct ieee80211_hdr_3addr)+2; + pmlmepriv->assoc_req + sizeof(struct ieee80211_hdr_3addr) + 2; roam_info.req_ie_len =3D - pmlmepriv->assoc_req_len-sizeof(struct ieee80211_hdr_3addr)-2; + pmlmepriv->assoc_req_len - sizeof(struct ieee80211_hdr_3addr) - 2; roam_info.resp_ie =3D - pmlmepriv->assoc_rsp+sizeof(struct ieee80211_hdr_3addr)+6; + pmlmepriv->assoc_rsp + sizeof(struct ieee80211_hdr_3addr) + 6; roam_info.resp_ie_len =3D - pmlmepriv->assoc_rsp_len-sizeof(struct ieee80211_hdr_3addr)-6; + pmlmepriv->assoc_rsp_len - sizeof(struct ieee80211_hdr_3addr) - 6; cfg80211_roamed(padapter->pnetdev, &roam_info, GFP_ATOMIC); } else { cfg80211_connect_result(padapter->pnetdev, cur_network->network.mac_addr= ess - , pmlmepriv->assoc_req+sizeof(struct ieee80211_hdr_3addr)+2 - , pmlmepriv->assoc_req_len-sizeof(struct ieee80211_hdr_3addr)-2 - , pmlmepriv->assoc_rsp+sizeof(struct ieee80211_hdr_3addr)+6 - , pmlmepriv->assoc_rsp_len-sizeof(struct ieee80211_hdr_3addr)-6 + , pmlmepriv->assoc_req + sizeof(struct ieee80211_hdr_3addr) + 2 + , pmlmepriv->assoc_req_len - sizeof(struct ieee80211_hdr_3addr) - 2 + , pmlmepriv->assoc_rsp + sizeof(struct ieee80211_hdr_3addr) + 6 + , pmlmepriv->assoc_rsp_len - sizeof(struct ieee80211_hdr_3addr) - 6 , WLAN_STATUS_SUCCESS, GFP_ATOMIC); } } @@ -708,7 +708,7 @@ static int rtw_cfg80211_set_encryption(struct net_devic= e *dev, struct ieee_param param->u.crypt.err =3D 0; param->u.crypt.alg[IEEE_CRYPT_ALG_NAME_LEN - 1] =3D '\0'; =20 - if (param_len < (u32) ((u8 *) param->u.crypt.key - (u8 *) param) + param-= >u.crypt.key_len) { + if (param_len < (u32)((u8 *)param->u.crypt.key - (u8 *)param) + param->u.= crypt.key_len) { ret =3D -EINVAL; goto exit; } @@ -1019,10 +1019,10 @@ static int cfg80211_rtw_get_station(struct wiphy *w= iphy, } =20 /* for Ad-Hoc/AP mode */ - if ((check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) - || check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) - || check_fwstate(pmlmepriv, WIFI_AP_STATE)) - && check_fwstate(pmlmepriv, _FW_LINKED)) { + if ((check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) || + check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) || + check_fwstate(pmlmepriv, WIFI_AP_STATE)) && + check_fwstate(pmlmepriv, _FW_LINKED)) { /* TODO: should acquire station info... */ } =20 @@ -1219,7 +1219,7 @@ static int cfg80211_rtw_scan(struct wiphy *wiphy spin_unlock_bh(&pwdev_priv->scan_req_lock); =20 if (check_fwstate(pmlmepriv, WIFI_AP_STATE) =3D=3D true) { - if (check_fwstate(pmlmepriv, WIFI_UNDER_WPS|_FW_UNDER_SURVEY|_FW_UNDER_L= INKING) =3D=3D true) { + if (check_fwstate(pmlmepriv, WIFI_UNDER_WPS | _FW_UNDER_SURVEY | _FW_UND= ER_LINKING) =3D=3D true) { need_indicate_scan_done =3D true; goto check_need_indicate_scan_done; } @@ -1273,7 +1273,7 @@ static int cfg80211_rtw_scan(struct wiphy *wiphy } =20 /* parsing channels, n_channels */ - memset(ch, 0, sizeof(struct rtw_ieee80211_channel)*RTW_CHANNEL_SCAN_AMOUN= T); + memset(ch, 0, sizeof(struct rtw_ieee80211_channel) * RTW_CHANNEL_SCAN_AMO= UNT); for (i =3D 0; i < request->n_channels && i < RTW_CHANNEL_SCAN_AMOUNT; i++= ) { ch[i].hw_value =3D request->channels[i]->hw_value; ch[i].flags =3D request->channels[i]->flags; @@ -1287,7 +1287,7 @@ static int cfg80211_rtw_scan(struct wiphy *wiphy } else if (request->n_channels <=3D 4) { for (j =3D request->n_channels - 1; j >=3D 0; j--) for (i =3D 0; i < survey_times; i++) - memcpy(&ch[j*survey_times+i], &ch[j], sizeof(struct rtw_ieee80211_chan= nel)); + memcpy(&ch[j * survey_times + i], &ch[j], sizeof(struct rtw_ieee80211_= channel)); _status =3D rtw_sitesurvey_cmd(padapter, ssid, RTW_SSID_SCAN_AMOUNT, ch,= survey_times * request->n_channels); } else { _status =3D rtw_sitesurvey_cmd(padapter, ssid, RTW_SSID_SCAN_AMOUNT, NUL= L, 0); @@ -1436,7 +1436,7 @@ static int rtw_cfg80211_set_wpa_ie(struct adapter *pa= dapter, u8 *pie, size_t iel goto exit; } =20 - if (ielen > MAX_WPA_IE_LEN+MAX_WPS_IE_LEN+MAX_P2P_IE_LEN) { + if (ielen > MAX_WPA_IE_LEN + MAX_WPS_IE_LEN + MAX_P2P_IE_LEN) { ret =3D -EINVAL; goto exit; } @@ -1456,19 +1456,19 @@ static int rtw_cfg80211_set_wpa_ie(struct adapter *= padapter, u8 *pie, size_t iel =20 pwpa =3D rtw_get_wpa_ie(buf, &wpa_ielen, ielen); if (pwpa && wpa_ielen > 0) { - if (rtw_parse_wpa_ie(pwpa, wpa_ielen+2, &group_cipher, &pairwise_cipher,= NULL) =3D=3D _SUCCESS) { + if (rtw_parse_wpa_ie(pwpa, wpa_ielen + 2, &group_cipher, &pairwise_ciphe= r, NULL) =3D=3D _SUCCESS) { padapter->securitypriv.dot11AuthAlgrthm =3D dot11AuthAlgrthm_8021X; padapter->securitypriv.ndisauthtype =3D Ndis802_11AuthModeWPAPSK; - memcpy(padapter->securitypriv.supplicant_ie, &pwpa[0], wpa_ielen+2); + memcpy(padapter->securitypriv.supplicant_ie, &pwpa[0], wpa_ielen + 2); } } =20 pwpa2 =3D rtw_get_wpa2_ie(buf, &wpa2_ielen, ielen); if (pwpa2 && wpa2_ielen > 0) { - if (rtw_parse_wpa2_ie(pwpa2, wpa2_ielen+2, &group_cipher, &pairwise_ciph= er, NULL) =3D=3D _SUCCESS) { + if (rtw_parse_wpa2_ie(pwpa2, wpa2_ielen + 2, &group_cipher, &pairwise_ci= pher, NULL) =3D=3D _SUCCESS) { padapter->securitypriv.dot11AuthAlgrthm =3D dot11AuthAlgrthm_8021X; padapter->securitypriv.ndisauthtype =3D Ndis802_11AuthModeWPA2PSK; - memcpy(padapter->securitypriv.supplicant_ie, &pwpa2[0], wpa2_ielen+2); + memcpy(padapter->securitypriv.supplicant_ie, &pwpa2[0], wpa2_ielen + 2); } } =20 @@ -1863,7 +1863,7 @@ static int cfg80211_rtw_set_pmksa(struct wiphy *wiphy, if (!memcmp(psecuritypriv->PMKIDList[index].Bssid, (u8 *)pmksa->bssid, E= TH_ALEN)) { memcpy(psecuritypriv->PMKIDList[index].PMKID, (u8 *)pmksa->pmkid, WLAN_= PMKID_LEN); psecuritypriv->PMKIDList[index].bUsed =3D true; - psecuritypriv->PMKIDIndex =3D index+1; + psecuritypriv->PMKIDIndex =3D index + 1; blInserted =3D true; break; } @@ -2064,8 +2064,8 @@ static netdev_tx_t rtw_cfg80211_monitor_if_xmit_entry= (struct sk_buff *skb, struc _rtw_xmit_entry(skb, padapter->pnetdev); return NETDEV_TX_OK; =20 - } else if ((frame_control & (IEEE80211_FCTL_FTYPE|IEEE80211_FCTL_STYPE)) = =3D=3D - (IEEE80211_FTYPE_MGMT|IEEE80211_STYPE_ACTION)) { + } else if ((frame_control & (IEEE80211_FCTL_FTYPE | IEEE80211_FCTL_STYPE)= ) =3D=3D + (IEEE80211_FTYPE_MGMT | IEEE80211_STYPE_ACTION)) { /* only for action frames */ struct xmit_frame *pmgntframe; struct pkt_attrib *pattrib; @@ -2174,7 +2174,7 @@ static int rtw_cfg80211_add_monitor_if(struct adapter= *padapter, char *name, str goto out; =20 *ndev =3D pwdev_priv->pmon_ndev =3D mon_ndev; - memcpy(pwdev_priv->ifname_mon, name, IFNAMSIZ+1); + memcpy(pwdev_priv->ifname_mon, name, IFNAMSIZ + 1); =20 out: if (ret && mon_wdev) { @@ -2268,14 +2268,14 @@ static int rtw_add_beacon(struct adapter *adapter, = const u8 *head, size_t head_l if (head_len < 24) return -EINVAL; =20 - pbuf =3D rtw_zmalloc(head_len+tail_len); + pbuf =3D rtw_zmalloc(head_len + tail_len); if (!pbuf) return -ENOMEM; =20 - memcpy(pbuf, (void *)head+24, head_len-24);/* 24 =3Dbeacon header len. */ - memcpy(pbuf+head_len-24, (void *)tail, tail_len); + memcpy(pbuf, (void *)head + 24, head_len - 24);/* 24 =3Dbeacon header le= n. */ + memcpy(pbuf + head_len - 24, (void *)tail, tail_len); =20 - len =3D head_len+tail_len-24; + len =3D head_len + tail_len - 24; =20 /* check wps ie if inclued */ rtw_get_wps_ie(pbuf + _FIXED_IE_LENGTH_, len - _FIXED_IE_LENGTH_, NULL, &= wps_ielen); @@ -2558,7 +2558,7 @@ static int cfg80211_rtw_mgmt_tx(struct wiphy *wiphy, pwdev_priv =3D adapter_wdev_data(padapter); =20 /* cookie generation */ - *cookie =3D (unsigned long) buf; + *cookie =3D (unsigned long)buf; =20 /* indicate ack before issue frame to avoid racing with rsp frame */ rtw_cfg80211_mgmt_tx_status(padapter, *cookie, buf, len, ack, GFP_KERNEL); --=20 2.39.2 (Apple Git-143) From nobody Sun Feb 8 13:44:58 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8A1BEB64DC for ; Sun, 25 Jun 2023 16:00:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230092AbjFYQA3 (ORCPT ); Sun, 25 Jun 2023 12:00:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229683AbjFYQA1 (ORCPT ); Sun, 25 Jun 2023 12:00:27 -0400 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DDB29E6B for ; Sun, 25 Jun 2023 09:00:14 -0700 (PDT) Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-98746d7f35dso369528866b.2 for ; Sun, 25 Jun 2023 09:00:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20221208; t=1687708813; x=1690300813; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8HEPT8Bd1YmooVkgrRxZtZ29IrBb/STNk+5AYMa14s4=; b=Bnv3Wirku7OWEKTVzHuSbtGBeIIIBcHsxSR3JJVJRVkrifx+p3CIoa66PQwTiXmA9Z xJwDVHKOzg+iafAuVY24jsL6tdbsF+gkGVSKAbhzrFleQq8+bOdDVXfessvBV1eUTtZf 4n6gvr8kgdJwB2M6Ro9P16SB9EjqAakRhqg2VfCrdjQqz10aWSAspdKfzSlify5L9hG6 tUCW49jvFStX+kSvVmH4fxN9XPaaVwBGV7K6oqRrqO0BQBsP+wH756aAWA4cWEIWPaXG 5r02pmZY1k/mRHQ/A/2F+y5QKeU/bLIC/yqrFfW7hYE4CPr1V27agijdQrSTobWP9dMJ Om6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687708813; x=1690300813; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8HEPT8Bd1YmooVkgrRxZtZ29IrBb/STNk+5AYMa14s4=; b=S5fPC2rpQOGnlu7LPIFguik5SUcsMpNqdNYKj45x2NOkwBRol4DNIFoijTbEH4CFrg cAWarzjtR2uko8xDONlHOgQEzQOWez4BgEHqaUprXH83X1KtfdekekMNCjNcI5teY9Sw tNOGlD8/5LejLP1c2k1iECnABsbRf4GxiabvHhLHlEOa22k97ArUn4/ABhWB0ecACXVQ ZlJ/b4qPGQYLwABBmSoNe8+d/tOVGk7bV6MsKfA88OQa05FNv16xYjccT6vHLvOdRYKj qs1PMFHD3jGN0IqR5i+vLNBV+t6laWvgfa4Wb2UbaXS/Sr2tXBRHNnuX7w/ziqx6H2Y9 PIog== X-Gm-Message-State: AC+VfDwD+VuS1QMjPdz3sgr2AlZh5f9QNAUbVQsezepBozCg+tta5m/+ C8NKyOj/6rIbgjBoe9AyymM= X-Google-Smtp-Source: ACHHUZ6bR04DX99HeYc+j1R+qmDDwCjYs741rt4tawPai2hJX4pyev9zDyzy0V7IeFnTk+mwHVLalg== X-Received: by 2002:a17:907:6295:b0:979:65f0:cd12 with SMTP id nd21-20020a170907629500b0097965f0cd12mr26345759ejc.15.1687708813116; Sun, 25 Jun 2023 09:00:13 -0700 (PDT) Received: from localhost.localdomain ([2a02:810a:9640:26a8:484f:5091:3ba0:ecc]) by smtp.gmail.com with ESMTPSA id gj22-20020a170906e11600b0098e025cda3dsm1779631ejb.140.2023.06.25.09.00.12 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 25 Jun 2023 09:00:12 -0700 (PDT) From: Franziska Naepelt X-Google-Original-From: Franziska Naepelt To: franziska.naepelt@googlemail.com Cc: eperi1024@gmail.com, franziska.naepelt@gmail.com, gregkh@linuxfoundation.org, hdegoede@redhat.com, johannes.berg@intel.com, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, quic_vjakkam@quicinc.com, tegongkang@gmail.com Subject: [PATCH v3 2/3] staging: rtl8723bs: Fix alignment open parenthesis Date: Sun, 25 Jun 2023 18:00:10 +0200 Message-Id: <20230625160010.32504-1-franziska.naepelt@gmail.com> X-Mailer: git-send-email 2.39.2 (Apple Git-143) In-Reply-To: <20230625155632.32403-1-franziska.naepelt@gmail.com> References: <20230625155632.32403-1-franziska.naepelt@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Fix the following checkpatch issues: - CHECK: Alignment should match open parenthesis Signed-off-by: Franziska Naepelt --- v3: Make the patch apply to staging-next --- .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 91 ++++++++++--------- 1 file changed, 49 insertions(+), 42 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/st= aging/rtl8723bs/os_dep/ioctl_cfg80211.c index 7a651952f77c..8f30098168f1 100644 --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c @@ -95,14 +95,14 @@ static struct ieee80211_channel rtw_2ghz_channels[] =3D= { static void rtw_2g_channels_init(struct ieee80211_channel *channels) { memcpy((void *)channels, (void *)rtw_2ghz_channels, - sizeof(struct ieee80211_channel) * RTW_2G_CHANNELS_NUM + sizeof(struct ieee80211_channel) * RTW_2G_CHANNELS_NUM ); } static void rtw_2g_rates_init(struct ieee80211_rate *rates) { memcpy(rates, rtw_g_rates, - sizeof(struct ieee80211_rate) * RTW_G_RATES_NUM + sizeof(struct ieee80211_rate) * RTW_G_RATES_NUM ); } @@ -276,7 +276,7 @@ struct cfg80211_bss *rtw_cfg80211_inform_bss(struct ada= pter *padapter, struct wl /* We've set wiphy's signal_type as CFG80211_SIGNAL_TYPE_MBM: signal stre= ngth in mBm (100*dBm) */ if (check_fwstate(pmlmepriv, _FW_LINKED) =3D=3D true && - is_same_network(&pmlmepriv->cur_network.network, &pnetwork->network, 0))= { + is_same_network(&pmlmepriv->cur_network.network, &pnetwork->network, = 0)) { notify_signal =3D 100 * translate_percentage_to_dbm(padapter->recvpriv.s= ignal_strength);/* dbm */ } else { notify_signal =3D 100 * translate_percentage_to_dbm(pnetwork->network.ph= y_info.signal_strength);/* dbm */ @@ -314,7 +314,7 @@ struct cfg80211_bss *rtw_cfg80211_inform_bss(struct ada= pter *padapter, struct wl *((__le64 *)pbuf) =3D cpu_to_le64(notify_timestamp); bss =3D cfg80211_inform_bss_frame(wiphy, notify_channel, (struct ieee8021= 1_mgmt *)buf, - len, notify_signal, GFP_ATOMIC); + len, notify_signal, GFP_ATOMIC); if (unlikely(!bss)) goto exit; @@ -346,9 +346,9 @@ int rtw_cfg80211_check_bss(struct adapter *padapter) notify_channel =3D ieee80211_get_channel(padapter->rtw_wdev->wiphy, freq); bss =3D cfg80211_get_bss(padapter->rtw_wdev->wiphy, notify_channel, - pnetwork->mac_address, pnetwork->ssid.ssid, - pnetwork->ssid.ssid_length, - IEEE80211_BSS_TYPE_ANY, IEEE80211_PRIVACY_ANY); + pnetwork->mac_address, pnetwork->ssid.ssid, + pnetwork->ssid.ssid_length, + IEEE80211_BSS_TYPE_ANY, IEEE80211_PRIVACY_ANY); cfg80211_put_bss(padapter->rtw_wdev->wiphy, bss); @@ -487,7 +487,7 @@ void rtw_cfg80211_indicate_disconnect(struct adapter *p= adapter) NULL, 0, true, GFP_ATOMIC); } else { cfg80211_connect_result(padapter->pnetdev, NULL, NULL, 0, NULL, 0, - WLAN_STATUS_UNSPECIFIED_FAILURE, GFP_ATOMIC/*GFP_KERNEL*/); + WLAN_STATUS_UNSPECIFIED_FAILURE, GFP_ATOMIC/*GFP_KERNEL*/); } } } @@ -778,7 +778,7 @@ static int rtw_cfg80211_set_encryption(struct net_devic= e *dev, struct ieee_param psta->ieee8021x_blocked =3D false; if ((padapter->securitypriv.ndisencryptstatus =3D=3D Ndis802_11Encrypt= ion2Enabled) || - (padapter->securitypriv.ndisencryptstatus =3D=3D Ndis802_11Encrypti= on3Enabled)) { + (padapter->securitypriv.ndisencryptstatus =3D=3D Ndis802_11Encryp= tion3Enabled)) { psta->dot118021XPrivacy =3D padapter->securitypriv.dot11PrivacyAlgrth= m; } @@ -827,7 +827,7 @@ static int rtw_cfg80211_set_encryption(struct net_devic= e *dev, struct ieee_param pbcmc_sta->ieee8021x_blocked =3D false; if ((padapter->securitypriv.ndisencryptstatus =3D=3D Ndis802_11Encrypt= ion2Enabled) || - (padapter->securitypriv.ndisencryptstatus =3D=3D Ndis802_11Encrypti= on3Enabled)) { + (padapter->securitypriv.ndisencryptstatus =3D=3D Ndis802_11Encryp= tion3Enabled)) { pbcmc_sta->dot118021XPrivacy =3D padapter->securitypriv.dot11PrivacyA= lgrthm; } } @@ -945,9 +945,9 @@ static int cfg80211_rtw_del_key(struct wiphy *wiphy, st= ruct net_device *ndev, } static int cfg80211_rtw_set_default_key(struct wiphy *wiphy, - struct net_device *ndev, int link_id, u8 key_index - , bool unicast, bool multicast - ) + struct net_device *ndev, int link_id, + u8 key_index, bool unicast, + bool multicast) { struct adapter *padapter =3D rtw_netdev_priv(ndev); struct security_priv *psecuritypriv =3D &padapter->securitypriv; @@ -1122,9 +1122,10 @@ void rtw_cfg80211_unlink_bss(struct adapter *padapte= r, struct wlan_network *pnet struct wlan_bssid_ex *select_network =3D &pnetwork->network; bss =3D cfg80211_get_bss(wiphy, NULL/*notify_channel*/, - select_network->mac_address, select_network->ssid.ssid, - select_network->ssid.ssid_length, IEEE80211_BSS_TYPE_ANY, - IEEE80211_PRIVACY_ANY); + select_network->mac_address, + select_network->ssid.ssid, + select_network->ssid.ssid_length, + IEEE80211_BSS_TYPE_ANY, IEEE80211_PRIVACY_ANY); if (bss) { cfg80211_unlink_bss(wiphy, bss); @@ -1329,7 +1330,7 @@ static int rtw_cfg80211_set_wpa_version(struct securi= ty_priv *psecuritypriv, u32 } static int rtw_cfg80211_set_auth_type(struct security_priv *psecuritypriv, - enum nl80211_auth_type sme_auth_type) + enum nl80211_auth_type sme_auth_type) { switch (sme_auth_type) { case NL80211_AUTHTYPE_AUTOMATIC: @@ -1634,7 +1635,7 @@ static int cfg80211_rtw_leave_ibss(struct wiphy *wiph= y, struct net_device *ndev) } static int cfg80211_rtw_connect(struct wiphy *wiphy, struct net_device *nd= ev, - struct cfg80211_connect_params *sme) + struct cfg80211_connect_params *sme) { int ret =3D 0; enum ndis_802_11_authentication_mode authmode; @@ -1709,7 +1710,7 @@ static int cfg80211_rtw_connect(struct wiphy *wiphy, = struct net_device *ndev, /* For WEP Shared auth */ if ((psecuritypriv->dot11AuthAlgrthm =3D=3D dot11AuthAlgrthm_Shared || - psecuritypriv->dot11AuthAlgrthm =3D=3D dot11AuthAlgrthm_Auto) && sme-= >key) { + psecuritypriv->dot11AuthAlgrthm =3D=3D dot11AuthAlgrthm_Auto) && sme= ->key) { u32 wep_key_idx, wep_key_len, wep_total_len; struct ndis_802_11_wep *pwep =3D NULL; @@ -1807,15 +1808,14 @@ static int cfg80211_rtw_disconnect(struct wiphy *wi= phy, struct net_device *ndev, } static int cfg80211_rtw_set_txpower(struct wiphy *wiphy, - struct wireless_dev *wdev, - enum nl80211_tx_power_setting type, int mbm) + struct wireless_dev *wdev, + enum nl80211_tx_power_setting type, int mbm) { return 0; } static int cfg80211_rtw_get_txpower(struct wiphy *wiphy, - struct wireless_dev *wdev, - int *dbm) + struct wireless_dev *wdev, int *dbm) { *dbm =3D (12); @@ -2228,7 +2228,7 @@ static struct wireless_dev * } static int cfg80211_rtw_del_virtual_intf(struct wiphy *wiphy, - struct wireless_dev *wdev + struct wireless_dev *wdev ) { struct net_device *ndev =3D wdev_to_ndev(wdev); @@ -2295,13 +2295,14 @@ static int rtw_add_beacon(struct adapter *adapter, = const u8 *head, size_t head_l } static int cfg80211_rtw_start_ap(struct wiphy *wiphy, struct net_device *n= dev, - struct cfg80211_ap_settings *settings) + struct cfg80211_ap_settings *settings) { int ret =3D 0; struct adapter *adapter =3D rtw_netdev_priv(ndev); - ret =3D rtw_add_beacon(adapter, settings->beacon.head, settings->beacon.h= ead_len, - settings->beacon.tail, settings->beacon.tail_len); + ret =3D rtw_add_beacon(adapter, settings->beacon.head, + settings->beacon.head_len, settings->beacon.tail, + settings->beacon.tail_len); adapter->mlmeextpriv.mlmext_info.hidden_ssid_mode =3D settings->hidden_ss= id; @@ -2318,8 +2319,9 @@ static int cfg80211_rtw_start_ap(struct wiphy *wiphy,= struct net_device *ndev, return ret; } -static int cfg80211_rtw_change_beacon(struct wiphy *wiphy, struct net_devi= ce *ndev, - struct cfg80211_beacon_data *info) +static int cfg80211_rtw_change_beacon(struct wiphy *wiphy, + struct net_device *ndev, + struct cfg80211_beacon_data *info) { struct adapter *adapter =3D rtw_netdev_priv(ndev); @@ -2332,9 +2334,10 @@ static int cfg80211_rtw_stop_ap(struct wiphy *wiphy,= struct net_device *ndev, return 0; } -static int cfg80211_rtw_add_station(struct wiphy *wiphy, struct net_device= *ndev, - const u8 *mac, - struct station_parameters *params) +static int cfg80211_rtw_add_station(struct wiphy *wiphy, + struct net_device *ndev, + const u8 *mac, + struct station_parameters *params) { return 0; } @@ -2396,8 +2399,10 @@ static int cfg80211_rtw_del_station(struct wiphy *wi= phy, struct net_device *ndev return ret; } -static int cfg80211_rtw_change_station(struct wiphy *wiphy, struct net_dev= ice *ndev, - const u8 *mac, struct station_parameters *params) +static int cfg80211_rtw_change_station(struct wiphy *wiphy, + struct net_device *ndev, + const u8 *mac, + struct station_parameters *params) { return 0; } @@ -2422,8 +2427,10 @@ static struct sta_info *rtw_sta_info_get_by_idx(cons= t int idx, struct sta_priv * return psta; } -static int cfg80211_rtw_dump_station(struct wiphy *wiphy, struct net_devic= e *ndev, - int idx, u8 *mac, struct station_info *sinfo) +static int cfg80211_rtw_dump_station(struct wiphy *wiphy, + struct net_device *ndev, + int idx, u8 *mac, + struct station_info *sinfo) { int ret =3D 0; struct adapter *padapter =3D rtw_netdev_priv(ndev); @@ -2445,8 +2452,9 @@ static int cfg80211_rtw_dump_station(struct wiphy *wi= phy, struct net_device *nde return ret; } -static int cfg80211_rtw_change_bss(struct wiphy *wiphy, struct net_device = *ndev, - struct bss_parameters *params) +static int cfg80211_rtw_change_bss(struct wiphy *wiphy, + struct net_device *ndev, + struct bss_parameters *params) { return 0; } @@ -2529,10 +2537,9 @@ static int _cfg80211_rtw_mgmt_tx(struct adapter *pad= apter, u8 tx_ch, const u8 *b return ret; } -static int cfg80211_rtw_mgmt_tx(struct wiphy *wiphy, - struct wireless_dev *wdev, - struct cfg80211_mgmt_tx_params *params, - u64 *cookie) +static int cfg80211_rtw_mgmt_tx(struct wiphy *wiphy, struct wireless_dev *= wdev, + struct cfg80211_mgmt_tx_params *params, + u64 *cookie) { struct net_device *ndev =3D wdev_to_ndev(wdev); struct ieee80211_channel *chan =3D params->chan; -- 2.39.2 (Apple Git-143) From nobody Sun Feb 8 13:44:58 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CEB6EB64DD for ; Sun, 25 Jun 2023 16:00:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230358AbjFYQAq (ORCPT ); Sun, 25 Jun 2023 12:00:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230309AbjFYQAl (ORCPT ); Sun, 25 Jun 2023 12:00:41 -0400 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A6029E5B for ; Sun, 25 Jun 2023 09:00:28 -0700 (PDT) Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-51d805cb33aso2062201a12.3 for ; Sun, 25 Jun 2023 09:00:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20221208; t=1687708827; x=1690300827; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hG/25rXMoqPrP3Tjboz29CAT2Eb1EYcAQYXNo5YWZvc=; b=c9c38HB37VE/iwHwIt39e3BuInPDZopPtT7zqLzHHbIQnx335cBnNyaT9m3NsTwNcZ MU79NtMPe7WFrfy+2hE+ta1x+hPS/q9nn9vBFNtC6DiXwolyGaAgAqhg9jpfr836i4Yg 67TFssyE5XP/vplY5q3a/wjeqhMvv6lATVxgg2bGkOEebLfPYIlirO/kkHtx5fAaykTE TF4k/prSrRhYw5UBxPBaNDfR4toIj1n8cNzPcyVlwEe8Y+MY4SrXJnkyYkwPBfOTVQch Vc+4rlvL0l5QtSQwQIC6rGJW0QausMtJAYZb3XJkPT13gDOsnQW0XOBIf3slBY4pHc5d SWsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687708827; x=1690300827; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hG/25rXMoqPrP3Tjboz29CAT2Eb1EYcAQYXNo5YWZvc=; b=R4/PIx892B3nfFQvHawIkkvmCpPGk3EEea5ESlcJs9TkxzVhmKTJvCXKA35lUSGm5u vfALdIOLv/9sWWOWExzPpYI7xwsfMOiOPX9YXv6ho6s2XdFEU8dVZPNeeGabeD3XCYmD d2hvTBGj36uvgSGG6jW0PKYo0z38gR0xUl3DDn2z4k7oHhD439zhSrfUOK9Q4Xr6yS2U XQvxDsEQcKvaJMSJkmF4cL2sn3fvSdK4CSjqQjxQsjswYWtgCUvU5SxD8tcW/ZKdDPIP /PvQoWVNyjo82Ms4Cs+mLF+lWmaw03+uuVGkdZRLvYyOBCLu1QR3MCI7FGBBiKoSG5uz N8RQ== X-Gm-Message-State: AC+VfDxKpPfg4ilhvV/elUYhFtlPVkyyVVHn7w9ZnYoodOxhEym6oRoH WjheXZcofVKkvLCC+yHiYGY= X-Google-Smtp-Source: ACHHUZ4tqpEJiYvZaeySsYlQSPef9pgtu5Yo46eD4zRvjEU7iFJYhXw9Lo81nZmvXhjgHqCb+H3Sig== X-Received: by 2002:aa7:c2d7:0:b0:51d:9362:5060 with SMTP id m23-20020aa7c2d7000000b0051d93625060mr1679703edp.1.1687708826863; Sun, 25 Jun 2023 09:00:26 -0700 (PDT) Received: from localhost.localdomain ([2a02:810a:9640:26a8:484f:5091:3ba0:ecc]) by smtp.gmail.com with ESMTPSA id r16-20020aa7da10000000b0051d2968b26asm1895469eds.77.2023.06.25.09.00.26 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 25 Jun 2023 09:00:26 -0700 (PDT) From: Franziska Naepelt X-Google-Original-From: Franziska Naepelt To: franziska.naepelt@googlemail.com Cc: eperi1024@gmail.com, franziska.naepelt@gmail.com, gregkh@linuxfoundation.org, hdegoede@redhat.com, johannes.berg@intel.com, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, quic_vjakkam@quicinc.com, tegongkang@gmail.com Subject: [PATCH v3 3/3] staging: rtl8723bs: Fix remaining blank line issue Date: Sun, 25 Jun 2023 18:00:24 +0200 Message-Id: <20230625160024.32530-1-franziska.naepelt@gmail.com> X-Mailer: git-send-email 2.39.2 (Apple Git-143) In-Reply-To: <20230625155632.32403-1-franziska.naepelt@gmail.com> References: <20230625155632.32403-1-franziska.naepelt@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Fix the following checkpatch blank line issue: - CHECK: Please don't use multiple blank lines Signed-off-by: Franziska Naepelt --- v3: This fix was accidentially part of the fix spaces issue, moved to This separate patch now. --- drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/st= aging/rtl8723bs/os_dep/ioctl_cfg80211.c index 8f30098168f1..292cba045023 100644 --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c @@ -266,7 +266,6 @@ struct cfg80211_bss *rtw_cfg80211_inform_bss(struct ada= pter *padapter, struct wl } /* spin_unlock_bh(&pwdev_priv->scan_req_lock); */ - channel =3D pnetwork->network.configuration.ds_config; freq =3D rtw_ieee80211_channel_to_frequency(channel, NL80211_BAND_2GHZ); -- 2.39.2 (Apple Git-143)