[PATCH 0/8] Add multiple PMCs support in pmc core driver

Rajvi Jingar posted 8 patches 2 years, 7 months ago
drivers/platform/x86/intel/pmc/Makefile     |   4 +-
drivers/platform/x86/intel/pmc/adl.c        |  16 +-
drivers/platform/x86/intel/pmc/cnp.c        |  18 +-
drivers/platform/x86/intel/pmc/core.c       | 470 ++++++----
drivers/platform/x86/intel/pmc/core.h       | 125 ++-
drivers/platform/x86/intel/pmc/core_ssram.c | 133 +++
drivers/platform/x86/intel/pmc/icl.c        |   7 +-
drivers/platform/x86/intel/pmc/mtl.c        | 954 +++++++++++++++++++-
drivers/platform/x86/intel/pmc/spt.c        |   7 +-
drivers/platform/x86/intel/pmc/tgl.c        |  21 +-
10 files changed, 1516 insertions(+), 239 deletions(-)
create mode 100644 drivers/platform/x86/intel/pmc/core_ssram.c
[PATCH 0/8] Add multiple PMCs support in pmc core driver
Posted by Rajvi Jingar 2 years, 7 months ago
Newer platforms starting from Meteor Lake can have multiple PMCs.
This patch series include changes to enable pmc core driver to support
multiple PMCs for newer platforms. It adds devid and register maps to
enable IOE-P and IOE-M available on Meteor Lake platform. It also fixes
the register maps for SOC-M.

Patch includes:
platform/x86:intel/pmc: Update maps for Meteor Lake P/M platforms
platform/x86:intel/pmc: Combine core_init() and core_configure()
platform/x86:intel/pmc: Add support to handle multiple PMCs
platform/x86:intel/pmc: Enable debugfs multiple PMC support
platform/x86:intel/pmc: Discover PMC devices
platform/x86:intel/pmc: Use SSRAM to discover pwrm base address of primary PMC
platform/x86:intel/pmc: Add Meteor Lake IOE-P PMC related maps
platform/x86:intel/pmc: Add Meteor Lake IOE-M PMC related maps

 drivers/platform/x86/intel/pmc/Makefile     |   4 +-
 drivers/platform/x86/intel/pmc/adl.c        |  16 +-
 drivers/platform/x86/intel/pmc/cnp.c        |  18 +-
 drivers/platform/x86/intel/pmc/core.c       | 470 ++++++----
 drivers/platform/x86/intel/pmc/core.h       | 125 ++-
 drivers/platform/x86/intel/pmc/core_ssram.c | 133 +++
 drivers/platform/x86/intel/pmc/icl.c        |   7 +-
 drivers/platform/x86/intel/pmc/mtl.c        | 954 +++++++++++++++++++-
 drivers/platform/x86/intel/pmc/spt.c        |   7 +-
 drivers/platform/x86/intel/pmc/tgl.c        |  21 +-
 10 files changed, 1516 insertions(+), 239 deletions(-)
 create mode 100644 drivers/platform/x86/intel/pmc/core_ssram.c

-- 
2.25.1
Re: [PATCH 0/8] Add multiple PMCs support in pmc core driver
Posted by Hans de Goede 2 years, 7 months ago
Hi,

On 6/14/23 00:53, Rajvi Jingar wrote:
> Newer platforms starting from Meteor Lake can have multiple PMCs.
> This patch series include changes to enable pmc core driver to support
> multiple PMCs for newer platforms. It adds devid and register maps to
> enable IOE-P and IOE-M available on Meteor Lake platform. It also fixes
> the register maps for SOC-M.
> 
> Patch includes:
> platform/x86:intel/pmc: Update maps for Meteor Lake P/M platforms
> platform/x86:intel/pmc: Combine core_init() and core_configure()
> platform/x86:intel/pmc: Add support to handle multiple PMCs
> platform/x86:intel/pmc: Enable debugfs multiple PMC support
> platform/x86:intel/pmc: Discover PMC devices
> platform/x86:intel/pmc: Use SSRAM to discover pwrm base address of primary PMC
> platform/x86:intel/pmc: Add Meteor Lake IOE-P PMC related maps
> platform/x86:intel/pmc: Add Meteor Lake IOE-M PMC related maps

Thank you for your patch-series, I've applied the series to my
review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans





> 
>  drivers/platform/x86/intel/pmc/Makefile     |   4 +-
>  drivers/platform/x86/intel/pmc/adl.c        |  16 +-
>  drivers/platform/x86/intel/pmc/cnp.c        |  18 +-
>  drivers/platform/x86/intel/pmc/core.c       | 470 ++++++----
>  drivers/platform/x86/intel/pmc/core.h       | 125 ++-
>  drivers/platform/x86/intel/pmc/core_ssram.c | 133 +++
>  drivers/platform/x86/intel/pmc/icl.c        |   7 +-
>  drivers/platform/x86/intel/pmc/mtl.c        | 954 +++++++++++++++++++-
>  drivers/platform/x86/intel/pmc/spt.c        |   7 +-
>  drivers/platform/x86/intel/pmc/tgl.c        |  21 +-
>  10 files changed, 1516 insertions(+), 239 deletions(-)
>  create mode 100644 drivers/platform/x86/intel/pmc/core_ssram.c
>