[PATCH v5 0/3] Add support to configure Coresight Dummy subunit

Hao Zhang posted 3 patches 1 year ago
There is a newer version of this series
.../arm/arm,coresight-dummy-sink.yaml         |  73 ++++++++
.../arm/arm,coresight-dummy-source.yaml       |  71 ++++++++
.../trace/coresight/coresight-dummy.rst       |  32 ++++
drivers/hwtracing/coresight/Kconfig           |  11 ++
drivers/hwtracing/coresight/Makefile          |   1 +
drivers/hwtracing/coresight/coresight-dummy.c | 163 ++++++++++++++++++
include/linux/coresight.h                     |   1 +
7 files changed, 352 insertions(+)
create mode 100644 Documentation/devicetree/bindings/arm/arm,coresight-dummy-sink.yaml
create mode 100644 Documentation/devicetree/bindings/arm/arm,coresight-dummy-source.yaml
create mode 100644 Documentation/trace/coresight/coresight-dummy.rst
create mode 100644 drivers/hwtracing/coresight/coresight-dummy.c
[PATCH v5 0/3] Add support to configure Coresight Dummy subunit
Posted by Hao Zhang 1 year ago
Changes in V5:
1. Follow the alphabetical order for the header files in
coresight-dummy.c. -- Suzuki K Poulose
2. Update the maintainers.
3. Split the Coresight Dummy YAML to 2 schema files. 
-- Rob Herring & Krzysztof Kozlowski
4. Update the coresight-dummy.rst file. -- Bagas Sanjaya

Changes in V4:
1. Remove traceid allocation in dummy_probe function since it is
currently not in use, will upstream it as the part of ATID filtering
in the further.  -- Suzuki K Poulose
2. Remove 'oneOf' as there is only one entry. -- Rob Herring

Changes in V3:
1. Use API "dev_dbg" to replace "dev_info". -- Suzuki K Poulose
2. Drop "qcom" property and take it as a dummy framework.
-- Suzuki K Poulose
3. Add new sub-type "CORESIGHT_DEV_SUBTYPE_SINK_DUMMY" to support
coresight dummy module -- Mike Leach
4. Use compatibles "arm,coresight-dummy-source" and
"arm,coresight-dummy-sink" to replace property "qcom,dummy-source" and
"qcom,dummy-sink". -- Mike Leach
5. Define source_devs and sink_devs DEVLIST to replace dummy_devs, make
it clear at the first level. -- Mike Leach
6. Modify subject of YAML patch, drop "YAML schema". -- Krzysztof Kozlowski
7. Drop some redundant items and correct syntax errors in yaml file.
-- Krzysztof Kozlowski & Rob Herring
8. Correct required property of yaml file, constrain out ports to
dummy-source and in ports to dummy-sink. -- Mike Leach
9. Drop "Sysfs files and directories" contents of coresight-dummy.rst.
-- Suzuki K Poulose/Greg Kroah-Hartman
10.Correct syntax errors of coresight-dummy.rst. -- Bagas Sanjaya

Changes in V2:
1. Declare dummy_init and dummy_exit as static to fix missing-prototypes
warnings. -- kernel test robot
2. Fix the errors of coresight-dummy yaml file. -- Rob Herring

Hao Zhang (3):
  Coresight: Add coresight dummy driver
  dt-bindings: arm: Add support for Coresight dummy trace
  Documentation: trace: Add documentation for Coresight Dummy Trace

 .../arm/arm,coresight-dummy-sink.yaml         |  73 ++++++++
 .../arm/arm,coresight-dummy-source.yaml       |  71 ++++++++
 .../trace/coresight/coresight-dummy.rst       |  32 ++++
 drivers/hwtracing/coresight/Kconfig           |  11 ++
 drivers/hwtracing/coresight/Makefile          |   1 +
 drivers/hwtracing/coresight/coresight-dummy.c | 163 ++++++++++++++++++
 include/linux/coresight.h                     |   1 +
 7 files changed, 352 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/arm/arm,coresight-dummy-sink.yaml
 create mode 100644 Documentation/devicetree/bindings/arm/arm,coresight-dummy-source.yaml
 create mode 100644 Documentation/trace/coresight/coresight-dummy.rst
 create mode 100644 drivers/hwtracing/coresight/coresight-dummy.c

-- 
2.17.1
Re: [PATCH v5 0/3] Add support to configure Coresight Dummy subunit
Posted by Hao Zhang 1 year ago
Hi,

Add the missing information for this patch series.

Thanks,
Hao

On 5/26/2023 6:07 PM, Hao Zhang wrote:

Introduction of Coresight Dummy subunit
The Coresight Dummy subunit is for Coresight Dummy component, there are
some specific Coresight devices that HLOS don't have permission to access.
Such as some TPDMs, they would be configured in NON-HLOS side, but it's
necessary to build Coresight path for it to debug. So there need driver 
to register dummy devices as Coresight devices.

Commit link:
https://git.codelinaro.org/clo/linux-kernel/coresight/-/tree/coresight-dummy-v5

> Changes in V5:
> 1. Follow the alphabetical order for the header files in
> coresight-dummy.c. -- Suzuki K Poulose
> 2. Update the maintainers.
> 3. Split the Coresight Dummy YAML to 2 schema files.
> -- Rob Herring & Krzysztof Kozlowski
> 4. Update the coresight-dummy.rst file. -- Bagas Sanjaya
> 
> Changes in V4:
> 1. Remove traceid allocation in dummy_probe function since it is
> currently not in use, will upstream it as the part of ATID filtering
> in the further.  -- Suzuki K Poulose
> 2. Remove 'oneOf' as there is only one entry. -- Rob Herring
> 
> Changes in V3:
> 1. Use API "dev_dbg" to replace "dev_info". -- Suzuki K Poulose
> 2. Drop "qcom" property and take it as a dummy framework.
> -- Suzuki K Poulose
> 3. Add new sub-type "CORESIGHT_DEV_SUBTYPE_SINK_DUMMY" to support
> coresight dummy module -- Mike Leach
> 4. Use compatibles "arm,coresight-dummy-source" and
> "arm,coresight-dummy-sink" to replace property "qcom,dummy-source" and
> "qcom,dummy-sink". -- Mike Leach
> 5. Define source_devs and sink_devs DEVLIST to replace dummy_devs, make
> it clear at the first level. -- Mike Leach
> 6. Modify subject of YAML patch, drop "YAML schema". -- Krzysztof Kozlowski
> 7. Drop some redundant items and correct syntax errors in yaml file.
> -- Krzysztof Kozlowski & Rob Herring
> 8. Correct required property of yaml file, constrain out ports to
> dummy-source and in ports to dummy-sink. -- Mike Leach
> 9. Drop "Sysfs files and directories" contents of coresight-dummy.rst.
> -- Suzuki K Poulose/Greg Kroah-Hartman
> 10.Correct syntax errors of coresight-dummy.rst. -- Bagas Sanjaya
> 
> Changes in V2:
> 1. Declare dummy_init and dummy_exit as static to fix missing-prototypes
> warnings. -- kernel test robot
> 2. Fix the errors of coresight-dummy yaml file. -- Rob Herring
> 
> Hao Zhang (3):
>    Coresight: Add coresight dummy driver
>    dt-bindings: arm: Add support for Coresight dummy trace
>    Documentation: trace: Add documentation for Coresight Dummy Trace
> 
>   .../arm/arm,coresight-dummy-sink.yaml         |  73 ++++++++
>   .../arm/arm,coresight-dummy-source.yaml       |  71 ++++++++
>   .../trace/coresight/coresight-dummy.rst       |  32 ++++
>   drivers/hwtracing/coresight/Kconfig           |  11 ++
>   drivers/hwtracing/coresight/Makefile          |   1 +
>   drivers/hwtracing/coresight/coresight-dummy.c | 163 ++++++++++++++++++
>   include/linux/coresight.h                     |   1 +
>   7 files changed, 352 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/arm/arm,coresight-dummy-sink.yaml
>   create mode 100644 Documentation/devicetree/bindings/arm/arm,coresight-dummy-source.yaml
>   create mode 100644 Documentation/trace/coresight/coresight-dummy.rst
>   create mode 100644 drivers/hwtracing/coresight/coresight-dummy.c
>
Re: [PATCH v5 0/3] Add support to configure Coresight Dummy subunit
Posted by Bagas Sanjaya 1 year ago
On Mon, May 29, 2023 at 03:17:32PM +0800, Hao Zhang wrote:
> Hi,
> 
> Add the missing information for this patch series.
> 
> Thanks,
> Hao
> 
> On 5/26/2023 6:07 PM, Hao Zhang wrote:
> 
> Introduction of Coresight Dummy subunit
> The Coresight Dummy subunit is for Coresight Dummy component, there are
> some specific Coresight devices that HLOS don't have permission to access.
> Such as some TPDMs, they would be configured in NON-HLOS side, but it's
> necessary to build Coresight path for it to debug. So there need driver to
> register dummy devices as Coresight devices.
> 
> Commit link:
> https://git.codelinaro.org/clo/linux-kernel/coresight/-/tree/coresight-dummy-v5

OK, please reroll.

-- 
An old man doll... just what I always wanted! - Clara