On Renesas hardware, we had issues because the above flag was set during
'open'. It was concluded that it needs to be set during 'probe'. It
looks like SMS911x needs the same fix but I can't test it because I
don't have the hardware. At least, leave a note about the issue.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/net/ethernet/smsc/smsc911x.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/smsc/smsc911x.c b/drivers/net/ethernet/smsc/smsc911x.c
index a2e511912e6a..745e0180eb34 100644
--- a/drivers/net/ethernet/smsc/smsc911x.c
+++ b/drivers/net/ethernet/smsc/smsc911x.c
@@ -1038,6 +1038,7 @@ static int smsc911x_mii_probe(struct net_device *dev)
 	}
 
 	/* Indicate that the MAC is responsible for managing PHY PM */
+	/* FIXME: should be set right after mdiobus is registered */
 	phydev->mac_managed_pm = true;
 	phy_attached_info(phydev);
 
-- 
2.30.2

Hi Wolfram,

On Tue, Mar 14, 2023 at 2:30 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> On Renesas hardware, we had issues because the above flag was set during
> 'open'. It was concluded that it needs to be set during 'probe'. It
> looks like SMS911x needs the same fix but I can't test it because I
> don't have the hardware. At least, leave a note about the issue.

You no longer have the APE6-EVM?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

> > On Renesas hardware, we had issues because the above flag was set during
> > 'open'. It was concluded that it needs to be set during 'probe'. It
> > looks like SMS911x needs the same fix but I can't test it because I
> > don't have the hardware. At least, leave a note about the issue.
> 
> You no longer have the APE6-EVM?

I should have it somewhere. Cool, thanks for the pointer!