From nobody Wed Feb 11 14:38:53 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF73BC74A5B for ; Tue, 14 Mar 2023 13:19:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232384AbjCNNTa (ORCPT ); Tue, 14 Mar 2023 09:19:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232391AbjCNNSr (ORCPT ); Tue, 14 Mar 2023 09:18:47 -0400 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 755B1618B for ; Tue, 14 Mar 2023 06:15:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=sang-engineering.com; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=k1; bh=SsTC9UU9wdPdSI 0PbPhntycZBlShn3e/V5pFPLMU5/8=; b=ZvcXfLKABiDC9npZb4SVa4ELduNGUH JYWlTOq5gC2b1Av3MwV0fQnLvYANm1jrF0pT40lXXp0CxRsKZsy3vYQ9Tq9h8aJr 28EY9RgVIc3Y//DR8263wPxS2Mdmzx+kTMLxVu0VBVJZZG9mv8UlX+qnZXcuzzXG m9CExX8bF7Wg4= Received: (qmail 3111703 invoked from network); 14 Mar 2023 14:14:58 +0100 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 14 Mar 2023 14:14:58 +0100 X-UD-Smtp-Session: l3s3148p1@fFKrA9z2ts0ujnvb From: Wolfram Sang To: netdev@vger.kernel.org Cc: linux-renesas-soc@vger.kernel.org, kernel@pengutronix.de, Wolfram Sang , Steve Glendinning , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org Subject: [PATCH net-next 4/4] smsc911x: add FIXME to move 'mac_managed_pm' to probe Date: Tue, 14 Mar 2023 14:14:42 +0100 Message-Id: <20230314131443.46342-5-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230314131443.46342-1-wsa+renesas@sang-engineering.com> References: <20230314131443.46342-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" On Renesas hardware, we had issues because the above flag was set during 'open'. It was concluded that it needs to be set during 'probe'. It looks like SMS911x needs the same fix but I can't test it because I don't have the hardware. At least, leave a note about the issue. Signed-off-by: Wolfram Sang --- drivers/net/ethernet/smsc/smsc911x.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/smsc/smsc911x.c b/drivers/net/ethernet/sm= sc/smsc911x.c index a2e511912e6a..745e0180eb34 100644 --- a/drivers/net/ethernet/smsc/smsc911x.c +++ b/drivers/net/ethernet/smsc/smsc911x.c @@ -1038,6 +1038,7 @@ static int smsc911x_mii_probe(struct net_device *dev) } =20 /* Indicate that the MAC is responsible for managing PHY PM */ + /* FIXME: should be set right after mdiobus is registered */ phydev->mac_managed_pm =3D true; phy_attached_info(phydev); =20 --=20 2.30.2