On the ODROID forum, Dongjin Kim said he is not planning to submit a new
version of the patchset adding support for the Hardkernel ODROID-M1
board. I therefore decided to address the issues reported during the
initial review, and I also did some small fixes either because some
things changed in the meantime on the kernel side or because I noticed
some warning or issues when using the hardware.

I continued writing some additional patches to complete the ODROID M1
DTS to almost fully support the hardware, the drivers being already
present in the kernel.

This new version includes feedback from the linux-rockchip mailing list
and from the Odroid forum.

Changes since v2:
* Renamed "Rockchip RK3568 Hardkernel ODROID-M1" into "Hardkernel Odroid
  M1" and fix the sorting.
* Fix sorting of arch/arm64/boot/dts/rockchip/Makefile
* Collected Acked-by and Tested-by
* Switched the NOR flash to dual I/O from quad I/O to solve a pin
  conflicts with the EMMC.
* Added a comment about the pull-up on the IR receiver GPIO

Changes since v1 (patches 1 & 2):
* Added Acked-by to the first patch
* Fixed indentation
* Removed unneeded labels
* Renamed labels to not use underscore
* Renamed regulator nodes
* Added -pin to pinctrl bindings
* Changed GPU related regulators to always on (see 2cda380102ff)
* Added phy-supply to gmac0
* Added supplies to sdhci
* Changed SD card speed to SDR50 from SDR104 (see 1ea90b2d293f)
* Fixed power LED polarity and set the default-state to "keep"

Aurelien Jarno (11):
  arm64: dts: rockchip: add thermal support to ODROID-M1
  arm64: dts: rockchip: Add NOR flash to ODROID-M1
  arm64: dts: rockchip: Add analog audio on ODROID-M1
  arm64: dts: rockchip: Enable vop2 and hdmi tx on ODROID-M1
  arm64: dts: rockchip: Enable HDMI audio on ODROID-M1.
  arm64: dts: rockchip: Enable the GPU on ODROID-M1
  arm64: dts: rockchip: Enable the USB 2.0 ports on ODROID-M1
  arm64: dts: rockchip: Enable the USB 3.0 ports on ODROID-M1
  arm64: dts: rockchip: Add SATA support to ODROID-M1
  arm64: dts: rockchip: Add PCIEe v3 nodes to ODROID-M1
  arm64: dts: rockchip: Add IR receiver node to ODROID-M1

Dongjin Kim (2):
  dt-bindings: rockchip: Add Hardkernel ODROID-M1 board
  arm64: dts: rockchip: Add Hardkernel ODROID-M1 board

 .../devicetree/bindings/arm/rockchip.yaml     |   5 +
 arch/arm64/boot/dts/rockchip/Makefile         |   1 +
 .../boot/dts/rockchip/rk3568-odroid-m1.dts    | 744 ++++++++++++++++++
 3 files changed, 750 insertions(+)
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3568-odroid-m1.dts

-- 
2.35.1

Den 30.09.2022 kl. 07.12 skrev Aurelien Jarno:
> On the ODROID forum, Dongjin Kim said he is not planning to submit a new
> version of the patchset adding support for the Hardkernel ODROID-M1
> board. I therefore decided to address the issues reported during the
> initial review, and I also did some small fixes either because some
> things changed in the meantime on the kernel side or because I noticed
> some warning or issues when using the hardware.
>
> I continued writing some additional patches to complete the ODROID M1
> DTS to almost fully support the hardware, the drivers being already
> present in the kernel.
>
> This new version includes feedback from the linux-rockchip mailing list
> and from the Odroid forum.
>
> Changes since v2:
> * Renamed "Rockchip RK3568 Hardkernel ODROID-M1" into "Hardkernel Odroid
>    M1" and fix the sorting.
> * Fix sorting of arch/arm64/boot/dts/rockchip/Makefile
> * Collected Acked-by and Tested-by

Even though I added my Tested-by to this series, it seems I didn't test 
it on eMMC.

This fails to boot for me on eMMC, but works on SD card and NVMe.

Sorry about that.

> * Switched the NOR flash to dual I/O from quad I/O to solve a pin
>    conflicts with the EMMC.
> * Added a comment about the pull-up on the IR receiver GPIO
>
> Changes since v1 (patches 1 & 2):
> * Added Acked-by to the first patch
> * Fixed indentation
> * Removed unneeded labels
> * Renamed labels to not use underscore
> * Renamed regulator nodes
> * Added -pin to pinctrl bindings
> * Changed GPU related regulators to always on (see 2cda380102ff)
> * Added phy-supply to gmac0
> * Added supplies to sdhci
> * Changed SD card speed to SDR50 from SDR104 (see 1ea90b2d293f)
> * Fixed power LED polarity and set the default-state to "keep"
>
> Aurelien Jarno (11):
>    arm64: dts: rockchip: add thermal support to ODROID-M1
>    arm64: dts: rockchip: Add NOR flash to ODROID-M1
>    arm64: dts: rockchip: Add analog audio on ODROID-M1
>    arm64: dts: rockchip: Enable vop2 and hdmi tx on ODROID-M1
>    arm64: dts: rockchip: Enable HDMI audio on ODROID-M1.
>    arm64: dts: rockchip: Enable the GPU on ODROID-M1
>    arm64: dts: rockchip: Enable the USB 2.0 ports on ODROID-M1
>    arm64: dts: rockchip: Enable the USB 3.0 ports on ODROID-M1
>    arm64: dts: rockchip: Add SATA support to ODROID-M1
>    arm64: dts: rockchip: Add PCIEe v3 nodes to ODROID-M1
>    arm64: dts: rockchip: Add IR receiver node to ODROID-M1
>
> Dongjin Kim (2):
>    dt-bindings: rockchip: Add Hardkernel ODROID-M1 board
>    arm64: dts: rockchip: Add Hardkernel ODROID-M1 board
>
>   .../devicetree/bindings/arm/rockchip.yaml     |   5 +
>   arch/arm64/boot/dts/rockchip/Makefile         |   1 +
>   .../boot/dts/rockchip/rk3568-odroid-m1.dts    | 744 ++++++++++++++++++
>   3 files changed, 750 insertions(+)
>   create mode 100644 arch/arm64/boot/dts/rockchip/rk3568-odroid-m1.dts
>
-- 
Kind regards
*Dan Johansen*
Project lead of the *Manjaro ARM* project
Manjaro-ARM <https://manjaro.org>

On 2022-10-08 14:11, Dan Johansen wrote:
> 
> Den 30.09.2022 kl. 07.12 skrev Aurelien Jarno:
> > On the ODROID forum, Dongjin Kim said he is not planning to submit a new
> > version of the patchset adding support for the Hardkernel ODROID-M1
> > board. I therefore decided to address the issues reported during the
> > initial review, and I also did some small fixes either because some
> > things changed in the meantime on the kernel side or because I noticed
> > some warning or issues when using the hardware.
> > 
> > I continued writing some additional patches to complete the ODROID M1
> > DTS to almost fully support the hardware, the drivers being already
> > present in the kernel.
> > 
> > This new version includes feedback from the linux-rockchip mailing list
> > and from the Odroid forum.
> > 
> > Changes since v2:
> > * Renamed "Rockchip RK3568 Hardkernel ODROID-M1" into "Hardkernel Odroid
> >    M1" and fix the sorting.
> > * Fix sorting of arch/arm64/boot/dts/rockchip/Makefile
> > * Collected Acked-by and Tested-by
> 
> Even though I added my Tested-by to this series, it seems I didn't test it
> on eMMC.
> 
> This fails to boot for me on eMMC, but works on SD card and NVMe.

Thanks for the feedback. I do not have an eMMC, so this the only part
from the patchset that I haven't been able to test.

First of all, which version have you tested? The v2 includes fixes for
the eMMC, there was a conflict with the NOR flash. If the problem is
still there in the v2, could you please send the boot log or the error
message?

Thanks
Aurelien

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien@aurel32.net                 http://www.aurel32.net

On 2022-10-08 15:53, Aurelien Jarno wrote:
> On 2022-10-08 14:11, Dan Johansen wrote:
> > 
> > Den 30.09.2022 kl. 07.12 skrev Aurelien Jarno:
> > > On the ODROID forum, Dongjin Kim said he is not planning to submit a new
> > > version of the patchset adding support for the Hardkernel ODROID-M1
> > > board. I therefore decided to address the issues reported during the
> > > initial review, and I also did some small fixes either because some
> > > things changed in the meantime on the kernel side or because I noticed
> > > some warning or issues when using the hardware.
> > > 
> > > I continued writing some additional patches to complete the ODROID M1
> > > DTS to almost fully support the hardware, the drivers being already
> > > present in the kernel.
> > > 
> > > This new version includes feedback from the linux-rockchip mailing list
> > > and from the Odroid forum.
> > > 
> > > Changes since v2:
> > > * Renamed "Rockchip RK3568 Hardkernel ODROID-M1" into "Hardkernel Odroid
> > >    M1" and fix the sorting.
> > > * Fix sorting of arch/arm64/boot/dts/rockchip/Makefile
> > > * Collected Acked-by and Tested-by
> > 
> > Even though I added my Tested-by to this series, it seems I didn't test it
> > on eMMC.
> > 
> > This fails to boot for me on eMMC, but works on SD card and NVMe.
> 
> Thanks for the feedback. I do not have an eMMC, so this the only part
> from the patchset that I haven't been able to test.
> 
> First of all, which version have you tested? The v2 includes fixes for
> the eMMC, there was a conflict with the NOR flash. If the problem is
> still there in the v2, could you please send the boot log or the error
> message?

Sorry I meant v3 above. Anyway in the meantime I have bought an eMMC,
and I confirm that:
- it does no work with the v2 due to a conflict with the NOR flash
  driver
- it does work with the v3

Therefore can you please retry with the v3?

Thanks
Aurelien

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien@aurel32.net                 http://www.aurel32.net

Den 15.10.2022 kl. 20.47 skrev Aurelien Jarno:
> On 2022-10-08 15:53, Aurelien Jarno wrote:
>> On 2022-10-08 14:11, Dan Johansen wrote:
>>> Den 30.09.2022 kl. 07.12 skrev Aurelien Jarno:
>>>> On the ODROID forum, Dongjin Kim said he is not planning to submit a new
>>>> version of the patchset adding support for the Hardkernel ODROID-M1
>>>> board. I therefore decided to address the issues reported during the
>>>> initial review, and I also did some small fixes either because some
>>>> things changed in the meantime on the kernel side or because I noticed
>>>> some warning or issues when using the hardware.
>>>>
>>>> I continued writing some additional patches to complete the ODROID M1
>>>> DTS to almost fully support the hardware, the drivers being already
>>>> present in the kernel.
>>>>
>>>> This new version includes feedback from the linux-rockchip mailing list
>>>> and from the Odroid forum.
>>>>
>>>> Changes since v2:
>>>> * Renamed "Rockchip RK3568 Hardkernel ODROID-M1" into "Hardkernel Odroid
>>>>     M1" and fix the sorting.
>>>> * Fix sorting of arch/arm64/boot/dts/rockchip/Makefile
>>>> * Collected Acked-by and Tested-by
>>> Even though I added my Tested-by to this series, it seems I didn't test it
>>> on eMMC.
>>>
>>> This fails to boot for me on eMMC, but works on SD card and NVMe.
>> Thanks for the feedback. I do not have an eMMC, so this the only part
>> from the patchset that I haven't been able to test.
>>
>> First of all, which version have you tested? The v2 includes fixes for
>> the eMMC, there was a conflict with the NOR flash. If the problem is
>> still there in the v2, could you please send the boot log or the error
>> message?
> Sorry I meant v3 above. Anyway in the meantime I have bought an eMMC,
> and I confirm that:
> - it does no work with the v2 due to a conflict with the NOR flash
>    driver
> - it does work with the v3
>
> Therefore can you please retry with the v3?

Just tried with v3 applied and can confirm, that eMMC does work in that. 
Thanks.

So we can re-add my:

Tested-by: Dan Johansen <strit@manjaro.org>

>
> Thanks
> Aurelien
>
-- 
Kind regards
*Dan Johansen*
Project lead of the *Manjaro ARM* project
Manjaro-ARM <https://manjaro.org>

Trying to apply the patchset, but patch 3 does not seem to apply on top 
of patch 2 for me.

We do patch in other rk3568 boards, which is messing up the Makefile 
patching, so I needed to redo patch 2 to fit.

So it might an error on my part.

Den 15.10.2022 kl. 20.47 skrev Aurelien Jarno:
> On 2022-10-08 15:53, Aurelien Jarno wrote:
>> On 2022-10-08 14:11, Dan Johansen wrote:
>>> Den 30.09.2022 kl. 07.12 skrev Aurelien Jarno:
>>>> On the ODROID forum, Dongjin Kim said he is not planning to submit a new
>>>> version of the patchset adding support for the Hardkernel ODROID-M1
>>>> board. I therefore decided to address the issues reported during the
>>>> initial review, and I also did some small fixes either because some
>>>> things changed in the meantime on the kernel side or because I noticed
>>>> some warning or issues when using the hardware.
>>>>
>>>> I continued writing some additional patches to complete the ODROID M1
>>>> DTS to almost fully support the hardware, the drivers being already
>>>> present in the kernel.
>>>>
>>>> This new version includes feedback from the linux-rockchip mailing list
>>>> and from the Odroid forum.
>>>>
>>>> Changes since v2:
>>>> * Renamed "Rockchip RK3568 Hardkernel ODROID-M1" into "Hardkernel Odroid
>>>>     M1" and fix the sorting.
>>>> * Fix sorting of arch/arm64/boot/dts/rockchip/Makefile
>>>> * Collected Acked-by and Tested-by
>>> Even though I added my Tested-by to this series, it seems I didn't test it
>>> on eMMC.
>>>
>>> This fails to boot for me on eMMC, but works on SD card and NVMe.
>> Thanks for the feedback. I do not have an eMMC, so this the only part
>> from the patchset that I haven't been able to test.
>>
>> First of all, which version have you tested? The v2 includes fixes for
>> the eMMC, there was a conflict with the NOR flash. If the problem is
>> still there in the v2, could you please send the boot log or the error
>> message?
> Sorry I meant v3 above. Anyway in the meantime I have bought an eMMC,
> and I confirm that:
> - it does no work with the v2 due to a conflict with the NOR flash
>    driver
> - it does work with the v3
>
> Therefore can you please retry with the v3?
>
> Thanks
> Aurelien
>
-- 
Kind regards
*Dan Johansen*
Project lead of the *Manjaro ARM* project
Manjaro-ARM <https://manjaro.org>

Den 16.10.2022 kl. 11.35 skrev Dan Johansen:
> Trying to apply the patchset, but patch 3 does not seem to apply on 
> top of patch 2 for me.
>
> We do patch in other rk3568 boards, which is messing up the Makefile 
> patching, so I needed to redo patch 2 to fit.
>
> So it might an error on my part.

Yes. This was an error on my part. Not applying the other rk3568 board 
patches we have, this does apply cleanly.

Sorry for the noise/confusion on that. Will reply shortly with an answer 
to the original question.

>
> Den 15.10.2022 kl. 20.47 skrev Aurelien Jarno:
>> On 2022-10-08 15:53, Aurelien Jarno wrote:
>>> On 2022-10-08 14:11, Dan Johansen wrote:
>>>> Den 30.09.2022 kl. 07.12 skrev Aurelien Jarno:
>>>>> On the ODROID forum, Dongjin Kim said he is not planning to submit 
>>>>> a new
>>>>> version of the patchset adding support for the Hardkernel ODROID-M1
>>>>> board. I therefore decided to address the issues reported during the
>>>>> initial review, and I also did some small fixes either because some
>>>>> things changed in the meantime on the kernel side or because I 
>>>>> noticed
>>>>> some warning or issues when using the hardware.
>>>>>
>>>>> I continued writing some additional patches to complete the ODROID M1
>>>>> DTS to almost fully support the hardware, the drivers being already
>>>>> present in the kernel.
>>>>>
>>>>> This new version includes feedback from the linux-rockchip mailing 
>>>>> list
>>>>> and from the Odroid forum.
>>>>>
>>>>> Changes since v2:
>>>>> * Renamed "Rockchip RK3568 Hardkernel ODROID-M1" into "Hardkernel 
>>>>> Odroid
>>>>>     M1" and fix the sorting.
>>>>> * Fix sorting of arch/arm64/boot/dts/rockchip/Makefile
>>>>> * Collected Acked-by and Tested-by
>>>> Even though I added my Tested-by to this series, it seems I didn't 
>>>> test it
>>>> on eMMC.
>>>>
>>>> This fails to boot for me on eMMC, but works on SD card and NVMe.
>>> Thanks for the feedback. I do not have an eMMC, so this the only part
>>> from the patchset that I haven't been able to test.
>>>
>>> First of all, which version have you tested? The v2 includes fixes for
>>> the eMMC, there was a conflict with the NOR flash. If the problem is
>>> still there in the v2, could you please send the boot log or the error
>>> message?
>> Sorry I meant v3 above. Anyway in the meantime I have bought an eMMC,
>> and I confirm that:
>> - it does no work with the v2 due to a conflict with the NOR flash
>>    driver
>> - it does work with the v3
>>
>> Therefore can you please retry with the v3?
>>
>> Thanks
>> Aurelien
>>
-- 
Kind regards
*Dan Johansen*
Project lead of the *Manjaro ARM* project
Manjaro-ARM <https://manjaro.org>

On Fri, 30 Sep 2022 07:12:33 +0200, Aurelien Jarno wrote:
> On the ODROID forum, Dongjin Kim said he is not planning to submit a new
> version of the patchset adding support for the Hardkernel ODROID-M1
> board. I therefore decided to address the issues reported during the
> initial review, and I also did some small fixes either because some
> things changed in the meantime on the kernel side or because I noticed
> some warning or issues when using the hardware.
> 
> [...]

Applied, thanks!

[01/13] dt-bindings: rockchip: Add Hardkernel ODROID-M1 board
        commit: 19cc53eb2ce63c0e5adc2fd89494fb16f383ac10
[02/13] arm64: dts: rockchip: Add Hardkernel ODROID-M1 board
        commit: fd35832677032980df230f02509d6c016664cc89
[03/13] arm64: dts: rockchip: add thermal support to ODROID-M1
        commit: f5511bd8498da222b6455038a0cf3e7d2b2dfc7e
[04/13] arm64: dts: rockchip: Add NOR flash to ODROID-M1
        commit: 9f96204b7dcf94d03cad41194447c665d10675b7
[05/13] arm64: dts: rockchip: Add analog audio on ODROID-M1
        commit: 78f858447cb78cac7259093d095fb783328b835c
[06/13] arm64: dts: rockchip: Enable vop2 and hdmi tx on ODROID-M1
        commit: 913404aa2e60610f9cae375069dae97e11d726ed
[07/13] arm64: dts: rockchip: Enable HDMI audio on ODROID-M1.
        commit: 1ca7ddddf36494f0f6afd4f35d37827323271f39
[08/13] arm64: dts: rockchip: Enable the GPU on ODROID-M1
        commit: cb80b3455c7cadc4c1157879930e919f607d557c
[09/13] arm64: dts: rockchip: Enable the USB 2.0 ports on ODROID-M1
        commit: 4685d7b68aaac199ab0d950d2047405bf551f964
[10/13] arm64: dts: rockchip: Enable the USB 3.0 ports on ODROID-M1
        commit: 9984ef562653c8d0beb51021fc286706b6ec4802
[11/13] arm64: dts: rockchip: Add SATA support to ODROID-M1
        commit: 6a5a04d52ccc42e0e59ff69fca9c1db7e08ba44b
[12/13] arm64: dts: rockchip: Add PCIEe v3 nodes to ODROID-M1
        commit: 35b28582aa3dfd7b6861b7ebc72798b0ff50ed41
[13/13] arm64: dts: rockchip: Add IR receiver node to ODROID-M1
        commit: d6882992fe8182e3122be34af3f491948a8b9069

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>