[PATCH v3 0/7] clk: mediatek: use mtk_clk_simple_probe to simplify

Miles Chen posted 7 patches 2 years ago
drivers/clk/mediatek/clk-mt2701-bdp.c         | 36 +++++++------------
drivers/clk/mediatek/clk-mt2701-img.c         | 36 +++++++------------
drivers/clk/mediatek/clk-mt2701-vdec.c        | 36 +++++++------------
drivers/clk/mediatek/clk-mt2712-bdp.c         | 34 +++++++-----------
drivers/clk/mediatek/clk-mt2712-img.c         | 34 +++++++-----------
drivers/clk/mediatek/clk-mt2712-jpgdec.c      | 34 +++++++-----------
drivers/clk/mediatek/clk-mt2712-mfg.c         | 34 +++++++-----------
drivers/clk/mediatek/clk-mt2712-vdec.c        | 34 +++++++-----------
drivers/clk/mediatek/clk-mt2712-venc.c        | 34 +++++++-----------
drivers/clk/mediatek/clk-mt6765-audio.c       | 34 +++++++-----------
drivers/clk/mediatek/clk-mt6765-cam.c         | 33 +++++++----------
drivers/clk/mediatek/clk-mt6765-img.c         | 33 +++++++----------
drivers/clk/mediatek/clk-mt6765-mipi0a.c      | 34 +++++++-----------
drivers/clk/mediatek/clk-mt6765-mm.c          | 33 +++++++----------
drivers/clk/mediatek/clk-mt6765-vcodec.c      | 34 +++++++-----------
drivers/clk/mediatek/clk-mt6779-aud.c         | 29 +++++++--------
drivers/clk/mediatek/clk-mt6779-cam.c         | 29 +++++++--------
drivers/clk/mediatek/clk-mt6779-img.c         | 29 +++++++--------
drivers/clk/mediatek/clk-mt6779-ipe.c         | 29 +++++++--------
drivers/clk/mediatek/clk-mt6779-mfg.c         | 27 +++++++-------
drivers/clk/mediatek/clk-mt6779-vdec.c        | 29 +++++++--------
drivers/clk/mediatek/clk-mt6779-venc.c        | 29 +++++++--------
drivers/clk/mediatek/clk-mt6797-img.c         | 36 +++++++------------
drivers/clk/mediatek/clk-mt6797-vdec.c        | 36 +++++++------------
drivers/clk/mediatek/clk-mt6797-venc.c        | 36 +++++++------------
drivers/clk/mediatek/clk-mt8183-cam.c         | 27 +++++++-------
drivers/clk/mediatek/clk-mt8183-img.c         | 27 +++++++-------
drivers/clk/mediatek/clk-mt8183-ipu0.c        | 27 +++++++-------
drivers/clk/mediatek/clk-mt8183-ipu1.c        | 27 +++++++-------
drivers/clk/mediatek/clk-mt8183-ipu_adl.c     | 27 +++++++-------
drivers/clk/mediatek/clk-mt8183-ipu_conn.c    | 27 +++++++-------
drivers/clk/mediatek/clk-mt8183-mfgcfg.c      | 29 +++++++--------
drivers/clk/mediatek/clk-mt8183-vdec.c        | 27 +++++++-------
drivers/clk/mediatek/clk-mt8183-venc.c        | 27 +++++++-------
drivers/clk/mediatek/clk-mt8192-cam.c         |  1 +
drivers/clk/mediatek/clk-mt8192-img.c         |  1 +
.../clk/mediatek/clk-mt8192-imp_iic_wrap.c    |  1 +
drivers/clk/mediatek/clk-mt8192-ipe.c         |  1 +
drivers/clk/mediatek/clk-mt8192-mdp.c         |  1 +
drivers/clk/mediatek/clk-mt8192-mfg.c         |  1 +
drivers/clk/mediatek/clk-mt8192-msdc.c        |  1 +
drivers/clk/mediatek/clk-mt8192-scp_adsp.c    |  1 +
drivers/clk/mediatek/clk-mt8192-vdec.c        |  1 +
drivers/clk/mediatek/clk-mt8192-venc.c        |  1 +
44 files changed, 430 insertions(+), 647 deletions(-)
[PATCH v3 0/7] clk: mediatek: use mtk_clk_simple_probe to simplify
Posted by Miles Chen 2 years ago
Hi everyone,

This is v3 patches to use mtk_clk_simple_probe to simplify driver. It is almost
a RESEND patch, the only difference is adding reviewed-by tags and a tested-by tag
to the commit messages.

I tested the series on MT8192 and MT6779.
This patch is based on next-20220921 and [1].

Change since v1:
- Angelo's patch [1] already exported mtk_clk_simple_probe and mtk_clk_simple_remove,
so drop this part from my v1 and depends on [1].
- add a reviewed-by tag

Change since v2:
- add reviewed-by tags and a tested-by tag

mtk_clk_simple_probe() was introduced by Chun-Jie in commit
c58cd0e40ffa ("clk: mediatek: Add mtk_clk_simple_probe() to simplify clock providers")
and mtk_clk_simple_remove() was added in commit
commit 2204d96b1919 ("clk: mediatek: Add mtk_clk_simple_remove()")

With mtk_clk_simple_probe and mtk_clk_simple_remove,
we can get rid of defining the same probe function in clk drivers.
mtk_clk_simple_probe and mtk_clk_simple_remove are used in new platforms
now, let's apply them to old SoCs.

The process is quite straightforward: 
a. Look up probe functions which can be replaced by mtk_clk_simple_probe()
b. Add mtk_clk_desc and add .data
c. Replace the probe function with mtk_clk_simple_probe and mtk_clk_simple_remove

Thanks,
Miles

[1] https://lore.kernel.org/lkml/20220921091455.41327-1-angelogioacchino.delregno@collabora.com/



Miles Chen (7):
  clk: mediatek: mt2701: use mtk_clk_simple_probe to simplify driver
  clk: mediatek: mt2712: use mtk_clk_simple_probe to simplify driver
  clk: mediatek: mt6765: use mtk_clk_simple_probe to simplify driver
  clk: mediatek: mt6779: use mtk_clk_simple_probe to simplify driver
  clk: mediatek: mt6797: use mtk_clk_simple_probe to simplify driver
  clk: mediatek: mt8183: use mtk_clk_simple_probe to simplify driver
  clk: mediatek: mt8192: add mtk_clk_simple_remove

 drivers/clk/mediatek/clk-mt2701-bdp.c         | 36 +++++++------------
 drivers/clk/mediatek/clk-mt2701-img.c         | 36 +++++++------------
 drivers/clk/mediatek/clk-mt2701-vdec.c        | 36 +++++++------------
 drivers/clk/mediatek/clk-mt2712-bdp.c         | 34 +++++++-----------
 drivers/clk/mediatek/clk-mt2712-img.c         | 34 +++++++-----------
 drivers/clk/mediatek/clk-mt2712-jpgdec.c      | 34 +++++++-----------
 drivers/clk/mediatek/clk-mt2712-mfg.c         | 34 +++++++-----------
 drivers/clk/mediatek/clk-mt2712-vdec.c        | 34 +++++++-----------
 drivers/clk/mediatek/clk-mt2712-venc.c        | 34 +++++++-----------
 drivers/clk/mediatek/clk-mt6765-audio.c       | 34 +++++++-----------
 drivers/clk/mediatek/clk-mt6765-cam.c         | 33 +++++++----------
 drivers/clk/mediatek/clk-mt6765-img.c         | 33 +++++++----------
 drivers/clk/mediatek/clk-mt6765-mipi0a.c      | 34 +++++++-----------
 drivers/clk/mediatek/clk-mt6765-mm.c          | 33 +++++++----------
 drivers/clk/mediatek/clk-mt6765-vcodec.c      | 34 +++++++-----------
 drivers/clk/mediatek/clk-mt6779-aud.c         | 29 +++++++--------
 drivers/clk/mediatek/clk-mt6779-cam.c         | 29 +++++++--------
 drivers/clk/mediatek/clk-mt6779-img.c         | 29 +++++++--------
 drivers/clk/mediatek/clk-mt6779-ipe.c         | 29 +++++++--------
 drivers/clk/mediatek/clk-mt6779-mfg.c         | 27 +++++++-------
 drivers/clk/mediatek/clk-mt6779-vdec.c        | 29 +++++++--------
 drivers/clk/mediatek/clk-mt6779-venc.c        | 29 +++++++--------
 drivers/clk/mediatek/clk-mt6797-img.c         | 36 +++++++------------
 drivers/clk/mediatek/clk-mt6797-vdec.c        | 36 +++++++------------
 drivers/clk/mediatek/clk-mt6797-venc.c        | 36 +++++++------------
 drivers/clk/mediatek/clk-mt8183-cam.c         | 27 +++++++-------
 drivers/clk/mediatek/clk-mt8183-img.c         | 27 +++++++-------
 drivers/clk/mediatek/clk-mt8183-ipu0.c        | 27 +++++++-------
 drivers/clk/mediatek/clk-mt8183-ipu1.c        | 27 +++++++-------
 drivers/clk/mediatek/clk-mt8183-ipu_adl.c     | 27 +++++++-------
 drivers/clk/mediatek/clk-mt8183-ipu_conn.c    | 27 +++++++-------
 drivers/clk/mediatek/clk-mt8183-mfgcfg.c      | 29 +++++++--------
 drivers/clk/mediatek/clk-mt8183-vdec.c        | 27 +++++++-------
 drivers/clk/mediatek/clk-mt8183-venc.c        | 27 +++++++-------
 drivers/clk/mediatek/clk-mt8192-cam.c         |  1 +
 drivers/clk/mediatek/clk-mt8192-img.c         |  1 +
 .../clk/mediatek/clk-mt8192-imp_iic_wrap.c    |  1 +
 drivers/clk/mediatek/clk-mt8192-ipe.c         |  1 +
 drivers/clk/mediatek/clk-mt8192-mdp.c         |  1 +
 drivers/clk/mediatek/clk-mt8192-mfg.c         |  1 +
 drivers/clk/mediatek/clk-mt8192-msdc.c        |  1 +
 drivers/clk/mediatek/clk-mt8192-scp_adsp.c    |  1 +
 drivers/clk/mediatek/clk-mt8192-vdec.c        |  1 +
 drivers/clk/mediatek/clk-mt8192-venc.c        |  1 +
 44 files changed, 430 insertions(+), 647 deletions(-)

-- 
2.18.0
Re: [PATCH v3 0/7] clk: mediatek: use mtk_clk_simple_probe to simplify
Posted by Chen-Yu Tsai 1 year, 12 months ago
On Thu, Sep 22, 2022 at 5:19 PM Miles Chen <miles.chen@mediatek.com> wrote:
>
> Hi everyone,
>
> This is v3 patches to use mtk_clk_simple_probe to simplify driver. It is almost
> a RESEND patch, the only difference is adding reviewed-by tags and a tested-by tag
> to the commit messages.
>
> I tested the series on MT8192 and MT6779.
> This patch is based on next-20220921 and [1].
>
> Change since v1:
> - Angelo's patch [1] already exported mtk_clk_simple_probe and mtk_clk_simple_remove,
> so drop this part from my v1 and depends on [1].
> - add a reviewed-by tag
>
> Change since v2:
> - add reviewed-by tags and a tested-by tag
>
> mtk_clk_simple_probe() was introduced by Chun-Jie in commit
> c58cd0e40ffa ("clk: mediatek: Add mtk_clk_simple_probe() to simplify clock providers")
> and mtk_clk_simple_remove() was added in commit
> commit 2204d96b1919 ("clk: mediatek: Add mtk_clk_simple_remove()")
>
> With mtk_clk_simple_probe and mtk_clk_simple_remove,
> we can get rid of defining the same probe function in clk drivers.
> mtk_clk_simple_probe and mtk_clk_simple_remove are used in new platforms
> now, let's apply them to old SoCs.
>
> The process is quite straightforward:
> a. Look up probe functions which can be replaced by mtk_clk_simple_probe()
> b. Add mtk_clk_desc and add .data
> c. Replace the probe function with mtk_clk_simple_probe and mtk_clk_simple_remove
>
> Thanks,
> Miles
>
> [1] https://lore.kernel.org/lkml/20220921091455.41327-1-angelogioacchino.delregno@collabora.com/
>
>
>
> Miles Chen (7):
>   clk: mediatek: mt2701: use mtk_clk_simple_probe to simplify driver
>   clk: mediatek: mt2712: use mtk_clk_simple_probe to simplify driver
>   clk: mediatek: mt6765: use mtk_clk_simple_probe to simplify driver
>   clk: mediatek: mt6779: use mtk_clk_simple_probe to simplify driver
>   clk: mediatek: mt6797: use mtk_clk_simple_probe to simplify driver
>   clk: mediatek: mt8183: use mtk_clk_simple_probe to simplify driver
>   clk: mediatek: mt8192: add mtk_clk_simple_remove

I've queued this series up here [1] and will send a pull request to
the clock maintainer later this week.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/wens/linux.git/log/?h=clk-mtk-for-6.1