[v5] Use composable cache instead of L2 cache

[PATCH v5 0/7] Use composable cache instead of L2 cache

Posted by Zong Li 3 years, 6 months ago

Since composable cache may be L3 cache if private L2 cache exists, we
should use its original name "composable cache" to prevent confusion.

This patchset contains the modification which is related to ccache, such
as DT binding and EDAC driver.

The DT binding is based on top of Conor's patch, it has got ready for
merging, and it looks that it would be taken into the next few 6.0-rc
version. If there is any change, the next version of this series will be
posted as well.
https://lore.kernel.org/linux-riscv/20220825180417.1259360-2-mail@conchuod.ie/

Change log in v5:
 - Add a patch to modify aux vector for sysconf

Change log in v4:
 - Change the return value from from ENODEV to ENOENT
 - Apply pr_fmt refinement to all pr_err

Change log in v3:
 - Merged the EDAC patch into L2 rename patch
 - Define the macro for register shift and refine the relative code
 - Fix some indent issues

Change log in v2:
 - Separate the rename and diff to different patches
 - Rebase the dt-bindings based on Conor's modification
 - Include the patches of Ben for refinement of printing message

Ben Dooks (2):
  soc: sifive: ccache: reduce printing on init
  soc: sifive: ccache: use pr_fmt() to remove CCACHE: prefixes

Greentime Hu (2):
  soc: sifive: ccache: Rename SiFive L2 cache to Composable cache.
  riscv: Add cache information in AUX vector

Zong Li (3):
  dt-bindings: sifive-ccache: change Sifive L2 cache to Composable cache
  soc: sifive: ccache: determine the cache level from dts
  soc: sifive: ccache: define the macro for the register shifts

 ...five-l2-cache.yaml => sifive,ccache0.yaml} |  28 ++-
 arch/riscv/include/asm/elf.h                  |   4 +
 arch/riscv/include/uapi/asm/auxvec.h          |   4 +-
 drivers/edac/Kconfig                          |   2 +-
 drivers/edac/sifive_edac.c                    |  12 +-
 drivers/soc/sifive/Kconfig                    |   6 +-
 drivers/soc/sifive/Makefile                   |   2 +-
 .../{sifive_l2_cache.c => sifive_ccache.c}    | 200 ++++++++++--------
 .../{sifive_l2_cache.h => sifive_ccache.h}    |  16 +-
 9 files changed, 158 insertions(+), 116 deletions(-)
 rename Documentation/devicetree/bindings/riscv/{sifive-l2-cache.yaml => sifive,ccache0.yaml} (83%)
 rename drivers/soc/sifive/{sifive_l2_cache.c => sifive_ccache.c} (31%)
 rename include/soc/sifive/{sifive_l2_cache.h => sifive_ccache.h} (12%)

-- 
2.17.1

Re: [PATCH v5 0/7] Use composable cache instead of L2 cache

Posted by Palmer Dabbelt 3 years, 5 months ago

On Tue, 13 Sep 2022 06:18:10 +0000, Zong Li wrote:
> Since composable cache may be L3 cache if private L2 cache exists, we
> should use its original name "composable cache" to prevent confusion.
> 
> This patchset contains the modification which is related to ccache, such
> as DT binding and EDAC driver.
> 
> The DT binding is based on top of Conor's patch, it has got ready for
> merging, and it looks that it would be taken into the next few 6.0-rc
> version. If there is any change, the next version of this series will be
> posted as well.
> https://lore.kernel.org/linux-riscv/20220825180417.1259360-2-mail@conchuod.ie/
> 
> [...]

Applied, thanks!

[1/7] dt-bindings: sifive-ccache: change Sifive L2 cache to Composable cache
      https://git.kernel.org/palmer/c/44dce4b084f8
[2/7] soc: sifive: ccache: Rename SiFive L2 cache to Composable cache.
      https://git.kernel.org/palmer/c/ca120a79cf5a
[3/7] soc: sifive: ccache: determine the cache level from dts
      https://git.kernel.org/palmer/c/95f196f3212b
[4/7] soc: sifive: ccache: reduce printing on init
      https://git.kernel.org/palmer/c/3fb787e5bad5
[5/7] soc: sifive: ccache: use pr_fmt() to remove CCACHE: prefixes
      https://git.kernel.org/palmer/c/696ab9bda22a
[6/7] soc: sifive: ccache: define the macro for the register shifts
      https://git.kernel.org/palmer/c/afc7a5834f0d
[7/7] riscv: Add cache information in AUX vector
      https://git.kernel.org/palmer/c/da29dbcda49d

Best regards,
-- 
Palmer Dabbelt <palmer@rivosinc.com>

Re: [PATCH v5 0/7] Use composable cache instead of L2 cache

Posted by Zong Li 3 years, 6 months ago

On Tue, Sep 13, 2022 at 2:18 PM Zong Li <zong.li@sifive.com> wrote:
>
> Since composable cache may be L3 cache if private L2 cache exists, we
> should use its original name "composable cache" to prevent confusion.
>
> This patchset contains the modification which is related to ccache, such
> as DT binding and EDAC driver.
>
> The DT binding is based on top of Conor's patch, it has got ready for
> merging, and it looks that it would be taken into the next few 6.0-rc
> version. If there is any change, the next version of this series will be
> posted as well.
> https://lore.kernel.org/linux-riscv/20220825180417.1259360-2-mail@conchuod.ie/
>
> Change log in v5:
>  - Add a patch to modify aux vector for sysconf
>
> Change log in v4:
>  - Change the return value from from ENODEV to ENOENT
>  - Apply pr_fmt refinement to all pr_err
>
> Change log in v3:
>  - Merged the EDAC patch into L2 rename patch
>  - Define the macro for register shift and refine the relative code
>  - Fix some indent issues
>
> Change log in v2:
>  - Separate the rename and diff to different patches
>  - Rebase the dt-bindings based on Conor's modification
>  - Include the patches of Ben for refinement of printing message
>
> Ben Dooks (2):
>   soc: sifive: ccache: reduce printing on init
>   soc: sifive: ccache: use pr_fmt() to remove CCACHE: prefixes
>
> Greentime Hu (2):
>   soc: sifive: ccache: Rename SiFive L2 cache to Composable cache.
>   riscv: Add cache information in AUX vector
>
> Zong Li (3):
>   dt-bindings: sifive-ccache: change Sifive L2 cache to Composable cache
>   soc: sifive: ccache: determine the cache level from dts
>   soc: sifive: ccache: define the macro for the register shifts
>
>  ...five-l2-cache.yaml => sifive,ccache0.yaml} |  28 ++-
>  arch/riscv/include/asm/elf.h                  |   4 +
>  arch/riscv/include/uapi/asm/auxvec.h          |   4 +-
>  drivers/edac/Kconfig                          |   2 +-
>  drivers/edac/sifive_edac.c                    |  12 +-
>  drivers/soc/sifive/Kconfig                    |   6 +-
>  drivers/soc/sifive/Makefile                   |   2 +-
>  .../{sifive_l2_cache.c => sifive_ccache.c}    | 200 ++++++++++--------
>  .../{sifive_l2_cache.h => sifive_ccache.h}    |  16 +-
>  9 files changed, 158 insertions(+), 116 deletions(-)
>  rename Documentation/devicetree/bindings/riscv/{sifive-l2-cache.yaml => sifive,ccache0.yaml} (83%)
>  rename drivers/soc/sifive/{sifive_l2_cache.c => sifive_ccache.c} (31%)
>  rename include/soc/sifive/{sifive_l2_cache.h => sifive_ccache.h} (12%)
>
> --
> 2.17.1
>

Hi Palmer,
I was wondering if this series looks good to you, and could you please
help us to take it into riscv-tree?
Thanks.

Re: [PATCH v5 0/7] Use composable cache instead of L2 cache

Posted by Ben Dooks 3 years, 6 months ago

On 21/09/2022 06:09, Zong Li wrote:
> On Tue, Sep 13, 2022 at 2:18 PM Zong Li <zong.li@sifive.com> wrote:
>>
>> Since composable cache may be L3 cache if private L2 cache exists, we
>> should use its original name "composable cache" to prevent confusion.
>>
>> This patchset contains the modification which is related to ccache, such
>> as DT binding and EDAC driver.
>>
>> The DT binding is based on top of Conor's patch, it has got ready for
>> merging, and it looks that it would be taken into the next few 6.0-rc
>> version. If there is any change, the next version of this series will be
>> posted as well.
>> https://lore.kernel.org/linux-riscv/20220825180417.1259360-2-mail@conchuod.ie/
>>
>> Change log in v5:
>>   - Add a patch to modify aux vector for sysconf
>>
>> Change log in v4:
>>   - Change the return value from from ENODEV to ENOENT
>>   - Apply pr_fmt refinement to all pr_err
>>
>> Change log in v3:
>>   - Merged the EDAC patch into L2 rename patch
>>   - Define the macro for register shift and refine the relative code
>>   - Fix some indent issues
>>
>> Change log in v2:
>>   - Separate the rename and diff to different patches
>>   - Rebase the dt-bindings based on Conor's modification
>>   - Include the patches of Ben for refinement of printing message
>>
>> Ben Dooks (2):
>>    soc: sifive: ccache: reduce printing on init
>>    soc: sifive: ccache: use pr_fmt() to remove CCACHE: prefixes
>>
>> Greentime Hu (2):
>>    soc: sifive: ccache: Rename SiFive L2 cache to Composable cache.
>>    riscv: Add cache information in AUX vector
>>
>> Zong Li (3):
>>    dt-bindings: sifive-ccache: change Sifive L2 cache to Composable cache
>>    soc: sifive: ccache: determine the cache level from dts
>>    soc: sifive: ccache: define the macro for the register shifts
>>
>>   ...five-l2-cache.yaml => sifive,ccache0.yaml} |  28 ++-
>>   arch/riscv/include/asm/elf.h                  |   4 +
>>   arch/riscv/include/uapi/asm/auxvec.h          |   4 +-
>>   drivers/edac/Kconfig                          |   2 +-
>>   drivers/edac/sifive_edac.c                    |  12 +-
>>   drivers/soc/sifive/Kconfig                    |   6 +-
>>   drivers/soc/sifive/Makefile                   |   2 +-
>>   .../{sifive_l2_cache.c => sifive_ccache.c}    | 200 ++++++++++--------
>>   .../{sifive_l2_cache.h => sifive_ccache.h}    |  16 +-
>>   9 files changed, 158 insertions(+), 116 deletions(-)
>>   rename Documentation/devicetree/bindings/riscv/{sifive-l2-cache.yaml => sifive,ccache0.yaml} (83%)
>>   rename drivers/soc/sifive/{sifive_l2_cache.c => sifive_ccache.c} (31%)
>>   rename include/soc/sifive/{sifive_l2_cache.h => sifive_ccache.h} (12%)
>>
>> --
>> 2.17.1
>>
> 
> Hi Palmer,
> I was wondering if this series looks good to you, and could you please
> help us to take it into riscv-tree?
> Thanks.


I've given this series some basic testing, so would also like to see
this sorted out.

-- 
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius

https://www.codethink.co.uk/privacy.html

Re: [PATCH v5 0/7] Use composable cache instead of L2 cache

Posted by Zong Li 3 years, 6 months ago

On Wed, Sep 21, 2022 at 1:09 PM Zong Li <zong.li@sifive.com> wrote:
>
> On Tue, Sep 13, 2022 at 2:18 PM Zong Li <zong.li@sifive.com> wrote:
> >
> > Since composable cache may be L3 cache if private L2 cache exists, we
> > should use its original name "composable cache" to prevent confusion.
> >
> > This patchset contains the modification which is related to ccache, such
> > as DT binding and EDAC driver.
> >
> > The DT binding is based on top of Conor's patch, it has got ready for
> > merging, and it looks that it would be taken into the next few 6.0-rc
> > version. If there is any change, the next version of this series will be
> > posted as well.
> > https://lore.kernel.org/linux-riscv/20220825180417.1259360-2-mail@conchuod.ie/
> >
> > Change log in v5:
> >  - Add a patch to modify aux vector for sysconf
> >
> > Change log in v4:
> >  - Change the return value from from ENODEV to ENOENT
> >  - Apply pr_fmt refinement to all pr_err
> >
> > Change log in v3:
> >  - Merged the EDAC patch into L2 rename patch
> >  - Define the macro for register shift and refine the relative code
> >  - Fix some indent issues
> >
> > Change log in v2:
> >  - Separate the rename and diff to different patches
> >  - Rebase the dt-bindings based on Conor's modification
> >  - Include the patches of Ben for refinement of printing message
> >
> > Ben Dooks (2):
> >   soc: sifive: ccache: reduce printing on init
> >   soc: sifive: ccache: use pr_fmt() to remove CCACHE: prefixes
> >
> > Greentime Hu (2):
> >   soc: sifive: ccache: Rename SiFive L2 cache to Composable cache.
> >   riscv: Add cache information in AUX vector
> >
> > Zong Li (3):
> >   dt-bindings: sifive-ccache: change Sifive L2 cache to Composable cache
> >   soc: sifive: ccache: determine the cache level from dts
> >   soc: sifive: ccache: define the macro for the register shifts
> >
> >  ...five-l2-cache.yaml => sifive,ccache0.yaml} |  28 ++-
> >  arch/riscv/include/asm/elf.h                  |   4 +
> >  arch/riscv/include/uapi/asm/auxvec.h          |   4 +-
> >  drivers/edac/Kconfig                          |   2 +-
> >  drivers/edac/sifive_edac.c                    |  12 +-
> >  drivers/soc/sifive/Kconfig                    |   6 +-
> >  drivers/soc/sifive/Makefile                   |   2 +-
> >  .../{sifive_l2_cache.c => sifive_ccache.c}    | 200 ++++++++++--------
> >  .../{sifive_l2_cache.h => sifive_ccache.h}    |  16 +-
> >  9 files changed, 158 insertions(+), 116 deletions(-)
> >  rename Documentation/devicetree/bindings/riscv/{sifive-l2-cache.yaml => sifive,ccache0.yaml} (83%)
> >  rename drivers/soc/sifive/{sifive_l2_cache.c => sifive_ccache.c} (31%)
> >  rename include/soc/sifive/{sifive_l2_cache.h => sifive_ccache.h} (12%)
> >
> > --
> > 2.17.1
> >
>
> Hi Palmer,
> I was wondering if this series looks good to you, and could you please
> help us to take it into riscv-tree?
> Thanks.

Hi Palmer,
The new merge window is going to open, do you think is it suitable to
merge this series this time? Thanks.