drm/tidss: Set max DMA segment size

[PATCH] drm/tidss: Set max DMA segment size

Posted by Andrew Davis 3 years, 7 months ago

We have no segment size limitations. Set to unlimited.

Signed-off-by: Andrew Davis <afd@ti.com>
---
 drivers/gpu/drm/tidss/tidss_dispc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/tidss/tidss_dispc.c b/drivers/gpu/drm/tidss/tidss_dispc.c
index dd3c6a606ae2..624545e4636c 100644
--- a/drivers/gpu/drm/tidss/tidss_dispc.c
+++ b/drivers/gpu/drm/tidss/tidss_dispc.c
@@ -2685,6 +2685,7 @@ int dispc_init(struct tidss_device *tidss)
 		if (r)
 			dev_warn(dev, "cannot set DMA masks to 48-bit\n");
 	}
+	dma_set_max_seg_size(dev, UINT_MAX);
 
 	dispc = devm_kzalloc(dev, sizeof(*dispc), GFP_KERNEL);
 	if (!dispc)
-- 
2.36.1

Re: [PATCH] drm/tidss: Set max DMA segment size

Posted by Tomi Valkeinen 3 years, 3 months ago

On 23/08/2022 03:16, Andrew Davis wrote:
> We have no segment size limitations. Set to unlimited.
> 
> Signed-off-by: Andrew Davis <afd@ti.com>
> ---
>   drivers/gpu/drm/tidss/tidss_dispc.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/tidss/tidss_dispc.c b/drivers/gpu/drm/tidss/tidss_dispc.c
> index dd3c6a606ae2..624545e4636c 100644
> --- a/drivers/gpu/drm/tidss/tidss_dispc.c
> +++ b/drivers/gpu/drm/tidss/tidss_dispc.c
> @@ -2685,6 +2685,7 @@ int dispc_init(struct tidss_device *tidss)
>   		if (r)
>   			dev_warn(dev, "cannot set DMA masks to 48-bit\n");
>   	}
> +	dma_set_max_seg_size(dev, UINT_MAX);
>   
>   	dispc = devm_kzalloc(dev, sizeof(*dispc), GFP_KERNEL);
>   	if (!dispc)

Thanks, I'll apply to drm-misc.

  Tomi

Re: [PATCH] drm/tidss: Set max DMA segment size

Posted by Andrew Davis 3 years, 4 months ago

On 8/22/22 7:16 PM, Andrew Davis wrote:
> We have no segment size limitations. Set to unlimited.
> 
> Signed-off-by: Andrew Davis <afd@ti.com>
> ---

Ping, still valid.

Andrew

>   drivers/gpu/drm/tidss/tidss_dispc.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/tidss/tidss_dispc.c b/drivers/gpu/drm/tidss/tidss_dispc.c
> index dd3c6a606ae2..624545e4636c 100644
> --- a/drivers/gpu/drm/tidss/tidss_dispc.c
> +++ b/drivers/gpu/drm/tidss/tidss_dispc.c
> @@ -2685,6 +2685,7 @@ int dispc_init(struct tidss_device *tidss)
>   		if (r)
>   			dev_warn(dev, "cannot set DMA masks to 48-bit\n");
>   	}
> +	dma_set_max_seg_size(dev, UINT_MAX);
>   
>   	dispc = devm_kzalloc(dev, sizeof(*dispc), GFP_KERNEL);
>   	if (!dispc)