[v2] ARM: dts: mvebu: Add definitions for PCIe legacy INTx interrupts

[PATCH v2 00/10] ARM: dts: mvebu: Add definitions for PCIe legacy INTx interrupts

Posted by Marek Behún 3 years, 9 months ago

As suggested by Gregory [1] (although he suggested it only for armada
380), add definitions for PCIe legacy INTx interrupts into every DTS
file used by the pci-mvebu.c controller driver.

It was tested on 88F6820 (A385) and 88F6281 (Kirkwood) SoCs.

[1] https://lore.kernel.org/linux-arm-kernel/87wnhxjxlq.fsf@BL-laptop/

Changes since v1:
- dropped armada-385 patch, which was already applied
- added commit messages

Pali Rohár (10):
  ARM: dts: kirkwood: Add definitions for PCIe legacy INTx interrupts
  ARM: dts: dove: Add definitions for PCIe legacy INTx interrupts
  ARM: dts: armada-370.dtsi: Add definitions for PCIe legacy INTx
    interrupts
  ARM: dts: armada-xp-98dx3236.dtsi: Add definitions for PCIe legacy
    INTx interrupts
  ARM: dts: armada-xp-mv78230.dtsi: Add definitions for PCIe legacy INTx
    interrupts
  ARM: dts: armada-xp-mv78260.dtsi: Add definitions for PCIe legacy INTx
    interrupts
  ARM: dts: armada-xp-mv78460.dtsi: Add definitions for PCIe legacy INTx
    interrupts
  ARM: dts: armada-375.dtsi: Add definitions for PCIe legacy INTx
    interrupts
  ARM: dts: armada-380.dtsi: Add definitions for PCIe legacy INTx
    interrupts
  ARM: dts: armada-39x.dtsi: Add definitions for PCIe legacy INTx
    interrupts

 arch/arm/boot/dts/armada-370.dtsi         |  28 ++++-
 arch/arm/boot/dts/armada-375.dtsi         |  28 ++++-
 arch/arm/boot/dts/armada-380.dtsi         |  42 ++++++-
 arch/arm/boot/dts/armada-39x.dtsi         |  56 +++++++--
 arch/arm/boot/dts/armada-xp-98dx3236.dtsi |  14 ++-
 arch/arm/boot/dts/armada-xp-mv78230.dtsi  |  70 +++++++++--
 arch/arm/boot/dts/armada-xp-mv78260.dtsi  | 126 ++++++++++++++++---
 arch/arm/boot/dts/armada-xp-mv78460.dtsi  | 140 ++++++++++++++++++----
 arch/arm/boot/dts/dove.dtsi               |  28 ++++-
 arch/arm/boot/dts/kirkwood-6192.dtsi      |  14 ++-
 arch/arm/boot/dts/kirkwood-6281.dtsi      |  14 ++-
 arch/arm/boot/dts/kirkwood-6282.dtsi      |  28 ++++-
 arch/arm/boot/dts/kirkwood-98dx4122.dtsi  |  14 ++-
 13 files changed, 516 insertions(+), 86 deletions(-)

-- 
2.35.1

Re: [PATCH v2 00/10] ARM: dts: mvebu: Add definitions for PCIe legacy INTx interrupts

Posted by Andrew Lunn 3 years, 9 months ago

On Tue, Jul 12, 2022 at 06:40:58PM +0200, Marek Behún wrote:
> As suggested by Gregory [1] (although he suggested it only for armada
> 380), add definitions for PCIe legacy INTx interrupts into every DTS
> file used by the pci-mvebu.c controller driver.
> 
> It was tested on 88F6820 (A385) and 88F6281 (Kirkwood) SoCs.
> 
> [1] https://lore.kernel.org/linux-arm-kernel/87wnhxjxlq.fsf@BL-laptop/
> 
> Changes since v1:
> - dropped armada-385 patch, which was already applied
> - added commit messages

Thanks for updating the commit message.

I don't see any Fixes: tags here. So from that, can i assume that
there are no known broken devices? We don't need to involve stable.

      Andrew

Re: [PATCH v2 00/10] ARM: dts: mvebu: Add definitions for PCIe legacy INTx interrupts

Posted by Marek Behún 3 years, 9 months ago

On Tue, 12 Jul 2022 18:59:20 +0200
Andrew Lunn <andrew@lunn.ch> wrote:

> On Tue, Jul 12, 2022 at 06:40:58PM +0200, Marek Behún wrote:
> > As suggested by Gregory [1] (although he suggested it only for armada
> > 380), add definitions for PCIe legacy INTx interrupts into every DTS
> > file used by the pci-mvebu.c controller driver.
> > 
> > It was tested on 88F6820 (A385) and 88F6281 (Kirkwood) SoCs.
> > 
> > [1] https://lore.kernel.org/linux-arm-kernel/87wnhxjxlq.fsf@BL-laptop/
> > 
> > Changes since v1:
> > - dropped armada-385 patch, which was already applied
> > - added commit messages  
> 
> Thanks for updating the commit message.
> 
> I don't see any Fixes: tags here. So from that, can i assume that
> there are no known broken devices? We don't need to involve stable.

I don't think so. If it turns out we do, we can just send it to stable
afterwards.

Marek

Re: [PATCH v2 00/10] ARM: dts: mvebu: Add definitions for PCIe legacy INTx interrupts

Posted by Pali Rohár 3 years, 8 months ago

Hello! What is state of these patches? I see no response for more than month.

On Tuesday 12 July 2022 18:40:58 Marek Behún wrote:
> As suggested by Gregory [1] (although he suggested it only for armada
> 380), add definitions for PCIe legacy INTx interrupts into every DTS
> file used by the pci-mvebu.c controller driver.
> 
> It was tested on 88F6820 (A385) and 88F6281 (Kirkwood) SoCs.
> 
> [1] https://lore.kernel.org/linux-arm-kernel/87wnhxjxlq.fsf@BL-laptop/
> 
> Changes since v1:
> - dropped armada-385 patch, which was already applied
> - added commit messages
> 
> Pali Rohár (10):
>   ARM: dts: kirkwood: Add definitions for PCIe legacy INTx interrupts
>   ARM: dts: dove: Add definitions for PCIe legacy INTx interrupts
>   ARM: dts: armada-370.dtsi: Add definitions for PCIe legacy INTx
>     interrupts
>   ARM: dts: armada-xp-98dx3236.dtsi: Add definitions for PCIe legacy
>     INTx interrupts
>   ARM: dts: armada-xp-mv78230.dtsi: Add definitions for PCIe legacy INTx
>     interrupts
>   ARM: dts: armada-xp-mv78260.dtsi: Add definitions for PCIe legacy INTx
>     interrupts
>   ARM: dts: armada-xp-mv78460.dtsi: Add definitions for PCIe legacy INTx
>     interrupts
>   ARM: dts: armada-375.dtsi: Add definitions for PCIe legacy INTx
>     interrupts
>   ARM: dts: armada-380.dtsi: Add definitions for PCIe legacy INTx
>     interrupts
>   ARM: dts: armada-39x.dtsi: Add definitions for PCIe legacy INTx
>     interrupts
> 
>  arch/arm/boot/dts/armada-370.dtsi         |  28 ++++-
>  arch/arm/boot/dts/armada-375.dtsi         |  28 ++++-
>  arch/arm/boot/dts/armada-380.dtsi         |  42 ++++++-
>  arch/arm/boot/dts/armada-39x.dtsi         |  56 +++++++--
>  arch/arm/boot/dts/armada-xp-98dx3236.dtsi |  14 ++-
>  arch/arm/boot/dts/armada-xp-mv78230.dtsi  |  70 +++++++++--
>  arch/arm/boot/dts/armada-xp-mv78260.dtsi  | 126 ++++++++++++++++---
>  arch/arm/boot/dts/armada-xp-mv78460.dtsi  | 140 ++++++++++++++++++----
>  arch/arm/boot/dts/dove.dtsi               |  28 ++++-
>  arch/arm/boot/dts/kirkwood-6192.dtsi      |  14 ++-
>  arch/arm/boot/dts/kirkwood-6281.dtsi      |  14 ++-
>  arch/arm/boot/dts/kirkwood-6282.dtsi      |  28 ++++-
>  arch/arm/boot/dts/kirkwood-98dx4122.dtsi  |  14 ++-
>  13 files changed, 516 insertions(+), 86 deletions(-)
> 
> -- 
> 2.35.1
>

Re: [PATCH v2 00/10] ARM: dts: mvebu: Add definitions for PCIe legacy INTx interrupts

Posted by Gregory CLEMENT 3 years, 7 months ago

Hello,

> Hello! What is state of these patches? I see no response for more than
> month.

Actually I didn't received the second version of the series, but I
manged to find it in lore and so I applied it on mvebu/dt

Thanks,

Gregory


>
> On Tuesday 12 July 2022 18:40:58 Marek Behún wrote:
>> As suggested by Gregory [1] (although he suggested it only for armada
>> 380), add definitions for PCIe legacy INTx interrupts into every DTS
>> file used by the pci-mvebu.c controller driver.
>> 
>> It was tested on 88F6820 (A385) and 88F6281 (Kirkwood) SoCs.
>> 
>> [1] https://lore.kernel.org/linux-arm-kernel/87wnhxjxlq.fsf@BL-laptop/
>> 
>> Changes since v1:
>> - dropped armada-385 patch, which was already applied
>> - added commit messages
>> 
>> Pali Rohár (10):
>>   ARM: dts: kirkwood: Add definitions for PCIe legacy INTx interrupts
>>   ARM: dts: dove: Add definitions for PCIe legacy INTx interrupts
>>   ARM: dts: armada-370.dtsi: Add definitions for PCIe legacy INTx
>>     interrupts
>>   ARM: dts: armada-xp-98dx3236.dtsi: Add definitions for PCIe legacy
>>     INTx interrupts
>>   ARM: dts: armada-xp-mv78230.dtsi: Add definitions for PCIe legacy INTx
>>     interrupts
>>   ARM: dts: armada-xp-mv78260.dtsi: Add definitions for PCIe legacy INTx
>>     interrupts
>>   ARM: dts: armada-xp-mv78460.dtsi: Add definitions for PCIe legacy INTx
>>     interrupts
>>   ARM: dts: armada-375.dtsi: Add definitions for PCIe legacy INTx
>>     interrupts
>>   ARM: dts: armada-380.dtsi: Add definitions for PCIe legacy INTx
>>     interrupts
>>   ARM: dts: armada-39x.dtsi: Add definitions for PCIe legacy INTx
>>     interrupts
>> 
>>  arch/arm/boot/dts/armada-370.dtsi         |  28 ++++-
>>  arch/arm/boot/dts/armada-375.dtsi         |  28 ++++-
>>  arch/arm/boot/dts/armada-380.dtsi         |  42 ++++++-
>>  arch/arm/boot/dts/armada-39x.dtsi         |  56 +++++++--
>>  arch/arm/boot/dts/armada-xp-98dx3236.dtsi |  14 ++-
>>  arch/arm/boot/dts/armada-xp-mv78230.dtsi  |  70 +++++++++--
>>  arch/arm/boot/dts/armada-xp-mv78260.dtsi  | 126 ++++++++++++++++---
>>  arch/arm/boot/dts/armada-xp-mv78460.dtsi  | 140 ++++++++++++++++++----
>>  arch/arm/boot/dts/dove.dtsi               |  28 ++++-
>>  arch/arm/boot/dts/kirkwood-6192.dtsi      |  14 ++-
>>  arch/arm/boot/dts/kirkwood-6281.dtsi      |  14 ++-
>>  arch/arm/boot/dts/kirkwood-6282.dtsi      |  28 ++++-
>>  arch/arm/boot/dts/kirkwood-98dx4122.dtsi  |  14 ++-
>>  13 files changed, 516 insertions(+), 86 deletions(-)
>> 
>> -- 
>> 2.35.1
>> 

-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com