[PATCH v3 0/2] x86: AMX enabling example with new constants

Chang S. Bae posted 2 patches 3 years, 9 months ago
Documentation/x86/xstate.rst      | 55 +++++++++++++++++++++++++++++++
arch/x86/include/uapi/asm/prctl.h |  3 ++
2 files changed, 58 insertions(+)
[PATCH v3 0/2] x86: AMX enabling example with new constants
Posted by Chang S. Bae 3 years, 9 months ago
Hi all,

Here are the changes from the last version [1]:
* Add AMX feature numbers as ABI constants (Tony Luck).
* Revise sentences in the documentation (Bagas Sanjaya).
* Adjust the code example.

Thank you Tony and Bagas for the feedback.

=== Cover Letter ===

With the AMX support in the mainline, recently I heard some folks had a
hard time understanding the AMX enabling process. A code example is
expected to clarify the steps. Along with that, add a couple of ABI
constants useful for the feature enabling.

The arch_prctl(2) manual page [2] is missing these new options. Perhaps,
the man-page update follows up along with this.

These changes can be found in the repo:
  git://github.com/intel/amx-linux.git doc

And the compiled preview is available here:
  https://htmlpreview.github.io/?https://github.com/intel/amx-linux/doc-web/x86/xstate.html

Thanks,
Chang

[1] https://lore.kernel.org/lkml/20220629224235.20589-1-chang.seok.bae@intel.com/
[2] arch_prctl(2): https://man7.org/linux/man-pages/man2/arch_prctl.2.html

Chang S. Bae (2):
  x86/arch_prctl: Add AMX feature numbers as ABI constants
  Documentation/x86: Add the AMX enabling example

 Documentation/x86/xstate.rst      | 55 +++++++++++++++++++++++++++++++
 arch/x86/include/uapi/asm/prctl.h |  3 ++
 2 files changed, 58 insertions(+)


base-commit: 32346491ddf24599decca06190ebca03ff9de7f8
-- 
2.17.1
RE: [PATCH v3 0/2] x86: AMX enabling example with new constants
Posted by Luck, Tony 3 years, 9 months ago
> The arch_prctl(2) manual page [2] is missing these new options. Perhaps,
> the man-page update follows up along with this.

This isn't the right process to get a manual page updated.

See:

https://www.kernel.org/doc/man-pages/contributing.html

then log a bug, write a patch, and submit it to add the AMX options.

-Tony
Re: [PATCH v3 0/2] x86: AMX enabling example with new constants
Posted by Chang S. Bae 3 years, 9 months ago
On 7/21/2022 1:53 PM, Luck, Tony wrote:
>> The arch_prctl(2) manual page [2] is missing these new options. Perhaps,
>> the man-page update follows up along with this.
> 
> This isn't the right process to get a manual page updated.
> 
> See:
> 
> https://www.kernel.org/doc/man-pages/contributing.html
> 
> then log a bug, write a patch, and submit it to add the AMX options.

Indeed. I didn't intend this series to initiate the process to update 
the man page. Instead, I wanted to establish the kernel doc before 
starting it. But it looks like not super clear, sorry.

Thanks,
Chang