arch/arm/boot/dts/imx6qdl-ts7970.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Device-tree incorrectly used "ngpio" which caused the driver to
fallback to 32 ngpios.
This platform has 62 GPIO registers.
Signed-off-by: Kris Bahnsen <kris@embeddedTS.com>
---
arch/arm/boot/dts/imx6qdl-ts7970.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx6qdl-ts7970.dtsi b/arch/arm/boot/dts/imx6qdl-ts7970.dtsi
index fded07f370b3..d6ba4b2a60f6 100644
--- a/arch/arm/boot/dts/imx6qdl-ts7970.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-ts7970.dtsi
@@ -226,7 +226,7 @@
reg = <0x28>;
#gpio-cells = <2>;
gpio-controller;
- ngpio = <32>;
+ ngpios = <62>;
};
sgtl5000: codec@a {
base-commit: 03c765b0e3b4cb5063276b086c76f7a612856a9a
--
2.11.0
On 30/06/2022 20:27, Kris Bahnsen wrote: > Device-tree incorrectly used "ngpio" which caused the driver to > fallback to 32 ngpios. > > This platform has 62 GPIO registers. > > Signed-off-by: Kris Bahnsen <kris@embeddedTS.com> > --- Ah and one more - for some reason you did not send it to maintainers, so patch will be most likely ignored. Please use scripts/get_maintainer.pl to CC relevant people. Best regards, Krzysztof
On Thu, 2022-06-30 at 20:56 +0200, Krzysztof Kozlowski wrote: > On 30/06/2022 20:27, Kris Bahnsen wrote: > > Device-tree incorrectly used "ngpio" which caused the driver to > > fallback to 32 ngpios. > > > > This platform has 62 GPIO registers. > > > > Signed-off-by: Kris Bahnsen <kris@embeddedTS.com> > > --- > > > Ah and one more - for some reason you did not send it to maintainers, so > patch will be most likely ignored. Please use scripts/get_maintainer.pl > to CC relevant people. I reviewed that output and erred on the side of not generating too much noise and skipped folks/lists marked as general ARM/NXP maintainers. I'll be sure to send to all in the future. Forgot about Fixes: tag, I'll add that in a v2. Thanks for the feedback. > > Best regards, > Krzysztof >
On 30/06/2022 21:11, Kris Bahnsen wrote: > On Thu, 2022-06-30 at 20:56 +0200, Krzysztof Kozlowski wrote: >> On 30/06/2022 20:27, Kris Bahnsen wrote: >>> Device-tree incorrectly used "ngpio" which caused the driver to >>> fallback to 32 ngpios. >>> >>> This platform has 62 GPIO registers. >>> >>> Signed-off-by: Kris Bahnsen <kris@embeddedTS.com> >>> --- >> >> >> Ah and one more - for some reason you did not send it to maintainers, so >> patch will be most likely ignored. Please use scripts/get_maintainer.pl >> to CC relevant people. > > I reviewed that output and erred on the side of not generating > too much noise and skipped folks/lists marked as general ARM/NXP > maintainers. I'll be sure to send to all in the future. For small patchsets usually entire output of get_maintainers.pl is correct. What's worth to skip are the entries coming from history (--no-git-fallback). Best regards, Krzysztof
On 30/06/2022 20:27, Kris Bahnsen wrote: > Device-tree incorrectly used "ngpio" which caused the driver to > fallback to 32 ngpios. > > This platform has 62 GPIO registers. > > Signed-off-by: Kris Bahnsen <kris@embeddedTS.com> You should add here Fixes tag. Best regards, Krzysztof
© 2016 - 2026 Red Hat, Inc.