[v2] ARM: dts: imx6qdl-ts7970: Fix ngpio typo and count

[PATCH v2] ARM: dts: imx6qdl-ts7970: Fix ngpio typo and count

Posted by Kris Bahnsen 3 years, 9 months ago

Device-tree incorrectly used "ngpio" which caused the driver to
fallback to 32 ngpios.

This platform has 62 GPIO registers.

Fixes: 9ff8e9fccef9 ("ARM: dts: TS-7970: add basic device tree")
Signed-off-by: Kris Bahnsen <kris@embeddedTS.com>
---
V1 -> V2:
- Add fixes tag
- V1 patch not sent to all relevant parties

 arch/arm/boot/dts/imx6qdl-ts7970.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx6qdl-ts7970.dtsi b/arch/arm/boot/dts/imx6qdl-ts7970.dtsi
index fded07f370b3..d6ba4b2a60f6 100644
--- a/arch/arm/boot/dts/imx6qdl-ts7970.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-ts7970.dtsi
@@ -226,7 +226,7 @@
 		reg = <0x28>;
 		#gpio-cells = <2>;
 		gpio-controller;
-		ngpio = <32>;
+		ngpios = <62>;
 	};
 
 	sgtl5000: codec@a {

base-commit: 03c765b0e3b4cb5063276b086c76f7a612856a9a
-- 
2.11.0

Re: [PATCH v2] ARM: dts: imx6qdl-ts7970: Fix ngpio typo and count

Posted by Shawn Guo 3 years, 9 months ago

On Thu, Jun 30, 2022 at 02:03:27PM -0700, Kris Bahnsen wrote:
> Device-tree incorrectly used "ngpio" which caused the driver to
> fallback to 32 ngpios.
> 
> This platform has 62 GPIO registers.
> 
> Fixes: 9ff8e9fccef9 ("ARM: dts: TS-7970: add basic device tree")
> Signed-off-by: Kris Bahnsen <kris@embeddedTS.com>

Applied, thanks!

Re: [PATCH v2] ARM: dts: imx6qdl-ts7970: Fix ngpio typo and count

Posted by Fabio Estevam 3 years, 9 months ago

Hi Kris,

On Thu, Jun 30, 2022 at 6:03 PM Kris Bahnsen <kris@embeddedts.com> wrote:
>
> Device-tree incorrectly used "ngpio" which caused the driver to
> fallback to 32 ngpios.
>
> This platform has 62 GPIO registers.
>
> Fixes: 9ff8e9fccef9 ("ARM: dts: TS-7970: add basic device tree")
> Signed-off-by: Kris Bahnsen <kris@embeddedTS.com>

Reviewed-by: Fabio Estevam <festevam@gmail.com>