Hi,

There are several changes in this series:
- Add missing NVME_SMART_CRIT_PMR_UNRELIABLE enum type.
- Add missing NVME_AEN_CFG_SMART_CRIT_* enum types.
- Enable smart AEN.

zhenwei pi (3):
  nvme: introduce bit 5 of smart critical warning
  nvme: introduce smart bits of aen cfg
  nvme: enable smart AEN

 drivers/nvme/host/core.c |  6 +++++-
 include/linux/nvme.h     | 20 ++++++++++++++++----
 2 files changed, 21 insertions(+), 5 deletions(-)

-- 
2.20.1

> Hi,
> 
> There are several changes in this series:
> - Add missing NVME_SMART_CRIT_PMR_UNRELIABLE enum type.
> - Add missing NVME_AEN_CFG_SMART_CRIT_* enum types.
> - Enable smart AEN.

Is there another side to this patchset? meaning some userland agent
that listens to these events and does something with these?

On 5/11/22 03:13, Sagi Grimberg wrote:
> 
>> Hi,
>>
>> There are several changes in this series:
>> - Add missing NVME_SMART_CRIT_PMR_UNRELIABLE enum type.
>> - Add missing NVME_AEN_CFG_SMART_CRIT_* enum types.
>> - Enable smart AEN.
> 
> Is there another side to this patchset? meaning some userland agent
> that listens to these events and does something with these?

I tried to test SMART AEN end to end by QEMU NVMe emulation. I did not 
realize that the SMART AEN CFG is not optional.

Also sent this to QEMU(Klaus corrected me):
https://patchwork.kernel.org/project/qemu-devel/cover/20220507072644.263105-1-pizhenwei@bytedance.com/

-- 
zhenwei pi

Hi,

Sorry, I misunderstand OAES[7:0], only the first patch "nvme: introduce 
bit 5 of smart critical warning" is available.

On 5/7/22 14:50, zhenwei pi wrote:
> Hi,
> 
> There are several changes in this series:
> - Add missing NVME_SMART_CRIT_PMR_UNRELIABLE enum type.
> - Add missing NVME_AEN_CFG_SMART_CRIT_* enum types.
> - Enable smart AEN.
> 
> zhenwei pi (3):
>    nvme: introduce bit 5 of smart critical warning
>    nvme: introduce smart bits of aen cfg
>    nvme: enable smart AEN
> 
>   drivers/nvme/host/core.c |  6 +++++-
>   include/linux/nvme.h     | 20 ++++++++++++++++----
>   2 files changed, 21 insertions(+), 5 deletions(-)
> 

-- 
zhenwei pi