From nobody Fri May 8 08:23:30 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EF19C433F5 for ; Sat, 7 May 2022 06:54:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1445921AbiEGG6R (ORCPT ); Sat, 7 May 2022 02:58:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38560 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230196AbiEGG6M (ORCPT ); Sat, 7 May 2022 02:58:12 -0400 Received: from mail-pf1-x429.google.com (mail-pf1-x429.google.com [IPv6:2607:f8b0:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 289745DD0C for ; Fri, 6 May 2022 23:54:26 -0700 (PDT) Received: by mail-pf1-x429.google.com with SMTP id p8so7994232pfh.8 for ; Fri, 06 May 2022 23:54:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QReXyHcN++8ZnG2EAL0MCJ6b3jaE9j2fBL439Rjlnbw=; b=s+YUi5RX2rfgtaYeELXxYjzxZHhXeqAlxqYW841Loi+QpDbMl5CvQr20fAZ0/+sGh9 r6ZG2cvgzgePuBm7irTI6/W4JXSG4flFw2g2YtS8llhCdlcV6hjxybpSsf2Rff8VPgIP hL5wmIWP8rnKLApA3ZG8UcxzrGJg4iZd8vslmn9fq2xxX9+TiquMWpEVtVsfL5w6WVrq zCC/RLz+12TAFjewEH0u0bzgkVYRDGaLF9qGmGHCeTqhsX5iHZwBIR2LoQxEdMH+NqT5 QWLsDOP2R5W8aOSmStQhtxsen1knaqqEOFNxHVD95UR1vx/5yxQneV9RvWzvVnoA7edS WCcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QReXyHcN++8ZnG2EAL0MCJ6b3jaE9j2fBL439Rjlnbw=; b=j+vnnWdVPPvgwCFGUi8LuVnlmMK45tY3JCMJxBUJuXfHHSS9p1Ollyi1KNh1HWuEVr JsVBypCbE2bDHv+8fWlCvFDCKwhX6x4ShOjQ5m/4L+QzqZALmrnsPpzxCSpMZIGCpnHz XnaOJZo9HHUkVcaVHWt9XfhfJz2/9GXkXQDkxgQ5S3/1ub277esQAwxjfegCblycY/XY Qbrg5fWvjydH6RJ4iV/h2fSyMrYc6LH+ppVuuZFx4exun5o8r/vMZDMjKCpZmTodtAmA dnTVL9XbjPsl/+KzZHvykFzX0W9EobdcNUkDOdjfchMrFI0hkkHL8S+hF6ynYoXbUXzF MYqQ== X-Gm-Message-State: AOAM531moFoofBgAqunzGxhe1CQxg6O8Jrk3NUHAubcWU3gMb2DEzd+9 56yW87A3bncroI9teYDab/XXYg== X-Google-Smtp-Source: ABdhPJw6SAxt8Mk4xZLntEaQck4s/Gg8DeKj51whay6UwZPAno6fleXHlqMOPIazxWlobmQT4EEXyA== X-Received: by 2002:a63:4d1:0:b0:3c1:630d:b6b with SMTP id 200-20020a6304d1000000b003c1630d0b6bmr5767272pge.623.1651906465566; Fri, 06 May 2022 23:54:25 -0700 (PDT) Received: from always-x1.www.tendawifi.com ([139.177.225.239]) by smtp.gmail.com with ESMTPSA id y20-20020a1709027c9400b0015e8d4eb1ebsm2905162pll.53.2022.05.06.23.54.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 May 2022 23:54:25 -0700 (PDT) From: zhenwei pi To: kbusch@kernel.org, hch@lst.de Cc: sagi@grimberg.me, axboe@fb.com, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, zhenwei pi Subject: [PATCH 1/3] nvme: introduce bit 5 of smart critical warning Date: Sat, 7 May 2022 14:50:24 +0800 Message-Id: <20220507065026.260306-2-pizhenwei@bytedance.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220507065026.260306-1-pizhenwei@bytedance.com> References: <20220507065026.260306-1-pizhenwei@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" According to NVM Express v1.4, Section 5.14.1.2 ("SMART / Health Information"), introduce bit 5 for "Persistent Memory Region has become read-only or unreliable". Signed-off-by: zhenwei pi --- include/linux/nvme.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/nvme.h b/include/linux/nvme.h index f626a445d1a8..882ad7523127 100644 --- a/include/linux/nvme.h +++ b/include/linux/nvme.h @@ -662,6 +662,7 @@ enum { NVME_SMART_CRIT_RELIABILITY =3D 1 << 2, NVME_SMART_CRIT_MEDIA =3D 1 << 3, NVME_SMART_CRIT_VOLATILE_MEMORY =3D 1 << 4, + NVME_SMART_CRIT_PMR_UNRELIABLE =3D 1 << 5, }; =20 enum { --=20 2.20.1 From nobody Fri May 8 08:23:30 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8492DC433EF for ; Sat, 7 May 2022 06:54:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1445943AbiEGG6V (ORCPT ); Sat, 7 May 2022 02:58:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1445902AbiEGG6P (ORCPT ); Sat, 7 May 2022 02:58:15 -0400 Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E42995DE42 for ; Fri, 6 May 2022 23:54:29 -0700 (PDT) Received: by mail-pj1-x1033.google.com with SMTP id e24so8869889pjt.2 for ; Fri, 06 May 2022 23:54:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RRa4965RJ8y32BByKAGeELe6oxXld3+6IanDwJTYWnY=; b=xNQKDdJP4WbwJcuJABhBBVkZABgGtp/lIpUgcfm4U35ypS+0RPtYoa7EyuOaUS0e99 5Q5J1qXVN8JrP3Xb1ZYvXZCKvfJiuFGO5eoZDsVx11rO2LvAEXtz9xt0qTLksGz/L4k4 9eKTTxI2lJR+mi65seLq0E2Q9l5H+VhaXY8SkhgOPvxWWfe4BKYuQfJCieuJ1x0kuYjC jeIKxfLH8Fz8iZLmkAWbkbH9AG8zdYR2ESnXCSOHsnU+iCzCWj5Vi7r5jDXBpopFHyVj 65QaL1taLk1grCv16rfwwrFqoakS5TagNUPQ7Gc22lvIGeuH7TNZK5bAQtQP8L58ebyv MLhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RRa4965RJ8y32BByKAGeELe6oxXld3+6IanDwJTYWnY=; b=1Evx711SHBmXPbv6Ys8bMqSlyJ5V0ZsWdcX6M1tVYigZOzCHTBHXoyeqCV2bNurm73 VdxpIiOO20xNdaInsEV1vAEM1Ijk0pvFAItmHPnTBnzMdkDiNaAdcLYKRWo+qQBwIf90 ozCASNd70j3VyP1pWhv5+s6C0rvx/WAjAtIXGdT4vRE/ZQcETvBddA8Bb56z5Thl/tDo hsrNbti72vEKTb5lenhxc4/zyrc89og8sorcQMveagzQX9oAmaesG/gmnYCLBQRQlNvH DUKAIFdnvgjJwgRiaU8YeMmqtJ+qqN+wXSgYlmWjJZwJF4sryQibEJye7AXuAZLyht6W 4SBw== X-Gm-Message-State: AOAM530s8JMCsQdaAs88cVqSaPS0ULb+6nRRyCQh9pzBg+m1Hz+cxxQz RMUX9hyh0bPMiDnN7cT6xqoIvBqo5N4hiA== X-Google-Smtp-Source: ABdhPJy+ytxstxUEpu8mNGXpx9L/zPq4dqAsHosZjVqYEE5lXWnzQpcO+5TlDLudLY7n4T8N+OY7KQ== X-Received: by 2002:a17:90b:38cd:b0:1dc:1ebe:2c6c with SMTP id nn13-20020a17090b38cd00b001dc1ebe2c6cmr8313033pjb.149.1651906469423; Fri, 06 May 2022 23:54:29 -0700 (PDT) Received: from always-x1.www.tendawifi.com ([139.177.225.239]) by smtp.gmail.com with ESMTPSA id y20-20020a1709027c9400b0015e8d4eb1ebsm2905162pll.53.2022.05.06.23.54.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 May 2022 23:54:28 -0700 (PDT) From: zhenwei pi To: kbusch@kernel.org, hch@lst.de Cc: sagi@grimberg.me, axboe@fb.com, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, zhenwei pi Subject: [PATCH 2/3] nvme: introduce smart bits of aen cfg Date: Sat, 7 May 2022 14:50:25 +0800 Message-Id: <20220507065026.260306-3-pizhenwei@bytedance.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220507065026.260306-1-pizhenwei@bytedance.com> References: <20220507065026.260306-1-pizhenwei@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" According to NVM Express v1.4, Section 5.21.1.11 (Asynchronous Event Configuration), introduce bit 0 ~ bit 5. Signed-off-by: zhenwei pi --- include/linux/nvme.h | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/include/linux/nvme.h b/include/linux/nvme.h index 882ad7523127..e9f1563ab878 100644 --- a/include/linux/nvme.h +++ b/include/linux/nvme.h @@ -688,10 +688,21 @@ enum { }; =20 enum { - NVME_AEN_CFG_NS_ATTR =3D 1 << NVME_AEN_BIT_NS_ATTR, - NVME_AEN_CFG_FW_ACT =3D 1 << NVME_AEN_BIT_FW_ACT, - NVME_AEN_CFG_ANA_CHANGE =3D 1 << NVME_AEN_BIT_ANA_CHANGE, - NVME_AEN_CFG_DISC_CHANGE =3D 1 << NVME_AEN_BIT_DISC_CHANGE, + /* + * NVMe SPEC 1.4: 5.21.1.11 Asynchronous Event Configuration + * bits 07:00: SMART / Health Critical Warnings + */ + NVME_AEN_CFG_SMART_CRIT_SPARE =3D NVME_SMART_CRIT_SPARE, + NVME_AEN_CFG_SMART_CRIT_TEMPERATURE =3D NVME_SMART_CRIT_TEMPERATURE, + NVME_AEN_CFG_SMART_CRIT_RELIABILITY =3D NVME_SMART_CRIT_RELIABILITY, + NVME_AEN_CFG_SMART_CRIT_MEDIA =3D NVME_SMART_CRIT_MEDIA, + NVME_AEN_CFG_SMART_CRIT_VOLATILE_MEMORY =3D NVME_SMART_CRIT_VOLATILE_MEMO= RY, + NVME_AEN_CFG_SMART_CRIT_PMR_UNRELIABLE =3D NVME_SMART_CRIT_PMR_UNRELIABLE, + + NVME_AEN_CFG_NS_ATTR =3D 1 << NVME_AEN_BIT_NS_ATTR, + NVME_AEN_CFG_FW_ACT =3D 1 << NVME_AEN_BIT_FW_ACT, + NVME_AEN_CFG_ANA_CHANGE =3D 1 << NVME_AEN_BIT_ANA_CHANGE, + NVME_AEN_CFG_DISC_CHANGE =3D 1 << NVME_AEN_BIT_DISC_CHANGE, }; =20 struct nvme_lba_range_type { --=20 2.20.1 From nobody Fri May 8 08:23:30 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A442C433EF for ; Sat, 7 May 2022 06:54:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1445948AbiEGG6Z (ORCPT ); Sat, 7 May 2022 02:58:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1445927AbiEGG6S (ORCPT ); Sat, 7 May 2022 02:58:18 -0400 Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73DA95DD0C for ; Fri, 6 May 2022 23:54:33 -0700 (PDT) Received: by mail-pj1-x1033.google.com with SMTP id e24so8869889pjt.2 for ; Fri, 06 May 2022 23:54:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Ea/7f8A4NPQmZCTH61ttxUc8ZcgpbXzjfNgGF4s2Ed8=; b=HV26AlNcvQjy5U6VCD2LyHjl66aup0wiyAv9NbIbjwNj4A5rzlYWDAopGzbQlgCHfn Vtt3dcN9sXGKfTkYkc45A3mkD7SLE8qP5yBaZOcWvPOpXLl0pCde87ILhrDTavB7RPHY 1WZgvdHqkKBBHxxDGvd7vOWgSCxEQE23wKXyC9XTKCg4WvSIitFpgtQjpdLZxsUfw8Bo gJaSFkbXfhu52lZKOthl/9Q010pvSdraynadbyaEs6C153grIWgpOiu8ShONZIwTrJZE D3VR55j8kTGmwxu/muldSinB74Z7u0/9P0we/UsSBfPy1k+xOb4ZIWEyTs+J1RcQlIzE VrHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Ea/7f8A4NPQmZCTH61ttxUc8ZcgpbXzjfNgGF4s2Ed8=; b=5lnY2U75AhA1cPhxdm74kFd2Q0/1Es/ZeLYJHtd91mfAOUY2p/qWyHe26pjpJouKJl O1A5qs5EbQmOf4jQkFEjlHI04WPjypyBMUoX7S+8889Z9j4ceEMu89JcbyyYwBCHfv04 SYRVkWh+/PLbw6JX3U2cEpBG/COwA+c1WLcQLELsPMVEFhmntdQNtOXz2SPWM+1NmTHR M0tnQh1DM91W8ZEpFL/CLh8pwukvG88NQII4j4Nt8BW5ZksBZp9gUAkHr9O4KXkUmqHO iDAevT0mQ+jyxhw9zviQlOJIcOdUj7pzxFglenyxA24CPg3PwxhoBDX7oA1o5jQ01xF5 c16Q== X-Gm-Message-State: AOAM530XAUkE5qjFt2y7XYQJUVq+eyCN9hdIZ6pNPOuujneLdsQ4/EHZ RZXizZa7qP7x/7pCL5Cked0WwU4TWuVLZg== X-Google-Smtp-Source: ABdhPJwVFbDKu1C1H66AqhkbJbo0SmUKfhgk9fiE1NUon3vtipkhLVIjMHrAkhfw3aRf2T0XRpo4oA== X-Received: by 2002:a17:902:e742:b0:15e:9a7b:24c3 with SMTP id p2-20020a170902e74200b0015e9a7b24c3mr7311641plf.17.1651906473207; Fri, 06 May 2022 23:54:33 -0700 (PDT) Received: from always-x1.www.tendawifi.com ([139.177.225.239]) by smtp.gmail.com with ESMTPSA id y20-20020a1709027c9400b0015e8d4eb1ebsm2905162pll.53.2022.05.06.23.54.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 May 2022 23:54:32 -0700 (PDT) From: zhenwei pi To: kbusch@kernel.org, hch@lst.de Cc: sagi@grimberg.me, axboe@fb.com, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, zhenwei pi Subject: [PATCH 3/3] nvme: enable smart AEN Date: Sat, 7 May 2022 14:50:26 +0800 Message-Id: <20220507065026.260306-4-pizhenwei@bytedance.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220507065026.260306-1-pizhenwei@bytedance.com> References: <20220507065026.260306-1-pizhenwei@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Try to enable AEN on host side, this is helpful to minitor the critical warning from the NVMe controller. Signed-off-by: zhenwei pi --- drivers/nvme/host/core.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index e1846d04817f..f386a4f1d434 100644 --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -1490,8 +1490,12 @@ int nvme_set_queue_count(struct nvme_ctrl *ctrl, int= *count) } EXPORT_SYMBOL_GPL(nvme_set_queue_count); =20 +#define NVME_AEN_SMART \ + (NVME_AEN_CFG_SMART_CRIT_SPARE | NVME_AEN_CFG_SMART_CRIT_TEMPERATURE | \ + NVME_AEN_CFG_SMART_CRIT_RELIABILITY | NVME_AEN_CFG_SMART_CRIT_MEDIA | \ + NVME_AEN_CFG_SMART_CRIT_VOLATILE_MEMORY | NVME_AEN_CFG_SMART_CRIT_PMR_UN= RELIABLE) #define NVME_AEN_SUPPORTED \ - (NVME_AEN_CFG_NS_ATTR | NVME_AEN_CFG_FW_ACT | \ + (NVME_AEN_SMART | NVME_AEN_CFG_NS_ATTR | NVME_AEN_CFG_FW_ACT | \ NVME_AEN_CFG_ANA_CHANGE | NVME_AEN_CFG_DISC_CHANGE) =20 static void nvme_enable_aen(struct nvme_ctrl *ctrl) --=20 2.20.1