dmaengine: plx_dma: Move spin_lock_bh() to spin_lock()

[PATCH] dmaengine: plx_dma: Move spin_lock_bh() to spin_lock()

Posted by Yunbo Yu 4 years, 2 months ago

It is unnecessary to call spin_lock_bh() for you are already in a tasklet.

Signed-off-by: Yunbo Yu <yuyunbo519@gmail.com>
---
 drivers/dma/plx_dma.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/dma/plx_dma.c b/drivers/dma/plx_dma.c
index 1ffcb5ca9788..12725fa1655f 100644
--- a/drivers/dma/plx_dma.c
+++ b/drivers/dma/plx_dma.c
@@ -137,7 +137,7 @@ static void plx_dma_process_desc(struct plx_dma_dev *plxdev)
 	struct plx_dma_desc *desc;
 	u32 flags;
 
-	spin_lock_bh(&plxdev->ring_lock);
+	spin_lock(&plxdev->ring_lock);
 
 	while (plxdev->tail != plxdev->head) {
 		desc = plx_dma_get_desc(plxdev, plxdev->tail);
@@ -165,7 +165,7 @@ static void plx_dma_process_desc(struct plx_dma_dev *plxdev)
 		plxdev->tail++;
 	}
 
-	spin_unlock_bh(&plxdev->ring_lock);
+	spin_unlock(&plxdev->ring_lock);
 }
 
 static void plx_dma_abort_desc(struct plx_dma_dev *plxdev)
-- 
2.25.1

Re: [PATCH] dmaengine: plx_dma: Move spin_lock_bh() to spin_lock()

Posted by Vinod Koul 4 years, 1 month ago

On 18-04-22, 22:20, Yunbo Yu wrote:
> It is unnecessary to call spin_lock_bh() for you are already in a tasklet.

call spin_lock_bh() if you are already in a ..


With that fixed, applied. Thanks
> 
> Signed-off-by: Yunbo Yu <yuyunbo519@gmail.com>
> ---
>  drivers/dma/plx_dma.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/plx_dma.c b/drivers/dma/plx_dma.c
> index 1ffcb5ca9788..12725fa1655f 100644
> --- a/drivers/dma/plx_dma.c
> +++ b/drivers/dma/plx_dma.c
> @@ -137,7 +137,7 @@ static void plx_dma_process_desc(struct plx_dma_dev *plxdev)
>  	struct plx_dma_desc *desc;
>  	u32 flags;
>  
> -	spin_lock_bh(&plxdev->ring_lock);
> +	spin_lock(&plxdev->ring_lock);
>  
>  	while (plxdev->tail != plxdev->head) {
>  		desc = plx_dma_get_desc(plxdev, plxdev->tail);
> @@ -165,7 +165,7 @@ static void plx_dma_process_desc(struct plx_dma_dev *plxdev)
>  		plxdev->tail++;
>  	}
>  
> -	spin_unlock_bh(&plxdev->ring_lock);
> +	spin_unlock(&plxdev->ring_lock);
>  }
>  
>  static void plx_dma_abort_desc(struct plx_dma_dev *plxdev)
> -- 
> 2.25.1

-- 
~Vinod

Re: [PATCH] dmaengine: plx_dma: Move spin_lock_bh() to spin_lock()

Posted by Logan Gunthorpe 4 years, 2 months ago


On 2022-04-18 08:20, Yunbo Yu wrote:
> It is unnecessary to call spin_lock_bh() for you are already in a tasklet.
> 
> Signed-off-by: Yunbo Yu <yuyunbo519@gmail.com>

Ah, thanks!

Reviewed-by: Logan Gunthorpe <logang@deltatee.com>

> ---
>  drivers/dma/plx_dma.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/plx_dma.c b/drivers/dma/plx_dma.c
> index 1ffcb5ca9788..12725fa1655f 100644
> --- a/drivers/dma/plx_dma.c
> +++ b/drivers/dma/plx_dma.c
> @@ -137,7 +137,7 @@ static void plx_dma_process_desc(struct plx_dma_dev *plxdev)
>  	struct plx_dma_desc *desc;
>  	u32 flags;
>  
> -	spin_lock_bh(&plxdev->ring_lock);
> +	spin_lock(&plxdev->ring_lock);
>  
>  	while (plxdev->tail != plxdev->head) {
>  		desc = plx_dma_get_desc(plxdev, plxdev->tail);
> @@ -165,7 +165,7 @@ static void plx_dma_process_desc(struct plx_dma_dev *plxdev)
>  		plxdev->tail++;
>  	}
>  
> -	spin_unlock_bh(&plxdev->ring_lock);
> +	spin_unlock(&plxdev->ring_lock);
>  }
>  
>  static void plx_dma_abort_desc(struct plx_dma_dev *plxdev)