From nobody Thu Jun 18 17:22:54 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0EF2C433F5 for ; Mon, 18 Apr 2022 15:20:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345335AbiDRPXK (ORCPT ); Mon, 18 Apr 2022 11:23:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33490 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345448AbiDRPWh (ORCPT ); Mon, 18 Apr 2022 11:22:37 -0400 Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com [IPv6:2607:f8b0:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 99C8AD64D4; Mon, 18 Apr 2022 07:20:25 -0700 (PDT) Received: by mail-pg1-x535.google.com with SMTP id j71so5622082pge.11; Mon, 18 Apr 2022 07:20:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ccR/mnwveIJy1+ZaW/EVppjy7Ucpakkl1UjrV+8YXAk=; b=XEiadJDP5pRoh9TElIIjDpGwvXHzinAi+cZWXrgMmFKiX356STHcLvNbO/c4ZXqYR+ Knr6EZeYjIYRu+IGA4188A6O5jEjDX+gUVdW9aHQQlKjhWwpyR56ED5Vp8stWXA4J1ak 8AHGY95ejcUuPKxQJ1d+az7rMgzmOIpfUxg2dgkIvTXy+XBlc1r3waKeAPgceGMgZ7mg puYi4vLQaxF1WxYlH6DaagWeva2/CIpCKVWQNfy+fjeue2xiKePqXJgpnSzW2mH1gbJE oTccNo7N0WvpV3hPRzj37uMo0R6+5UHRTP0CT34GEOwDNcTdxLBet0zw5PCYmFZjPFM4 wEPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ccR/mnwveIJy1+ZaW/EVppjy7Ucpakkl1UjrV+8YXAk=; b=7fEOISAzpKMNi3Kfp4ZYYp++bpV7TZ9q+EByBMjbDcEivS7VV1+Gcv4w4KCJNMvLLB wFb4sXwti+Pe7lyxeQ1OQbNLqojmFtICsbX/v7ISY80krrkv8qTguTSKw+vCLMqOSnV+ WxMHajkQpo0pRZAPHUFepslWZQ3Acri5MdshwbUUG44Yxd2Y7l/yApDxW/ggEgBAhw1d gvG2D0m8si05T9mUle+x9shahDGtc8E7is26qW4CDecsc+7cuAokxqm09PrCxw6afPBC 1NIfUt+kjmZfAP2pzYuRMas2nBVEn2LHn9Z5jJiQsF5FA5HHdodSf82O0ubpGiiGwpIE yTAg== X-Gm-Message-State: AOAM532h7p+tCBLRal/8Z9JeLEeCzhwkS1WIMY98ugwVEk+B6TQzlHw5 buHi9c8PdEidYZ5H0EUt+bneZWgP5ZJhB/NQyVs= X-Google-Smtp-Source: ABdhPJz9os8jYLIPcOuVijLhtTg5dh1Z5J9eTsNjGg6jB1Kc2u6VraFunUrIqz9QmP5si3ls5lZ3OA== X-Received: by 2002:a05:6a00:1310:b0:4ca:cc46:20c7 with SMTP id j16-20020a056a00131000b004cacc4620c7mr12720042pfu.44.1650291624922; Mon, 18 Apr 2022 07:20:24 -0700 (PDT) Received: from localhost ([210.21.229.138]) by smtp.gmail.com with ESMTPSA id y15-20020a17090a1f4f00b001c7ecaf9e13sm13425938pjy.35.2022.04.18.07.20.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Apr 2022 07:20:24 -0700 (PDT) From: Yunbo Yu To: logang@deltatee.com, vkoul@kernel.org Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Yunbo Yu Subject: [PATCH] dmaengine: plx_dma: Move spin_lock_bh() to spin_lock() Date: Mon, 18 Apr 2022 22:20:21 +0800 Message-Id: <20220418142021.1241558-1-yuyunbo519@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" It is unnecessary to call spin_lock_bh() for you are already in a tasklet. Signed-off-by: Yunbo Yu Reviewed-by: Logan Gunthorpe --- drivers/dma/plx_dma.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/dma/plx_dma.c b/drivers/dma/plx_dma.c index 1ffcb5ca9788..12725fa1655f 100644 --- a/drivers/dma/plx_dma.c +++ b/drivers/dma/plx_dma.c @@ -137,7 +137,7 @@ static void plx_dma_process_desc(struct plx_dma_dev *pl= xdev) struct plx_dma_desc *desc; u32 flags; =20 - spin_lock_bh(&plxdev->ring_lock); + spin_lock(&plxdev->ring_lock); =20 while (plxdev->tail !=3D plxdev->head) { desc =3D plx_dma_get_desc(plxdev, plxdev->tail); @@ -165,7 +165,7 @@ static void plx_dma_process_desc(struct plx_dma_dev *pl= xdev) plxdev->tail++; } =20 - spin_unlock_bh(&plxdev->ring_lock); + spin_unlock(&plxdev->ring_lock); } =20 static void plx_dma_abort_desc(struct plx_dma_dev *plxdev) --=20 2.25.1