[PATCH v2 0/8] staging: r8188eu: fix and clean up some firmware code

Michael Straube posted 8 patches 4 years, 2 months ago
There is a newer version of this series
drivers/staging/r8188eu/core/rtw_fw.c | 77 ++++++++++-----------------
1 file changed, 28 insertions(+), 49 deletions(-)
[PATCH v2 0/8] staging: r8188eu: fix and clean up some firmware code
Posted by Michael Straube 4 years, 2 months ago
This series fixes wrong size of struct rt_firmware_hdr in the first
patch and does some cleanups in rtl8188e_firmware_download() in the
other patches.

Tested on x86_64 with Inter-Tech DMG-02.

v2:
Added a patch to check size of struct rt_firmware_hdr at compile time.

Michael Straube (8):
  staging: r8188eu: fix struct rt_firmware_hdr
  staging: r8188eu: clean up comments in struct rt_firmware_hdr
  staging: r8188eu: rename fields of struct rt_firmware_hdr
  staging: r8188eu: use sizeof instead of hardcoded firmware header size
  staging: r8188eu: remove variables from rtl8188e_firmware_download()
  staging: r8188eu: always log firmware info
  staging: r8188eu: check firmware header existence before access
  staging: r8188eu: check rt_firmware_hdr size at compile time

 drivers/staging/r8188eu/core/rtw_fw.c | 77 ++++++++++-----------------
 1 file changed, 28 insertions(+), 49 deletions(-)

-- 
2.35.1
Re: [PATCH v2 0/8] staging: r8188eu: fix and clean up some firmware code
Posted by Larry Finger 4 years, 2 months ago
On 4/14/22 05:43, Michael Straube wrote:
> This series fixes wrong size of struct rt_firmware_hdr in the first
> patch and does some cleanups in rtl8188e_firmware_download() in the
> other patches.
> 
> Tested on x86_64 with Inter-Tech DMG-02.
> 
> v2:
> Added a patch to check size of struct rt_firmware_hdr at compile time.

Please wait a while before submitting new versions until those of us in time 
zones further west get a chance. My objections to the logging change still apply.

NACK

Larry