On 4/17/22 12:54, Michael Straube wrote:
> This series fixes wrong size of struct rt_firmware_hdr in the first
> patch and does some cleanups in rtl8188e_firmware_download() in the
> other patches.
>
> Tested on x86_64 with Inter-Tech DMG-02.
>
> v4:
> - Keep the in-line comments of struct rt_firmware_hdr.
>
> v3:
> - Splitted the first patch into two separate patches.
> - Added back logging the firmware version only once.
> - Included the compile time check for size of rt_firmware_hdr from
> patch 8/8 of v2 in the patch that replaces the hardcoded size.
>
> v2:
> - Added a patch to check size of struct rt_firmware_hdr at compile time.
>
> Michael Straube (8):
> staging: r8188eu: fix struct rt_firmware_hdr
> staging: r8188eu: convert u32 fields of rt_firmware_hdr to __le32
> staging: r8188eu: clean up comments in struct rt_firmware_hdr
> staging: r8188eu: rename fields of struct rt_firmware_hdr
> staging: r8188eu: use sizeof instead of hardcoded firmware header size
> staging: r8188eu: remove variables from rtl8188e_firmware_download()
> staging: r8188eu: use pr_info_once() to log the firmware version
> staging: r8188eu: check firmware header existence before access
>
> drivers/staging/r8188eu/core/rtw_fw.c | 84 +++++++++++----------------
> 1 file changed, 34 insertions(+), 50 deletions(-)
It has been a bit of effort, but I have no comments on this version.
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Big improvement,
Larry