[v3] clocksource/drivers/timer-microchip-pit64b: fixes and improvements

[PATCH v3 0/6] clocksource/drivers/timer-microchip-pit64b: fixes and improvements

Posted by Claudiu Beznea 4 years, 3 months ago

Hi,

The series adds one fix and few improvement for PIT64B timer. Patch 1/7
was initially posted at [1].

Thank you,
Claudiu Beznea

[1] https://lore.kernel.org/lkml/20210707054415.92832-1-claudiu.beznea@microchip.com/

Changes in v3:
- removed patch "clocksource/drivers/timer-microchip-pit64b: remove timer-of depenency"
  as it breaks build on other platforms
- adapt patch 6/6 to comply with kernel-doc specification

Changes in v2:
- removed patch 5/7 "clocksource/drivers/timer-microchip-pit64b: add delay timer"
  to avoid compilation errors on non ARM platforms; will re-introduce it after
  a bit of rework on AT91 specific Kconfig
- added patch "clocksource/drivers/timer-microchip-pit64b: fix compilation warnings"
- in patch "clocksource/drivers/timer-microchip-pit64b: use mchp_pit64b_{suspend,
  resume}" remove gclk_unprepare, pclk_unprepare labels and code under them


Claudiu Beznea (6):
  clocksource/drivers/timer-microchip-pit64b: remove mmio selection
  clocksource/drivers/timer-microchip-pit64b: use notrace
  clocksource/drivers/timer-microchip-pit64b: use 5MHz for clockevent
  clocksource/drivers/timer-microchip-pit64b: remove suspend/resume ops
    for ce
  clocksource/drivers/timer-microchip-pit64b: use mchp_pit64b_{suspend,
    resume}
  clocksource/drivers/timer-microchip-pit64b: fix compilation warnings

 drivers/clocksource/Kconfig                  |  1 -
 drivers/clocksource/timer-microchip-pit64b.c | 72 ++++++++------------
 2 files changed, 30 insertions(+), 43 deletions(-)

-- 
2.32.0

Re: [PATCH v3 0/6] clocksource/drivers/timer-microchip-pit64b: fixes and improvements

Posted by Daniel Lezcano 4 years, 3 months ago

Hi Claudiu,

I would like to pick patches 1,2,3 but not the others one because I'm 
not convinced about the suspend / resume changes and need some time to 
think about it.

   -- D.


On 04/03/2022 14:35, Claudiu Beznea wrote:
> Hi,
> 
> The series adds one fix and few improvement for PIT64B timer. Patch 1/7
> was initially posted at [1].
> 
> Thank you,
> Claudiu Beznea
> 
> [1] https://lore.kernel.org/lkml/20210707054415.92832-1-claudiu.beznea@microchip.com/
> 
> Changes in v3:
> - removed patch "clocksource/drivers/timer-microchip-pit64b: remove timer-of depenency"
>    as it breaks build on other platforms
> - adapt patch 6/6 to comply with kernel-doc specification
> 
> Changes in v2:
> - removed patch 5/7 "clocksource/drivers/timer-microchip-pit64b: add delay timer"
>    to avoid compilation errors on non ARM platforms; will re-introduce it after
>    a bit of rework on AT91 specific Kconfig
> - added patch "clocksource/drivers/timer-microchip-pit64b: fix compilation warnings"
> - in patch "clocksource/drivers/timer-microchip-pit64b: use mchp_pit64b_{suspend,
>    resume}" remove gclk_unprepare, pclk_unprepare labels and code under them
> 
> 
> Claudiu Beznea (6):
>    clocksource/drivers/timer-microchip-pit64b: remove mmio selection
>    clocksource/drivers/timer-microchip-pit64b: use notrace
>    clocksource/drivers/timer-microchip-pit64b: use 5MHz for clockevent
>    clocksource/drivers/timer-microchip-pit64b: remove suspend/resume ops
>      for ce
>    clocksource/drivers/timer-microchip-pit64b: use mchp_pit64b_{suspend,
>      resume}
>    clocksource/drivers/timer-microchip-pit64b: fix compilation warnings
> 
>   drivers/clocksource/Kconfig                  |  1 -
>   drivers/clocksource/timer-microchip-pit64b.c | 72 ++++++++------------
>   2 files changed, 30 insertions(+), 43 deletions(-)
> 


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

Re: [PATCH v3 0/6] clocksource/drivers/timer-microchip-pit64b: fixes and improvements

Posted by Claudiu.Beznea@microchip.com 4 years, 3 months ago

On 04.03.2022 21:46, Daniel Lezcano wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
> 
> Hi Claudiu,
> 
> I would like to pick patches 1,2,3 but not the others one because I'm
> not convinced about the suspend / resume changes and need some time to
> think about it.
Hi Daniel,

Sure!

Just to let you know, I've tested it on suspend/resume scenarios (some of
the scenarios were cutting down the power to PIT64B blocks) and on a system
having both PIT64B and ARM generic timer enabled.

Thank you,
Claudiu Beznea

> 
>   -- D.
> 
> 
> On 04/03/2022 14:35, Claudiu Beznea wrote:
>> Hi,
>>
>> The series adds one fix and few improvement for PIT64B timer. Patch 1/7
>> was initially posted at [1].
>>
>> Thank you,
>> Claudiu Beznea
>>
>> [1]
>> https://lore.kernel.org/lkml/20210707054415.92832-1-claudiu.beznea@microchip.com/
>>
>>
>> Changes in v3:
>> - removed patch "clocksource/drivers/timer-microchip-pit64b: remove
>> timer-of depenency"
>>    as it breaks build on other platforms
>> - adapt patch 6/6 to comply with kernel-doc specification
>>
>> Changes in v2:
>> - removed patch 5/7 "clocksource/drivers/timer-microchip-pit64b: add
>> delay timer"
>>    to avoid compilation errors on non ARM platforms; will re-introduce it
>> after
>>    a bit of rework on AT91 specific Kconfig
>> - added patch "clocksource/drivers/timer-microchip-pit64b: fix
>> compilation warnings"
>> - in patch "clocksource/drivers/timer-microchip-pit64b: use
>> mchp_pit64b_{suspend,
>>    resume}" remove gclk_unprepare, pclk_unprepare labels and code under them
>>
>>
>> Claudiu Beznea (6):
>>    clocksource/drivers/timer-microchip-pit64b: remove mmio selection
>>    clocksource/drivers/timer-microchip-pit64b: use notrace
>>    clocksource/drivers/timer-microchip-pit64b: use 5MHz for clockevent
>>    clocksource/drivers/timer-microchip-pit64b: remove suspend/resume ops
>>      for ce
>>    clocksource/drivers/timer-microchip-pit64b: use mchp_pit64b_{suspend,
>>      resume}
>>    clocksource/drivers/timer-microchip-pit64b: fix compilation warnings
>>
>>   drivers/clocksource/Kconfig                  |  1 -
>>   drivers/clocksource/timer-microchip-pit64b.c | 72 ++++++++------------
>>   2 files changed, 30 insertions(+), 43 deletions(-)
>>
> 
> 
> -- 
> <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
> 
> Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
> <http://twitter.com/#!/linaroorg> Twitter |
> <http://www.linaro.org/linaro-blog/> Blog