Hi,

This is V2, find V1 here:
https://lore.kernel.org/all/1764054776-1308696-1-git-send-email-tariqt@nvidia.com/

This series by Shahar introduces a new helper function
netif_xmit_timeout_ms() to check if a TX queue has timed out and report
the timeout duration.
It also encapsulates the check for whether the TX queue is stopped.

Replace duplicated open-coded timeout check in hns3 driver with the new
helper.

For mlx5e, refine the TX timeout recovery flow to act only on SQs whose
transmit timestamp indicates an actual timeout, as determined by the
helper. This prevents unnecessary channel reopen events caused by
attempting recovery on queues that are merely stopped but not truly
timed out.

Regards,
Tariq

V2:
- Rebase.
- Move helper to include/net/netdev_queues.h.
- Remove output paramter trans_start from the new helper.
- Revert the code in dev_watchdog to not use the helper.
- Fix the helper name in commit message.

Shahar Shitrit (3):
  net: Introduce netif_xmit_timeout_ms() helper
  net: hns3: Use netif_xmit_timeout_ms() helper
  net/mlx5e: Refine TX timeout handling to skip non-timed-out SQ

 drivers/net/ethernet/hisilicon/hns3/hns3_enet.c   | 12 +++++-------
 drivers/net/ethernet/mellanox/mlx5/core/en_main.c |  2 +-
 include/net/netdev_queues.h                       | 11 +++++++++++
 3 files changed, 17 insertions(+), 8 deletions(-)


base-commit: 60d8484c4cec811f5ceb6550655df74490d1a165
-- 
2.31.1

On Mon, Jan 12, 2026 at 11:16:20AM +0200, Tariq Toukan wrote:
> Hi,
> 
> This is V2, find V1 here:
> https://lore.kernel.org/all/1764054776-1308696-1-git-send-email-tariqt@nvidia.com/
> 
> This series by Shahar introduces a new helper function
> netif_xmit_timeout_ms() to check if a TX queue has timed out and report
> the timeout duration.
> It also encapsulates the check for whether the TX queue is stopped.
> 
> Replace duplicated open-coded timeout check in hns3 driver with the new
> helper.
> 
> For mlx5e, refine the TX timeout recovery flow to act only on SQs whose
> transmit timestamp indicates an actual timeout, as determined by the
> helper. This prevents unnecessary channel reopen events caused by
> attempting recovery on queues that are merely stopped but not truly
> timed out.
> 
> Regards,
> Tariq
> 
> V2:
> - Rebase.
> - Move helper to include/net/netdev_queues.h.
> - Remove output paramter trans_start from the new helper.
> - Revert the code in dev_watchdog to not use the helper.
> - Fix the helper name in commit message.

Thanks for the updates.
I agree the address the review of v1.
And, overall, this looks good to me.

Reviewed-by: Simon Horman <horms@kernel.org>