From nobody Sat Feb 7 13:05:34 2026 Received: from SA9PR02CU001.outbound.protection.outlook.com (mail-southcentralusazon11013026.outbound.protection.outlook.com [40.93.196.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D83BC3254B5; Mon, 12 Jan 2026 09:17:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.196.26 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768209474; cv=fail; b=PRUgAiE+cgiVcioHE+/WHzqJR2oEdQO/E9FMAhG5K4CCVsN2MGDi5e8GNBm36KR4KDHqt2mPylpu+1n0IirzPOCShY98q3CUga1fSefJGJfwjMebOJU87MH/SLR1OYQ/uGV3aYTsxEIqb1ehkoA8NRdzkXQlUGG7cbFp8yBQ9HU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768209474; c=relaxed/simple; bh=6yc94fLBSIgLCeh0omiW65WfHSLtb6xSbSz7nlh4hy8=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=UGuyEdDTxXVfSNt/mPkA7v4s+YQ8Z8GUfgjjxTcCXD684Dskq0GaqXIWiCi9VlhHvu/v5F8cfuwH0u0ro4iQNouPMewcGIeBPyOI5pO3FeA24y9YXN9K5LdYi9/nQpTC9WcXYelGZcTBIxVrW5YdO6xquOB33FMxoPcPPeRvJOY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=uC0mouJV; arc=fail smtp.client-ip=40.93.196.26 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="uC0mouJV" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=g+cMHjPN9gHWYbqCoGeSpgDqKAsqtmFkf6MEKffMzbSaeZ9UHzRlPdKztIMC6ae32JAmQ8J1gnan+1xY5xKv1mVFjDQtI09EheMLWlknWM51E4rNYdCEWMs5rITAUGarCA2BuS5ciBk1mVl6IVpL3MMNz1dC8a1cB33JQNCv9s0rWP7zSPRulGJC0vXRghFXeiiuTXqIpUTO0HmP9AyyCuDYxnUaso2Sn0/n6xCLpzJwgCrAiP/YD3D1MlyvZw/7zhCUhSVpaRYIbdYQ++QOsSfx8h3tNjjlawtke7JGXwG67aOue2uuaOQRgkXQZVpEgUlcHa7QrWRVC8iIy0sOsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nOYo6+zQJmkhCMdubdMkP5ZAj4WEkdGu/y5HNNh46Mc=; b=U7st98qcbp+paQwZCsdiFTrX442yHj59Nt5jJLkadLH8MgkK6ibXaeermN6D24EXvXSEQ7d2C7aMDmb2aH8Ah7QyF2xc1dplVq8wz6l7t6GOvKgX1GfEMFJiIFs0jZufAWtyxFPlkocge4tt/f8kwx+DsBNXjjaTusl4WXldHnEr5pfooNX8bveIIExEy8ZTkOvAGUm2N/hCO7qUzhVR800XoRGJf9FE1f7mRMVr2/6EC4E0XLGkJtXBnigRDKkUdWuifl4fRji5qBO8ZgJEK6j1T5tmf8YJGwHX3WF4jEY8ywAPR8gaKJfzqFpoBLwK2Kw333ke/ZTbMHyf3QNWjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=google.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nOYo6+zQJmkhCMdubdMkP5ZAj4WEkdGu/y5HNNh46Mc=; b=uC0mouJVlCfmp2/JOigC2JkS3i8MOjvsThvgfLbNZQKPQH5agGmipNXd9XKvTaUwqob4ZuAycPJFcK0ftcDk6AptJvBdClyiRQyLIt2gvV0yoYK4Zh6QVc42YiLdJSFS1sLQw9MYj7bxbE9s06rH9ky82CkIRktxv5OyjRKeSMrsLRIIWGenl0ow65fKEr2LbrAJyGEruaMqqCaATTjs6gZwBmr9XQyIL9kQAg9mFN///ur+ZmnFF+FJvtH+U5eqFSW+v4zHlYF7+hUuRbPq6m1dIZ1QGn+6KoVP76E8f9LPL+QDu7Z4/Z5CZnDM8towCbYzUqDzNHTSwcw8OjHuWQ== Received: from BN9PR03CA0107.namprd03.prod.outlook.com (2603:10b6:408:fd::22) by CY1PR12MB9699.namprd12.prod.outlook.com (2603:10b6:930:108::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9499.7; Mon, 12 Jan 2026 09:17:48 +0000 Received: from BN2PEPF000044A7.namprd04.prod.outlook.com (2603:10b6:408:fd:cafe::f4) by BN9PR03CA0107.outlook.office365.com (2603:10b6:408:fd::22) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9499.7 via Frontend Transport; Mon, 12 Jan 2026 09:17:41 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BN2PEPF000044A7.mail.protection.outlook.com (10.167.243.101) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9520.1 via Frontend Transport; Mon, 12 Jan 2026 09:17:48 +0000 Received: from rnnvmail205.nvidia.com (10.129.68.10) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 12 Jan 2026 01:17:37 -0800 Received: from rnnvmail205.nvidia.com (10.129.68.10) by rnnvmail205.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 12 Jan 2026 01:17:37 -0800 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.129.68.10) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Mon, 12 Jan 2026 01:17:32 -0800 From: Tariq Toukan To: Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , "David S. Miller" CC: Jian Shen , Salil Mehta , Jijie Shao , Saeed Mahameed , "Tariq Toukan" , Mark Bloch , Leon Romanovsky , , , , Gal Pressman , Moshe Shemesh , Shahar Shitrit , Yael Chemla , Jamal Hadi Salim Subject: [PATCH net-next V2 1/3] net: Introduce netif_xmit_timeout_ms() helper Date: Mon, 12 Jan 2026 11:16:21 +0200 Message-ID: <1768209383-1546791-2-git-send-email-tariqt@nvidia.com> X-Mailer: git-send-email 2.8.0 In-Reply-To: <1768209383-1546791-1-git-send-email-tariqt@nvidia.com> References: <1768209383-1546791-1-git-send-email-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN2PEPF000044A7:EE_|CY1PR12MB9699:EE_ X-MS-Office365-Filtering-Correlation-Id: 1f303eb8-0ac5-46b2-9038-08de51bb7437 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|376014|36860700013|7416014|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?VH73Uml378JtJtaioMUl+dnOQEqk59esEwxayxdaGnYF3JiK+k+iXCZHrcc6?= =?us-ascii?Q?U1ybth7LB4PNg8OGu2NfF6p59oNoZX6luhzaiNhGEJn9XJeLxMRQaAtfxA9k?= =?us-ascii?Q?eOMfcYBS5Y2VevgpjXfv3DZD8P9K9unQYob+f1AnwOUz8Nv7Y/EA/yksWccN?= =?us-ascii?Q?CTUjac3M6czzersZHcl4cCT6Z9xSVPxJRpXd5wn+OusPudN2ablQxjCTJZmQ?= =?us-ascii?Q?0NI9nqA1tWMV+yAWHilEVNObsR+NqIiK4O9zQd2VEuialXiwpdKmAT6y0TmT?= =?us-ascii?Q?VxGvzqhk8I92vsQt4s2kNoXizao3XCIjLHh5V1AhCDULqEviRJcwkZhQi0Vh?= =?us-ascii?Q?nGrtyhmLTpcD0X/p7vop5no4T9K4KPTpxNfiwK0X1wASGISE01U/G6jNubzq?= =?us-ascii?Q?8BTCgyj+PM5/lDzPhQyG6wN3yjgMxNgh+2KjQPoFIiWfiWL0AIcQxLlJqAFD?= =?us-ascii?Q?Li7FbGWkHq2OTl/fsa9h+lRkE8Frf7CTdmnPjYs90RfivGjh2jz5LU/BwmAF?= =?us-ascii?Q?c8jd3HQyvSb8UvaJoRYNczecsJSHELxI0/kXRHsjMBXqyY0htpfa/gVgaihy?= =?us-ascii?Q?aWRcnDEdMDCxEQVdehY1jhZGbObm1WUwwjCmsQckTFk7Y+f7A6fnCIHkgjpY?= =?us-ascii?Q?WvfFHrMXxSIenKA+5xPVQ4a4DgVKuqnefQKDmo3xkylwmJ+eVYdE7Pi7TcJH?= =?us-ascii?Q?bKInzwfvOpMsSS7ADnLkkdfu1K2p2hXW8E224FQDJqudJ++bHiUU2iVl0DxN?= =?us-ascii?Q?0VRN+jbF5k+NIOsxV+pMEckf3rHel14zfhwYIjm/Zq4WbCzVYjkpWPJuRlGA?= =?us-ascii?Q?EAcO+HNg6M7mNIOUuZai205C/YnchUDeMrjyrMwPGMtnuPCBJMQi+cLsdo/g?= =?us-ascii?Q?lyeistCzDzljUavALrJQnRtkgnLo1LXHk2ujDgmfTs3o3SkrKK2HLZKBd6cA?= =?us-ascii?Q?7glb+mc0MmSVOosjxLBE0zGSpV/UwU1ebrpGTUIAK6jdECkDRQ4RnGsX14V0?= =?us-ascii?Q?3PVevrPkjJ5VrpcLDjCUvye+x2empSJn7Q25UQ5DC/oePtbRMOCWk5DV3TF2?= =?us-ascii?Q?WErF33ctbpUUbTySsPxVYuntq5QPhm0jfagrXiX6D4nDwmQLKTkd5LmCkcrv?= =?us-ascii?Q?jv8yX4cIbJeFU6pXIF05XSvtSaj9imIMrRJUsGuBlfj+x0jK/PG0S/nkczuA?= =?us-ascii?Q?kw5R5goGdKIFnYCf1viq7iqdoRj35rKDzslIAI63aItr0f0T6BfffqKB9OHX?= =?us-ascii?Q?vdFYzOHr5+3F2VFlBR2EGwhMpEgbonDxU3KBoJpJBZV2oc4eHcZjSA/PnIwD?= =?us-ascii?Q?1vewZh884EdMO4t7a2b4IemkTSRoLd9sA/HqTzqE80bFEKLskttcIvvkHrJk?= =?us-ascii?Q?YiWW1X8V4A75xPjDhjAk7KpGWJ1wSpB0x21haxg1LQXInO6jNuDYqzukv7X2?= =?us-ascii?Q?UE3ngJx8FiK6/GWujqs8hMTsWIelnfIwpv5uc3qEJusOmWngtK8YL2fvwoYb?= =?us-ascii?Q?OB00crHIiIet6zxGPNARMTY63jMjAC+tZKWr+iOQXzxWnUHDGCpGLI0vnQt3?= =?us-ascii?Q?Gj0HVsOvsuRXJtbBorc=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(82310400026)(376014)(36860700013)(7416014)(1800799024);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2026 09:17:48.1847 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1f303eb8-0ac5-46b2-9038-08de51bb7437 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN2PEPF000044A7.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR12MB9699 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Shahar Shitrit Introduce a new helper function netif_xmit_timeout_ms() to check if a TX queue is stopped and has timed out and report the timeout duration. This makes the timeout logic reusable, and will be used in several places in subsequent patches. Signed-off-by: Shahar Shitrit Reviewed-by: Yael Chemla Signed-off-by: Tariq Toukan Reviewed-by: Simon Horman --- include/net/netdev_queues.h | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/include/net/netdev_queues.h b/include/net/netdev_queues.h index cd00e0406cf4..b55d3b9cb9c2 100644 --- a/include/net/netdev_queues.h +++ b/include/net/netdev_queues.h @@ -310,6 +310,17 @@ static inline void netif_subqueue_sent(const struct ne= t_device *dev, netdev_tx_sent_queue(txq, bytes); } =20 +static inline unsigned int netif_xmit_timeout_ms(struct netdev_queue *txq) +{ + unsigned long trans_start =3D READ_ONCE(txq->trans_start); + + if (netif_xmit_stopped(txq) && + time_after(jiffies, trans_start + txq->dev->watchdog_timeo)) + return jiffies_to_msecs(jiffies - trans_start); + + return 0; +} + #define netif_subqueue_maybe_stop(dev, idx, get_desc, stop_thrs, start_thr= s) \ ({ \ struct netdev_queue *_txq; \ --=20 2.31.1 From nobody Sat Feb 7 13:05:34 2026 Received: from BN1PR04CU002.outbound.protection.outlook.com (mail-eastus2azon11010052.outbound.protection.outlook.com [52.101.56.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 666A1339855; Mon, 12 Jan 2026 09:18:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.56.52 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768209482; cv=fail; b=pUx+jAFf7K7Be9Vg5Hc0X7jI9RU7xXsjh3YPn/PZUfuIVj9Ufk3BvbrDdnlyThk/vwo5eG+zgFO7QqtWmFbkQRtDSOtV0LDPxCbwEVzSr2CkJ/zTzm7ls+4wao/W8orqulxztoANiIMuTyXNWVSYTqNDkf+VnKAGvJpQGDkQbKQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768209482; c=relaxed/simple; bh=eFPhaPUK124apg02FdJaZTUIx0psMyiYF47np6imuoA=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=OY6FDSPeUhK5ic6gG89AxgnEy9GOVFPRMGvXAUvpFvECgZNbRMESQO54PLBPPd5oDXBd5Yt5aIhow8SoNSxoTrOku33cn4/vyCGGqi557P4jR2OLQLADyQBaGntflI61a5b5swADuVIVL6gKVE1u8vkq3dUyNypMY5NEQd6f28Q= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=Wa1vEpDB; arc=fail smtp.client-ip=52.101.56.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="Wa1vEpDB" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=aPGJ6pOVCe8KJHvJJHKSqw14Ewbqnreqj+OslWpzOoSJwKfAsQ+hPTZvjOEBRtnmiWiu30mIsNRLZX/7MRWiXp3QHAsqt6M6JbvUY0gpCHrCzL/OsSzdn/8dvUdPgtqcRdyRTbs/qStqOj+BsXvEzabblSQrOpzX/c7IdQ9ySqEqAkGGLDJuqOeYz4wQVRk8t7oFwy3vh6XEqpz/TvhEeKbGMjHfSEObQ15xHlsOs+HyncwjHLFnGWyR7ce51wgu9Ym1UziYUvWg8FxjY/3lTCCiMCTTG4XbjkojLQKJLoV2UPFyT9ugVrqAi3C8PaZqKeGAVOTy8RKqaN4YQACGdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VhYHZjCuCclo7JEjkVbKOq3KSoKZ/VbGkAY5JgtEE98=; b=J5hQg0NJLznipiaQ4DdAyfprv0l2c6gX7pBLRhUsFSpAeAvpX+C2xpnyPftFcTiIN4L2PYftVlPXR6XxUNIfad0fZeVFzOmRXP4O3hjjt40yLwLeT4t+5ktWe3/iTnbSgaHxF8CJhvGmtxyD8syufJm1LVZqfW9cTRAQx6f0cNS4whTArgexXQXgqWYT72ATfoYanvDrhah5Fg6z030v1NM4dCbS8ibtrF2uiA4khJu+QdHeK4zwJrhDUsiTwxXch70d+hQHbx09szfZmCP6D3xcdL1Y6cHrdwYC/f4Jeoz4dCXFj/q5x8P9VOeGoC4Dtwp5jo70TH+iNyA3PWITVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=google.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VhYHZjCuCclo7JEjkVbKOq3KSoKZ/VbGkAY5JgtEE98=; b=Wa1vEpDBwb0UouSfOQmjskEnUOMCzPu9yd5d9w+4j3C0zPH9Zm8Mq9jpk/httCh0MqKOakvVCYwOwB06mcFphRk4NZRhPInQAf/ruZKyOwCepUjIQUf/APLq3PYT9Z/FtvBgNmUU3bDtLSm6/ZNRiMO1RtAxWyVH4vNygfK8Wk05j60RBpP0Z8W3nYZr2j6AWQUffAx0efTGwE+2Rt8DQGWnNfyyiy9BkEgOqq4Q8lCA91LxsXpfS5E2l6DqfBUXUgDTsZoLMu4RNNXlwSqJPsdYIGhNROLbCzpEQDqh7qLWUfSUYKX2pVlD+OEFWaHbpxFEa3ofSIomP9ctirl0Pw== Received: from MN2PR05CA0035.namprd05.prod.outlook.com (2603:10b6:208:c0::48) by MW4PR12MB7119.namprd12.prod.outlook.com (2603:10b6:303:220::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9499.7; Mon, 12 Jan 2026 09:17:55 +0000 Received: from BN2PEPF000044A5.namprd04.prod.outlook.com (2603:10b6:208:c0:cafe::1a) by MN2PR05CA0035.outlook.office365.com (2603:10b6:208:c0::48) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9520.4 via Frontend Transport; Mon, 12 Jan 2026 09:17:52 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BN2PEPF000044A5.mail.protection.outlook.com (10.167.243.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9520.1 via Frontend Transport; Mon, 12 Jan 2026 09:17:54 +0000 Received: from rnnvmail202.nvidia.com (10.129.68.7) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 12 Jan 2026 01:17:42 -0800 Received: from rnnvmail205.nvidia.com (10.129.68.10) by rnnvmail202.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 12 Jan 2026 01:17:42 -0800 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.129.68.10) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Mon, 12 Jan 2026 01:17:37 -0800 From: Tariq Toukan To: Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , "David S. Miller" CC: Jian Shen , Salil Mehta , Jijie Shao , Saeed Mahameed , "Tariq Toukan" , Mark Bloch , Leon Romanovsky , , , , Gal Pressman , Moshe Shemesh , Shahar Shitrit , Yael Chemla , Jamal Hadi Salim Subject: [PATCH net-next V2 2/3] net: hns3: Use netif_xmit_timeout_ms() helper Date: Mon, 12 Jan 2026 11:16:22 +0200 Message-ID: <1768209383-1546791-3-git-send-email-tariqt@nvidia.com> X-Mailer: git-send-email 2.8.0 In-Reply-To: <1768209383-1546791-1-git-send-email-tariqt@nvidia.com> References: <1768209383-1546791-1-git-send-email-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN2PEPF000044A5:EE_|MW4PR12MB7119:EE_ X-MS-Office365-Filtering-Correlation-Id: beb35bd9-96d7-46af-2fdf-08de51bb77e8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|82310400026|36860700013|7416014|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?MtnAGlEwSQzFnB10engxBR9CqrDMjv8sPZKasX9bivf4NoWBp6BQjQeIn0IN?= =?us-ascii?Q?1BuRLX9w40YAH1n/iVJedNcaFUPZ/G/J3qfUNw1z8qAwRWjvF7WKNgoWe4Pw?= =?us-ascii?Q?zmRNA7D9clCIj0CMZG+4NivHYD0rWtLiGFWmCicqfM/hPSx20MgCs0dUUpAy?= =?us-ascii?Q?Gokpb4CfxO0ioI4NhXANZCSWJE2f/kpwqW8FFCxUv3uj7Rw76wppKegL5umc?= =?us-ascii?Q?ezfWUDhovoYffViBWuBg8RZh9pfc8N9wbSsCgTSddpS9FE7qZ5d5rnJ9r9Oq?= =?us-ascii?Q?FdGpJY1DVdZv0hEmbBqEhMiUDfO9WTC/kI6mAHyZfsJlXuZFAqv+DOiRArxy?= =?us-ascii?Q?1Pul1lR+rdE112VFqcKwRsnzUUVvExWPFqkH7et1I6vGHM7lsWVI2pB+VnCc?= =?us-ascii?Q?tRuR4nujjdO2wWJMqsjP8wol8Yyvoy7De/GB8fjypxqEFYvOHcL7aJiUhmuO?= =?us-ascii?Q?3uwu382/+CJ3cZy3gVmoKzsmD/xfgbSkNlHoHDnKdkn+7e1bWbe+RIW3N8sY?= =?us-ascii?Q?7p/+X5Wf12zxDNt61FJ9YF3EhsyrLUGnbAJXUo5BCdJv2OdBXKQzayiSLiYP?= =?us-ascii?Q?ealbw4erGczo34xQSEJ43g9uIETMYaM42oyokFBbx/AdfAaIIn4080TIGLJH?= =?us-ascii?Q?EJUjKLkyEXg5SLFjs7b0caATfu3jlZmsMU7Ln68dmf04aTsEZcrQNgy0KB82?= =?us-ascii?Q?KGD+cKPPV9LMzbxRDECpyBZjJqvDG0B5NBJGZjLhkbD1Q5yP8C9tShTcF5Xw?= =?us-ascii?Q?YESw0Xx29axiXYKoRO+QPfVsMBCRdkg8T9vmV0BMtz4IG/wFCzuXeBgSCoCT?= =?us-ascii?Q?cSM3RVpx1uTmmjtm0/WuPL3gItYSrAG/H3stmCkNEC7lE+hVL0ODOfR8a4as?= =?us-ascii?Q?kZnVYcrcG7nw52Z53uH0Wml1B1SRqso816bpMJn3pLQf4IQekpOIFwmE8Ov0?= =?us-ascii?Q?4vlYb6TmWnvR5o1E5bf02+7OnLLu2kYU44bRNE4dPfTSDzXLOxJjjVBIe9vM?= =?us-ascii?Q?tgsKCvrSAHgUzt5NotdrIuhtdhBiTtu8D4oBOlaWHQLdWIHJ3QEPf9HMcDAD?= =?us-ascii?Q?QTkyJ756gRE/xvLAIyFUOhBiMT0vfpQ+r0sddNV1Br138KpiCWwHsJWUJHyl?= =?us-ascii?Q?f4zV+aPT7wv2PV7px4Z0cZ71VC2dSZIU8dtzusExVqi8klH+t8wbKwwz7p86?= =?us-ascii?Q?GSO1LYUlehoNEGWP79N8OYXPKj+NEr/NicAJCDrVt+CK+W2O6dD3hdDv1+f2?= =?us-ascii?Q?BX7GLf5XWA/zMIxrHhn09SG83b1IUVvkFAgpAyBYW2LN8HnRbeOO2Rti6NAL?= =?us-ascii?Q?lHMzltHCgTxev942JmUnXuD3mvYcNDU6C+GVCHEKEa83drxFpasJVDyC8lUW?= =?us-ascii?Q?IzrqjdgIsCPL7Fhp7HUwV9qYGSMqy4NhbN1DPKkQ0lJv4Ar7NtGltOfTDjhG?= =?us-ascii?Q?6VrZOSrdn1UG0K9vCAdBYlpzL5AH/F+dQUKo4g6GTpcUWO2DvW9Zgs0U/9mK?= =?us-ascii?Q?PqSAVdsbhu4RRN16DNkOx4gWtba6ve+iHvoF7xoFZ8AIoeHB2ykFMlZqJl5d?= =?us-ascii?Q?4mkoVTBgsKbZaDlrliw=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(1800799024)(82310400026)(36860700013)(7416014)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2026 09:17:54.3830 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: beb35bd9-96d7-46af-2fdf-08de51bb77e8 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN2PEPF000044A5.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7119 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Shahar Shitrit Replace the open-coded TX queue timeout check in hns3_get_timeout_queue() with a call to netif_xmit_timeout_ms() helper. Signed-off-by: Shahar Shitrit Reviewed-by: Yael Chemla Signed-off-by: Tariq Toukan Reviewed-by: Jijie Shao Reviewed-by: Simon Horman --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/= ethernet/hisilicon/hns3/hns3_enet.c index 7a0654e2d3dd..7b9269f6fdfc 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c @@ -25,6 +25,7 @@ #include #include #include +#include =20 #include "hnae3.h" #include "hns3_enet.h" @@ -2807,14 +2808,12 @@ static int hns3_get_timeout_queue(struct net_device= *ndev) =20 /* Find the stopped queue the same way the stack does */ for (i =3D 0; i < ndev->num_tx_queues; i++) { + unsigned int timedout_ms; struct netdev_queue *q; - unsigned long trans_start; =20 q =3D netdev_get_tx_queue(ndev, i); - trans_start =3D READ_ONCE(q->trans_start); - if (netif_xmit_stopped(q) && - time_after(jiffies, - (trans_start + ndev->watchdog_timeo))) { + timedout_ms =3D netif_xmit_timeout_ms(q); + if (timedout_ms) { #ifdef CONFIG_BQL struct dql *dql =3D &q->dql; =20 @@ -2823,8 +2822,7 @@ static int hns3_get_timeout_queue(struct net_device *= ndev) dql->adj_limit, dql->num_completed); #endif netdev_info(ndev, "queue state: 0x%lx, delta msecs: %u\n", - q->state, - jiffies_to_msecs(jiffies - trans_start)); + q->state, timedout_ms); break; } } --=20 2.31.1 From nobody Sat Feb 7 13:05:34 2026 Received: from CO1PR03CU002.outbound.protection.outlook.com (mail-westus2azon11010006.outbound.protection.outlook.com [52.101.46.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8645E347FE2; Mon, 12 Jan 2026 09:18:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.46.6 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768209498; cv=fail; b=cbANDOtM6Dztgc00bgknwef97jPsb2a015zTfw4+96XOzMXJxpbDTefrhyvYHRmJCAyX8cnOQc/mdWxaaMi3lDOglm4hx+GTZxoxgrdkLngFQZl+vOOSZSaVzFG+4gB6QyPj1emADomYV8mDT2lSrhez6MGBzJRMuu39asz6kxk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768209498; c=relaxed/simple; bh=HQoU9xEBMxQ8G/RU8I43Mx22IsTHIbw47gfcNddH56c=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=n8okmMk0YsNm56AD+XU0Bim2arkZV9psMElvBNFE3TieHIk0Of+iEjrKp60756CdtWMnQBsbM91TENHEbAb6It83275BJy3R1r5MTnGAj4Cwr8KMIhdMBfeODW0KAzzgOhDRqKHxTTwDuU1Y3Xr2tQzX5uifIdFbhgO2kXn4A+M= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=qEkBHTmS; arc=fail smtp.client-ip=52.101.46.6 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="qEkBHTmS" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=FeSWcrs0dEW7Tu5VKY9jsN+eDfQ3NJYoqi11raIgEYsuIcslyw/lkginHMY6OsCjS46E6mMIf+1P4KGEKcDd01XJic0N2ktkrjnyBCS1fgCghwBYTA+tOndYSA3YA25emF7EhXS67bsCLk6PoCFPtPcT52yimw5RdCmPRM3amB2L1WEg1XrhxypWgCf6IkNCiQig++tfx13UsbtiS7MMO9VYzoTYGyg7v3QBz9XN58hi/59jXhZN8WQ9fgHkYEKBQHMqGesDlazsX44PyQ7KBDwZFwUtVTvKSNca5xRL7RMmvT0kXKpBzR6osc0bbfBzQXLIMm5VL+SRu7Or0zQfUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xf942PCStO7fjU9ge+o11HdVAcMvr+Fs7TshzeceW+I=; b=RgykmCRfC2NO6VhpKLGYsnJ1sEpzddnRjmn+m8dm2rSVJHHSFGVoKlVkvrEV1Uv3m7qQHt2301crwL+PUYsiwqXY0+/c9pSlvFKMtn65znSbRBSqJhfDByM+7EnUWX8Y+U8xMMr4wQHAFbt5zNOfKFUinNAWRkZDRnBtpO4AmFtWsJXZUoNcujHIzrNhSq2uhbMfRRIJ87UfXIyhSjqRSjc/XYdxGngZEdYVMh0vgRAQWd/X5nawuwhQdhX4GFgMkMDhgnDRUHseww0BS1fjE2wqsBrA0Km3CIXZk97yI353u8JpDnRpdp9J7XR39vF3lKkaF99kZPk9Pb3SK5zUzA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=google.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xf942PCStO7fjU9ge+o11HdVAcMvr+Fs7TshzeceW+I=; b=qEkBHTmShUGSEzHMTx4zZnvDUmkQmAG7uR7A0/dPpf2xypY8dX8P6M6gGaz1y310spuJN1gDu/DoKjFiC5e90WNXt7Oni4xF1/e6Tyul37Gv4yvrkrE0QdUWnta7015bbFxODMqm45WzzJePCGMw227PifCUVgJ5M3fX7HgRMUKsbQxPHIZjkPN0pK9CFmMfS7L3Jv6T26J5ksxBbrYs5uWP3k3tPW1362cpmHTZKQvp3MN+rnSMY1l90/J0CCcEPW65Lcrz9sAbQqG8Ff5qxraRxCp+miqaYR+1OZ1bn+EJYnzZPQTnz95I2MJk3vRaETPm9lcwbKxNpYUd+vv9Dg== Received: from BN9PR03CA0526.namprd03.prod.outlook.com (2603:10b6:408:131::21) by CY5PR12MB6132.namprd12.prod.outlook.com (2603:10b6:930:24::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9499.7; Mon, 12 Jan 2026 09:18:00 +0000 Received: from BN2PEPF000044AA.namprd04.prod.outlook.com (2603:10b6:408:131:cafe::e1) by BN9PR03CA0526.outlook.office365.com (2603:10b6:408:131::21) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9499.7 via Frontend Transport; Mon, 12 Jan 2026 09:17:13 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BN2PEPF000044AA.mail.protection.outlook.com (10.167.243.105) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9520.1 via Frontend Transport; Mon, 12 Jan 2026 09:17:59 +0000 Received: from rnnvmail202.nvidia.com (10.129.68.7) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 12 Jan 2026 01:17:47 -0800 Received: from rnnvmail205.nvidia.com (10.129.68.10) by rnnvmail202.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 12 Jan 2026 01:17:47 -0800 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.129.68.10) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Mon, 12 Jan 2026 01:17:42 -0800 From: Tariq Toukan To: Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , "David S. Miller" CC: Jian Shen , Salil Mehta , Jijie Shao , Saeed Mahameed , "Tariq Toukan" , Mark Bloch , Leon Romanovsky , , , , Gal Pressman , Moshe Shemesh , Shahar Shitrit , Yael Chemla , Jamal Hadi Salim Subject: [PATCH net-next V2 3/3] net/mlx5e: Refine TX timeout handling to skip non-timed-out SQ Date: Mon, 12 Jan 2026 11:16:23 +0200 Message-ID: <1768209383-1546791-4-git-send-email-tariqt@nvidia.com> X-Mailer: git-send-email 2.8.0 In-Reply-To: <1768209383-1546791-1-git-send-email-tariqt@nvidia.com> References: <1768209383-1546791-1-git-send-email-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN2PEPF000044AA:EE_|CY5PR12MB6132:EE_ X-MS-Office365-Filtering-Correlation-Id: ffc288bf-e7ee-41c3-a39f-08de51bb7b25 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|36860700013|1800799024|82310400026; X-Microsoft-Antispam-Message-Info: =?utf-8?B?UnBlNWN4Y3hkTUdDUFZtUnhYL3p1MW4xWm9QbDEybmdXcWJLNVdYSDcrcDBG?= =?utf-8?B?Y2Z3NCtUWHZsSmdoNTZPQTlML1VabkJuK2EweDJsQy92YXkzcDdsNnB5S2hW?= =?utf-8?B?bjExR3pudVE5RTVuelcwYktkeWZmWm9yTW0yNzQ4ZjJ6cno2WDg3dzRaTkd3?= =?utf-8?B?eEt4YWlrOFVNTTh5eDZRVmF2RmNEaU9CZkFJOU1tTUNmZzVrWG84WlhpNDZU?= =?utf-8?B?L0NvTElqYzVrcCt5bjNDdGZHeTE5b0p0STFMVXRIODBjU0hjUzEwMXJoc1Bz?= =?utf-8?B?bXM4elVoY1B5TytJSHJ1eEpVZTBTeXA5YjFucFNDd2QxekJyaXRXTWNtYUth?= =?utf-8?B?cXdtWHVwQ3FDV2MzNkVtcXQ1a3NFQVhTK0Z4QzB6Z2VtdVFNR2g0U2lVQnFD?= =?utf-8?B?YzQwOXlibTlkWkpiMno1cUlSRVpyekwwWE16R25HWmxVUlZaRDNGVkhKZnNu?= =?utf-8?B?R2lRNloxNWdtczNaWHFHTlhDa2djNTVhK0pUWUVDNFM4SGQ1Rld3T2gyK3dZ?= =?utf-8?B?MVhGTkZrWmt2WlBKM1RyQjhiQnp6bFFFakVPcjBUTlJtN2dncFdTdHR0QTJ1?= =?utf-8?B?MDdITTFjTW5uQXdzNUVvRnhEUUxLQWJyb2tETGFqOFZ5OFIvNDV2ZkliYVNG?= =?utf-8?B?bWVuZGJaQUhxeE84dFdTaVlCS01jTHpiN3JwWFMyZEN4aUJLdjNTY1RKNmdj?= =?utf-8?B?QnlYRXdlQ25GWW4waDN6cUJDeUo4aGhXKzdGNGIrbS9CY2RjV1BEOWg1YXFs?= =?utf-8?B?M0orZndhMVdRaGsvWS8rRUZMQjFXUU9aRDd5N2lReDVod1lHdG5HSjJzaU9D?= =?utf-8?B?WitVUDB0UEwrZjlRWFhZRDJjSFgwMzV6cVpWeXhHMzJhazFkazBvT0V1NWxx?= =?utf-8?B?d01hazNreWlTMEpEdjJiUEQxSy9LYTg1ZUFZdTdwN0xLVVlVTjg1VG50L0tq?= =?utf-8?B?VERlaXQxS0RMVVg5M244KzNLZ1dlR280RTlDTlFRbGhCTGN6SWRqU0JOL1Zq?= =?utf-8?B?d0k3cFRUcWtZVHlBQ1A0WTZjaVJOOC9sdzcrVTlPK25qcUZ1RFJMV0MvZ0pY?= =?utf-8?B?eUFiam0ya0cxc0dpWmZiMEpzeXJ0dUozaElMdWtvakNhN2pEWWlCdThnTzM4?= =?utf-8?B?U05hTVpwYS9jSjh5TmcwN3VMZlhLTzErczF5WkpXK0pObHB3Wks1ME1zOENF?= =?utf-8?B?WTJ6OEpWNFFkbWtROENsMU1TTWJLb1hpZlRIdXdBOXZ4dlJUWlkxNXBSQzlJ?= =?utf-8?B?d201VjdtVTNCVmFIV05pN2JvaGhvSGJJWDB4ZUFrVkVRM0YzdW1NcFkrNTR5?= =?utf-8?B?N0lwS2ZyT25xQ3h5bFpYclhDa1hZS2wzeThmU2RnRDVVMkFPVnNtbGhLMEVM?= =?utf-8?B?TGhzR25DRXdneVBidGhzN2JFUjFjZnh6aDlPR3FySlg3ZmxTVWFaSmg5OEc5?= =?utf-8?B?ZTNZZExZdDdtUUF2S0FLWkJRTTAxOUxjblBON3g0UlNsRTh3MjBSMnA2c2FN?= =?utf-8?B?dVE5R01pcldTSTRiZFNCRWR5UGs1ekRwOTY5dHJVQTlWYWZCS1Ntc293REhW?= =?utf-8?B?R0lubUs2K0lxay8wMnQ2ejVBK3h0VytNYkJkdmdVaUZOT2dEYVJYRUlEVm52?= =?utf-8?B?MDRaa2MyVThYUTd6eFd4ZXpuM3orcy9QMTdJbm9sc0xTenN0dndNK3JqbXc4?= =?utf-8?B?WTlSWW5UYkFva01ScTRVU3lKamUyeHl1ZTM3eG5Xa1JvTkZrQ0llL2E1QmRU?= =?utf-8?B?RGZyS0JTbTFQelZPWUpRMXhxVjNBamRvd1JWTWRxcTJieGlsaEYydTIxQTZH?= =?utf-8?B?YWUxOC9WbFBDZEM3bUx3elprcUNaR05veFNhRGI2NEFESE5XRzV6dmZ6dUNt?= =?utf-8?B?Z0l4aHpjMXRtUndSR2NmZUVGa2cvL1hhVVgwWUxrS1J3UC9wWWdpVnlxUERm?= =?utf-8?B?OG5rMGh5REJSa0RGalpTU3MydTNqZG9jNTJncWQ4WkZrcVNPZVI3UGFIZ0px?= =?utf-8?B?czdQQVdDN0haanQzWUc4UVlCKzJJZ0tMdldxSFVDcmR2YkdnSHlsRklVMUxN?= =?utf-8?B?bWwydHpyRWlhY1FtMVh5dktXYVF5Tk1iRERTcUVjSWhCNkVrYlplOUx1Y0Vq?= =?utf-8?Q?vj3M=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(376014)(7416014)(36860700013)(1800799024)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2026 09:17:59.8054 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ffc288bf-e7ee-41c3-a39f-08de51bb7b25 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN2PEPF000044AA.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6132 From: Shahar Shitrit mlx5e_tx_timeout_work() is invoked when the dev_watchdog reports a timed-out TX queue. Currently, the recovery flow is triggered for all stopped SQs, which is not always correct =E2=80=94 some SQs may be temporar= ily stopped without actually timing out. Attempting to recover such SQs results in no EQE being polled (since no real timeout occurred), which the driver misinterprets as a recovery failure, unnecessarily causing channel reopening. Improve the logic to initiate recovery only for SQs that are both stopped and timed out. Utilize the helper introduced in the previous patch to determine whether the netdevice watchdog timeout period has elapsed since the SQ=E2=80=99s last transmit timestamp. Signed-off-by: Shahar Shitrit Reviewed-by: Yael Chemla Signed-off-by: Tariq Toukan Reviewed-by: Simon Horman --- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c b/drivers/ne= t/ethernet/mellanox/mlx5/core/en_main.c index 3ac47df83ac8..7dbcf71404d8 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c @@ -5137,7 +5137,7 @@ static void mlx5e_tx_timeout_work(struct work_struct = *work) netdev_get_tx_queue(netdev, i); struct mlx5e_txqsq *sq =3D priv->txq2sq[i]; =20 - if (!netif_xmit_stopped(dev_queue)) + if (!netif_xmit_timeout_ms(dev_queue)) continue; =20 if (mlx5e_reporter_tx_timeout(sq)) --=20 2.31.1