[PATCH] mfd: rt5033: Fix missing regmap_del_irq_chip()

Zhang Changzhong posted 1 patch 3 weeks, 4 days ago
drivers/mfd/rt5033.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH] mfd: rt5033: Fix missing regmap_del_irq_chip()
Posted by Zhang Changzhong 3 weeks, 4 days ago
Fix missing call to regmap_del_irq_chip() in error handling path by
using devm_regmap_add_irq_chip().

Fixes: 0b271258544b ("mfd: rt5033: Add Richtek RT5033 driver core.")
Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
---
 drivers/mfd/rt5033.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mfd/rt5033.c b/drivers/mfd/rt5033.c
index 7e23ab3..84ebc96 100644
--- a/drivers/mfd/rt5033.c
+++ b/drivers/mfd/rt5033.c
@@ -81,8 +81,8 @@ static int rt5033_i2c_probe(struct i2c_client *i2c)
 	chip_rev = dev_id & RT5033_CHIP_REV_MASK;
 	dev_info(&i2c->dev, "Device found (rev. %d)\n", chip_rev);
 
-	ret = regmap_add_irq_chip(rt5033->regmap, rt5033->irq,
-			IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
+	ret = devm_regmap_add_irq_chip(rt5033->dev, rt5033->regmap,
+			rt5033->irq, IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
 			0, &rt5033_irq_chip, &rt5033->irq_data);
 	if (ret) {
 		dev_err(&i2c->dev, "Failed to request IRQ %d: %d\n",
-- 
2.9.5
Re: (subset) [PATCH] mfd: rt5033: Fix missing regmap_del_irq_chip()
Posted by Lee Jones 2 weeks, 4 days ago
On Wed, 30 Oct 2024 23:41:06 +0800, Zhang Changzhong wrote:
> Fix missing call to regmap_del_irq_chip() in error handling path by
> using devm_regmap_add_irq_chip().
> 
> 

Applied, thanks!

[1/1] mfd: rt5033: Fix missing regmap_del_irq_chip()
      commit: d256d612f47529ed0b332298e2d5ea981a4dd5b8

--
Lee Jones [李琼斯]