From nobody Mon Nov 25 02:31:41 2024 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A0031E885F for ; Wed, 30 Oct 2024 15:02:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.188 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730300544; cv=none; b=FpkC6agFV+DDHJKeOOZcNXrHBtgMzZVoGAN586My1kRA843WtyPP3t2ykGUDvKSXrfTJ1HN41FuX40yzJfqGrifSz8rvibhiNPxNeC89EYBod8tYQQsPsh2N8vaQ1FMnPZolIcxSJPpxvi6NzUTe+59UFcfxtHHLZctAx+od1Uo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730300544; c=relaxed/simple; bh=2bKSKgI7FJqNVrw7OMqnymXnoOrC6zDNg5UOHtPRxkI=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=fsWu1lnHVCBQ3CDbE8YYFyhm5QbpPtWZEmaOHRrvc9ki3lukH8gUmqwWge1cDmP5cJZmXUoE1k5GkfmB9jRQZP0wlWMY98ZeEMQqhICMI7x3okTOj9b1WzTT1sQGBQPluarWXbjuLn3xyfAMvc+zH7O2BwTprOTbsCCGZrgKel8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.188 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.88.194]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4XdqzM4HgSzdkSw; Wed, 30 Oct 2024 22:59:43 +0800 (CST) Received: from dggpeml500006.china.huawei.com (unknown [7.185.36.76]) by mail.maildlp.com (Postfix) with ESMTPS id 4DA031402E2; Wed, 30 Oct 2024 23:02:17 +0800 (CST) Received: from localhost.localdomain (10.175.112.70) by dggpeml500006.china.huawei.com (7.185.36.76) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 30 Oct 2024 23:02:16 +0800 From: Zhang Changzhong To: Lee Jones , Beomho Seo , Chanwoo Choi , CC: Zhang Changzhong , Wei Yongjun Subject: [PATCH] mfd: rt5033: Fix missing regmap_del_irq_chip() Date: Wed, 30 Oct 2024 23:41:06 +0800 Message-ID: <1730302867-8391-1-git-send-email-zhangchangzhong@huawei.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpeml500006.china.huawei.com (7.185.36.76) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix missing call to regmap_del_irq_chip() in error handling path by using devm_regmap_add_irq_chip(). Fixes: 0b271258544b ("mfd: rt5033: Add Richtek RT5033 driver core.") Signed-off-by: Zhang Changzhong --- drivers/mfd/rt5033.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/rt5033.c b/drivers/mfd/rt5033.c index 7e23ab3..84ebc96 100644 --- a/drivers/mfd/rt5033.c +++ b/drivers/mfd/rt5033.c @@ -81,8 +81,8 @@ static int rt5033_i2c_probe(struct i2c_client *i2c) chip_rev =3D dev_id & RT5033_CHIP_REV_MASK; dev_info(&i2c->dev, "Device found (rev. %d)\n", chip_rev); =20 - ret =3D regmap_add_irq_chip(rt5033->regmap, rt5033->irq, - IRQF_TRIGGER_FALLING | IRQF_ONESHOT, + ret =3D devm_regmap_add_irq_chip(rt5033->dev, rt5033->regmap, + rt5033->irq, IRQF_TRIGGER_FALLING | IRQF_ONESHOT, 0, &rt5033_irq_chip, &rt5033->irq_data); if (ret) { dev_err(&i2c->dev, "Failed to request IRQ %d: %d\n", --=20 2.9.5