[PATCH v10 0/4] PCI: qcom: ep: Add basic interconnect support

Krishna chaitanya chundru posted 4 patches 2 years, 1 month ago
.../devicetree/bindings/pci/qcom,pcie-ep.yaml      | 15 +++++
arch/arm/boot/dts/qcom/qcom-sdx55.dtsi             |  5 +-
arch/arm/boot/dts/qcom/qcom-sdx65.dtsi             |  4 ++
drivers/pci/controller/dwc/pcie-qcom-ep.c          | 71 ++++++++++++++++++++++
4 files changed, 93 insertions(+), 2 deletions(-)
[PATCH v10 0/4] PCI: qcom: ep: Add basic interconnect support
Posted by Krishna chaitanya chundru 2 years, 1 month ago
Add basic support for managing "pcie-mem" interconnect path by setting
a low constraint before enabling clocks and updating it after the link
is up based on link speed and width the device got enumerated.

changes from v9:
	- addressed the comments by mani.
changes from v8:
        - Added cpu to pcie path in dtsi and in dtsi binding.
changes from v7:
        - setting icc bw to '0' in disable resources as suggested by mani.
changes from v6:
        - addressed the comments as suggested by mani.
changes from v5:
        - addressed the comments by mani.
changes from v4:
        - rebased with linux-next.
        - Added comments as suggested by mani.
        - removed the arm: dts: qcom: sdx55: Add interconnect path
          as that patch is already applied.
changes from v3:
        - ran make DT_CHECKER_FLAGS=-m dt_binding_check and fixed
         errors.
        - Added macros in the qcom ep driver patch as suggested by Dmitry
changes from v2:
        - changed the logic for getting speed and width as suggested
         by bjorn.
        - fixed compilation errors.


Krishna chaitanya chundru (4):
  PCI: qcom-ep: Add ICC bandwidth voting support
  arm: dts: qcom: sdx65: Add PCIe EP interconnect path
  arm: dts: qcom: sdx55: Add CPU PCIe EP interconnect path
  dt-bindings: PCI: qcom: ep: Add interconnects path

 .../devicetree/bindings/pci/qcom,pcie-ep.yaml      | 15 +++++
 arch/arm/boot/dts/qcom/qcom-sdx55.dtsi             |  5 +-
 arch/arm/boot/dts/qcom/qcom-sdx65.dtsi             |  4 ++
 drivers/pci/controller/dwc/pcie-qcom-ep.c          | 71 ++++++++++++++++++++++
 4 files changed, 93 insertions(+), 2 deletions(-)

-- 
2.7.4
Re: [PATCH v10 0/4] PCI: qcom: ep: Add basic interconnect support
Posted by Manivannan Sadhasivam 2 years, 1 month ago
On Wed, Jul 19, 2023 at 12:50:14PM +0530, Krishna chaitanya chundru wrote:
> Add basic support for managing "pcie-mem" interconnect path by setting
> a low constraint before enabling clocks and updating it after the link
> is up based on link speed and width the device got enumerated.
> 

Krzysztof, can this series be merged for 6.6? Bjorn A will pick the dts patches.

- Mani

> changes from v9:
> 	- addressed the comments by mani.
> changes from v8:
>         - Added cpu to pcie path in dtsi and in dtsi binding.
> changes from v7:
>         - setting icc bw to '0' in disable resources as suggested by mani.
> changes from v6:
>         - addressed the comments as suggested by mani.
> changes from v5:
>         - addressed the comments by mani.
> changes from v4:
>         - rebased with linux-next.
>         - Added comments as suggested by mani.
>         - removed the arm: dts: qcom: sdx55: Add interconnect path
>           as that patch is already applied.
> changes from v3:
>         - ran make DT_CHECKER_FLAGS=-m dt_binding_check and fixed
>          errors.
>         - Added macros in the qcom ep driver patch as suggested by Dmitry
> changes from v2:
>         - changed the logic for getting speed and width as suggested
>          by bjorn.
>         - fixed compilation errors.
> 
> 
> Krishna chaitanya chundru (4):
>   PCI: qcom-ep: Add ICC bandwidth voting support
>   arm: dts: qcom: sdx65: Add PCIe EP interconnect path
>   arm: dts: qcom: sdx55: Add CPU PCIe EP interconnect path
>   dt-bindings: PCI: qcom: ep: Add interconnects path
> 
>  .../devicetree/bindings/pci/qcom,pcie-ep.yaml      | 15 +++++
>  arch/arm/boot/dts/qcom/qcom-sdx55.dtsi             |  5 +-
>  arch/arm/boot/dts/qcom/qcom-sdx65.dtsi             |  4 ++
>  drivers/pci/controller/dwc/pcie-qcom-ep.c          | 71 ++++++++++++++++++++++
>  4 files changed, 93 insertions(+), 2 deletions(-)
> 
> -- 
> 2.7.4
> 

-- 
மணிவண்ணன் சதாசிவம்
Re: [PATCH v10 0/4] PCI: qcom: ep: Add basic interconnect support
Posted by Krzysztof Wilczyński 2 years ago
Hello,

> > Add basic support for managing "pcie-mem" interconnect path by setting
> > a low constraint before enabling clocks and updating it after the link
> > is up based on link speed and width the device got enumerated.
> > 
> 
> Krzysztof, can this series be merged for 6.6? Bjorn A will pick the dts patches.

Applied.  Sorry for the delay.

That said, it's now up to Bjorn (Bjorn Helgaas) to take it, or let it slide
for 6.7, depending on how far he has got with his Pull Request.

	Krzysztof
Re: [PATCH v10 0/4] PCI: qcom: ep: Add basic interconnect support
Posted by Krishna Chaitanya Chundru 2 years ago
On 7/28/2023 8:26 AM, Manivannan Sadhasivam wrote:
> On Wed, Jul 19, 2023 at 12:50:14PM +0530, Krishna chaitanya chundru wrote:
>> Add basic support for managing "pcie-mem" interconnect path by setting
>> a low constraint before enabling clocks and updating it after the link
>> is up based on link speed and width the device got enumerated.
>>
> Krzysztof, can this series be merged for 6.6? Bjorn A will pick the dts patches.
>
> - Mani

A Gentle ping

- KC

>> changes from v9:
>> 	- addressed the comments by mani.
>> changes from v8:
>>          - Added cpu to pcie path in dtsi and in dtsi binding.
>> changes from v7:
>>          - setting icc bw to '0' in disable resources as suggested by mani.
>> changes from v6:
>>          - addressed the comments as suggested by mani.
>> changes from v5:
>>          - addressed the comments by mani.
>> changes from v4:
>>          - rebased with linux-next.
>>          - Added comments as suggested by mani.
>>          - removed the arm: dts: qcom: sdx55: Add interconnect path
>>            as that patch is already applied.
>> changes from v3:
>>          - ran make DT_CHECKER_FLAGS=-m dt_binding_check and fixed
>>           errors.
>>          - Added macros in the qcom ep driver patch as suggested by Dmitry
>> changes from v2:
>>          - changed the logic for getting speed and width as suggested
>>           by bjorn.
>>          - fixed compilation errors.
>>
>>
>> Krishna chaitanya chundru (4):
>>    PCI: qcom-ep: Add ICC bandwidth voting support
>>    arm: dts: qcom: sdx65: Add PCIe EP interconnect path
>>    arm: dts: qcom: sdx55: Add CPU PCIe EP interconnect path
>>    dt-bindings: PCI: qcom: ep: Add interconnects path
>>
>>   .../devicetree/bindings/pci/qcom,pcie-ep.yaml      | 15 +++++
>>   arch/arm/boot/dts/qcom/qcom-sdx55.dtsi             |  5 +-
>>   arch/arm/boot/dts/qcom/qcom-sdx65.dtsi             |  4 ++
>>   drivers/pci/controller/dwc/pcie-qcom-ep.c          | 71 ++++++++++++++++++++++
>>   4 files changed, 93 insertions(+), 2 deletions(-)
>>
>> -- 
>> 2.7.4
>>
Re: [PATCH v10 0/4] PCI: qcom: ep: Add basic interconnect support
Posted by Krzysztof Kozlowski 2 years ago
On 29/08/2023 13:41, Krishna Chaitanya Chundru wrote:
> 
> On 7/28/2023 8:26 AM, Manivannan Sadhasivam wrote:
>> On Wed, Jul 19, 2023 at 12:50:14PM +0530, Krishna chaitanya chundru wrote:
>>> Add basic support for managing "pcie-mem" interconnect path by setting
>>> a low constraint before enabling clocks and updating it after the link
>>> is up based on link speed and width the device got enumerated.
>>>
>> Krzysztof, can this series be merged for 6.6? Bjorn A will pick the dts patches.
>>
>> - Mani
> 
> A Gentle ping
> 

Whom do you ping and why me? If you choose not to use
scripts/get_maintainers.pl, it's your right, but then you might get
maintainers wrong and no surprise patches got not accepted...

Plus, it's merge window, so why pinging now?

Best regards,
Krzysztof
Re: [PATCH v10 0/4] PCI: qcom: ep: Add basic interconnect support
Posted by Krzysztof Wilczyński 2 years ago
Hello,

> Add basic support for managing "pcie-mem" interconnect path by setting
> a low constraint before enabling clocks and updating it after the link
> is up based on link speed and width the device got enumerated.

Applied to controller/qcom-ep, thank you!

[1/4] dt-bindings: PCI: qcom: ep: Add interconnects path
      https://git.kernel.org/pci/pci/c/e590ad240ff0
[4/4] PCI: qcom-ep: Add ICC bandwidth voting support
      https://git.kernel.org/pci/pci/c/0c104996e6a8

	Krzysztof
Re: (subset) [PATCH v10 0/4] PCI: qcom: ep: Add basic interconnect support
Posted by Bjorn Andersson 8 months, 2 weeks ago
On Wed, 19 Jul 2023 12:50:14 +0530, Krishna chaitanya chundru wrote:
> Add basic support for managing "pcie-mem" interconnect path by setting
> a low constraint before enabling clocks and updating it after the link
> is up based on link speed and width the device got enumerated.
> 
> changes from v9:
> 	- addressed the comments by mani.
> changes from v8:
>         - Added cpu to pcie path in dtsi and in dtsi binding.
> changes from v7:
>         - setting icc bw to '0' in disable resources as suggested by mani.
> changes from v6:
>         - addressed the comments as suggested by mani.
> changes from v5:
>         - addressed the comments by mani.
> changes from v4:
>         - rebased with linux-next.
>         - Added comments as suggested by mani.
>         - removed the arm: dts: qcom: sdx55: Add interconnect path
>           as that patch is already applied.
> changes from v3:
>         - ran make DT_CHECKER_FLAGS=-m dt_binding_check and fixed
>          errors.
>         - Added macros in the qcom ep driver patch as suggested by Dmitry
> changes from v2:
>         - changed the logic for getting speed and width as suggested
>          by bjorn.
>         - fixed compilation errors.
> 
> [...]

Applied, thanks!

[2/4] arm: dts: qcom: sdx65: Add PCIe EP interconnect path
      commit: 84d2ae7c09d93949fc9e9fe57bdb78a2f3fa24aa
[3/4] arm: dts: qcom: sdx55: Add CPU PCIe EP interconnect path
      commit: 7ec041bd2715df2da4ab19c403c27d58d173c7c0

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>