[PATCH v12 00/12] Add soundcard support for sc7280 based platforms.

Srinivasa Rao Mandadapu posted 12 patches 3 years, 11 months ago
There is a newer version of this series
arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts        |  37 ++++
arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dts | 150 +++++++++++++++
arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi    |   8 +
arch/arm64/boot/dts/qcom/sc7280-idp.dtsi          | 217 ++++++++++++++++++++++
arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi        |  74 ++++++++
arch/arm64/boot/dts/qcom/sc7280.dtsi              | 190 +++++++++++++++++++
6 files changed, 676 insertions(+)
[PATCH v12 00/12] Add soundcard support for sc7280 based platforms.
Posted by Srinivasa Rao Mandadapu 3 years, 11 months ago
This patch set is to add bolero digital macros, WCD and maxim codecs nodes
for audio on sc7280 based platforms.

This patch set depends on:
    -- https://patchwork.kernel.org/project/linux-arm-msm/list/?series=638776
    -- https://patchwork.kernel.org/project/linux-arm-msm/list/?series=634597
    -- https://patchwork.kernel.org/project/linux-clk/list/?series=637999
    -- https://patchwork.kernel.org/project/linux-arm-msm/list/?series=638002

Changes Since V11:
    -- Remove output-low pinconf setting in wcd-reset-n-sleep node.
    -- Update dependency list.
Changes Since V10:
    -- Modify digital macro codecs pin control labels.
    -- Updated dependency list.
Changes Since V9:
    -- Move wcd codec and digital codec nodes to sc7280-qcard file.
    -- Modify the reg property as per link number in sound node.
    -- Fix the us-euro pin control usage in wcd codec node.
    -- Move wcd pin control nodes to specific crd board files.
    -- Sort max98360a codec node in alphabetical order.
    -- Modify the commit messages.
Changes Since V8:
    -- Split patches as per sc7280 CRD revision 3, 4 and 5 boards.
    -- Add corresponding dt nodes for herobrine crd boards.
    -- Update dai-link node names as per dt-bindings in sound node.
    -- Add reg property in sound node as per dt-bindings which was removed in previous series.
    -- Fix typo errors.
    -- Update wcd codec pin control properties in board specific files.
Changes Since V7:
    -- Remove redundant interrupt names in soundwire node.
    -- Fix typo errors.
    -- Remove redundant reg property in sound node.
    -- Rebased on top of latest kernel tip.
Changes Since V6:
    -- Modify link-names and audio routing in a sound node.
    -- Move amp_en pin control node to appropriate consumer patch.
    -- Split patches as per digital macro codecs and board specific codecs and sort it.
    -- Modify label and node names to lpass specific.
Changes Since V5:
    -- Move soc specific bolero digital codec nodes to soc specific file.
    -- Bring wcd938x codec reset pin control and US/EURO HS selection nodes from other series.
    -- Change node name and remove redundant status property in sound node.
Changes Since V4:
    -- Update nodes in sorting order.
    -- Update DTS node names as per dt-bindings.
    -- Update Node properties in proper order.
    -- Update missing pinctrl properties like US/EURO HS selection, wcd reset control.
    -- Remove redundant labels.
    -- Remove unused size cells and address cells in tx macro node.
    -- Keep all same nodes at one place, which are defined in same file.
    -- Add max98360a codec node to herobrine board specific targets.
Changes Since V3:
    -- Move digital codec macro nodes to board specific dtsi file.
    -- Update pin controls in lpass cpu node.
    -- Update dependency patch list.
    -- Create patches on latest kernel.
Changes Since V2:
    -- Add power domains to digital codec macro nodes.
    -- Change clock node usage in lpass cpu node.
    -- Add codec mem clock to lpass cpu node.
    -- Modify the node names to be generic.
    -- Move sound and codec nodes to root node.
    -- sort dai links as per reg.
    -- Fix typo errors.
Changes Since V1:
    -- Update the commit message of cpu node patch.
    -- Add gpio control property to support Euro headset in wcd938x node.
    -- Fix clock properties in lpass cpu and digital codec macro node.

Srinivasa Rao Mandadapu (12):
  arm64: dts: qcom: sc7280: Add nodes for soundwire and va tx rx digital
    macro codecs
  arm64: dts: qcom: sc7280: Enable digital codecs and soundwire for CRD
    1.0/2.0 and IDP boards
  arm64: dts: qcom: sc7280: Enable digital codecs and soundwire for CRD
    3.0/3.1
  arm64: dts: qcom: sc7280: Add wcd9385 codec node for CRD 1.0/2.0 and
    IDP boards
  arm64: dts: qcom: sc7280: Add wcd9385 codec node for CRD 3.0/3.1
  arm64: dts: qcom: sc7280: Add max98360a codec for CRD 1.0/2.0 and IDP
    boards
  arm64: dts: qcom: sc7280: herobrine: Add max98360a codec node
  arm64: dts: qcom: sc7280: Add lpass cpu node
  arm64: dts: qcom: sc7280: Enable lpass cpu node for CRD 1.0/2.0 and
    IDP boards.
  arm64: dts: qcom: sc7280: Enable lpass cpu node for CRD 3.0/3.1
  arm64: dts: qcom: sc7280: Add sound node for CRD 1.0/2.0 and IDP
    boards
  arm64: dts: qcom: sc7280: Add sound node for CRD 3.0/3.1

 arch/arm64/boot/dts/qcom/sc7280-crd-r3.dts        |  37 ++++
 arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dts | 150 +++++++++++++++
 arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi    |   8 +
 arch/arm64/boot/dts/qcom/sc7280-idp.dtsi          | 217 ++++++++++++++++++++++
 arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi        |  74 ++++++++
 arch/arm64/boot/dts/qcom/sc7280.dtsi              | 190 +++++++++++++++++++
 6 files changed, 676 insertions(+)

-- 
2.7.4
Re: [PATCH v12 00/12] Add soundcard support for sc7280 based platforms.
Posted by Matthias Kaehlcke 3 years, 11 months ago
On Fri, May 20, 2022 at 05:48:32PM +0530, Srinivasa Rao Mandadapu wrote:
> This patch set is to add bolero digital macros, WCD and maxim codecs nodes
> for audio on sc7280 based platforms.
> 
> This patch set depends on:
>     -- https://patchwork.kernel.org/project/linux-arm-msm/list/?series=638776
>     -- https://patchwork.kernel.org/project/linux-arm-msm/list/?series=634597
>     -- https://patchwork.kernel.org/project/linux-clk/list/?series=637999
>     -- https://patchwork.kernel.org/project/linux-arm-msm/list/?series=638002

Another dependency (at least in terms of functionality) is:

ASoC: qcom: soundwire: Add support for controlling audio CGCR from HLOS
https://patchwork.kernel.org/patch/12853622/

And then there is this:

arm64: dts: qcom: sc7280: Add lpasscore & lpassaudio clock controllers
https://patchwork.kernel.org/project/linux-arm-msm/patch/20220523100058.26241-1-quic_tdas@quicinc.com/

A previous version (v3) of that patch already landed (9499240d15f2
"arm64: dts: qcom: sc7280: Add lpasscore & lpassaudio clock controllers"),
it is not clear to me why it is still evolving as if that weren't the
case.

From the newer version of the patch at least marking the 'lpasscc' node
as disabled is needed.
Re: [PATCH v12 00/12] Add soundcard support for sc7280 based platforms.
Posted by Srinivasa Rao Mandadapu 3 years, 11 months ago
On 6/7/2022 3:02 AM, Matthias Kaehlcke wrote:
Thanks for your time Matthias!!!
> On Fri, May 20, 2022 at 05:48:32PM +0530, Srinivasa Rao Mandadapu wrote:
>> This patch set is to add bolero digital macros, WCD and maxim codecs nodes
>> for audio on sc7280 based platforms.
>>
>> This patch set depends on:
>>      -- https://patchwork.kernel.org/project/linux-arm-msm/list/?series=638776
>>      -- https://patchwork.kernel.org/project/linux-arm-msm/list/?series=634597
>>      -- https://patchwork.kernel.org/project/linux-clk/list/?series=637999
>>      -- https://patchwork.kernel.org/project/linux-arm-msm/list/?series=638002
> Another dependency (at least in terms of functionality) is:
>
> ASoC: qcom: soundwire: Add support for controlling audio CGCR from HLOS
> https://patchwork.kernel.org/patch/12853622/
This is landed today.
>
> And then there is this:
>
> arm64: dts: qcom: sc7280: Add lpasscore & lpassaudio clock controllers
> https://patchwork.kernel.org/project/linux-arm-msm/patch/20220523100058.26241-1-quic_tdas@quicinc.com/
>
> A previous version (v3) of that patch already landed (9499240d15f2
> "arm64: dts: qcom: sc7280: Add lpasscore & lpassaudio clock controllers"),
> it is not clear to me why it is still evolving as if that weren't the
> case.

I too have same doubt. the changes should be incremental and new patch. 
May be Taniya considered

the status in patchwork.kernel org, where still it's showing new.

>
>  From the newer version of the patch at least marking the 'lpasscc' node
> as disabled is needed.

yes, agree. And the node name changed to lpasscore to lpass_core.

Included Taniya in the mail chain for further discussion.
Re: [PATCH v12 00/12] Add soundcard support for sc7280 based platforms.
Posted by Bjorn Andersson 3 years, 7 months ago
On Fri, 20 May 2022 17:48:32 +0530, Srinivasa Rao Mandadapu wrote:
> This patch set is to add bolero digital macros, WCD and maxim codecs nodes
> for audio on sc7280 based platforms.
> 
> This patch set depends on:
>     -- https://patchwork.kernel.org/project/linux-arm-msm/list/?series=638776
>     -- https://patchwork.kernel.org/project/linux-arm-msm/list/?series=634597
>     -- https://patchwork.kernel.org/project/linux-clk/list/?series=637999
>     -- https://patchwork.kernel.org/project/linux-arm-msm/list/?series=638002
> 
> [...]

Applied, thanks!

[01/12] arm64: dts: qcom: sc7280: Add nodes for soundwire and va tx rx digital macro codecs
        commit: 12ef689f09abb50f0862c8e08138dd45cbf27233
[02/12] arm64: dts: qcom: sc7280: Enable digital codecs and soundwire for CRD 1.0/2.0 and IDP boards
        commit: d3219de8bcebe4057696a2f99ce90c8812114c78
[03/12] arm64: dts: qcom: sc7280: Enable digital codecs and soundwire for CRD 3.0/3.1
        commit: d5a959f96be1b27c81d6197d66624cd6cc146fe6
[04/12] arm64: dts: qcom: sc7280: Add wcd9385 codec node for CRD 1.0/2.0 and IDP boards
        commit: f8b4eb64f2003e0a1fa5011009955d46f90af285
[05/12] arm64: dts: qcom: sc7280: Add wcd9385 codec node for CRD 3.0/3.1
        commit: 0a3a56a93fd96cb3e3d42778f275e91750c242a7
[06/12] arm64: dts: qcom: sc7280: Add max98360a codec for CRD 1.0/2.0 and IDP boards
        commit: d6c006f510d9f29ff78761bb3ef50f14ebc05b7b
[07/12] arm64: dts: qcom: sc7280: herobrine: Add max98360a codec node
        commit: 14afeaf917375967bb84b4347cd8e4156b84c470
[08/12] arm64: dts: qcom: sc7280: Add lpass cpu node
        commit: aee6873edb93a3919706f70884e55880d8c727a5
[09/12] arm64: dts: qcom: sc7280: Enable lpass cpu node for CRD 1.0/2.0 and IDP boards.
        commit: 8cf4133bc1fbb6fbc695e4398b940caf3ec59ba5
[10/12] arm64: dts: qcom: sc7280: Enable lpass cpu node for CRD 3.0/3.1
        commit: f10c73ac6e90ca2343fc4f06b61ce8c1824c9bfd
[11/12] arm64: dts: qcom: sc7280: Add sound node for CRD 1.0/2.0 and IDP boards
        commit: ece7d81f2447f4fd4f5d5345e921036871babf2b
[12/12] arm64: dts: qcom: sc7280: Add sound node for CRD 3.0/3.1
        commit: 29e0b604f040ef794cd36d43b97bd9c040ed99e6

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>