The following changes since commit 757a34115e7491744a63dfc3d291fd1de5297ee2:

  Merge tag 'pull-nvme-20250515' of https://gitlab.com/birkelund/qemu into staging (2025-05-15 13:42:27 -0400)

are available in the Git repository at:

  https://gitlab.com/jsnow/qemu.git tags/python-pull-request

for you to fetch changes up to 818060c02a53df4b27bc86cbac3a26009996b6a4:

  qapi: delete un-needed python static analysis configs (2025-05-19 12:44:01 -0400)

----------------------------------------------------------------
Python PR

Add scripts/qapi and docs/sphinx/*qapi* to the Python static analysis checks

----------------------------------------------------------------

John Snow (5):
  qapi: Add some pylint ignores
  docs/qapidoc: linting fixes
  python: update missing dependencies from minreqs
  python: add qapi static analysis tests
  qapi: delete un-needed python static analysis configs

Markus Armbruster (1):
  python: Drop redundant warn_unused_configs = True

 docs/sphinx/qapi_domain.py  | 25 ++++++++++++++-----------
 docs/sphinx/qapidoc.py      |  5 +++--
 python/setup.cfg            |  2 +-
 python/tests/minreqs.txt    | 25 +++++++++++++++++++++++++
 python/tests/qapi-flake8.sh |  4 ++++
 python/tests/qapi-isort.sh  |  6 ++++++
 python/tests/qapi-mypy.sh   |  2 ++
 python/tests/qapi-pylint.sh |  6 ++++++
 scripts/qapi/.flake8        |  3 ---
 scripts/qapi/.isort.cfg     |  7 -------
 scripts/qapi/backend.py     |  2 ++
 scripts/qapi/mypy.ini       |  4 ----
 scripts/qapi/pylintrc       |  1 +
 13 files changed, 64 insertions(+), 28 deletions(-)
 create mode 100755 python/tests/qapi-flake8.sh
 create mode 100755 python/tests/qapi-isort.sh
 create mode 100755 python/tests/qapi-mypy.sh
 create mode 100755 python/tests/qapi-pylint.sh
 delete mode 100644 scripts/qapi/.flake8
 delete mode 100644 scripts/qapi/.isort.cfg
 delete mode 100644 scripts/qapi/mypy.ini

-- 
2.48.1

Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes.

On Tue, May 20, 2025 at 9:38 AM Stefan Hajnoczi <stefanha@redhat.com> wrote:

> Applied, thanks.
>
> Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for
> any user-visible changes.
>

Did these get dropped? I don't see them in origin/master.

--js

On Fri, May 23, 2025 at 1:40 PM John Snow <jsnow@redhat.com> wrote:
> On Tue, May 20, 2025 at 9:38 AM Stefan Hajnoczi <stefanha@redhat.com> wrote:
>>
>> Applied, thanks.
>>
>> Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes.
>
>
> Did these get dropped? I don't see them in origin/master.

Hi John,
Sorry, I missed an error message from the script that applies pull
requests. It was unable to parse your message.

The email uses content encoding quoted-printable and the text body
encodes carriage return characters (see =0D in the raw message at
https://lore.kernel.org/qemu-devel/20250519170055.3693275-1-jsnow%40redhat.com/raw).

I updated the script to discard the carriage returns when decoding the
message and it can parse your email now. Your pull request is running
through CI now:
https://gitlab.com/qemu-project/qemu/-/pipelines/1833846709

Stefan

On Mon, May 19, 2025 at 1:03 PM John Snow <jsnow@redhat.com> wrote:
>
> The following changes since commit 757a34115e7491744a63dfc3d291fd1de5297ee2:
>
>   Merge tag 'pull-nvme-20250515' of https://gitlab.com/birkelund/qemu into staging (2025-05-15 13:42:27 -0400)
>
> are available in the Git repository at:
>
>   https://gitlab.com/jsnow/qemu.git tags/python-pull-request
>
> for you to fetch changes up to 818060c02a53df4b27bc86cbac3a26009996b6a4:
>
>   qapi: delete un-needed python static analysis configs (2025-05-19 12:44:01 -0400)
>
> ----------------------------------------------------------------
> Python PR
>
> Add scripts/qapi and docs/sphinx/*qapi* to the Python static analysis checks
>
> ----------------------------------------------------------------

Please take a look at this CI failure:
https://gitlab.com/qemu-project/qemu/-/jobs/10135225231#L448

Thanks,
Stefan

>
> John Snow (5):
>   qapi: Add some pylint ignores
>   docs/qapidoc: linting fixes
>   python: update missing dependencies from minreqs
>   python: add qapi static analysis tests
>   qapi: delete un-needed python static analysis configs
>
> Markus Armbruster (1):
>   python: Drop redundant warn_unused_configs = True
>
>  docs/sphinx/qapi_domain.py  | 25 ++++++++++++++-----------
>  docs/sphinx/qapidoc.py      |  5 +++--
>  python/setup.cfg            |  2 +-
>  python/tests/minreqs.txt    | 25 +++++++++++++++++++++++++
>  python/tests/qapi-flake8.sh |  4 ++++
>  python/tests/qapi-isort.sh  |  6 ++++++
>  python/tests/qapi-mypy.sh   |  2 ++
>  python/tests/qapi-pylint.sh |  6 ++++++
>  scripts/qapi/.flake8        |  3 ---
>  scripts/qapi/.isort.cfg     |  7 -------
>  scripts/qapi/backend.py     |  2 ++
>  scripts/qapi/mypy.ini       |  4 ----
>  scripts/qapi/pylintrc       |  1 +
>  13 files changed, 64 insertions(+), 28 deletions(-)
>  create mode 100755 python/tests/qapi-flake8.sh
>  create mode 100755 python/tests/qapi-isort.sh
>  create mode 100755 python/tests/qapi-mypy.sh
>  create mode 100755 python/tests/qapi-pylint.sh
>  delete mode 100644 scripts/qapi/.flake8
>  delete mode 100644 scripts/qapi/.isort.cfg
>  delete mode 100644 scripts/qapi/mypy.ini
>
> --
> 2.48.1
>
>
>

On Fri, May 23, 2025 at 3:45 PM Stefan Hajnoczi <stefanha@gmail.com> wrote:

> On Mon, May 19, 2025 at 1:03 PM John Snow <jsnow@redhat.com> wrote:
> >
> > The following changes since commit
> 757a34115e7491744a63dfc3d291fd1de5297ee2:
> >
> >   Merge tag 'pull-nvme-20250515' of https://gitlab.com/birkelund/qemu
> into staging (2025-05-15 13:42:27 -0400)
> >
> > are available in the Git repository at:
> >
> >   https://gitlab.com/jsnow/qemu.git tags/python-pull-request
> >
> > for you to fetch changes up to 818060c02a53df4b27bc86cbac3a26009996b6a4:
> >
> >   qapi: delete un-needed python static analysis configs (2025-05-19
> 12:44:01 -0400)
> >
> > ----------------------------------------------------------------
> > Python PR
> >
> > Add scripts/qapi and docs/sphinx/*qapi* to the Python static analysis
> checks
> >
> > ----------------------------------------------------------------
>
> Please take a look at this CI failure:
> https://gitlab.com/qemu-project/qemu/-/jobs/10135225231#L448


Well, that's interesting. Maybe something changed in the interim ...
investigating now, thank you - I will send a v2 PR if appropriate when I
identify the cause.

Thanks!
~js


>
>
> Thanks,
> Stefan
>
> >
> > John Snow (5):
> >   qapi: Add some pylint ignores
> >   docs/qapidoc: linting fixes
> >   python: update missing dependencies from minreqs
> >   python: add qapi static analysis tests
> >   qapi: delete un-needed python static analysis configs
> >
> > Markus Armbruster (1):
> >   python: Drop redundant warn_unused_configs = True
> >
> >  docs/sphinx/qapi_domain.py  | 25 ++++++++++++++-----------
> >  docs/sphinx/qapidoc.py      |  5 +++--
> >  python/setup.cfg            |  2 +-
> >  python/tests/minreqs.txt    | 25 +++++++++++++++++++++++++
> >  python/tests/qapi-flake8.sh |  4 ++++
> >  python/tests/qapi-isort.sh  |  6 ++++++
> >  python/tests/qapi-mypy.sh   |  2 ++
> >  python/tests/qapi-pylint.sh |  6 ++++++
> >  scripts/qapi/.flake8        |  3 ---
> >  scripts/qapi/.isort.cfg     |  7 -------
> >  scripts/qapi/backend.py     |  2 ++
> >  scripts/qapi/mypy.ini       |  4 ----
> >  scripts/qapi/pylintrc       |  1 +
> >  13 files changed, 64 insertions(+), 28 deletions(-)
> >  create mode 100755 python/tests/qapi-flake8.sh
> >  create mode 100755 python/tests/qapi-isort.sh
> >  create mode 100755 python/tests/qapi-mypy.sh
> >  create mode 100755 python/tests/qapi-pylint.sh
> >  delete mode 100644 scripts/qapi/.flake8
> >  delete mode 100644 scripts/qapi/.isort.cfg
> >  delete mode 100644 scripts/qapi/mypy.ini
> >
> > --
> > 2.48.1
> >
> >
> >
>
>