From nobody Sat Nov 15 20:48:57 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1747674136; cv=none; d=zohomail.com; s=zohoarc; b=nO0RvXnTv/cAW3SV3WYYSAwuffyrVRz7D9KRcT/oJ77NWJx0aRTEpewQu7e8zcnW6zh7I9xtJQYK7u73e3pgkG6YGuFGjUpn0yODod/yoeVEh9zWxhfL9XRAtEQlBY/oi9RfeSm8IX+rgxZEr+aNJ/GF++XHBvQ7PSQ+lcNrpZ8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1747674136; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=jPRU8El0TvAdjD+sXu4gHgBVG1p6BhnFnrUSgwwyZ9o=; b=SSPLuDOnN6II4U9Q7AI+tkRyzX0zX+2/FCU+hMXf+MRlphLQsxzFGkQgKoZX/DfgX1Vn6QpNljpBgzCbHHqn0mu2ghGHqUEJz+gMUNZ2+Z85g2b4Muko2nB+n+voIF7WAdN1o6YG7h/La93awjWn5gfdYMtwnzxfZruE0TGgsAg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1747674136403686.0626353503654; Mon, 19 May 2025 10:02:16 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uH3ro-00079w-Ds; Mon, 19 May 2025 13:01:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uH3rS-00078D-Hm for qemu-devel@nongnu.org; Mon, 19 May 2025 13:01:11 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uH3rN-0000DP-Vr for qemu-devel@nongnu.org; Mon, 19 May 2025 13:01:10 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-230-kh0EbRw7OYygYkXF9Lk4aQ-1; Mon, 19 May 2025 13:01:02 -0400 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0940A180045B; Mon, 19 May 2025 17:01:01 +0000 (UTC) Received: from jsnow-thinkpadp16vgen1.westford.csb (unknown [10.22.89.235]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id B86FC1956095; Mon, 19 May 2025 17:00:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747674065; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jPRU8El0TvAdjD+sXu4gHgBVG1p6BhnFnrUSgwwyZ9o=; b=jBfj0PcDt13FqOY6acJRqFVOhzSaXzButNzkd4f8epHp0yha9CoVuYVx6CjTG7x5tdVwJm O2+Lkqk5kxnsNoY+EMwIaWpBEdRmg8+HQ0DYvPqqAU3KZ9SiC1/Vllp6rVfHQkgLjHQUFR cJAje/oFsaiOWgJK398mT0bnNxPOucM= X-MC-Unique: kh0EbRw7OYygYkXF9Lk4aQ-1 X-Mimecast-MFC-AGG-ID: kh0EbRw7OYygYkXF9Lk4aQ_1747674061 From: John Snow To: qemu-devel@nongnu.org Cc: Cleber Rosa , Michael Roth , John Snow , Markus Armbruster , Peter Maydell Subject: [PULL 1/6] qapi: Add some pylint ignores Date: Mon, 19 May 2025 13:00:50 -0400 Message-ID: <20250519170055.3693275-2-jsnow@redhat.com> In-Reply-To: <20250519170055.3693275-1-jsnow@redhat.com> References: <20250519170055.3693275-1-jsnow@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=-1, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1747674139147116600 Content-Type: text/plain; charset="utf-8" This restores the linting baseline in QAPI. Signed-off-by: John Snow Reviewed-by: Markus Armbruster Message-id: 20250512193357.3388514-2-jsnow@redhat.com Signed-off-by: John Snow --- scripts/qapi/backend.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/qapi/backend.py b/scripts/qapi/backend.py index 14e60aa67af..49ae6ecdd33 100644 --- a/scripts/qapi/backend.py +++ b/scripts/qapi/backend.py @@ -13,6 +13,7 @@ =20 =20 class QAPIBackend(ABC): + # pylint: disable=3Dtoo-few-public-methods =20 @abstractmethod def generate(self, @@ -36,6 +37,7 @@ def generate(self, =20 =20 class QAPICBackend(QAPIBackend): + # pylint: disable=3Dtoo-few-public-methods =20 def generate(self, schema: QAPISchema, --=20 2.48.1 From nobody Sat Nov 15 20:48:57 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1747674168; cv=none; d=zohomail.com; s=zohoarc; b=nGK4Cpgi0d7Le5dmP+uG/fq2wtAog1zVtPS7o6JvbIObOtCYf3N2nEHUPAeaT+NNi7OdmoogeGAoB+wcpDuALc2aF6WsGv/zDIBSppz8DDzmZqrDQQSRuAAArusQ3nU2HGjGK1z1AP0oRjJ6SUmFRneeI+cKh8SHiGWf9j8un8o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1747674168; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=PfvMmpiH74ETfKF0gYAIqykF4EKJoqp2DIO9IuZE8rg=; b=lCFRfG488ZZCSpt8LArIwEc9nnn1/9tqt2VGaXuOFnw5Z/CD4yqKCBrjzsrJB+Awy/reJMQdBKzSQdZ2e3HnOkexsSsi/qmOgQFFL6+kLubtBpIt1c/HNS/fTnuwy7w8xjLYrOdi11Hfo3X2NiRl3a9TjIrGnRvEaC40As2sLXI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1747674168499301.46897157207843; Mon, 19 May 2025 10:02:48 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uH3ro-0007A8-Dw; Mon, 19 May 2025 13:01:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uH3rX-00078d-M9 for qemu-devel@nongnu.org; Mon, 19 May 2025 13:01:21 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uH3rV-0000GP-Kr for qemu-devel@nongnu.org; Mon, 19 May 2025 13:01:15 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-227-LqZ9bc3RO8u0RG56E8kxgQ-1; Mon, 19 May 2025 13:01:04 -0400 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 251311800256; Mon, 19 May 2025 17:01:03 +0000 (UTC) Received: from jsnow-thinkpadp16vgen1.westford.csb (unknown [10.22.89.235]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 4E1C41956095; Mon, 19 May 2025 17:01:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747674072; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PfvMmpiH74ETfKF0gYAIqykF4EKJoqp2DIO9IuZE8rg=; b=KVUHtQC5sH++6Qs/yALUQ5Rlz+Z6jIprFvowpHjikl7f+hfVumuoGERqpGo6CDDITjAVsF 23N7Qc+7yjiVOT3GI3gC8zdvVzS9STa1Wdn8V82xTrYBTPTzUeFTXfcomiVdPRAl+sehmc tnw6yNlA3n1ZOknJw2+8zeyex9252dc= X-MC-Unique: LqZ9bc3RO8u0RG56E8kxgQ-1 X-Mimecast-MFC-AGG-ID: LqZ9bc3RO8u0RG56E8kxgQ_1747674063 From: John Snow To: qemu-devel@nongnu.org Cc: Cleber Rosa , Michael Roth , John Snow , Markus Armbruster , Peter Maydell Subject: [PULL 2/6] docs/qapidoc: linting fixes Date: Mon, 19 May 2025 13:00:51 -0400 Message-ID: <20250519170055.3693275-3-jsnow@redhat.com> In-Reply-To: <20250519170055.3693275-1-jsnow@redhat.com> References: <20250519170055.3693275-1-jsnow@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.13, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=-1, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1747674169810116600 Content-Type: text/plain; charset="utf-8" This restores the linting baseline in qapidoc. The order of some imports change slightly here due to configuring isort a little better: previously, isort was having difficulty understanding that "compat" and "qapidoc_legacy" were local modules because docs/sphinx "isn't a python package". Configuring this manually, isort chooses a different import ordering, which _is_ intentional here. Also: extra ignores are added for pylint. The most recent versions of pylint don't require these ignores, but the oldest versions we support do, so in the extra ignores go. Signed-off-by: John Snow Reviewed-by: Markus Armbruster Message-id: 20250512193357.3388514-3-jsnow@redhat.com Signed-off-by: John Snow --- docs/sphinx/qapi_domain.py | 25 ++++++++++++++----------- docs/sphinx/qapidoc.py | 5 +++-- 2 files changed, 17 insertions(+), 13 deletions(-) diff --git a/docs/sphinx/qapi_domain.py b/docs/sphinx/qapi_domain.py index c94af5719ca..ebc46a72c61 100644 --- a/docs/sphinx/qapi_domain.py +++ b/docs/sphinx/qapi_domain.py @@ -20,16 +20,6 @@ =20 from docutils import nodes from docutils.parsers.rst import directives - -from compat import ( - CompatField, - CompatGroupedField, - CompatTypedField, - KeywordNode, - ParserFix, - Signature, - SpaceNode, -) from sphinx import addnodes from sphinx.directives import ObjectDescription from sphinx.domains import ( @@ -44,6 +34,16 @@ from sphinx.util.docutils import SphinxDirective from sphinx.util.nodes import make_id, make_refnode =20 +from compat import ( + CompatField, + CompatGroupedField, + CompatTypedField, + KeywordNode, + ParserFix, + Signature, + SpaceNode, +) + =20 if TYPE_CHECKING: from typing import ( @@ -56,7 +56,6 @@ ) =20 from docutils.nodes import Element, Node - from sphinx.addnodes import desc_signature, pending_xref from sphinx.application import Sphinx from sphinx.builders import Builder @@ -168,6 +167,8 @@ class QAPIDescription(ParserFix): """ =20 def handle_signature(self, sig: str, signode: desc_signature) -> Signa= ture: + # pylint: disable=3Dunused-argument + # Do nothing. The return value here is the "name" of the entity # being documented; for QAPI, this is the same as the # "signature", which is just a name. @@ -210,6 +211,8 @@ def _get_fqn(self, name: Signature) -> str: def add_target_and_index( self, name: Signature, sig: str, signode: desc_signature ) -> None: + # pylint: disable=3Dunused-argument + # name is the return value of handle_signature. # sig is the original, raw text argument to handle_signature. # For QAPI, these are identical, currently. diff --git a/docs/sphinx/qapidoc.py b/docs/sphinx/qapidoc.py index 661b2c4ed0e..8011ac9efaf 100644 --- a/docs/sphinx/qapidoc.py +++ b/docs/sphinx/qapidoc.py @@ -27,6 +27,7 @@ =20 from __future__ import annotations =20 + __version__ =3D "2.0" =20 from contextlib import contextmanager @@ -56,8 +57,6 @@ QAPISchemaVisitor, ) from qapi.source import QAPISourceInfo - -from qapidoc_legacy import QAPISchemaGenRSTVisitor # type: ignore from sphinx import addnodes from sphinx.directives.code import CodeBlock from sphinx.errors import ExtensionError @@ -65,6 +64,8 @@ from sphinx.util.docutils import SphinxDirective, switch_source_input from sphinx.util.nodes import nested_parse_with_titles =20 +from qapidoc_legacy import QAPISchemaGenRSTVisitor # type: ignore + =20 if TYPE_CHECKING: from typing import ( --=20 2.48.1 From nobody Sat Nov 15 20:48:57 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1747674164; cv=none; d=zohomail.com; s=zohoarc; b=cATQBzetAmeF3+MPUEbS/Uo3SAJbovg8oGEh4CT/VAM5FrnNYfhGAh5wptAfQsHy/Ic5DmfEiM53I8p8qfBHiECmHXwwcgQaN+ms3W8/xabW2P36P6TZ6h26/+rDMoxS/fPcF3tkQmH89iKznItjyFpZCrD0tPu+iXi6tvF7aS0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1747674164; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=0e97MUo4GStcsTg/gF26ItM8AvBXil0RiJiTrucnajg=; b=EwYpNrPOSS5jHCUpqfV4XVtzmQ91L8nrRSKJCzBHJjnPk1AsFadQhUG+LUKdn+XsIWKPDqXivTb+OF6kKL11ejq2pa7g6BzlwolOFF8pPRQlEI7lRyUu2iy7v6cRv5bURl8ZrLcp5MIJHeSvibrXJRl3AqyQVwfMBGRHMyCsolU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1747674164190126.14661469699342; Mon, 19 May 2025 10:02:44 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uH3rp-0007B5-9t; Mon, 19 May 2025 13:01:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uH3rY-00078f-PT for qemu-devel@nongnu.org; Mon, 19 May 2025 13:01:21 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uH3rV-0000Gs-Ve for qemu-devel@nongnu.org; Mon, 19 May 2025 13:01:16 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-615-ftlgTjl4M9CLOUof4cFYvQ-1; Mon, 19 May 2025 13:01:07 -0400 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A5C691800773; Mon, 19 May 2025 17:01:05 +0000 (UTC) Received: from jsnow-thinkpadp16vgen1.westford.csb (unknown [10.22.89.235]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 6B6281955F21; Mon, 19 May 2025 17:01:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747674073; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0e97MUo4GStcsTg/gF26ItM8AvBXil0RiJiTrucnajg=; b=cEnu+tU+AKpeOMrPs7/5XZ9LBQmLQfp1ka+US7WqjAhyLTfNDQDbT0ClRwqLc3CNe3raov IG9F5dm3JkNkSdIDoidzk2bH5H549FuRejhD6uZ2gI9jPo4dpTCWzIyrWJWUvzsg8S3g+a iYFylbuN2j6TrSgYfGtc+TmCMN2GgtI= X-MC-Unique: ftlgTjl4M9CLOUof4cFYvQ-1 X-Mimecast-MFC-AGG-ID: ftlgTjl4M9CLOUof4cFYvQ_1747674065 From: John Snow To: qemu-devel@nongnu.org Cc: Cleber Rosa , Michael Roth , John Snow , Markus Armbruster , Peter Maydell Subject: [PULL 3/6] python: update missing dependencies from minreqs Date: Mon, 19 May 2025 13:00:52 -0400 Message-ID: <20250519170055.3693275-4-jsnow@redhat.com> In-Reply-To: <20250519170055.3693275-1-jsnow@redhat.com> References: <20250519170055.3693275-1-jsnow@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.13, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=-1, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1747674165569116600 Content-Type: text/plain; charset="utf-8" We pin all dependencies for the "check-minreqs" test because pip lacks a dependency resolver that installs "the oldest possible package that meets dependency criteria". So, in order to test our stated minimum requirements, we pin all of our dependencies (and their dependencies, transitively) at the oldest possible versions that still work and pass tests; proving that our minimum requirements are correct. (It also ensures no new features accidentally sneak in from developers on newer platforms.) A few transitive dependencies were omitted from the pinned dependency file by accident; as a result, pip's dependency solver can pull in newer dependencies, which we don't want. This patch corrects the previous oversight and pins the missing dependencies. Signed-off-by: John Snow Reviewed-by: Markus Armbruster Message-id: 20250512193357.3388514-4-jsnow@redhat.com Signed-off-by: John Snow --- python/tests/minreqs.txt | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/python/tests/minreqs.txt b/python/tests/minreqs.txt index 6445407ba87..d3d53e0da81 100644 --- a/python/tests/minreqs.txt +++ b/python/tests/minreqs.txt @@ -38,10 +38,14 @@ pyflakes=3D=3D2.5.0 =20 # Transitive mypy dependencies mypy-extensions=3D=3D1.0.0 +tomli=3D=3D1.1.0 typing-extensions=3D=3D4.7.1 =20 # Transitive pylint dependencies astroid=3D=3D2.15.4 +dill=3D=3D0.2 lazy-object-proxy=3D=3D1.4.0 +platformdirs=3D=3D2.2.0 toml=3D=3D0.10.0 +tomlkit=3D=3D0.10.1 wrapt=3D=3D1.14.0 --=20 2.48.1 From nobody Sat Nov 15 20:48:57 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1747674160; cv=none; d=zohomail.com; s=zohoarc; b=Eixt3VYY53Up0koWSeml41WnGT/uB8zZ/8SsxoDs/fdx2Q89zxGCVLsHtwQ/XFlMsbC/R37fXvZAKKeu/yWftOivLO/bXvbb7HlDVkW4d8F9CwwGxhZd/GgKoR6lfrXK0Sb8Mmv9APdvL1XCTyY6535gc/Ae8yd9hzNCBTmZ/g8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1747674160; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=3Ss10PBgQlOLfC44pZmhen3k/GDdrP0djwhFTen6dTU=; b=h0PFkAuwPVSpDxw44okzNvUEe799CPaoYeOzO0CNmxDYzcTQI8a+GZLQGwonk/O6v2P54iNcz1jmKeMmng97Py8FFW6/uIURkd0xljUMef448SxcSljWA2AiEHYJaItyc7fMaasTMLxq7Ymqb6U2omuvhVWyKvVx44VcaR+G3f8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1747674159994908.2364383346355; Mon, 19 May 2025 10:02:39 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uH3rs-0007Cp-Sy; Mon, 19 May 2025 13:01:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uH3rX-00078c-H9 for qemu-devel@nongnu.org; Mon, 19 May 2025 13:01:21 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uH3rV-0000GE-5J for qemu-devel@nongnu.org; Mon, 19 May 2025 13:01:15 -0400 Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-590-6LXYQ8mLPTacuxCMa-X80w-1; Mon, 19 May 2025 13:01:08 -0400 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 802E21956089; Mon, 19 May 2025 17:01:07 +0000 (UTC) Received: from jsnow-thinkpadp16vgen1.westford.csb (unknown [10.22.89.235]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id E9A861956095; Mon, 19 May 2025 17:01:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747674072; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3Ss10PBgQlOLfC44pZmhen3k/GDdrP0djwhFTen6dTU=; b=K26cCslpTuuRbQDXaDS9ZiozRVX05To1yR8+ahIRoGRI3HFDFvPBSsoMortW3LCgDvgo8U Pr5Lg+rk2xMiWvytb58Z4mcX4pM55D/K7UIlfwjApY+2XdC5oHu3DYznMT8aSVK1cgHJjz GI4ZGXtX8TEb1GSLMtMVth3hGt+l/n8= X-MC-Unique: 6LXYQ8mLPTacuxCMa-X80w-1 X-Mimecast-MFC-AGG-ID: 6LXYQ8mLPTacuxCMa-X80w_1747674067 From: John Snow To: qemu-devel@nongnu.org Cc: Cleber Rosa , Michael Roth , John Snow , Markus Armbruster , Peter Maydell Subject: [PULL 4/6] python: add qapi static analysis tests Date: Mon, 19 May 2025 13:00:53 -0400 Message-ID: <20250519170055.3693275-5-jsnow@redhat.com> In-Reply-To: <20250519170055.3693275-1-jsnow@redhat.com> References: <20250519170055.3693275-1-jsnow@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.13, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=-1, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1747674161768116600 Content-Type: text/plain; charset="utf-8" Update the python tests to also check QAPI and the QAPI Sphinx extensions. The docs/sphinx/qapidoc_legacy.py file is not included in these checks, as it is destined for removal soon. mypy is also not called on the QAPI Sphinx extensions, owing to difficulties supporting Sphinx 3.x - 8.x while maintaining static type checking support. mypy *is* called on all of the QAPI tools themselves, though. flake8, isort and mypy use the tool configuration from the existing python directory (in setup.cfg). pylint continues to use the special configuration located in scripts/qapi/ - that configuration is more permissive. If we wish to unify the two configurations, that's a separate series and a discussion for a later date. The list of pylint ignores is also updated, owing again to the wide window of pylint version support: newer versions require pragmas to occasionally silence the "too many positional arguments" warning, but older versions do not have such a warning category and will instead yelp about an unrecognized option. Silence that warning, too. As a result of this patch, one would be able to run any of the following tests locally from the qemu.git/python directory and have it cover the QAPI tooling as well. All of the following options run the python tests, static analysis tests, and linter checks; but with different combinations of dependencies and interpreters. - "make check-minreqs" Run tests specifically under our oldest supported Python and our oldest supported dependencies. This is the test that runs on GitLab as "check-python-minreqs". This helps ensure we do not regress support on older platforms accidentally. - "make check-tox" Runs the tests under the newest supported dependencies, but under each supported version of Python in turn. At time of writing, this is Python 3.8 to 3.13 inclusive. This test helps catch bleeding-edge problems before they become problems for developer workstations. This is the GitLab test "check-python-tox" and is an optionally run, may-fail test due to the unpredictable nature of new dependencies being released into the ecosystem that may cause regressions. - "make check-dev" Runs the tests under the newest supported dependencies using whatever version of Python the user happens to have installed. This is a quick convenience check that does not map to any particular GitLab test. (Note! check-dev may be busted on Fedora 41 and bleeding edge versions of setuptools. That's unrelated to this patch and I'll address it separately and soon. Thank you for your patience, --mgmt) Finally, finally, finally: this means that QAPI tooling will be linted and type-checked from the GitLab pipelines. Signed-off-by: John Snow Reviewed-by: Markus Armbruster Message-id: 20250512193357.3388514-5-jsnow@redhat.com Signed-off-by: John Snow --- python/setup.cfg | 1 + python/tests/minreqs.txt | 21 +++++++++++++++++++++ python/tests/qapi-flake8.sh | 4 ++++ python/tests/qapi-isort.sh | 6 ++++++ python/tests/qapi-mypy.sh | 2 ++ python/tests/qapi-pylint.sh | 6 ++++++ scripts/qapi/pylintrc | 1 + 7 files changed, 41 insertions(+) create mode 100755 python/tests/qapi-flake8.sh create mode 100755 python/tests/qapi-isort.sh create mode 100755 python/tests/qapi-mypy.sh create mode 100755 python/tests/qapi-pylint.sh diff --git a/python/setup.cfg b/python/setup.cfg index c48dff280a3..d21304cadd1 100644 --- a/python/setup.cfg +++ b/python/setup.cfg @@ -46,6 +46,7 @@ devel =3D urwid >=3D 2.1.2 urwid-readline >=3D 0.13 Pygments >=3D 2.9.0 + sphinx >=3D 3.4.3 =20 # Provides qom-fuse functionality fuse =3D diff --git a/python/tests/minreqs.txt b/python/tests/minreqs.txt index d3d53e0da81..3cc6f7bf4e3 100644 --- a/python/tests/minreqs.txt +++ b/python/tests/minreqs.txt @@ -11,6 +11,9 @@ # When adding new dependencies, pin the very oldest non-yanked version # on PyPI that allows the test suite to pass. =20 +# Dependencies for qapidoc/qapi_domain et al +sphinx=3D=3D3.4.3 + # Dependencies for the TUI addon (Required for successful linting) urwid=3D=3D2.1.2 urwid-readline=3D=3D0.13 @@ -49,3 +52,21 @@ platformdirs=3D=3D2.2.0 toml=3D=3D0.10.0 tomlkit=3D=3D0.10.1 wrapt=3D=3D1.14.0 + +# Transitive sphinx dependencies +Jinja2=3D=3D2.7 +MarkupSafe=3D=3D1.1.0 +alabaster=3D=3D0.7.1 +babel=3D=3D1.3 +docutils=3D=3D0.12 +imagesize=3D=3D0.5.0 +packaging=3D=3D14.0 +pytz=3D=3D2011b0 +requests=3D=3D2.5.0 +snowballstemmer=3D=3D1.1 +sphinxcontrib-applehelp=3D=3D1.0.0 +sphinxcontrib-devhelp=3D=3D1.0.0 +sphinxcontrib-htmlhelp=3D=3D1.0.0 +sphinxcontrib-jsmath=3D=3D1.0.0 +sphinxcontrib-qthelp=3D=3D1.0.0 +sphinxcontrib-serializinghtml=3D=3D1.0.0 diff --git a/python/tests/qapi-flake8.sh b/python/tests/qapi-flake8.sh new file mode 100755 index 00000000000..7b5983d64a9 --- /dev/null +++ b/python/tests/qapi-flake8.sh @@ -0,0 +1,4 @@ +#!/bin/sh -e +python3 -m flake8 ../scripts/qapi/ \ + ../docs/sphinx/qapidoc.py \ + ../docs/sphinx/qapi_domain.py diff --git a/python/tests/qapi-isort.sh b/python/tests/qapi-isort.sh new file mode 100755 index 00000000000..f31f12d3425 --- /dev/null +++ b/python/tests/qapi-isort.sh @@ -0,0 +1,6 @@ +#!/bin/sh -e +python3 -m isort --sp . -c ../scripts/qapi/ +# Force isort to recognize "compat" as a local module and not third-party +python3 -m isort --sp . -c -p compat -p qapidoc_legacy \ + ../docs/sphinx/qapi_domain.py \ + ../docs/sphinx/qapidoc.py diff --git a/python/tests/qapi-mypy.sh b/python/tests/qapi-mypy.sh new file mode 100755 index 00000000000..377b29b873b --- /dev/null +++ b/python/tests/qapi-mypy.sh @@ -0,0 +1,2 @@ +#!/bin/sh -e +python3 -m mypy ../scripts/qapi diff --git a/python/tests/qapi-pylint.sh b/python/tests/qapi-pylint.sh new file mode 100755 index 00000000000..f4bb7a5a795 --- /dev/null +++ b/python/tests/qapi-pylint.sh @@ -0,0 +1,6 @@ +#!/bin/sh -e +SETUPTOOLS_USE_DISTUTILS=3Dstdlib python3 -m pylint \ + --rcfile=3D../scripts/qapi/pylintrc \ + ../scripts/qapi/ \ + ../docs/sphinx/qapidoc.py \ + ../docs/sphinx/qapi_domain.py diff --git a/scripts/qapi/pylintrc b/scripts/qapi/pylintrc index d24eece7411..e16283ada3d 100644 --- a/scripts/qapi/pylintrc +++ b/scripts/qapi/pylintrc @@ -19,6 +19,7 @@ disable=3Dconsider-using-f-string, too-many-instance-attributes, too-many-positional-arguments, too-many-statements, + unknown-option-value, useless-option-value, =20 [REPORTS] --=20 2.48.1 From nobody Sat Nov 15 20:48:57 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1747674159; cv=none; d=zohomail.com; s=zohoarc; b=Ib5E/sVXpY6apqZVubqT+CziVL2ICyYOcDuZIZiaBxFGgP2nedDcdJ4V4hToDiKToCqEP4tzdk/d9FCh1dGNLrcwVsHcCPTiYSe9jx7yLhH+I/TS3G0M7jdYXvI3BSyOLgXzewnPQWk+f62J1FO7G0IcHBV/hwKChB8H25LNATM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1747674159; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=r/AVeVI8CEy7pp93TAfOGvrG+MLYlclUmyqZ549525s=; b=YTSCaIsjLIiFYfVtowdxNRB7raltwVy7fxGLtrxzzsXwP2pTzowh4Y/8hQg5vhV4uWIRcCBztvkR1MS66xxjH/vTQesWTyq2rHfXZIxnDPICQaE7iF7XqOYmpunvntKQRvU0n9hb74hDU9nJdFzU/5m0K8UT6Ti+QeiHj2ZaPgY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1747674159193871.4873696918947; Mon, 19 May 2025 10:02:39 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uH3rs-0007CL-85; Mon, 19 May 2025 13:01:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uH3rY-00078g-RQ for qemu-devel@nongnu.org; Mon, 19 May 2025 13:01:21 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uH3rW-0000H4-3t for qemu-devel@nongnu.org; Mon, 19 May 2025 13:01:16 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-606-_S8JjaroNkqGwXB7AIWbXw-1; Mon, 19 May 2025 13:01:10 -0400 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 269E51800877; Mon, 19 May 2025 17:01:09 +0000 (UTC) Received: from jsnow-thinkpadp16vgen1.westford.csb (unknown [10.22.89.235]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id C593C1956095; Mon, 19 May 2025 17:01:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747674073; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=r/AVeVI8CEy7pp93TAfOGvrG+MLYlclUmyqZ549525s=; b=i0CLbdaxJxN2Zhp6QtPWyzWp3FIKNQH8IpH2tgVfodK7DsLNummXCZCyFD8b5Iuu1gsRBn EfHNS8aUqTjrE5VF0A2WuCuY4G1kXsXv1VWAi2pVxPfEwkISiXGvdJFwrZHLiCDB/bUDES SbaGyZmPmcRyO36aj/5kdIyirCz2vMs= X-MC-Unique: _S8JjaroNkqGwXB7AIWbXw-1 X-Mimecast-MFC-AGG-ID: _S8JjaroNkqGwXB7AIWbXw_1747674069 From: John Snow To: qemu-devel@nongnu.org Cc: Cleber Rosa , Michael Roth , John Snow , Markus Armbruster , Peter Maydell Subject: [PULL 5/6] python: Drop redundant warn_unused_configs = True Date: Mon, 19 May 2025 13:00:54 -0400 Message-ID: <20250519170055.3693275-6-jsnow@redhat.com> In-Reply-To: <20250519170055.3693275-1-jsnow@redhat.com> References: <20250519170055.3693275-1-jsnow@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.13, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=-1, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1747674161574116600 Content-Type: text/plain; charset="utf-8" From: Markus Armbruster strict =3D True implies warn_unused_configs =3D True. Signed-off-by: Markus Armbruster Signed-off-by: John Snow Reviewed-by: Markus Armbruster Message-id: 20250512193357.3388514-6-jsnow@redhat.com Signed-off-by: John Snow --- python/setup.cfg | 1 - 1 file changed, 1 deletion(-) diff --git a/python/setup.cfg b/python/setup.cfg index d21304cadd1..d7f5dc7bafe 100644 --- a/python/setup.cfg +++ b/python/setup.cfg @@ -79,7 +79,6 @@ exclude =3D __pycache__, [mypy] strict =3D True python_version =3D 3.9 -warn_unused_configs =3D True namespace_packages =3D True warn_unused_ignores =3D False =20 --=20 2.48.1 From nobody Sat Nov 15 20:48:57 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1747674151; cv=none; d=zohomail.com; s=zohoarc; b=C3J+xyVHzC6PR61Oi6m7VylWYE5Xjhyy29bpUEkhnUrYKLgZRexvow4yS3iCbmJSldF1MO0igWpd3GDEQC3l9X8tf/WKMZPuVE3YKIvtOZqOXc+BNguEG/6hHWOPwiaxN40XmVHnMiCiDjrZdKG7OXkCNYp9yLmoAnhXU+540Yc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1747674151; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=iYcUQ6WuU3gAxqcUjkwsmQLK288Uzr5IRoqnUeDlqWQ=; b=bS/hoHnISRdGsCWnQAqo3PHvQjMHMJfcju0TjKjEMPE2mg0rvE5nxbPlWggQl5yG8KCjD4tvo7VTJ9v7lCcm1WjFV7xQYx3Ji1mMI10nkWUGKjTDRvxP+FIdYVJBbh9hb+sYlmMgeBaRLvHsAkWo1UGXPVs8dHtk8aKcbYtSPxw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1747674151281371.2496364680925; Mon, 19 May 2025 10:02:31 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uH3rr-0007Bb-7G; Mon, 19 May 2025 13:01:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uH3rZ-00078v-MC for qemu-devel@nongnu.org; Mon, 19 May 2025 13:01:21 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uH3rY-0000Hq-6q for qemu-devel@nongnu.org; Mon, 19 May 2025 13:01:17 -0400 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-194-GFSh4BHrM_u_4g6JhbEx6w-1; Mon, 19 May 2025 13:01:12 -0400 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 179C51955D99; Mon, 19 May 2025 17:01:11 +0000 (UTC) Received: from jsnow-thinkpadp16vgen1.westford.csb (unknown [10.22.89.235]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 6AB361956095; Mon, 19 May 2025 17:01:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747674075; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iYcUQ6WuU3gAxqcUjkwsmQLK288Uzr5IRoqnUeDlqWQ=; b=P3VZVBukHXrea/viTnTSM0Ejg6teSwv7YTP/CRi6gR1Nb6PuKUWAlg6EhC7nQ03gKar2pn oHtpoN3QT+voQTMXU0CvrAygE6A7FuYbW/qQItAJ8M+VIvnBQ/fW2YVxzS/xrKebqVN33e zprMLMc2ayRWDgUy+4wq64P5O2MaY7A= X-MC-Unique: GFSh4BHrM_u_4g6JhbEx6w-1 X-Mimecast-MFC-AGG-ID: GFSh4BHrM_u_4g6JhbEx6w_1747674071 From: John Snow To: qemu-devel@nongnu.org Cc: Cleber Rosa , Michael Roth , John Snow , Markus Armbruster , Peter Maydell Subject: [PULL 6/6] qapi: delete un-needed python static analysis configs Date: Mon, 19 May 2025 13:00:55 -0400 Message-ID: <20250519170055.3693275-7-jsnow@redhat.com> In-Reply-To: <20250519170055.3693275-1-jsnow@redhat.com> References: <20250519170055.3693275-1-jsnow@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.13, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=-1, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1747674153628116600 Content-Type: text/plain; charset="utf-8" Since the previous commit, python/setup.cfg applies to scripts/qapi/ as well. Configuration files in scripts/qapi/ override python/setup.cfg. scripts/qapi/.flake8 and scripts/qapi/.isort.cfg actually match python/setup.cfg exactly, and can go. The differences between scripts/qapi/mypy.ini and python/setup.cfg are harmless: namespace_packages being set to True is a requirement for the PEP420 nested package structure of QEMU but not for scripts/qapi, but has no effect on type checking the QAPI code. warn_unused_ignores is used in python/ to be able to target a wide variety of mypy versions; some of which that have added new ignore categories that are not present in older versions. Ultimately, scripts/qapi/mypy.ini can be removed without any real change in behavior to how mypy enforces type safety there. The pylint config is being left in place because the settings differ enough from the python/ directory settings that we need a chit-chat on how to merge them O:-) Signed-off-by: John Snow Reviewed-by: Markus Armbruster Message-id: 20250512193357.3388514-7-jsnow@redhat.com Signed-off-by: John Snow --- scripts/qapi/.flake8 | 3 --- scripts/qapi/.isort.cfg | 7 ------- scripts/qapi/mypy.ini | 4 ---- 3 files changed, 14 deletions(-) delete mode 100644 scripts/qapi/.flake8 delete mode 100644 scripts/qapi/.isort.cfg delete mode 100644 scripts/qapi/mypy.ini diff --git a/scripts/qapi/.flake8 b/scripts/qapi/.flake8 deleted file mode 100644 index a873ff67309..00000000000 --- a/scripts/qapi/.flake8 +++ /dev/null @@ -1,3 +0,0 @@ -[flake8] -# Prefer pylint's bare-except checks to flake8's -extend-ignore =3D E722 diff --git a/scripts/qapi/.isort.cfg b/scripts/qapi/.isort.cfg deleted file mode 100644 index 643caa1fbd6..00000000000 --- a/scripts/qapi/.isort.cfg +++ /dev/null @@ -1,7 +0,0 @@ -[settings] -force_grid_wrap=3D4 -force_sort_within_sections=3DTrue -include_trailing_comma=3DTrue -line_length=3D72 -lines_after_imports=3D2 -multi_line_output=3D3 diff --git a/scripts/qapi/mypy.ini b/scripts/qapi/mypy.ini deleted file mode 100644 index c9dbcec2db0..00000000000 --- a/scripts/qapi/mypy.ini +++ /dev/null @@ -1,4 +0,0 @@ -[mypy] -strict =3D True -disallow_untyped_calls =3D False -python_version =3D 3.9 --=20 2.48.1