[PULL v2 00/44] Python patches

John Snow posted 44 patches 2 years, 10 months ago
Only 1 patches received!
docs/devel/testing.rst                      |  26 +++
python/PACKAGE.rst                          |  43 ++++
python/README.rst                           |  58 +++++
python/qemu/README.rst                      |   8 +
python/qemu/machine/README.rst              |   9 +
python/qemu/qmp/README.rst                  |   9 +
python/qemu/utils/README.rst                |   7 +
.gitlab-ci.d/containers.yml                 |   5 +
.gitlab-ci.d/static_checks.yml              |  21 ++
python/.gitignore                           |  16 ++
python/MANIFEST.in                          |   3 +
python/Makefile                             |  48 ++++
python/Pipfile                              |  13 ++
python/Pipfile.lock                         | 231 ++++++++++++++++++++
python/VERSION                              |   1 +
python/avocado.cfg                          |  10 +
python/mypy.ini                             |   4 -
python/qemu/.flake8                         |   2 -
python/qemu/.isort.cfg                      |   7 -
python/qemu/__init__.py                     |  11 -
python/qemu/machine/__init__.py             |  36 +++
python/qemu/{ => machine}/console_socket.py |  11 +-
python/qemu/{ => machine}/machine.py        |  68 ++++--
python/qemu/{ => machine}/qtest.py          |   9 +-
python/qemu/pylintrc                        |  58 -----
python/qemu/{qmp.py => qmp/__init__.py}     |  12 +-
python/qemu/utils/__init__.py               |  45 ++++
python/qemu/{ => utils}/accel.py            |   0
python/setup.cfg                            | 102 +++++++++
python/setup.py                             |  23 ++
python/tests/flake8.sh                      |   2 +
python/tests/isort.sh                       |   2 +
python/tests/mypy.sh                        |   2 +
python/tests/pylint.sh                      |   2 +
tests/acceptance/avocado_qemu/__init__.py   |  69 +++++-
tests/acceptance/boot_linux.py              |  18 +-
tests/acceptance/hotplug_cpu.py             |  37 ++++
tests/acceptance/info_usernet.py            |  29 +++
tests/acceptance/linux_ssh_mips_malta.py    |  42 +---
tests/acceptance/virtio-gpu.py              |   2 +-
tests/acceptance/virtiofs_submounts.py      |  71 +-----
tests/docker/dockerfiles/python.docker      |  18 ++
tests/qemu-iotests/297                      |   1 +
tests/qemu-iotests/300                      |   4 +-
tests/qemu-iotests/iotests.py               |   4 +-
tests/requirements.txt                      |   2 +-
tests/vm/aarch64vm.py                       |   2 +-
tests/vm/basevm.py                          |  12 +-
48 files changed, 967 insertions(+), 248 deletions(-)
create mode 100644 python/PACKAGE.rst
create mode 100644 python/README.rst
create mode 100644 python/qemu/README.rst
create mode 100644 python/qemu/machine/README.rst
create mode 100644 python/qemu/qmp/README.rst
create mode 100644 python/qemu/utils/README.rst
create mode 100644 python/.gitignore
create mode 100644 python/MANIFEST.in
create mode 100644 python/Makefile
create mode 100644 python/Pipfile
create mode 100644 python/Pipfile.lock
create mode 100644 python/VERSION
create mode 100644 python/avocado.cfg
delete mode 100644 python/mypy.ini
delete mode 100644 python/qemu/.flake8
delete mode 100644 python/qemu/.isort.cfg
delete mode 100644 python/qemu/__init__.py
create mode 100644 python/qemu/machine/__init__.py
rename python/qemu/{ => machine}/console_socket.py (94%)
rename python/qemu/{ => machine}/machine.py (93%)
rename python/qemu/{ => machine}/qtest.py (95%)
delete mode 100644 python/qemu/pylintrc
rename python/qemu/{qmp.py => qmp/__init__.py} (96%)
create mode 100644 python/qemu/utils/__init__.py
rename python/qemu/{ => utils}/accel.py (100%)
create mode 100644 python/setup.cfg
create mode 100755 python/setup.py
create mode 100755 python/tests/flake8.sh
create mode 100755 python/tests/isort.sh
create mode 100755 python/tests/mypy.sh
create mode 100755 python/tests/pylint.sh
create mode 100644 tests/acceptance/hotplug_cpu.py
create mode 100644 tests/acceptance/info_usernet.py
create mode 100644 tests/docker/dockerfiles/python.docker
[PULL v2 00/44] Python patches
Posted by John Snow 2 years, 10 months ago
The following changes since commit 52848929b70dcf92a68aedcfd90207be81ba3274:

  Merge remote-tracking branch 'remotes/kraxel/tags/usb-20210528-pull-request' into staging (2021-05-30 20:10:30 +0100)

are available in the Git repository at:

  https://gitlab.com/jsnow/qemu.git tags/python-pull-request

for you to fetch changes up to 6b9c277797879ce41ed20deb6737f4156cc279b3:

  gitlab: add python linters to CI (2021-06-01 16:21:21 -0400)

----------------------------------------------------------------
Pull request

V2:
 - Squashed in fixup for
   'Python: add utility function for retrieving port redirection'
 - Rebased on today's upstream

CI here:
https://gitlab.com/jsnow/qemu/-/pipelines/313202814

----------------------------------------------------------------

Cleber Rosa (12):
  Python: expose QEMUMachine's temporary directory
  tests/acceptance/virtiofs_submounts.py: add missing accel tag
  tests/acceptance/virtiofs_submounts.py: evaluate string not length
  Python: add utility function for retrieving port redirection
  Acceptance Tests: move useful ssh methods to base class
  Acceptance Tests: add port redirection for ssh by default
  Acceptance Tests: make username/password configurable
  Acceptance Tests: set up SSH connection by default after boot for
    LinuxTest
  tests/acceptance/virtiofs_submounts.py: remove launch_vm()
  Acceptance Tests: add basic documentation on LinuxTest base class
  Acceptance Tests: introduce CPU hotplug test
  tests/acceptance/virtiofs_submounts.py: fix setup of SSH pubkey

John Snow (31):
  python/console_socket: avoid one-letter variable
  python/machine: use subprocess.DEVNULL instead of
    open(os.path.devnull)
  python/machine: use subprocess.run instead of subprocess.Popen
  python/console_socket: Add a pylint ignore
  python/machine: Disable pylint warning for open() in _pre_launch
  python/machine: disable warning for Popen in _launch()
  python/machine: Trim line length to below 80 chars
  iotests/297: add --namespace-packages to mypy arguments
  python: create qemu packages
  python: add qemu package installer
  python: add VERSION file
  python: add directory structure README.rst files
  python: add MANIFEST.in
  python: Add pipenv support
  python: add pylint import exceptions
  python: move pylintrc into setup.cfg
  python: add pylint to pipenv
  python: move flake8 config to setup.cfg
  python: add excluded dirs to flake8 config
  python: Add flake8 to pipenv
  python: move mypy.ini into setup.cfg
  python: add mypy to pipenv
  python: move .isort.cfg into setup.cfg
  python/qemu: add isort to pipenv
  python/qemu: add qemu package itself to pipenv
  python: add devel package requirements to setuptools
  python: add avocado-framework and tests
  python: add Makefile for some common tasks
  python: add .gitignore
  python: add tox support
  gitlab: add python linters to CI

Willian Rampazzo (1):
  acceptance tests: bump Avocado version to 88.1

 docs/devel/testing.rst                      |  26 +++
 python/PACKAGE.rst                          |  43 ++++
 python/README.rst                           |  58 +++++
 python/qemu/README.rst                      |   8 +
 python/qemu/machine/README.rst              |   9 +
 python/qemu/qmp/README.rst                  |   9 +
 python/qemu/utils/README.rst                |   7 +
 .gitlab-ci.d/containers.yml                 |   5 +
 .gitlab-ci.d/static_checks.yml              |  21 ++
 python/.gitignore                           |  16 ++
 python/MANIFEST.in                          |   3 +
 python/Makefile                             |  48 ++++
 python/Pipfile                              |  13 ++
 python/Pipfile.lock                         | 231 ++++++++++++++++++++
 python/VERSION                              |   1 +
 python/avocado.cfg                          |  10 +
 python/mypy.ini                             |   4 -
 python/qemu/.flake8                         |   2 -
 python/qemu/.isort.cfg                      |   7 -
 python/qemu/__init__.py                     |  11 -
 python/qemu/machine/__init__.py             |  36 +++
 python/qemu/{ => machine}/console_socket.py |  11 +-
 python/qemu/{ => machine}/machine.py        |  68 ++++--
 python/qemu/{ => machine}/qtest.py          |   9 +-
 python/qemu/pylintrc                        |  58 -----
 python/qemu/{qmp.py => qmp/__init__.py}     |  12 +-
 python/qemu/utils/__init__.py               |  45 ++++
 python/qemu/{ => utils}/accel.py            |   0
 python/setup.cfg                            | 102 +++++++++
 python/setup.py                             |  23 ++
 python/tests/flake8.sh                      |   2 +
 python/tests/isort.sh                       |   2 +
 python/tests/mypy.sh                        |   2 +
 python/tests/pylint.sh                      |   2 +
 tests/acceptance/avocado_qemu/__init__.py   |  69 +++++-
 tests/acceptance/boot_linux.py              |  18 +-
 tests/acceptance/hotplug_cpu.py             |  37 ++++
 tests/acceptance/info_usernet.py            |  29 +++
 tests/acceptance/linux_ssh_mips_malta.py    |  42 +---
 tests/acceptance/virtio-gpu.py              |   2 +-
 tests/acceptance/virtiofs_submounts.py      |  71 +-----
 tests/docker/dockerfiles/python.docker      |  18 ++
 tests/qemu-iotests/297                      |   1 +
 tests/qemu-iotests/300                      |   4 +-
 tests/qemu-iotests/iotests.py               |   4 +-
 tests/requirements.txt                      |   2 +-
 tests/vm/aarch64vm.py                       |   2 +-
 tests/vm/basevm.py                          |  12 +-
 48 files changed, 967 insertions(+), 248 deletions(-)
 create mode 100644 python/PACKAGE.rst
 create mode 100644 python/README.rst
 create mode 100644 python/qemu/README.rst
 create mode 100644 python/qemu/machine/README.rst
 create mode 100644 python/qemu/qmp/README.rst
 create mode 100644 python/qemu/utils/README.rst
 create mode 100644 python/.gitignore
 create mode 100644 python/MANIFEST.in
 create mode 100644 python/Makefile
 create mode 100644 python/Pipfile
 create mode 100644 python/Pipfile.lock
 create mode 100644 python/VERSION
 create mode 100644 python/avocado.cfg
 delete mode 100644 python/mypy.ini
 delete mode 100644 python/qemu/.flake8
 delete mode 100644 python/qemu/.isort.cfg
 delete mode 100644 python/qemu/__init__.py
 create mode 100644 python/qemu/machine/__init__.py
 rename python/qemu/{ => machine}/console_socket.py (94%)
 rename python/qemu/{ => machine}/machine.py (93%)
 rename python/qemu/{ => machine}/qtest.py (95%)
 delete mode 100644 python/qemu/pylintrc
 rename python/qemu/{qmp.py => qmp/__init__.py} (96%)
 create mode 100644 python/qemu/utils/__init__.py
 rename python/qemu/{ => utils}/accel.py (100%)
 create mode 100644 python/setup.cfg
 create mode 100755 python/setup.py
 create mode 100755 python/tests/flake8.sh
 create mode 100755 python/tests/isort.sh
 create mode 100755 python/tests/mypy.sh
 create mode 100755 python/tests/pylint.sh
 create mode 100644 tests/acceptance/hotplug_cpu.py
 create mode 100644 tests/acceptance/info_usernet.py
 create mode 100644 tests/docker/dockerfiles/python.docker

-- 
2.31.1



Re: [PULL v2 00/44] Python patches
Posted by Peter Maydell 2 years, 10 months ago
On Wed, 2 Jun 2021 at 00:31, John Snow <jsnow@redhat.com> wrote:
>
> The following changes since commit 52848929b70dcf92a68aedcfd90207be81ba3274:
>
>   Merge remote-tracking branch 'remotes/kraxel/tags/usb-20210528-pull-request' into staging (2021-05-30 20:10:30 +0100)
>
> are available in the Git repository at:
>
>   https://gitlab.com/jsnow/qemu.git tags/python-pull-request
>
> for you to fetch changes up to 6b9c277797879ce41ed20deb6737f4156cc279b3:
>
>   gitlab: add python linters to CI (2021-06-01 16:21:21 -0400)
>
> ----------------------------------------------------------------
> Pull request
>
> V2:
>  - Squashed in fixup for
>    'Python: add utility function for retrieving port redirection'
>  - Rebased on today's upstream
>
> CI here:
> https://gitlab.com/jsnow/qemu/-/pipelines/313202814
>


Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/6.1
for any user-visible changes.

-- PMM

Re: [PULL v2 00/44] Python patches
Posted by John Snow 2 years, 10 months ago
On 6/2/21 12:07 PM, Peter Maydell wrote:
> On Wed, 2 Jun 2021 at 00:31, John Snow <jsnow@redhat.com> wrote:
>>
>> The following changes since commit 52848929b70dcf92a68aedcfd90207be81ba3274:
>>
>>    Merge remote-tracking branch 'remotes/kraxel/tags/usb-20210528-pull-request' into staging (2021-05-30 20:10:30 +0100)
>>
>> are available in the Git repository at:
>>
>>    https://gitlab.com/jsnow/qemu.git tags/python-pull-request
>>
>> for you to fetch changes up to 6b9c277797879ce41ed20deb6737f4156cc279b3:
>>
>>    gitlab: add python linters to CI (2021-06-01 16:21:21 -0400)
>>
>> ----------------------------------------------------------------
>> Pull request
>>
>> V2:
>>   - Squashed in fixup for
>>     'Python: add utility function for retrieving port redirection'
>>   - Rebased on today's upstream
>>
>> CI here:
>> https://gitlab.com/jsnow/qemu/-/pipelines/313202814
>>
> 
> 
> Applied, thanks.
> 
> Please update the changelog at https://wiki.qemu.org/ChangeLog/6.1
> for any user-visible changes.
> 
> -- PMM
> 

Yay!!!

Shouldn't be any user-visible changes yet, but there are some 
developer-visible ones. (The new CI tests now protecting our python 
code, chiefly.) I don't think it's appropriate matter for the changelog.

Thank you!

🎉