[v1] hw/mips/gt64120: Minor fixes

[PATCH 0/6] hw/mips/gt64120: Minor fixes

Philippe Mathieu-Daudé posted 6 patches 3 years, 1 month ago

Diff against v1
Download series mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210305162107.2233203-1-f4bug@amsat.org

Maintainers: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>, "Philippe Mathieu-Daudé" <f4bug@amsat.org>, Jiaxun Yang <jiaxun.yang@flygoat.com>, Aurelien Jarno <aurelien@aurel32.net>

There is a newer version of this series

hw/mips/gt64xxx_pci.c | 67 +++++++++++++++++++++++++++----------------
hw/mips/malta.c       |  7 -----
hw/mips/trace-events  |  6 ++--
3 files changed, 47 insertions(+), 33 deletions(-)

Expand all Fold all

[PATCH 0/6] hw/mips/gt64120: Minor fixes

Posted by Philippe Mathieu-Daudé 3 years, 1 month ago

Trivial fixes extracted from another series which became too big,
so I prefer to send them in a previous step.

Philippe Mathieu-Daudé (6):
  hw/mips/gt64xxx: Initialize ISD I/O memory region in DeviceRealize()
  hw/mips/gt64xxx: Simplify ISD MemoryRegion read/write handlers
  hw/mips/gt64xxx: Fix typos in qemu_log_mask() formats
  hw/mips/gt64xxx: Rename trace events related to interrupt registers
  hw/mips/gt64xxx: Trace accesses to ISD registers
  hw/mips/gt64xxx: Let the GT64120 manage the lower 512MiB hole

 hw/mips/gt64xxx_pci.c | 67 +++++++++++++++++++++++++++----------------
 hw/mips/malta.c       |  7 -----
 hw/mips/trace-events  |  6 ++--
 3 files changed, 47 insertions(+), 33 deletions(-)

-- 
2.26.2

Re: [PATCH 0/6] hw/mips/gt64120: Minor fixes

Posted by Philippe Mathieu-Daudé 3 years, 1 month ago

Hi Zoltan,

On 3/5/21 5:21 PM, Philippe Mathieu-Daudé wrote:
> Trivial fixes extracted from another series which became too big,
> so I prefer to send them in a previous step.

I just realized I meant to Cc you on this series but forgot :/
As this model is pretty close to your MV64361 one, and this
series is trivial, do you mind reviewing it? It shouldn't take
more than 5min I hope ;)

Thanks,

Phil.

> 
> Philippe Mathieu-Daudé (6):
>   hw/mips/gt64xxx: Initialize ISD I/O memory region in DeviceRealize()
>   hw/mips/gt64xxx: Simplify ISD MemoryRegion read/write handlers
>   hw/mips/gt64xxx: Fix typos in qemu_log_mask() formats
>   hw/mips/gt64xxx: Rename trace events related to interrupt registers
>   hw/mips/gt64xxx: Trace accesses to ISD registers
>   hw/mips/gt64xxx: Let the GT64120 manage the lower 512MiB hole
> 
>  hw/mips/gt64xxx_pci.c | 67 +++++++++++++++++++++++++++----------------
>  hw/mips/malta.c       |  7 -----
>  hw/mips/trace-events  |  6 ++--
>  3 files changed, 47 insertions(+), 33 deletions(-)
>

Re: [PATCH 0/6] hw/mips/gt64120: Minor fixes

Posted by BALATON Zoltan 3 years, 1 month ago

On Tue, 9 Mar 2021, Philippe Mathieu-Daudé wrote:
> Hi Zoltan,
>
> On 3/5/21 5:21 PM, Philippe Mathieu-Daudé wrote:
>> Trivial fixes extracted from another series which became too big,
>> so I prefer to send them in a previous step.
>
> I just realized I meant to Cc you on this series but forgot :/
> As this model is pretty close to your MV64361 one, and this
> series is trivial, do you mind reviewing it? It shouldn't take
> more than 5min I hope ;)

Hello,

I've noticed this patch series and considered reviewing it but could not 
do it in five minutes and I've lost it since. Can you forward it to me 
again so I can reply to the patches? (It's been a while I've written the 
mv64361 model so I may need to check datasheets again.)

Regards,
BALATON Zoltan

> Thanks,
>
> Phil.
>
>>
>> Philippe Mathieu-Daudé (6):
>>   hw/mips/gt64xxx: Initialize ISD I/O memory region in DeviceRealize()
>>   hw/mips/gt64xxx: Simplify ISD MemoryRegion read/write handlers
>>   hw/mips/gt64xxx: Fix typos in qemu_log_mask() formats
>>   hw/mips/gt64xxx: Rename trace events related to interrupt registers
>>   hw/mips/gt64xxx: Trace accesses to ISD registers
>>   hw/mips/gt64xxx: Let the GT64120 manage the lower 512MiB hole
>>
>>  hw/mips/gt64xxx_pci.c | 67 +++++++++++++++++++++++++++----------------
>>  hw/mips/malta.c       |  7 -----
>>  hw/mips/trace-events  |  6 ++--
>>  3 files changed, 47 insertions(+), 33 deletions(-)
>>
>
>