[v3] meson: Try to clarify TCG / TCI options for new users

[PATCH v3 0/4] meson: Try to clarify TCG / TCI options for new users

Philippe Mathieu-Daudé posted 4 patches 3 years, 3 months ago

Diff against v1 v2 v4
Download series mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210122133004.1913923-1-philmd@redhat.com

There is a newer version of this series

configure   |  5 +++--
meson.build | 11 +++++++++--
2 files changed, 12 insertions(+), 4 deletions(-)

Expand all Fold all

[PATCH v3 0/4] meson: Try to clarify TCG / TCI options for new users

Posted by Philippe Mathieu-Daudé 3 years, 3 months ago

Since v2:
- Included Thomas suggestions

Some new users get confused between 'TCG' and 'TCI' and enable
TCI when TCG is better for they needs. Try to clarify it is
better to not use TCI when native backend is available.

Note, before Meson, warnings were summarized at the end of
./configure. Now they are displayed earlier, and likely
missed IMHO. No clue how to improve that :/

Based-on: <20210121095616.1471869-1-philmd@redhat.com>

Philippe Mathieu-Daudé (4):
  meson: Explicit TCG backend used
  meson: Warn when TCI is selected but TCG backend is available
  configure: Improve TCI feature description
  configure: Reword --enable-tcg-interpreter as --disable-native-tcg

 configure   |  5 +++--
 meson.build | 11 +++++++++--
 2 files changed, 12 insertions(+), 4 deletions(-)

-- 
2.26.2

Re: [PATCH v3 0/4] meson: Try to clarify TCG / TCI options for new users

Posted by Paolo Bonzini 3 years, 3 months ago

On 22/01/21 14:30, Philippe Mathieu-Daudé wrote:
> Since v2:
> - Included Thomas suggestions
> 
> Some new users get confused between 'TCG' and 'TCI' and enable
> TCI when TCG is better for they needs. Try to clarify it is
> better to not use TCI when native backend is available.
> 
> Note, before Meson, warnings were summarized at the end of
> ./configure. Now they are displayed earlier, and likely
> missed IMHO. No clue how to improve that :/
> 
> Based-on: <20210121095616.1471869-1-philmd@redhat.com>
> 
> Philippe Mathieu-Daudé (4):
>    meson: Explicit TCG backend used
>    meson: Warn when TCI is selected but TCG backend is available
>    configure: Improve TCI feature description
>    configure: Reword --enable-tcg-interpreter as --disable-native-tcg
> 
>   configure   |  5 +++--
>   meson.build | 11 +++++++++--
>   2 files changed, 12 insertions(+), 4 deletions(-)
> 

This will have to be reworked because the TCI option is moved to Meson 
in the pull request I have just sent, but patches 1-3 are good in concept.

Paolo