[v4] meson: Try to clarify TCG / TCI options for new users

[PATCH v4 0/4] meson: Try to clarify TCG / TCI options for new users

Philippe Mathieu-Daudé posted 4 patches 3 years, 3 months ago

Diff against v1 v2 v3
Download series mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210125144530.2837481-1-philmd@redhat.com

configure   |  7 ++++---
meson.build | 15 +++++++++++++--
2 files changed, 17 insertions(+), 5 deletions(-)

Expand all Fold all

[PATCH v4 0/4] meson: Try to clarify TCG / TCI options for new users

Posted by Philippe Mathieu-Daudé 3 years, 3 months ago

Since v3:
- Rebased
- Include fix for 23a77b2d18b ("build-system: clean up TCG/TCI configury")
- Use get_option() (Claudio)
- Use warning message suggested by Daniel
- Drop 'Reword --enable-tcg-interpreter as --disable-native-tcg' (Paolo)

Some new users get confused between 'TCG' and 'TCI' and enable
TCI when TCG is better for they needs. Try to clarify it is
better to not use TCI when native backend is available.

Note, before Meson, warnings were summarized at the end of
./configure. Now they are displayed earlier, and likely
missed IMHO. No clue how to improve that :/

Philippe Mathieu-Daudé (3):
  configure: Improve TCI feature description
  meson: Explicit TCG backend used
  meson: Warn when TCI is selected but TCG backend is available

Richard Henderson (1):
  configure: Fix --enable-tcg-interpreter

 configure   |  7 ++++---
 meson.build | 15 +++++++++++++--
 2 files changed, 17 insertions(+), 5 deletions(-)

-- 
2.26.2

Re: [PATCH v4 0/4] meson: Try to clarify TCG / TCI options for new users

Posted by Paolo Bonzini 3 years, 3 months ago

On 25/01/21 15:45, Philippe Mathieu-Daudé wrote:
> Since v3:
> - Rebased
> - Include fix for 23a77b2d18b ("build-system: clean up TCG/TCI configury")
> - Use get_option() (Claudio)
> - Use warning message suggested by Daniel
> - Drop 'Reword --enable-tcg-interpreter as --disable-native-tcg' (Paolo)
> 
> Some new users get confused between 'TCG' and 'TCI' and enable
> TCI when TCG is better for they needs. Try to clarify it is
> better to not use TCI when native backend is available.
> 
> Note, before Meson, warnings were summarized at the end of
> ./configure. Now they are displayed earlier, and likely
> missed IMHO. No clue how to improve that :/
> 
> Philippe Mathieu-Daudé (3):
>    configure: Improve TCI feature description
>    meson: Explicit TCG backend used
>    meson: Warn when TCI is selected but TCG backend is available
> 
> Richard Henderson (1):
>    configure: Fix --enable-tcg-interpreter
> 
>   configure   |  7 ++++---
>   meson.build | 15 +++++++++++++--
>   2 files changed, 17 insertions(+), 5 deletions(-)
> 

Queued, thanks.  In pattch 2 I made the corresponding changes at 
meson_options.txt too.

Paolo