From nobody Fri May 17 21:21:17 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1611585944; cv=none; d=zohomail.com; s=zohoarc; b=B1BiG4Vb2fEDtbD9pKIQBCEbxrnG49nEtiRsdb6dl2+AlRHzc4gW6ST8x0OP6XcVNGzSezDt2/dxcX/6uQVBw92FrzuaNKtvsTg48ywC+z/HtYDoyGte3XW9avY4jSVGXX9mrXyz3+ehYMNwyfu4YF8cRRE/9DqZNd7bqilRZfU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611585944; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=eyAIWgb9gsg8MioYvbK2q4hAEL+3fqa+Th3P+PoqI/E=; b=GTSZQ03WwCza4tq0wWTMPa1F6yZZZ5l6InMGvvFmUu7rnbosPXWScV2lVdXFR0GexXL4LDpm4uXiielrGXwXH3D2lGfFclaJBbY1FbERg0vZnkJPiJO+2rpFgmDAEACij0kyKR+3GpzvG1P8/3M/EDfKeTv0rvWBlfwLJpXJM/M= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 16115859444901021.4202881961464; Mon, 25 Jan 2021 06:45:44 -0800 (PST) Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-325--AyDOZqTOMepR_dIoI6kKg-1; Mon, 25 Jan 2021 09:45:41 -0500 Received: by mail-ed1-f69.google.com with SMTP id m16so7486431edd.21 for ; Mon, 25 Jan 2021 06:45:41 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (13.red-83-57-169.dynamicip.rima-tde.net. [83.57.169.13]) by smtp.gmail.com with ESMTPSA id gb14sm8184040ejc.61.2021.01.25.06.45.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Jan 2021 06:45:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611585943; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eyAIWgb9gsg8MioYvbK2q4hAEL+3fqa+Th3P+PoqI/E=; b=GozgLJ7gCxNGxBuoOCrNPJH0OgdM1sW4qXcfbLNM3I21bRXW/zTHJJA/2Q3TBeFiVK3KYv sgwJ5SadForl7ySNAyIeaKFVvIUwubfOdYCEKyGrv1i/Z6Xh++sGVw2IGzAKdQIDZnGZo1 lU3o+bVdN+X7SO31ZdG429Uvi1NFj7k= X-MC-Unique: -AyDOZqTOMepR_dIoI6kKg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=eyAIWgb9gsg8MioYvbK2q4hAEL+3fqa+Th3P+PoqI/E=; b=Yo53wuI+isjGNJcIbYedNuiekXeZ9ZQFuiNbhzYR5yXtJdeyA2vOS44g07fn33TV4L J5aKbLCmd+42q+TZAG//rWh5AfsYppyuvqu/9063x26mFMadfWVfkqn+l9JBe1MiI73h gNnV9MsRnG14xf7VvDxrYa53dpuISYPsU05dTjn3xyXlnL8+9u3TaPcu+4puvCS9hdNn doPP1g9CJLP8dDluAYy/8krpM75AfyOKtfRaTgE7nkm0LCMTygm3aK2/jZs1elyaBHAg +VhL6op1Ud7+cgDKyng5q8h4CLUqHWW9sXm58lxSuTIQe/j6yFXKK5+Z1+1AgKKiN9oO pUWw== X-Gm-Message-State: AOAM533Uuua+DcCICnzRLGBkaNE2GAiJQy6xlnNpZtCQCeiXWXSozPQC /AKIQAzl7pjB33jQdbSO72D2wdksPSvmAUw8LirumGzRMYFeBdJcY3QTXNTwmm+XEBzWU3ApIHi 7JusQ7Hx5FSZUHg== X-Received: by 2002:a17:906:358f:: with SMTP id o15mr588635ejb.369.1611585940493; Mon, 25 Jan 2021 06:45:40 -0800 (PST) X-Google-Smtp-Source: ABdhPJyVYQLQb66A79o/zw5D3p/Mlmg2n1oRdyBvcTXOdEjHjZYe4Rgdk6og4SOlqq37HtF15JItCg== X-Received: by 2002:a17:906:358f:: with SMTP id o15mr588624ejb.369.1611585940358; Mon, 25 Jan 2021 06:45:40 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Stefan Weil , Thomas Huth , Paolo Bonzini , Richard Henderson , "Daniel P . Berrange" , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v4 1/4] configure: Fix --enable-tcg-interpreter Date: Mon, 25 Jan 2021 15:45:27 +0100 Message-Id: <20210125144530.2837481-2-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210125144530.2837481-1-philmd@redhat.com> References: <20210125144530.2837481-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) From: Richard Henderson The configure option was backward, and we failed to pass the value on to meson. Fixes: 23a77b2d18b ("build-system: clean up TCG/TCI configury") Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20210124211119.35563-1-richard.henderson@linaro.org> Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel P. Berrang=C3=A9 Tested-by: Stefan Weil --- configure | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/configure b/configure index dcc5ea7d630..526c4cc1306 100755 --- a/configure +++ b/configure @@ -1119,9 +1119,9 @@ for opt do ;; --enable-whpx) whpx=3D"enabled" ;; - --disable-tcg-interpreter) tcg_interpreter=3D"true" + --disable-tcg-interpreter) tcg_interpreter=3D"false" ;; - --enable-tcg-interpreter) tcg_interpreter=3D"false" + --enable-tcg-interpreter) tcg_interpreter=3D"true" ;; --disable-cap-ng) cap_ng=3D"disabled" ;; @@ -6361,6 +6361,7 @@ NINJA=3D$ninja $meson setup \ -Dmalloc=3D$malloc -Dmalloc_trim=3D$malloc_trim -Dsparse=3D$sparse= \ -Dkvm=3D$kvm -Dhax=3D$hax -Dwhpx=3D$whpx -Dhvf=3D$hvf \ -Dxen=3D$xen -Dxen_pci_passthrough=3D$xen_pci_passthrough -Dtcg=3D= $tcg \ + -Dtcg_interpreter=3D$tcg_interpreter \ -Dcocoa=3D$cocoa -Dgtk=3D$gtk -Dmpath=3D$mpath -Dsdl=3D$sdl -Dsdl_= image=3D$sdl_image \ -Dvnc=3D$vnc -Dvnc_sasl=3D$vnc_sasl -Dvnc_jpeg=3D$vnc_jpeg -Dvnc_p= ng=3D$vnc_png \ -Dgettext=3D$gettext -Dxkbcommon=3D$xkbcommon -Du2f=3D$u2f -Dvirti= ofsd=3D$virtiofsd \ --=20 2.26.2 From nobody Fri May 17 21:21:17 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1611585952; cv=none; d=zohomail.com; s=zohoarc; b=bQYwqS6FfVVPMaI117WE1sOG57Gu68r0NJBER7uMMgjazfaSr2Xi5YMg+XzorNT/VGVpr+MqKVmQ1bwUPRKz6Qlgk4Mib7u8df/U/jpCwO2yw+8kQMZ3IYETmist7rw5XTD6Od++xKlDanHQJ2js8+YJrfb9J3ODb4AjB/gmqVw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611585952; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=/vTBGdpObdt7akXTKRcYVJLfbSFpvNvWMtOTP20LsSw=; b=Jsyx+IBymyLgqLRuyi0sPhdzG5h8XJqdqQBLxZyerxwBctTZv5FB97VlOG2me+SPrEuVe4tySKXcU1vw4Oxz5KDHS4hTkopaYmUrKGEUQzoERtAZh083lpfpGvbC1AbBImWZIp5BIAgiQS6Z/rFv1LTKm+FzH5ckhCPYZdiN2R8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1611585952486612.0730750131424; Mon, 25 Jan 2021 06:45:52 -0800 (PST) Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-30-jNz9dYbPOH-f7hHQ3l-6Uw-1; Mon, 25 Jan 2021 09:45:48 -0500 Received: by mail-ej1-f69.google.com with SMTP id j14so3851768eja.15 for ; Mon, 25 Jan 2021 06:45:48 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (13.red-83-57-169.dynamicip.rima-tde.net. [83.57.169.13]) by smtp.gmail.com with ESMTPSA id e22sm8473467ejd.79.2021.01.25.06.45.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Jan 2021 06:45:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611585951; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/vTBGdpObdt7akXTKRcYVJLfbSFpvNvWMtOTP20LsSw=; b=WRqKfcB2KQiSiMtaCp8RvZTBWyI8La1yrMtGQJh17CXIyQSshfI6LEO4+ygoKOuU/l2pXr 9nFsiiHWE/Ogsklm3NRxZo9WPxnh0HnwY2C7moCX6zIQCq0/eadulE3/iYCGSjrt1GELvE SZgYq7FAMNIr3rNjgNDoU7Q+NXGHxOU= X-MC-Unique: jNz9dYbPOH-f7hHQ3l-6Uw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/vTBGdpObdt7akXTKRcYVJLfbSFpvNvWMtOTP20LsSw=; b=F7tmCqn6K38A41X99GE77ZZuzUwKdNaHfVUZvBV9xepGcuYj2EUdhSJDdYDzZEfZiz nr6uTr9cxvWw3YHN/tNXHLE/t3pNXEeTSNVsac8kYYJYgmgNY29PuoqzdP+GZfFdC+Md NjOgAR/Mln8w8PK/8PwgTM5clgfZdXC97WdLkzzm6o95M0FE3ubucfqE3ka2WqHWzjzY fNMj3nfdQcNlwDlpdA4eF/gQVOPLoF2XZ1VG83aVTeupEqb9gnk4wG5TBu+v4+bETsEN kSVCtBCV+qcKDCrwgl7Qncu4Mh8afH6UkMbBu5gExDoF40oH8UWKNmGlB0gX+lRHJlkL tx5A== X-Gm-Message-State: AOAM533+ZIBX5u6sVUkZfin7niUMJ2oHAKZlThFylIv1rTaVyuBLKvgW 8phLWiKBIMTU+g/aSLmb2T5iS0/uz2OjoiGY19IQuYLKChTuXoyOZIq4SW6mG9WYyAcyVpu/lww edAfCSpVqzDBvIA== X-Received: by 2002:a17:906:3a98:: with SMTP id y24mr557814ejd.436.1611585947400; Mon, 25 Jan 2021 06:45:47 -0800 (PST) X-Google-Smtp-Source: ABdhPJxbqhCxaQl381d2LAvhvh+O0qV3j7JW5isaDMyu7oEjzWubENYGfe3V3+dRa6yNNc0pLIKnxQ== X-Received: by 2002:a17:906:3a98:: with SMTP id y24mr557803ejd.436.1611585947278; Mon, 25 Jan 2021 06:45:47 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Stefan Weil , Thomas Huth , Paolo Bonzini , Richard Henderson , "Daniel P . Berrange" , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v4 2/4] configure: Improve TCI feature description Date: Mon, 25 Jan 2021 15:45:28 +0100 Message-Id: <20210125144530.2837481-3-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210125144530.2837481-1-philmd@redhat.com> References: <20210125144530.2837481-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Users might want to enable all features, without realizing some features have negative effect. Mention the TCI feature is slow and experimental, hoping it will be selected knowingly. Suggested-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel P. Berrang=C3=A9 --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 526c4cc1306..00952ac8186 100755 --- a/configure +++ b/configure @@ -1748,7 +1748,7 @@ Advanced options (experts only): --with-trace-file=3DNAME Full PATH,NAME of file to store traces Default:trace- --disable-slirp disable SLIRP userspace network connectivity - --enable-tcg-interpreter enable TCG with bytecode interpreter (TCI) + --enable-tcg-interpreter enable TCI (TCG with bytecode interpreter, expe= rimental and slow) --enable-malloc-trim enable libc malloc_trim() for memory optimizati= on --oss-lib path to OSS library --cpu=3DCPU Build for host CPU [$cpu] --=20 2.26.2 From nobody Fri May 17 21:21:17 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1611585957; cv=none; d=zohomail.com; s=zohoarc; b=A+Y6Esqy0uWgTrxtcx9ftyJunQQb0fDn3KxKVqlNPYeCy4LPSymVXXi9L1QY69Z+47tAH7LZ/3Fj0moI2zbNnv6JhgvSFnQ0C/gi0QzN1VcxnpeHXepXFNV0UYofctEWnUtm7TRIX65z58DBN1BNGACffE4b9u9z7fFJq6jsEME= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611585957; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=B2Gd3t26d/y3LY2H+JD2tvGw/gAXWP5A1DeG2ouC98o=; b=O2/GNazoRRQsaIKkiRAcagUeqHE1Q0yeWKQH2k7ynyTYvR30X3z3SeL+Qslb8uJYTwCOqIjJUjImG2KFD7FK06Vxs2dIim2BhCqP/oJXlm7RVBUXiphkiOs7mKFAxakx4ug6kPi2LfccumrCUhgf+CsXmDM8xrrp61B9Rl3Hlfw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1611585957606275.1930365697947; Mon, 25 Jan 2021 06:45:57 -0800 (PST) Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-92-wmyJaHqWP9qZ5yLrIMN6fw-1; Mon, 25 Jan 2021 09:45:53 -0500 Received: by mail-ej1-f71.google.com with SMTP id n18so3865637ejc.11 for ; Mon, 25 Jan 2021 06:45:53 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (13.red-83-57-169.dynamicip.rima-tde.net. [83.57.169.13]) by smtp.gmail.com with ESMTPSA id o4sm4324731edw.78.2021.01.25.06.45.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Jan 2021 06:45:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611585955; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B2Gd3t26d/y3LY2H+JD2tvGw/gAXWP5A1DeG2ouC98o=; b=ans76OWiacsJSqSAHalFYoES04TWW1CfGpvIjVAye3FNhEX/Tm6PuT8jkCM6Mb5OoR1Cp2 Bo/M6X57G2vk1c/mqa9eCGlkwlPkfUwJPrNDo8qSDtITRnmh1WEjfQvZA5ozbzbm379/MD NvnFCsh9lowfT3Cew6nBYdCd4SddUfA= X-MC-Unique: wmyJaHqWP9qZ5yLrIMN6fw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=B2Gd3t26d/y3LY2H+JD2tvGw/gAXWP5A1DeG2ouC98o=; b=C5l8yYT6mz+tKATQC0qGvvl/33sGOjsQQgsjNPMKVHTGvjDym+YP6XjJLEjNFTXDQJ 9/y2vTYQHOpWKqSWvv4gxnzB2jtu1sCrIx+sh7+TbI0WdmSan321/c2lXorbPX2AUULs Y4evqc31jZCP3yocVj2ClvA2H6Hav6kUk2grT68udmMxIHpJH1/ynXjUvPxovo6/oGC+ 2GcpiFmSHN61GhoJOLhDdBehGkp26fbW9jE5Kijlue/oL/GU9URr/WzCKuBqJzyIiu0K KF7mdvXvZb6eiAuPRFLx7FR9CbFIbk26A3ga/FW4r0KC+G4tKrOItVs1B39pYJlS4hyM YwSg== X-Gm-Message-State: AOAM532gAkBFRVwEdnrzNzjNkLttDw224UgOj0Ww7dwABU0OfI4TJSAC AoMJmIR5YDNDrplNGJFExRy1EshXSRw1E6/tKg08RgedbLKsC8aKL69ONm68hKW0QjyZdEMIa7T W5z5SEswlXv630g== X-Received: by 2002:a50:fd84:: with SMTP id o4mr751452edt.340.1611585952668; Mon, 25 Jan 2021 06:45:52 -0800 (PST) X-Google-Smtp-Source: ABdhPJwyA0fXL//k93o4UH9A4XlD7FiddFN+j95oeaipptv/B9N4spO8S6tWfqxWTLyTL/YHLG2FCg== X-Received: by 2002:a50:fd84:: with SMTP id o4mr751439edt.340.1611585952571; Mon, 25 Jan 2021 06:45:52 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Stefan Weil , Thomas Huth , Paolo Bonzini , Richard Henderson , "Daniel P . Berrange" , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v4 3/4] meson: Explicit TCG backend used Date: Mon, 25 Jan 2021 15:45:29 +0100 Message-Id: <20210125144530.2837481-4-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210125144530.2837481-1-philmd@redhat.com> References: <20210125144530.2837481-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Reviewed-by: Thomas Huth Reviewed-by: Stefan Weil Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel P. Berrang=C3=A9 --- meson.build | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 35a9eddf5cf..16b2560e7e7 100644 --- a/meson.build +++ b/meson.build @@ -224,7 +224,7 @@ if not get_option('tcg').disabled() if cpu not in supported_cpus if get_option('tcg_interpreter') - warning('Unsupported CPU @0@, will use TCG with TCI (experimental)'.= format(cpu)) + warning('Unsupported CPU @0@, will use TCG with TCI (experimental an= d slow)'.format(cpu)) else error('Unsupported CPU @0@, try --enable-tcg-interpreter'.format(cpu= )) endif @@ -2447,8 +2447,12 @@ endif summary_info +=3D {'TCG support': config_all.has_key('CONFIG_TCG')} if config_all.has_key('CONFIG_TCG') + if get_option('tcg_interpreter') + summary_info +=3D {'TCG backend': 'TCI (TCG with bytecode interprete= r, experimental and slow)'} + else + summary_info +=3D {'TCG backend': 'native (@0@)'.format(cpu)} + endif summary_info +=3D {'TCG debug enabled': config_host.has_key('CONFIG_DEBU= G_TCG')} - summary_info +=3D {'TCG interpreter': tcg_arch =3D=3D 'tci'} endif summary_info +=3D {'target list': ' '.join(target_dirs)} if have_system --=20 2.26.2 From nobody Fri May 17 21:21:17 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1611585962; cv=none; d=zohomail.com; s=zohoarc; b=mTPYqZVmBt70zmrIgABRLWKFYEG5JUcK/YlDDCADT6SxD/AolUqAWmd05UpoEsCve314UYlPKYYD+YcXo8/YFaqhtamIG2W8cML/0Pei7K4vvJp3I0MhYdBT80k9fn9HMvzSvWk5Au42LaCK7Xr1sZNXoh69mfTIIk0z13fZNJY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611585962; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=moujoo3wpaqNyQsY1CrjUL6h3PWNXXcWEFS2F5fvjSs=; b=Cqibqd29Djf9CmgfrlDjm+EjHxxbNKVGVU4dZcpGDTg14SriCxdRK4Z3MnoQjY7PUBMSut4Nz9z8edWxBPLM3EDIJu35FvWH5tDcFP32z/mafWTjqkVw1Kjrxfm2gMD53ln5+lb/YhI5nPQDetkyN6MrlXvl0FSab5U5MJxeh0I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1611585962754687.6673477981692; Mon, 25 Jan 2021 06:46:02 -0800 (PST) Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-597-zLoTgGuUMD2X5l9sCbG28A-1; Mon, 25 Jan 2021 09:45:59 -0500 Received: by mail-ed1-f71.google.com with SMTP id m18so892107edp.13 for ; Mon, 25 Jan 2021 06:45:59 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (13.red-83-57-169.dynamicip.rima-tde.net. [83.57.169.13]) by smtp.gmail.com with ESMTPSA id l1sm8336612eje.12.2021.01.25.06.45.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Jan 2021 06:45:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611585961; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=moujoo3wpaqNyQsY1CrjUL6h3PWNXXcWEFS2F5fvjSs=; b=IxWLkoyp6FgCx3bkJRVIGQwLwwQYD4GNrR8/daCUB4BYdnUawYfjYURe0S3/yeHiA6KRCn 5PYsmz2ApRiGTipAUoiGtVqmdFG599YoVRNijFDDhb/RWlfRy9X4yVFzjHWzTyY3sKM7Av kRc/BosOKi+auzFJhLuCO+HD4cSxmAU= X-MC-Unique: zLoTgGuUMD2X5l9sCbG28A-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=moujoo3wpaqNyQsY1CrjUL6h3PWNXXcWEFS2F5fvjSs=; b=ppyEpA0rwAC0sveZedPiZ7NDqUDkrLeVKDUOBD4oNnuXQ4bTqcxeHJNa9bMaxffrQx zNz2iQ7U8FQ92toVLoZ7LK3AJPOeOpxZeeOkmjZQJRNRGhOvdNAaLfpRvqaSZdQzyYxm ar0ypf20kMc6+gvMikeUXqX//1RuQwfIlW0tiFGb4gFxwJ10HCT419LCWhbktHCAxtXK FR1QpGGFn52PEnJg4oYgxQJ2AxXqRMJbd984TjYbbwBFgasIttgIMz0WF5uGdk4ovtg5 MGunTPoBMntfNUSjWCxZOM+b5+IRGwel5zVPDvSVH1UUYpUKdR+6OYxRj9zJSEpH5hHk GzeA== X-Gm-Message-State: AOAM533/nKjyZgR6/zaKNSBHRXEhZTs6tM+ISgZXXf3k1RQxFzIaA4FF n07yvzrzGQv/cKY7JR/VDPBeiLFg7ftojdGCHE/VL2lKXnQf/3nnHTPxEW6yEqvOBWats0wDyR7 ebTtSrFAZ7abpqQ== X-Received: by 2002:a17:907:20a7:: with SMTP id pw7mr578429ejb.283.1611585958763; Mon, 25 Jan 2021 06:45:58 -0800 (PST) X-Google-Smtp-Source: ABdhPJwZjFAUdE2ZQt3llbkO2qTr/PmCco0P0DUiSz77Ob9rRL45HV+QX+FG3XB+CIWcH6hzBdnaKQ== X-Received: by 2002:a17:907:20a7:: with SMTP id pw7mr578417ejb.283.1611585958640; Mon, 25 Jan 2021 06:45:58 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Stefan Weil , Thomas Huth , Paolo Bonzini , Richard Henderson , "Daniel P . Berrange" , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v4 4/4] meson: Warn when TCI is selected but TCG backend is available Date: Mon, 25 Jan 2021 15:45:30 +0100 Message-Id: <20210125144530.2837481-5-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210125144530.2837481-1-philmd@redhat.com> References: <20210125144530.2837481-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Some new users get confused with 'TCG' and 'TCI', and enable TCI support expecting to enable TCG. Emit a warning when native TCG backend is available on the host architecture, mentioning this is a suboptimal configuration. Reviewed-by: Stefan Weil Reviewed-by: Thomas Huth Suggested-by: Daniel Berrang=C3=A9 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel P. Berrang=C3=A9 --- meson.build | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/meson.build b/meson.build index 16b2560e7e7..f675c54e636 100644 --- a/meson.build +++ b/meson.build @@ -228,6 +228,13 @@ else error('Unsupported CPU @0@, try --enable-tcg-interpreter'.format(cpu= )) endif + elif get_option('tcg_interpreter') + warning('Use of the TCG interpretor is not recommended on this host') + warning('architecture. There is a native TCG execution backend availab= le') + warning('which provides substantially better performance and reliabili= ty.') + warning('It is strongly recommended to remove the --enable-tcg-interpr= eter') + warning('configuration option on this architecture to use the native') + warning('backend.') endif if get_option('tcg_interpreter') tcg_arch =3D 'tci' --=20 2.26.2