From nobody Tue May 21 17:24:18 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1611322216; cv=none; d=zohomail.com; s=zohoarc; b=DcBWo5JuYTGXWfFTtA4p8I+a8nzfGHrZbIHW7sOSTYvd6Gv+mepleuYgYXSYl2WPcYmetWixMcxtKCNAKdtAkeRioTKUjUt0tA9ZHH6aOqKQwpfYFK9LvJe/TftAmMTalK7LzvOh8fw7yyRXD7A5Q8/M3wtH8c5IdZu8nmJiOjk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611322216; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=2KnzrbOXQKW+gjAQaElBHDQDPnPGtc8SuMwrCUeTfQs=; b=P2ZlLcJc2+GgWYxI4YfRJoqsjm4dzrA9wVV5cBL8LfR3XgxVMIvieo33byxhi9Gyft0xl3XwTEt7DsxrQs9Dwd1YMz7AMBg34qujEGSP4r39kFXvj5o44CCqIjcif6/s4hYWnGEihjDviau+TjgwceY1rODi9ZobSrLij2My7BU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1611322216248357.9735423234066; Fri, 22 Jan 2021 05:30:16 -0800 (PST) Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-547-4X7-9u4SMdOxnL-W64jixQ-1; Fri, 22 Jan 2021 08:30:13 -0500 Received: by mail-ed1-f70.google.com with SMTP id a24so2902356eda.14 for ; Fri, 22 Jan 2021 05:30:13 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (13.red-83-57-169.dynamicip.rima-tde.net. [83.57.169.13]) by smtp.gmail.com with ESMTPSA id k16sm4423726ejd.78.2021.01.22.05.30.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Jan 2021 05:30:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611322215; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2KnzrbOXQKW+gjAQaElBHDQDPnPGtc8SuMwrCUeTfQs=; b=UW0M2Op7YZkUQc8r9s+80Y4hTg1U21/qPHN2zMfnFJwgl+hIk2oL1Nl61VfXCYF0ipugc1 8CjEl743tOQv0fDxH7+X+FjtVQu8v17lCJKeW8rfD1Zr8fdlo86mpRofWOO/fLd7tCIty6 4TtcrqGDMRR5ELgbAZeMpwJG3Bv/i4g= X-MC-Unique: 4X7-9u4SMdOxnL-W64jixQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2KnzrbOXQKW+gjAQaElBHDQDPnPGtc8SuMwrCUeTfQs=; b=reCG9GplBItg++I8s7y/7veAB7ofjg2en9Tvl3UBqnSxqsjlTgNEKp6YTKyEno42j2 WrICuEV+MXzg9iL6rmfZZMuxKZlVf7QFWE3Wa/cgmdMzQrs8o1Gg61pZUT2wT5itEYXq jg52B5atzw0hrW49s5MSVZz/+mIQVUa7ehBodQgRR0plxDtVwvh3SDTYh74FRE1JbH+m ckjCFDtyCtQ5SNeOOuw3acqZSRdRT+XpolHzrEZ2YXcj7pWVcrofDOMR6XqtzP8JvzJh HM7+RH6ngHxzM8FLUeFVkxa97ygTDCctXYkR0MAlw3VkRSC0PM5zHZ7xq5efTpjpDbIV 0okw== X-Gm-Message-State: AOAM533jxdOfJetXVu+WCJI1j4ELUZoKHdh9UdbqwVwPgzzqQfYFNghu 8jFEFmBEVloNn6hwLjqWuYj9rotLFjwwmmueuVBmabDxBl4JHu3DPNYuA243m8hxA/URo5Ecwbh g5QEIUhHR750raQ== X-Received: by 2002:a17:907:a077:: with SMTP id ia23mr2789982ejc.434.1611322212496; Fri, 22 Jan 2021 05:30:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJzuSfHMZ53V3OprBiAdcKi9GojHq4lJGM5X12yW0zeKyVir9ZxjyTcCxEGmOLk8eu7+nJ1Iag== X-Received: by 2002:a17:907:a077:: with SMTP id ia23mr2789967ejc.434.1611322212323; Fri, 22 Jan 2021 05:30:12 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Stefan Weil , Paolo Bonzini , Richard Henderson , Thomas Huth , "Daniel P . Berrange" , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v3 1/4] meson: Explicit TCG backend used Date: Fri, 22 Jan 2021 14:30:01 +0100 Message-Id: <20210122133004.1913923-2-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210122133004.1913923-1-philmd@redhat.com> References: <20210122133004.1913923-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Reviewed-by: Thomas Huth Reviewed-by: Stefan Weil Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- meson.build | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 8535a83fb70..d5b76150e49 100644 --- a/meson.build +++ b/meson.build @@ -229,7 +229,7 @@ if not get_option('tcg').disabled() if cpu not in supported_cpus if 'CONFIG_TCG_INTERPRETER' in config_host - warning('Unsupported CPU @0@, will use TCG with TCI (experimental)'.= format(cpu)) + warning('Unsupported CPU @0@, will use TCG with TCI (experimental an= d slow)'.format(cpu)) else error('Unsupported CPU @0@, try --enable-tcg-interpreter'.format(cpu= )) endif @@ -2419,8 +2419,12 @@ endif summary_info +=3D {'TCG support': config_all.has_key('CONFIG_TCG')} if config_all.has_key('CONFIG_TCG') + if config_host.has_key('CONFIG_TCG_INTERPRETER') + summary_info +=3D {'TCG backend': 'TCG interpreter (experimental)'} + else + summary_info +=3D {'TCG backend': 'native (@0@)'.format(cpu)} + endif summary_info +=3D {'TCG debug enabled': config_host.has_key('CONFIG_DEBU= G_TCG')} - summary_info +=3D {'TCG interpreter': config_host.has_key('CONFIG_TCG_= INTERPRETER')} endif summary_info +=3D {'target list': ' '.join(target_dirs)} if have_system --=20 2.26.2 From nobody Tue May 21 17:24:18 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1611322221; cv=none; d=zohomail.com; s=zohoarc; b=HUYtD6/ogqoq4rHi2RlhoczMvuYIWjLqFElDfS7MOS7OXkP7ZMoJ8qerPR+0En8BOEScAGUFwrrkQZW2yeBq4J1lhbk3VpjX0GUDE0iVqSlpcwYbJPShScNYaz8A2ShQGCYNtiPHAy5PFKewnPwVRzJaeDExS+fqMRUN862CuoM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611322221; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=Ui9PEIVesR+pjrhyiwMOpt8icvFevk6frc+i55QdokQ=; b=nNTUsNdvz38HqPxrsz+lfrthmDwgdVOSrpN2AnKgb7dXvSVHDc3PpEjnlFH6QrUb2NC2lQZ7FspNfnsIUGbbu9HHgRSjSUJJ+vvk+8q+rJa3TvMPzuWRZesqJ0ZlFctMMrkeS7zghBOm6pfrqcRJFmqkRoLem5owLu0iq4mzuAU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1611322221880489.5453041770793; Fri, 22 Jan 2021 05:30:21 -0800 (PST) Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-320-qfSmiM-GO7G0bldBgXNxiA-1; Fri, 22 Jan 2021 08:30:19 -0500 Received: by mail-ej1-f71.google.com with SMTP id b18so2177347ejz.6 for ; Fri, 22 Jan 2021 05:30:18 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (13.red-83-57-169.dynamicip.rima-tde.net. [83.57.169.13]) by smtp.gmail.com with ESMTPSA id g10sm4379867ejp.37.2021.01.22.05.30.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Jan 2021 05:30:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611322220; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ui9PEIVesR+pjrhyiwMOpt8icvFevk6frc+i55QdokQ=; b=Ubsb1lOALZi+iLT9yu7JSOw3kF5kl2hdLZRKlWNCXEUHTcyKq3YIJp7lge89OUZKFhsz+d Hcss3yS7uJmYc5nYdMs0fzJMtMiwtdyt8M9GBzn/o+kaqhW6NouNNGbgIvB9HfEf8QjpiK 3v9ymk6+9B/cBIEE9YbNtq6Tp0KBifM= X-MC-Unique: qfSmiM-GO7G0bldBgXNxiA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Ui9PEIVesR+pjrhyiwMOpt8icvFevk6frc+i55QdokQ=; b=C8U0QTHmIe4AyONjrn4f9Yhc6hp7t18+ekhVhjk4n+VyAWq7Dh6Jv8j2dVGWerDvbr aXfHBSTGueMMUNpIAHF4V80Q6WAKbtpyhAIYgYc1bcveNFXkOdu+jB5XJAoniFm+ftsQ k1kH3SqVmlxIDzt1JA3zKC6/3JPhOQsTuUqCVrKxmgTZAfOSJw9YLuAo5RlqAPjroo7B 8R5GkilVUnxEcus6do3PNhvvhUnCxUH99BdLnic0BgxluWLhjb9R30G9ig3jWwqFy+Df sdLWRCqBtvVNCQVIjsw2UN0G2YpvVHyu4f3DCFeT+K3jzUdcyzZvbfavmMZPlIt0FTjZ +fzg== X-Gm-Message-State: AOAM532X5bkuTCUvU0Rc3N5oifTX3w4tWiBoHl5ZNT4XIPGQfrNTOcP0 TsRYYkxlWs/RPB84OBW5mRLTmo4Zryu5kLz8V8H9KI615tw2mj3apNXT24SSNT1Xa+O2CSI5Hld mqPOJLIwAYbI2Jw== X-Received: by 2002:a05:6402:1819:: with SMTP id g25mr3079011edy.46.1611322217733; Fri, 22 Jan 2021 05:30:17 -0800 (PST) X-Google-Smtp-Source: ABdhPJz3CX/xAcgYy/rJFitVeqKwpJ97IyOMYpVA0gCrcNv3Xe2SMlDxyel2dUpKbY+7IUrq7Z7RHg== X-Received: by 2002:a05:6402:1819:: with SMTP id g25mr3078999edy.46.1611322217531; Fri, 22 Jan 2021 05:30:17 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Stefan Weil , Paolo Bonzini , Richard Henderson , Thomas Huth , "Daniel P . Berrange" , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v3 2/4] meson: Warn when TCI is selected but TCG backend is available Date: Fri, 22 Jan 2021 14:30:02 +0100 Message-Id: <20210122133004.1913923-3-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210122133004.1913923-1-philmd@redhat.com> References: <20210122133004.1913923-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Some new users get confused with 'TCG' and 'TCI', and enable TCI support expecting to enable TCG. Emit a warning when native TCG backend is available on the host architecture, mentioning this is a suboptimal configuration. Reviewed-by: Stefan Weil Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- meson.build | 3 +++ 1 file changed, 3 insertions(+) diff --git a/meson.build b/meson.build index d5b76150e49..d3df5fa3516 100644 --- a/meson.build +++ b/meson.build @@ -234,6 +234,9 @@ error('Unsupported CPU @0@, try --enable-tcg-interpreter'.format(cpu= )) endif endif + if 'CONFIG_TCG_INTERPRETER' in config_host and cpu in supported_cpus + warning('Experimental TCI requested while native TCG is available on @= 0@, suboptimal performance expected'.format(cpu)) + endif accelerators +=3D 'CONFIG_TCG' config_host +=3D { 'CONFIG_TCG': 'y' } endif --=20 2.26.2 From nobody Tue May 21 17:24:18 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1611322230; cv=none; d=zohomail.com; s=zohoarc; b=gNHShll1r19usO4dsSnIp18FVEsdXtcG70N7E5UWG+COa7706TyasRz8U1qCuqg+7F+p1oG9+r6CmcvLyiNHdyK8zzJvsWIbT4LkoZ05YZG6/Sc6fhh6KgtLaM70GX4aGAKFsPlixlwofas+7ivSxujcyZpp48cy82kv1j9hiDk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611322230; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=SC9toH6zd85Yt0/fqqNGyw/NDQltVKupxFW46xt/En4=; b=XT8W+qMLYkS09F1isTcLvyljH2HFB26aZjKUlcsKuWMbJOQAO0JQg9bbzpYQb7LNZZHDN05I6Gojf+gX9Vca7FR0VPu5WHw3RU2Il/60hpkIJYUdC2aFxE/oHlkkL9vKtl3mkQvRS4L7z+Re5nG1kgQUa9ITiofXOFIbl0qDAW0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1611322230260249.41112492894308; Fri, 22 Jan 2021 05:30:30 -0800 (PST) Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-46-EIaO17RXP0CsQIrGt8AJ-Q-1; Fri, 22 Jan 2021 08:30:24 -0500 Received: by mail-ed1-f70.google.com with SMTP id u17so2919894edi.18 for ; Fri, 22 Jan 2021 05:30:24 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (13.red-83-57-169.dynamicip.rima-tde.net. [83.57.169.13]) by smtp.gmail.com with ESMTPSA id cx6sm5656035edb.53.2021.01.22.05.30.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Jan 2021 05:30:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611322226; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SC9toH6zd85Yt0/fqqNGyw/NDQltVKupxFW46xt/En4=; b=YNYUdOYnVBaWNxDL3NVF7yrQOKBuoMMJ5s3XGzDcNLNqS9oMrGb6F68g3h2I+1x/VT9k58 y088pmhKwA64HB8DEUXANazK1WSIa0CgYeauna1AlAKvEV84ONW1hXy8rOKD3HkGV7Hx/o kBfW7mYU9T/xgYOknXMgfkGOgwmV4qk= X-MC-Unique: EIaO17RXP0CsQIrGt8AJ-Q-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SC9toH6zd85Yt0/fqqNGyw/NDQltVKupxFW46xt/En4=; b=ncRiKNFiDNMWUJVjnilALnUyTAc1jHMHOyA8HYjsfHKKFl1FHHlkYe0mLIfm57CvLg Aa3WiWr2RChZPLzSxEhHuunFtfxefGCDdtEOUe2fLkersh+mtJQwhqZ239JIsEhFVTji XSbBQEZi+wxfGUvdtmgegzzzFVOFQZ88jnc/7sQkTAk7QHuXbOWmVz5sPqEJPTT2G2sr CnVptOOu9Bq9pTmED+nZOBvTMgNS8U4f4MAa6zGRpK0EVPFx5iSKVU+QMux3SQeuuYsV 0uGbJg9C2qhxkA5ZRVZyHZoUV3/Apf5fdBTWOgW6LA0/0w0/+P2RzQ16Kd6xE4v+pwsM RzCw== X-Gm-Message-State: AOAM530eoCjeH0gxS0mNwP9/2b/jwre9vP6ArsVAh/sL/SEXqoTywC7F FmpIIAXPHFDiSWAH5+sCgvrACX0aeg0XhNGcZJFIN4u1RmKXQziYEmXKufu5ZkdFsaHvxGYAMXl +r9LA8lgNHEJMUQ== X-Received: by 2002:a05:6402:18f:: with SMTP id r15mr3155249edv.189.1611322222929; Fri, 22 Jan 2021 05:30:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJzztiGKu/Yz4F20eM1ZObBDm/xvfQL+kgj20IqgEvBwILnfpDkZYzkxoXHJrrUP9ZXrXE8a9A== X-Received: by 2002:a05:6402:18f:: with SMTP id r15mr3155240edv.189.1611322222802; Fri, 22 Jan 2021 05:30:22 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Stefan Weil , Paolo Bonzini , Richard Henderson , Thomas Huth , "Daniel P . Berrange" , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v3 3/4] configure: Improve TCI feature description Date: Fri, 22 Jan 2021 14:30:03 +0100 Message-Id: <20210122133004.1913923-4-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210122133004.1913923-1-philmd@redhat.com> References: <20210122133004.1913923-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Users might want to enable all features, without realizing some features have negative effect. Mention the TCI feature is slow and experimental, hoping it will be selected knowingly. Suggested-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 9f016b06b54..48bd6f48d7a 100755 --- a/configure +++ b/configure @@ -1753,7 +1753,7 @@ Advanced options (experts only): --with-trace-file=3DNAME Full PATH,NAME of file to store traces Default:trace- --disable-slirp disable SLIRP userspace network connectivity - --enable-tcg-interpreter enable TCG with bytecode interpreter (TCI) + --enable-tcg-interpreter enable TCI (TCG with bytecode interpreter, expe= rimental and slow) --enable-malloc-trim enable libc malloc_trim() for memory optimizati= on --oss-lib path to OSS library --cpu=3DCPU Build for host CPU [$cpu] --=20 2.26.2 From nobody Tue May 21 17:24:18 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1611322232; cv=none; d=zohomail.com; s=zohoarc; b=ZybtfhAl6ghKmtEuiAkGCJD9NhMJtJGcylaY7H1G726n3NnOZrp9hYtAoTCHbUHetYQx88Ozyd76Bdz2onkuPgMLp/hksRJpD/CQoOb/SZ9CYf6vQ8MAc6KVNRk0Dhhfo9SMG4atP8m32zEz5eBxQDY/fViDFPX0tUhDHOdIG+4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611322232; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=rqLUxS6+wXdFYNdF20lIIzQLVCdqXVLR3cT1O1xo2Ts=; b=JkxDxJagRVnFX+yKrTpCS6jSp32mJ5oThpepG+wATaD8d57rtWqoX73n32I+8JvDRlx6bY/HXpDeUE9gqaIWTfkucz4uYbMQp/jFR3Qo4xf8p8ChQiAwckFJQlucjNYcufJp9Y5tFCW6tRteKhS19MyVPfLQETTvLna4tUo7ucA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1611322232333994.0824265356282; Fri, 22 Jan 2021 05:30:32 -0800 (PST) Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-458-Md2XOB9SOhi7EE4aI0kG_g-1; Fri, 22 Jan 2021 08:30:29 -0500 Received: by mail-ed1-f72.google.com with SMTP id a24so2902844eda.14 for ; Fri, 22 Jan 2021 05:30:29 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (13.red-83-57-169.dynamicip.rima-tde.net. [83.57.169.13]) by smtp.gmail.com with ESMTPSA id b26sm5431195eds.48.2021.01.22.05.30.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Jan 2021 05:30:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611322231; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rqLUxS6+wXdFYNdF20lIIzQLVCdqXVLR3cT1O1xo2Ts=; b=CbTzDYo75Qql2yW8EKA5nbKx1RVvt6qodHAP/XxuUT1kmcc5NuRgaf4Sp2hiPOEI9mGdq4 i/7Qy6bMoRN63IES5nLxmvDJSl53EposMuf/ZopzFGbxQl7Nz8HSVtNVWH+767Qu/WGNe1 aNV0OFEDxarK8A/pALukVR+xiQC+8oU= X-MC-Unique: Md2XOB9SOhi7EE4aI0kG_g-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rqLUxS6+wXdFYNdF20lIIzQLVCdqXVLR3cT1O1xo2Ts=; b=DBaVIGYkhScw5f9e9yLeYNOdTw+hX82xJcyvKILdo0MbfqpZgdHrMW46kdktJ18G35 NY8eEsZPdVFoD6WMmRdzqldVN7wOJMN63WKckE24oR5MrqXjhpY19x/Fqczvr1f1x+6Y Ag2tOBE+UhDaDgqWKM/Sdt3Mqk5Tl2M/9gHD5VN9MFujrYuaGsObcsZVzaG4F6b2gxyr 2Ga112eNikKKrxJTi0guOMyAah+uRE/6IFlL1OHwD73Ua1pr8sMB6IF59EW9otM5CkSO gaJW0L/N+VOe449pc436Ey4NkTCeLMJFSz1L3u+ig8t63Xsr7y+GVW2ALtpDSKANEn0g SPgg== X-Gm-Message-State: AOAM531/rm/8rM1mMxcoohV63R/jBKTx3X1dDIEKmFcYHkauxuM1pnqg EM1WBo6yxjOjv91NTs2++xcbLHEj2kiOLeHbKDnu1oIbN1LHnVaQUxmAajwLvqtpAssK177RHyJ PLhU8+d5cUp1jQw== X-Received: by 2002:a17:906:3401:: with SMTP id c1mr3067678ejb.156.1611322227979; Fri, 22 Jan 2021 05:30:27 -0800 (PST) X-Google-Smtp-Source: ABdhPJxDKkqjq0cxNEgFzumErQwUHNNbfoMfN/tF8SdsThiumUxWd15W8HQSTlEswAsIubpLRCMsCg== X-Received: by 2002:a17:906:3401:: with SMTP id c1mr3067667ejb.156.1611322227806; Fri, 22 Jan 2021 05:30:27 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Stefan Weil , Paolo Bonzini , Richard Henderson , Thomas Huth , "Daniel P . Berrange" , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v3 4/4] configure: Reword --enable-tcg-interpreter as --disable-native-tcg Date: Fri, 22 Jan 2021 14:30:04 +0100 Message-Id: <20210122133004.1913923-5-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210122133004.1913923-1-philmd@redhat.com> References: <20210122133004.1913923-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Users might want to enable all features, without realizing some features have negative effect. Rename '--enable-tcg-interpreter' as '--disable-native-tcg' to avoid user selecting this feature without understanding it. '--enable-tcg-interpreter' is kept in for backward compability with scripts. Suggested-by: Thomas Huth Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- configure | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 48bd6f48d7a..5e5ff779a69 100755 --- a/configure +++ b/configure @@ -1121,7 +1121,8 @@ for opt do ;; --disable-tcg-interpreter) tcg_interpreter=3D"no" ;; - --enable-tcg-interpreter) tcg_interpreter=3D"yes" + --enable-tcg-interpreter) # backward compatibility + --disable-native-tcg) tcg_interpreter=3D"yes" ;; --disable-cap-ng) cap_ng=3D"disabled" ;; @@ -1753,7 +1754,7 @@ Advanced options (experts only): --with-trace-file=3DNAME Full PATH,NAME of file to store traces Default:trace- --disable-slirp disable SLIRP userspace network connectivity - --enable-tcg-interpreter enable TCI (TCG with bytecode interpreter, expe= rimental and slow) + --disable-native-tcg enable TCI (TCG with bytecode interpreter, expe= rimental and slow) --enable-malloc-trim enable libc malloc_trim() for memory optimizati= on --oss-lib path to OSS library --cpu=3DCPU Build for host CPU [$cpu] --=20 2.26.2