[v1] Fix some memleaks caused by ptimer_init

[PATCH 0/7] Fix some memleaks caused by ptimer_init

Gan Qixin posted 7 patches 3 years, 5 months ago

Diff against v2
Download series mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20201127071803.2479462-1-ganqixin@huawei.com

Maintainers: Antony Pavlov <antonynpavlov@gmail.com>, Subbaraya Sundeep <sundeep.lkml@gmail.com>, Beniamino Galvani <b.galvani@gmail.com>, Peter Maydell <peter.maydell@linaro.org>, Jan Kiszka <jan.kiszka@web.de>, Igor Mitsyanko <i.mitsyanko@gmail.com>

There is a newer version of this series

hw/arm/musicpal.c            | 22 +++++++++++++++++-----
hw/rtc/exynos4210_rtc.c      | 19 ++++++++++++++-----
hw/timer/allwinner-a10-pit.c | 21 ++++++++++++++++-----
hw/timer/digic-timer.c       | 18 +++++++++++++-----
hw/timer/exynos4210_mct.c    | 24 +++++++++++++++++++-----
hw/timer/exynos4210_pwm.c    | 21 ++++++++++++++++-----
hw/timer/mss-timer.c         | 23 ++++++++++++++++++-----
7 files changed, 113 insertions(+), 35 deletions(-)

Expand all Fold all

[PATCH 0/7] Fix some memleaks caused by ptimer_init

Posted by Gan Qixin 3 years, 5 months ago

Hi all,

When running device-introspect-test, I found some memory leaks caused by
ptimer_init in the init function, so I released it in the finalize function.


Gan Qixin (7):
  allwinner-a10-pit: Use ptimer_free() in the finalize function to avoid
    memleaks
  digic-timer: Use ptimer_free() in the finalize function to avoid
    memleaks
  exynos4210_mct: Use ptimer_free() in the finalize function to avoid
    memleaks
  exynos4210_pwm: Use ptimer_free() in the finalize function to avoid
    memleaks
  exynos4210_rtc: Use ptimer_free() in the finalize function to avoid
    memleaks
  mss-timer: Use ptimer_free() in the finalize function to avoid
    memleaks
  musicpal: Use ptimer_free() in the finalize function to avoid memleaks

 hw/arm/musicpal.c            | 22 +++++++++++++++++-----
 hw/rtc/exynos4210_rtc.c      | 19 ++++++++++++++-----
 hw/timer/allwinner-a10-pit.c | 21 ++++++++++++++++-----
 hw/timer/digic-timer.c       | 18 +++++++++++++-----
 hw/timer/exynos4210_mct.c    | 24 +++++++++++++++++++-----
 hw/timer/exynos4210_pwm.c    | 21 ++++++++++++++++-----
 hw/timer/mss-timer.c         | 23 ++++++++++++++++++-----
 7 files changed, 113 insertions(+), 35 deletions(-)

-- 
2.23.0

RE: [PATCH 0/7] Fix some memleaks caused by ptimer_init

Posted by ganqixin 3 years, 4 months ago

Kindly ping!

Hi all,
  These patches are waiting for review. Could someone help me check them?

Thanks,
Gan Qixin

> -----Original Message-----
> From: ganqixin
> Sent: Friday, November 27, 2020 3:18 PM
> To: qemu-arm@nongnu.org; qemu-devel@nongnu.org
> Cc: peter.maydell@linaro.org; Chenqun (kuhn)
> <kuhn.chenqun@huawei.com>; Zhanghailiang
> <zhang.zhanghailiang@huawei.com>; ganqixin <ganqixin@huawei.com>
> Subject: [PATCH 0/7] Fix some memleaks caused by ptimer_init
> 
> Hi all,
> 
> When running device-introspect-test, I found some memory leaks caused
> by ptimer_init in the init function, so I released it in the finalize function.
> 
> 
> Gan Qixin (7):
>   allwinner-a10-pit: Use ptimer_free() in the finalize function to avoid
>     memleaks
>   digic-timer: Use ptimer_free() in the finalize function to avoid
>     memleaks
>   exynos4210_mct: Use ptimer_free() in the finalize function to avoid
>     memleaks
>   exynos4210_pwm: Use ptimer_free() in the finalize function to avoid
>     memleaks
>   exynos4210_rtc: Use ptimer_free() in the finalize function to avoid
>     memleaks
>   mss-timer: Use ptimer_free() in the finalize function to avoid
>     memleaks
>   musicpal: Use ptimer_free() in the finalize function to avoid memleaks
> 
>  hw/arm/musicpal.c            | 22 +++++++++++++++++-----
>  hw/rtc/exynos4210_rtc.c      | 19 ++++++++++++++-----
>  hw/timer/allwinner-a10-pit.c | 21 ++++++++++++++++-----
>  hw/timer/digic-timer.c       | 18 +++++++++++++-----
>  hw/timer/exynos4210_mct.c    | 24 +++++++++++++++++++-----
>  hw/timer/exynos4210_pwm.c    | 21 ++++++++++++++++-----
>  hw/timer/mss-timer.c         | 23 ++++++++++++++++++-----
>  7 files changed, 113 insertions(+), 35 deletions(-)
> 
> --
> 2.23.0